bpf: Remove is_valid_bpf_tramp_flags()
authorXu Kuohai <xukuohai@huawei.com>
Mon, 11 Jul 2022 15:08:20 +0000 (11:08 -0400)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 11 Jul 2022 19:04:58 +0000 (21:04 +0200)
commit535a57a7ffc04932ad83c1a5649b09ba6c93ce83
treeffc9d4fc14e5a6b489fc1cfa6f5de8001368f164
parent9974d37ea75f01b47d16072b5dad305bd8d23fcc
bpf: Remove is_valid_bpf_tramp_flags()

Before generating bpf trampoline, x86 calls is_valid_bpf_tramp_flags()
to check the input flags. This check is architecture independent.
So, to be consistent with x86, arm64 should also do this check
before generating bpf trampoline.

However, the BPF_TRAMP_F_XXX flags are not used by user code and the
flags argument is almost constant at compile time, so this run time
check is a bit redundant.

Remove is_valid_bpf_tramp_flags() and add some comments to the usage of
BPF_TRAMP_F_XXX flags, as suggested by Alexei.

Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Acked-by: Song Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/20220711150823.2128542-2-xukuohai@huawei.com
arch/x86/net/bpf_jit_comp.c
kernel/bpf/bpf_struct_ops.c
kernel/bpf/trampoline.c