drm/i915/xehp: LNCF/LBCF workarounds should be on the GT list
authorMatt Roper <matthew.d.roper@intel.com>
Thu, 9 Feb 2023 23:22:28 +0000 (15:22 -0800)
committerMatt Roper <matthew.d.roper@intel.com>
Fri, 10 Feb 2023 20:08:58 +0000 (12:08 -0800)
commit4583d6beb04976dff3440b1efd2c5956997fd839
treece43f1e441366bc89807e35c74695f92f4989b3e
parenta13af50d75bc266bc746a2ac2b38d597f08f4201
drm/i915/xehp: LNCF/LBCF workarounds should be on the GT list

Although registers in the L3 bank/node configuration ranges are marked
as having "DEV" reset characteristics in the bspec, this appears to be a
hold-over from pre-Xe_HP platforms.  In reality, these registers
maintain their values across engine resets, meaning that workarounds
and tuning settings targeting them should be placed on the GT
workaround list rather than an engine workaround list.

Note that an extra clue here is that these registers moved from the
RENDER forcewake domain to the GT forcewake domain in Xe_HP; generally
RCS/CCS engine resets should not lead to the reset of a register that
lives outside the RENDER domain.

Re-applying these registers on engine resets wouldn't actually hurt
anything, but is unnecessary and just makes it more confusing to anyone
trying to decipher how these registers really work.

v2:
 - Also move DG2's Wa_14010648519 to the GT list.  (Gustavo)

Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230209232228.859317-1-matthew.d.roper@intel.com
drivers/gpu/drm/i915/gt/intel_workarounds.c