net: stmmac: gmac5+: fix potential integer overflow on 32 bit multiply
authorColin Ian King <colin.king@canonical.com>
Fri, 1 May 2020 14:10:16 +0000 (15:10 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 May 2020 18:57:21 +0000 (11:57 -0700)
commit44d95cc6b10ff7439d45839c96c581cb4368c088
tree2bd48e1c658e69d2db09d0b4d20ddbfc85257544
parenta7df4870d79b00742da6cc93ca2f336a71db77f7
net: stmmac: gmac5+: fix potential integer overflow on 32 bit multiply

The multiplication of cfg->ctr[1] by 1000000000 is performed using a
32 bit multiplication (since cfg->ctr[1] is a u32) and this can lead
to a potential overflow. Fix this by making the constant a ULL to
ensure a 64 bit multiply occurs.

Fixes: 504723af0d85 ("net: stmmac: Add basic EST support for GMAC5+")
Addresses-Coverity: ("Unintentional integer overflow")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac5.c