nmblib: avoid undefined behaviour in handle_name_ptrs()
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Sun, 19 Jan 2020 02:08:58 +0000 (15:08 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 7 Feb 2020 10:19:39 +0000 (10:19 +0000)
commit3bc7acc62646b105b03fd3c65e9170a373f95392
treeac070b3a58773ad85ab7558960458aba220091ed
parent91d4e79c279283dd6fc953a274b02b1957db84d8
nmblib: avoid undefined behaviour in handle_name_ptrs()

If *offset is length - 1, we would read ubuf[(*offset)+1] as the lower
bits of the new *offset. This value is undefined, but because it is
checked against the valid range, there is no way to read further
beyond that one byte.

Credit to oss-fuzz.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14242
OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=20193

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Feb  7 10:19:39 UTC 2020 on sn-devel-184
source3/libsmb/nmblib.c