CVE-2018-14629 dns: fix CNAME loop prevention using counter regression
authorStefan Metzmacher <metze@samba.org>
Wed, 28 Nov 2018 14:21:56 +0000 (15:21 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 4 Dec 2018 07:52:29 +0000 (08:52 +0100)
commit34f4491d79b47b2fe2457b8882f11644cf773bc4
treebbe82040201da2de1151ddc741e1af3d95df1925
parent14399fd818b130a6347eec860460929c292d5996
CVE-2018-14629 dns: fix CNAME loop prevention using counter regression

The loop prevention should only be done for CNAME records!

Otherwise we truncate the answer records for A, AAAA or
SRV queries, which is a bad idea if you have more than 20 DCs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec  4 08:52:29 CET 2018 on sn-devel-144
selftest/knownfail.d/dns
source4/dns_server/dns_query.c