net: fix nla_strcmp to handle more then one trailing null character
authorMaciej Żenczykowski <maze@google.com>
Wed, 5 May 2021 16:58:31 +0000 (09:58 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 May 2021 19:48:46 +0000 (12:48 -0700)
commit2c16db6c92b0ee4aa61e88366df82169e83c3f7e
treee6cc0490d4eec83f99eb8ddeaf28a77e48341296
parent52bfcdd87e83d9e69d22da5f26b1512ffc81deed
net: fix nla_strcmp to handle more then one trailing null character

Android userspace has been using TCA_KIND with a char[IFNAMESIZ]
many-null-terminated buffer containing the string 'bpf'.

This works on 4.19 and ceases to work on 5.10.

I'm not entirely sure what fixes tag to use, but I think the issue
was likely introduced in the below mentioned 5.4 commit.

Reported-by: Nucca Chen <nuccachen@google.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Fixes: 62794fc4fbf5 ("net_sched: add max len check for TCA_KIND")
Change-Id: I66dc281f165a2858fc29a44869a270a2d698a82b
Signed-off-by: David S. Miller <davem@davemloft.net>
lib/nlattr.c