dm integrity: fix memory corruption when tag_size is less than digest size
authorMikulas Patocka <mpatocka@redhat.com>
Sun, 3 Apr 2022 18:38:22 +0000 (14:38 -0400)
committerMike Snitzer <snitzer@kernel.org>
Wed, 13 Apr 2022 16:38:49 +0000 (12:38 -0400)
commit08c1af8f1c13bbf210f1760132f4df24d0ed46d6
tree676b1092df0ba94cb4452b1bdd1caafd7d70dcb0
parentce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
dm integrity: fix memory corruption when tag_size is less than digest size

It is possible to set up dm-integrity in such a way that the
"tag_size" parameter is less than the actual digest size. In this
situation, a part of the digest beyond tag_size is ignored.

In this case, dm-integrity would write beyond the end of the
ic->recalc_tags array and corrupt memory. The corruption happened in
integrity_recalc->integrity_sector_checksum->crypto_shash_final.

Fix this corruption by increasing the tags array so that it has enough
padding at the end to accomodate the loop in integrity_recalc() being
able to write a full digest size for the last member of the tags
array.

Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-integrity.c