thermal: core: Fix NULL pointer dereference in zone registration error path
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 14 Dec 2023 10:52:25 +0000 (11:52 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 15 Dec 2023 17:24:24 +0000 (18:24 +0100)
commit04e6ccfc93c5a1aa1d75a537cf27e418895e20ea
treee583fb217601df44aa455556558315a9539c7114
parent404f62cd6407f163e03cfaca97e27c1c4c62eb3c
thermal: core: Fix NULL pointer dereference in zone registration error path

If device_register() in thermal_zone_device_register_with_trips()
returns an error, the tz variable is set to NULL and subsequently
dereferenced in kfree(tz->tzp).

Commit adc8749b150c ("thermal/drivers/core: Use put_device() if
device_register() fails") added the tz = NULL assignment in question to
avoid a possible double-free after dropping the reference to the zone
device.  However, after commit 4649620d9404 ("thermal: core: Make
thermal_zone_device_unregister() return after freeing the zone"), that
assignment has become redundant, because dropping the reference to the
zone device does not cause the zone object to be freed any more.

Drop it to address the NULL pointer dereference.

Fixes: 3d439b1a2ad3 ("thermal/core: Alloc-copy-free the thermal zone parameters structure")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
drivers/thermal/thermal_core.c