X-Git-Url: http://git.samba.org/samba.git/?a=blobdiff_plain;f=libcli%2Fcldap%2Fcldap.c;fp=libcli%2Fcldap%2Fcldap.c;h=df81767a7606c8b494f876ee9904f399754388fa;hb=763d37e6a4ba7121e940a95e56502180c13e363e;hp=eb4f102e6ab1d318c0b0b5ceaa5b440f8b4baf23;hpb=321e948c98b01e344e97a0be22ed79f95feb9697;p=sfrench%2Fsamba-autobuild%2F.git

diff --git a/libcli/cldap/cldap.c b/libcli/cldap/cldap.c
index eb4f102e6ab..df81767a760 100644
--- a/libcli/cldap/cldap.c
+++ b/libcli/cldap/cldap.c
@@ -919,9 +919,7 @@ char *cldap_netlogon_create_filter(TALLOC_CTX *mem_ctx,
 	}
 	if (io->in.domain_sid) {
 		struct dom_sid *sid = dom_sid_parse_talloc(mem_ctx, io->in.domain_sid);
-		if (filter == NULL) {
-			return NULL;
-		}
+
 		filter = talloc_asprintf_append_buffer(filter, "(domainSid=%s)",
 						ldap_encode_ndr_dom_sid(mem_ctx, sid));
 		if (filter == NULL) {
@@ -931,9 +929,7 @@ char *cldap_netlogon_create_filter(TALLOC_CTX *mem_ctx,
 	if (io->in.domain_guid) {
 		struct GUID guid;
 		GUID_from_string(io->in.domain_guid, &guid);
-		if (filter == NULL) {
-			return NULL;
-		}
+
 		filter = talloc_asprintf_append_buffer(filter, "(DomainGuid=%s)",
 						ldap_encode_ndr_GUID(mem_ctx, &guid));
 		if (filter == NULL) {