Imported Upstream version 4.0.0+dfsg1
[abartlet/samba-debian.git] / source4 / torture / rpc / netlogon.c
index 70e1fd9ebbfc9cc6a917deb0e7ec3ce636c36188..1f92bc60eaca8022477441cfdb2631594845da6f 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
 
    test suite for netlogon rpc operations
@@ -7,17 +7,17 @@
    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2003-2004
    Copyright (C) Tim Potter      2003
    Copyright (C) Matthias Dieter Wallnöfer            2009-2010
-   
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #define TEST_MACHINE_NAME "torturetest"
 
-static bool test_LogonUasLogon(struct torture_context *tctx, 
+static bool test_netr_broken_binding_handle(struct torture_context *tctx,
+                                           struct dcerpc_pipe *p)
+{
+       NTSTATUS status;
+       struct netr_DsRGetSiteName r;
+       const char *site = NULL;
+       struct dcerpc_binding_handle *b = p->binding_handle;
+
+       r.in.computer_name      = talloc_asprintf(tctx, "\\\\%s",
+                                                 dcerpc_server_name(p));
+       r.out.site              = &site;
+
+       torture_comment(tctx,
+                       "Testing netlogon request with correct binding handle: %s\n",
+                       r.in.computer_name);
+
+       status = dcerpc_netr_DsRGetSiteName_r(b, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status,
+                                  "Netlogon request with broken binding handle");
+       torture_assert_werr_ok(tctx, r.out.result,
+                              "Netlogon request with broken binding handle");
+
+       if (torture_setting_bool(tctx, "samba3", false) ||
+           torture_setting_bool(tctx, "samba4", false)) {
+               torture_skip(tctx,
+                            "Skipping broken binding handle check against Samba");
+       }
+
+       r.in.computer_name      = talloc_asprintf(tctx, "\\\\\\\\%s",
+                                                 dcerpc_server_name(p));
+
+       torture_comment(tctx,
+                       "Testing netlogon request with broken binding handle: %s\n",
+                       r.in.computer_name);
+
+       status = dcerpc_netr_DsRGetSiteName_r(b, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status,
+                                  "Netlogon request with broken binding handle");
+       torture_assert_werr_equal(tctx, r.out.result,
+                                 WERR_INVALID_COMPUTERNAME,
+                                 "Netlogon request with broken binding handle");
+
+       r.in.computer_name      = "\\\\\\\\THIS_IS_NOT_VALID";
+
+       torture_comment(tctx,
+                       "Testing netlogon request with broken binding handle: %s\n",
+                       r.in.computer_name);
+
+       status = dcerpc_netr_DsRGetSiteName_r(b, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status,
+                                  "Netlogon request with broken binding handle");
+       torture_assert_werr_equal(tctx, r.out.result,
+                                 WERR_INVALID_COMPUTERNAME,
+                                 "Netlogon request with broken binding handle");
+
+       return true;
+}
+
+static bool test_LogonUasLogon(struct torture_context *tctx,
                               struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -115,8 +173,8 @@ bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context *tctx,
 
        creds = netlogon_creds_client_init(tctx, a.in.account_name,
                                           a.in.computer_name,
-                                          &credentials1, &credentials2, 
-                                          mach_password, &credentials3, 
+                                          &credentials1, &credentials2,
+                                          mach_password, &credentials3,
                                           0);
        torture_assert(tctx, creds != NULL, "memory allocation");
 
@@ -128,7 +186,7 @@ bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context *tctx,
 
        /* This allows the tests to continue against the more fussy windows 2008 */
        if (NT_STATUS_EQUAL(a.out.result, NT_STATUS_DOWNGRADE_DETECTED)) {
-               return test_SetupCredentials2(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS, 
+               return test_SetupCredentials2(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS,
                                              credentials,
                                              cli_credentials_get_secure_channel_type(credentials),
                                              creds_out);
@@ -136,7 +194,7 @@ bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context *tctx,
 
        torture_assert_ntstatus_ok(tctx, a.out.result, "ServerAuthenticate");
 
-       torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3), 
+       torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3),
                       "Credential chaining failed");
 
        *creds_out = creds;
@@ -184,9 +242,9 @@ bool test_SetupCredentials2(struct dcerpc_pipe *p, struct torture_context *tctx,
        a.out.return_credentials = &credentials3;
 
        creds = netlogon_creds_client_init(tctx, a.in.account_name,
-                                          a.in.computer_name, 
-                                          &credentials1, &credentials2, 
-                                          mach_password, &credentials3, 
+                                          a.in.computer_name,
+                                          &credentials1, &credentials2,
+                                          mach_password, &credentials3,
                                           negotiate_flags);
 
        torture_assert(tctx, creds != NULL, "memory allocation");
@@ -197,7 +255,7 @@ bool test_SetupCredentials2(struct dcerpc_pipe *p, struct torture_context *tctx,
                "ServerAuthenticate2 failed");
        torture_assert_ntstatus_ok(tctx, a.out.result, "ServerAuthenticate2 failed");
 
-       torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3), 
+       torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3),
                "Credential chaining failed");
 
        torture_comment(tctx, "negotiate_flags=0x%08x\n", negotiate_flags);
@@ -252,10 +310,10 @@ bool test_SetupCredentials3(struct dcerpc_pipe *p, struct torture_context *tctx,
 
        creds = netlogon_creds_client_init(tctx, a.in.account_name,
                                           a.in.computer_name,
-                                          &credentials1, &credentials2, 
+                                          &credentials1, &credentials2,
                                           &mach_password, &credentials3,
                                           negotiate_flags);
-       
+
        torture_assert(tctx, creds != NULL, "memory allocation");
 
        torture_comment(tctx, "Testing ServerAuthenticate3\n");
@@ -266,7 +324,7 @@ bool test_SetupCredentials3(struct dcerpc_pipe *p, struct torture_context *tctx,
        torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3), "Credential chaining failed");
 
        torture_comment(tctx, "negotiate_flags=0x%08x\n", negotiate_flags);
-       
+
        /* Prove that requesting a challenge again won't break it */
        torture_assert_ntstatus_ok(tctx, dcerpc_netr_ServerReqChallenge_r(b, tctx, &r),
                "ServerReqChallenge failed");
@@ -279,7 +337,7 @@ bool test_SetupCredentials3(struct dcerpc_pipe *p, struct torture_context *tctx,
 /*
   try a change password for our machine account
 */
-static bool test_SetPassword(struct torture_context *tctx, 
+static bool test_SetPassword(struct torture_context *tctx,
                             struct dcerpc_pipe *p,
                             struct cli_credentials *machine_credentials)
 {
@@ -308,7 +366,7 @@ static bool test_SetPassword(struct torture_context *tctx,
        netlogon_creds_des_encrypt(creds, &new_password);
 
        torture_comment(tctx, "Testing ServerPasswordSet on machine account\n");
-       torture_comment(tctx, "Changing machine account password to '%s'\n", 
+       torture_comment(tctx, "Changing machine account password to '%s'\n",
                        password);
 
        netlogon_creds_client_authenticator(creds, &credential);
@@ -325,9 +383,9 @@ static bool test_SetPassword(struct torture_context *tctx,
           credentials chaining fully, and we verify that the server
           allows the password to be set to the same value twice in a
           row (match win2k3) */
-       torture_comment(tctx, 
+       torture_comment(tctx,
                "Testing a second ServerPasswordSet on machine account\n");
-       torture_comment(tctx, 
+       torture_comment(tctx,
                "Changing machine account password to '%s' (same as previous run)\n", password);
 
        netlogon_creds_client_authenticator(creds, &credential);
@@ -342,8 +400,8 @@ static bool test_SetPassword(struct torture_context *tctx,
 
        cli_credentials_set_password(machine_credentials, password, CRED_SPECIFIED);
 
-       torture_assert(tctx, 
-               test_SetupCredentials(p, tctx, machine_credentials, &creds), 
+       torture_assert(tctx,
+               test_SetupCredentials(p, tctx, machine_credentials, &creds),
                "ServerPasswordSet failed to actually change the password");
 
        return true;
@@ -448,9 +506,10 @@ static DATA_BLOB netlogon_very_rand_pass(TALLOC_CTX *mem_ctx, int len)
 /*
   try a change password for our machine account
 */
-static bool test_SetPassword2(struct torture_context *tctx, 
-                             struct dcerpc_pipe *p, 
-                             struct cli_credentials *machine_credentials)
+static bool test_SetPassword2_with_flags(struct torture_context *tctx,
+                                        struct dcerpc_pipe *p,
+                                        struct cli_credentials *machine_credentials,
+                                        uint32_t flags)
 {
        struct netr_ServerPasswordSet2 r;
        const char *password;
@@ -462,7 +521,7 @@ static bool test_SetPassword2(struct torture_context *tctx,
        struct netr_CryptPassword new_password;
        struct dcerpc_binding_handle *b = p->binding_handle;
 
-       if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
+       if (!test_SetupCredentials2(p, tctx, flags, machine_credentials, cli_credentials_get_secure_channel_type(machine_credentials), &creds)) {
                return false;
        }
 
@@ -476,7 +535,11 @@ static bool test_SetPassword2(struct torture_context *tctx,
 
        password = generate_random_password(tctx, 8, 255);
        encode_pw_buffer(password_buf.data, password, STR_UNICODE);
-       netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
+       if (creds->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) {
+               netlogon_creds_aes_encrypt(creds, password_buf.data, 516);
+       } else {
+               netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
+       }
 
        memcpy(new_password.data, password_buf.data, 512);
        new_password.length = IVAL(password_buf.data, 512);
@@ -497,7 +560,7 @@ static bool test_SetPassword2(struct torture_context *tctx,
        cli_credentials_set_password(machine_credentials, password, CRED_SPECIFIED);
 
        if (!torture_setting_bool(tctx, "dangerous", false)) {
-               torture_comment(tctx, 
+               torture_comment(tctx,
                        "Not testing ability to set password to '', enable dangerous tests to perform this test\n");
        } else {
                /* by changing the machine password to ""
@@ -507,37 +570,43 @@ static bool test_SetPassword2(struct torture_context *tctx,
                 */
                password = "";
                encode_pw_buffer(password_buf.data, password, STR_UNICODE);
-               netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
-               
+               if (creds->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) {
+                       netlogon_creds_aes_encrypt(creds, password_buf.data, 516);
+               } else {
+                       netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
+               }
                memcpy(new_password.data, password_buf.data, 512);
                new_password.length = IVAL(password_buf.data, 512);
-               
-               torture_comment(tctx, 
+
+               torture_comment(tctx,
                        "Testing ServerPasswordSet2 on machine account\n");
-               torture_comment(tctx, 
+               torture_comment(tctx,
                        "Changing machine account password to '%s'\n", password);
-               
+
                netlogon_creds_client_authenticator(creds, &credential);
-               
+
                torture_assert_ntstatus_ok(tctx, dcerpc_netr_ServerPasswordSet2_r(b, tctx, &r),
                        "ServerPasswordSet2 failed");
                torture_assert_ntstatus_ok(tctx, r.out.result, "ServerPasswordSet2 failed");
-               
+
                if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                        torture_comment(tctx, "Credential chaining failed\n");
                }
-               
+
                cli_credentials_set_password(machine_credentials, password, CRED_SPECIFIED);
        }
 
-       torture_assert(tctx, test_SetupCredentials(p, tctx, machine_credentials, &creds), 
+       torture_assert(tctx, test_SetupCredentials(p, tctx, machine_credentials, &creds),
                "ServerPasswordSet failed to actually change the password");
 
        /* now try a random password */
        password = generate_random_password(tctx, 8, 255);
        encode_pw_buffer(password_buf.data, password, STR_UNICODE);
-       netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
-
+       if (creds->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) {
+               netlogon_creds_aes_encrypt(creds, password_buf.data, 516);
+       } else {
+               netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
+       }
        memcpy(new_password.data, password_buf.data, 512);
        new_password.length = IVAL(password_buf.data, 512);
 
@@ -558,9 +627,9 @@ static bool test_SetPassword2(struct torture_context *tctx,
           credentials chaining fully, and we verify that the server
           allows the password to be set to the same value twice in a
           row (match win2k3) */
-       torture_comment(tctx, 
+       torture_comment(tctx,
                "Testing a second ServerPasswordSet2 on machine account\n");
-       torture_comment(tctx, 
+       torture_comment(tctx,
                "Changing machine account password to '%s' (same as previous run)\n", password);
 
        netlogon_creds_client_authenticator(creds, &credential);
@@ -575,8 +644,8 @@ static bool test_SetPassword2(struct torture_context *tctx,
 
        cli_credentials_set_password(machine_credentials, password, CRED_SPECIFIED);
 
-       torture_assert (tctx, 
-               test_SetupCredentials(p, tctx, machine_credentials, &creds), 
+       torture_assert (tctx,
+               test_SetupCredentials(p, tctx, machine_credentials, &creds),
                "ServerPasswordSet failed to actually change the password");
 
        new_random_pass = netlogon_very_rand_pass(tctx, 128);
@@ -584,12 +653,16 @@ static bool test_SetPassword2(struct torture_context *tctx,
        /* now try a random stream of bytes for a password */
        set_pw_in_buffer(password_buf.data, &new_random_pass);
 
-       netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
+       if (creds->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) {
+               netlogon_creds_aes_encrypt(creds, password_buf.data, 516);
+       } else {
+               netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
+       }
 
        memcpy(new_password.data, password_buf.data, 512);
        new_password.length = IVAL(password_buf.data, 512);
 
-       torture_comment(tctx, 
+       torture_comment(tctx,
                "Testing a third ServerPasswordSet2 on machine account, with a completely random password\n");
 
        netlogon_creds_client_authenticator(creds, &credential);
@@ -607,13 +680,27 @@ static bool test_SetPassword2(struct torture_context *tctx,
        cli_credentials_set_password(machine_credentials, NULL, CRED_UNINITIALISED);
        cli_credentials_set_nt_hash(machine_credentials, &nt_hash, CRED_SPECIFIED);
 
-       torture_assert (tctx, 
-               test_SetupCredentials(p, tctx, machine_credentials, &creds), 
+       torture_assert (tctx,
+               test_SetupCredentials(p, tctx, machine_credentials, &creds),
                "ServerPasswordSet failed to actually change the password");
 
        return true;
 }
 
+static bool test_SetPassword2(struct torture_context *tctx,
+                             struct dcerpc_pipe *p,
+                             struct cli_credentials *machine_credentials)
+{
+       return test_SetPassword2_with_flags(tctx, p, machine_credentials, NETLOGON_NEG_AUTH2_ADS_FLAGS);
+}
+
+static bool test_SetPassword2_AES(struct torture_context *tctx,
+                                 struct dcerpc_pipe *p,
+                                 struct cli_credentials *machine_credentials)
+{
+       return test_SetPassword2_with_flags(tctx, p, machine_credentials, NETLOGON_NEG_AUTH2_ADS_FLAGS | NETLOGON_NEG_SUPPORTS_AES);
+}
+
 static bool test_GetPassword(struct torture_context *tctx,
                             struct dcerpc_pipe *p,
                             struct cli_credentials *machine_credentials)
@@ -707,7 +794,7 @@ static bool test_netlogon_ops_args(struct dcerpc_pipe *p, struct torture_context
                flags |= CLI_CRED_NTLMv2_AUTH;
        }
 
-       cli_credentials_get_ntlm_username_domain(cmdline_credentials, tctx, 
+       cli_credentials_get_ntlm_username_domain(cmdline_credentials, tctx,
                                                 &ninfo.identity_info.account_name.string,
                                                 &ninfo.identity_info.domain_name.string);
 
@@ -715,16 +802,16 @@ static bool test_netlogon_ops_args(struct dcerpc_pipe *p, struct torture_context
                ninfo.identity_info.domain_name.string = NULL;
        }
 
-       generate_random_buffer(ninfo.challenge, 
+       generate_random_buffer(ninfo.challenge,
                               sizeof(ninfo.challenge));
-       chal = data_blob_const(ninfo.challenge, 
+       chal = data_blob_const(ninfo.challenge,
                               sizeof(ninfo.challenge));
 
-       names_blob = NTLMv2_generate_names_blob(tctx, cli_credentials_get_workstation(credentials), 
+       names_blob = NTLMv2_generate_names_blob(tctx, cli_credentials_get_workstation(credentials),
                                                cli_credentials_get_domain(credentials));
 
-       status = cli_credentials_get_ntlm_response(cmdline_credentials, tctx, 
-                                                  &flags, 
+       status = cli_credentials_get_ntlm_response(cmdline_credentials, tctx,
+                                                  &flags,
                                                   chal,
                                                   names_blob,
                                                   &lm_resp, &nt_resp,
@@ -748,25 +835,25 @@ static bool test_netlogon_ops_args(struct dcerpc_pipe *p, struct torture_context
        r.in.computer_name = cli_credentials_get_workstation(credentials);
        r.in.credential = &auth;
        r.in.return_authenticator = &auth2;
-       r.in.logon_level = 2;
+       r.in.logon_level = NetlogonNetworkInformation;
        r.in.logon = &logon;
        r.out.validation = &validation;
        r.out.authoritative = &authoritative;
 
        d_printf("Testing LogonSamLogon with name %s\n", ninfo.identity_info.account_name.string);
-       
+
        for (i=2;i<=3;i++) {
                ZERO_STRUCT(auth2);
                netlogon_creds_client_authenticator(creds, &auth);
-               
+
                r.in.validation_level = i;
-               
+
                torture_assert_ntstatus_ok(tctx, dcerpc_netr_LogonSamLogon_r(b, tctx, &r),
                        "LogonSamLogon failed");
                torture_assert_ntstatus_ok(tctx, r.out.result, "LogonSamLogon failed");
-               
-               torture_assert(tctx, netlogon_creds_client_check(creds, 
-                                                                &r.out.return_authenticator->cred), 
+
+               torture_assert(tctx, netlogon_creds_client_check(creds,
+                                                                &r.out.return_authenticator->cred),
                        "Credential chaining failed");
                torture_assert_int_equal(tctx, *r.out.authoritative, 1,
                                         "LogonSamLogon invalid  *r.out.authoritative");
@@ -854,7 +941,7 @@ static bool test_netlogon_ops_args(struct dcerpc_pipe *p, struct torture_context
                                         "LogonSamLogon invalid  *r.out.authoritative");
        }
 
-       r.in.logon_level = 2;
+       r.in.logon_level = NetlogonNetworkInformation;
        r.in.credential = &auth;
 
        for (i=2;i<=3;i++) {
@@ -884,10 +971,64 @@ bool test_netlogon_ops(struct dcerpc_pipe *p, struct torture_context *tctx,
        return test_netlogon_ops_args(p, tctx, credentials, creds, false);
 }
 
+/*
+  try a netlogon GetCapabilities
+*/
+bool test_netlogon_capabilities(struct dcerpc_pipe *p, struct torture_context *tctx,
+                               struct cli_credentials *credentials,
+                               struct netlogon_creds_CredentialState *creds)
+{
+       NTSTATUS status;
+       struct netr_LogonGetCapabilities r;
+       union netr_Capabilities capabilities;
+       struct netr_Authenticator auth, return_auth;
+       struct netlogon_creds_CredentialState tmp_creds;
+       struct dcerpc_binding_handle *b = p->binding_handle;
+
+       r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
+       r.in.computer_name = cli_credentials_get_workstation(credentials);
+       r.in.credential = &auth;
+       r.in.return_authenticator = &return_auth;
+       r.in.query_level = 1;
+       r.out.capabilities = &capabilities;
+       r.out.return_authenticator = &return_auth;
+
+       torture_comment(tctx, "Testing LogonGetCapabilities\n");
+
+       ZERO_STRUCT(return_auth);
+
+       /*
+        * we need to operate on a temporary copy of creds
+        * because dcerpc_netr_LogonGetCapabilities was
+        * dcerpc_netr_DummyFunction and returns NT_STATUS_NOT_IMPLEMENTED
+        * without looking a the authenticator.
+        */
+       tmp_creds = *creds;
+       netlogon_creds_client_authenticator(&tmp_creds, &auth);
+
+       status = dcerpc_netr_LogonGetCapabilities_r(b, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status, "LogonGetCapabilities failed");
+       if (NT_STATUS_EQUAL(r.out.result, NT_STATUS_NOT_IMPLEMENTED)) {
+               return true;
+       }
+
+       *creds = tmp_creds;
+
+       torture_assert(tctx, netlogon_creds_client_check(creds,
+                                                        &r.out.return_authenticator->cred),
+                      "Credential chaining failed");
+
+       torture_assert_int_equal(tctx, creds->negotiate_flags,
+                                capabilities.server_capabilities,
+                                "negotiate flags");
+
+       return true;
+}
+
 /*
   try a netlogon SamLogon
 */
-static bool test_SamLogon(struct torture_context *tctx, 
+static bool test_SamLogon(struct torture_context *tctx,
                          struct dcerpc_pipe *p,
                          struct cli_credentials *credentials)
 {
@@ -919,13 +1060,13 @@ static uint64_t sequence_nums[3];
 /*
   try a netlogon DatabaseSync
 */
-static bool test_DatabaseSync(struct torture_context *tctx, 
+static bool test_DatabaseSync(struct torture_context *tctx,
                              struct dcerpc_pipe *p,
                              struct cli_credentials *machine_credentials)
 {
        struct netr_DatabaseSync r;
        struct netlogon_creds_CredentialState *creds;
-       const uint32_t database_ids[] = {SAM_DATABASE_DOMAIN, SAM_DATABASE_BUILTIN, SAM_DATABASE_PRIVS}; 
+       const uint32_t database_ids[] = {SAM_DATABASE_DOMAIN, SAM_DATABASE_BUILTIN, SAM_DATABASE_PRIVS};
        int i;
        struct netr_DELTA_ENUM_ARRAY *delta_enum_array = NULL;
        struct netr_Authenticator credential, return_authenticator;
@@ -978,10 +1119,10 @@ static bool test_DatabaseSync(struct torture_context *tctx,
                            delta_enum_array->num_deltas > 0 &&
                            delta_enum_array->delta_enum[0].delta_type == NETR_DELTA_DOMAIN &&
                            delta_enum_array->delta_enum[0].delta_union.domain) {
-                               sequence_nums[r.in.database_id] = 
+                               sequence_nums[r.in.database_id] =
                                        delta_enum_array->delta_enum[0].delta_union.domain->sequence_num;
                                torture_comment(tctx, "\tsequence_nums[%d]=%llu\n",
-                                      r.in.database_id, 
+                                      r.in.database_id,
                                       (unsigned long long)sequence_nums[r.in.database_id]);
                        }
                } while (NT_STATUS_EQUAL(r.out.result, STATUS_MORE_ENTRIES));
@@ -994,7 +1135,7 @@ static bool test_DatabaseSync(struct torture_context *tctx,
 /*
   try a netlogon DatabaseDeltas
 */
-static bool test_DatabaseDeltas(struct torture_context *tctx, 
+static bool test_DatabaseDeltas(struct torture_context *tctx,
                                struct dcerpc_pipe *p,
                                struct cli_credentials *machine_credentials)
 {
@@ -1003,7 +1144,7 @@ static bool test_DatabaseDeltas(struct torture_context *tctx,
        struct netr_Authenticator credential;
        struct netr_Authenticator return_authenticator;
        struct netr_DELTA_ENUM_ARRAY *delta_enum_array = NULL;
-       const uint32_t database_ids[] = {0, 1, 2}; 
+       const uint32_t database_ids[] = {0, 1, 2};
        int i;
        struct dcerpc_binding_handle *b = p->binding_handle;
 
@@ -1026,7 +1167,7 @@ static bool test_DatabaseDeltas(struct torture_context *tctx,
 
                *r.in.sequence_num -= 1;
 
-               torture_comment(tctx, "Testing DatabaseDeltas of id %d at %llu\n", 
+               torture_comment(tctx, "Testing DatabaseDeltas of id %d at %llu\n",
                       r.in.database_id, (unsigned long long)*r.in.sequence_num);
 
                do {
@@ -1592,7 +1733,7 @@ static bool test_DatabaseRedo(struct torture_context *tctx,
 /*
   try a netlogon AccountDeltas
 */
-static bool test_AccountDeltas(struct torture_context *tctx, 
+static bool test_AccountDeltas(struct torture_context *tctx,
                               struct dcerpc_pipe *p,
                               struct cli_credentials *machine_credentials)
 {
@@ -1637,7 +1778,7 @@ static bool test_AccountDeltas(struct torture_context *tctx,
 /*
   try a netlogon AccountSync
 */
-static bool test_AccountSync(struct torture_context *tctx, struct dcerpc_pipe *p, 
+static bool test_AccountSync(struct torture_context *tctx, struct dcerpc_pipe *p,
                             struct cli_credentials *machine_credentials)
 {
        struct netr_AccountSync r;
@@ -1684,7 +1825,7 @@ static bool test_AccountSync(struct torture_context *tctx, struct dcerpc_pipe *p
 /*
   try a netlogon GetDcName
 */
-static bool test_GetDcName(struct torture_context *tctx, 
+static bool test_GetDcName(struct torture_context *tctx,
                           struct dcerpc_pipe *p)
 {
        struct netr_GetDcName r;
@@ -1748,9 +1889,9 @@ static const char *function_code_str(TALLOC_CTX *mem_ctx,
 
 
 /*
-  try a netlogon LogonControl 
+  try a netlogon LogonControl
 */
-static bool test_LogonControl(struct torture_context *tctx, 
+static bool test_LogonControl(struct torture_context *tctx,
                              struct dcerpc_pipe *p,
                              struct cli_credentials *machine_credentials)
 
@@ -1876,7 +2017,7 @@ static bool test_LogonControl(struct torture_context *tctx,
 /*
   try a netlogon GetAnyDCName
 */
-static bool test_GetAnyDCName(struct torture_context *tctx, 
+static bool test_GetAnyDCName(struct torture_context *tctx,
                              struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -1924,7 +2065,7 @@ static bool test_GetAnyDCName(struct torture_context *tctx,
 /*
   try a netlogon LogonControl2
 */
-static bool test_LogonControl2(struct torture_context *tctx, 
+static bool test_LogonControl2(struct torture_context *tctx,
                               struct dcerpc_pipe *p,
                               struct cli_credentials *machine_credentials)
 
@@ -2029,7 +2170,7 @@ static bool test_LogonControl2(struct torture_context *tctx,
 /*
   try a netlogon DatabaseSync2
 */
-static bool test_DatabaseSync2(struct torture_context *tctx, 
+static bool test_DatabaseSync2(struct torture_context *tctx,
                               struct dcerpc_pipe *p,
                               struct cli_credentials *machine_credentials)
 {
@@ -2038,11 +2179,11 @@ static bool test_DatabaseSync2(struct torture_context *tctx,
        struct netr_Authenticator return_authenticator, credential;
 
        struct netlogon_creds_CredentialState *creds;
-       const uint32_t database_ids[] = {0, 1, 2}; 
+       const uint32_t database_ids[] = {0, 1, 2};
        int i;
        struct dcerpc_binding_handle *b = p->binding_handle;
 
-       if (!test_SetupCredentials2(p, tctx, NETLOGON_NEG_AUTH2_FLAGS, 
+       if (!test_SetupCredentials2(p, tctx, NETLOGON_NEG_AUTH2_FLAGS,
                                    machine_credentials,
                                    cli_credentials_get_secure_channel_type(machine_credentials),
                                    &creds)) {
@@ -2100,7 +2241,7 @@ static bool test_DatabaseSync2(struct torture_context *tctx,
 /*
   try a netlogon LogonControl2Ex
 */
-static bool test_LogonControl2Ex(struct torture_context *tctx, 
+static bool test_LogonControl2Ex(struct torture_context *tctx,
                                 struct dcerpc_pipe *p,
                                 struct cli_credentials *machine_credentials)
 
@@ -2123,7 +2264,7 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
        for (i=1;i<4;i++) {
                r.in.level = i;
 
-               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n", 
+               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n",
                       i, r.in.function_code);
 
                status = dcerpc_netr_LogonControl2Ex_r(b, tctx, &r);
@@ -2138,7 +2279,7 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
        for (i=1;i<4;i++) {
                r.in.level = i;
 
-               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n", 
+               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n",
                       i, r.in.function_code);
 
                status = dcerpc_netr_LogonControl2Ex_r(b, tctx, &r);
@@ -2153,7 +2294,7 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
        for (i=1;i<4;i++) {
                r.in.level = i;
 
-               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n", 
+               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n",
                       i, r.in.function_code);
 
                status = dcerpc_netr_LogonControl2Ex_r(b, tctx, &r);
@@ -2168,7 +2309,7 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
        for (i=1;i<4;i++) {
                r.in.level = i;
 
-               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n", 
+               torture_comment(tctx, "Testing LogonControl2Ex level %d function %d\n",
                       i, r.in.function_code);
 
                status = dcerpc_netr_LogonControl2Ex_r(b, tctx, &r);
@@ -2220,8 +2361,8 @@ static bool test_netr_GetForestTrustInformation(struct torture_context *tctx,
        return true;
 }
 
-static bool test_netr_DsRGetForestTrustInformation(struct torture_context *tctx, 
-                                                  struct dcerpc_pipe *p, const char *trusted_domain_name) 
+static bool test_netr_DsRGetForestTrustInformation(struct torture_context *tctx,
+                                                  struct dcerpc_pipe *p, const char *trusted_domain_name)
 {
        NTSTATUS status;
        struct netr_DsRGetForestTrustInformation r;
@@ -2247,7 +2388,7 @@ static bool test_netr_DsRGetForestTrustInformation(struct torture_context *tctx,
 /*
   try a netlogon netr_DsrEnumerateDomainTrusts
 */
-static bool test_DsrEnumerateDomainTrusts(struct torture_context *tctx, 
+static bool test_DsrEnumerateDomainTrusts(struct torture_context *tctx,
                                          struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -2279,7 +2420,7 @@ static bool test_DsrEnumerateDomainTrusts(struct torture_context *tctx,
                /* get info for transitive forest trusts */
 
                if (r.out.trusts->array[i].trust_attributes & NETR_TRUST_ATTRIBUTE_FOREST_TRANSITIVE) {
-                       if (!test_netr_DsRGetForestTrustInformation(tctx, p, 
+                       if (!test_netr_DsRGetForestTrustInformation(tctx, p,
                                                                    r.out.trusts->array[i].dns_name)) {
                                return false;
                        }
@@ -2327,8 +2468,8 @@ static bool test_netr_NetrEnumerateTrustedDomainsEx(struct torture_context *tctx
 
 
 static bool test_netr_DsRGetSiteName(struct dcerpc_pipe *p, struct torture_context *tctx,
-                                    const char *computer_name, 
-                                    const char *expected_site) 
+                                    const char *computer_name,
+                                    const char *expected_site)
 {
        NTSTATUS status;
        struct netr_DsRGetSiteName r;
@@ -2344,24 +2485,13 @@ static bool test_netr_DsRGetSiteName(struct dcerpc_pipe *p, struct torture_conte
        torture_assert_werr_ok(tctx, r.out.result, "DsRGetSiteName");
        torture_assert_str_equal(tctx, expected_site, site, "netr_DsRGetSiteName");
 
-       if (torture_setting_bool(tctx, "samba4", false))
-               torture_skip(tctx, "skipping computer name check against Samba4");
-
-       r.in.computer_name              = talloc_asprintf(tctx, "\\\\%s", computer_name);
-       torture_comment(tctx, 
-                       "Testing netr_DsRGetSiteName with broken computer name: %s\n", r.in.computer_name);
-
-       status = dcerpc_netr_DsRGetSiteName_r(b, tctx, &r);
-       torture_assert_ntstatus_ok(tctx, status, "DsRGetSiteName");
-       torture_assert_werr_equal(tctx, r.out.result, WERR_INVALID_COMPUTERNAME, "netr_DsRGetSiteName");
-
        return true;
 }
 
 /*
   try a netlogon netr_DsRGetDCName
 */
-static bool test_netr_DsRGetDCName(struct torture_context *tctx, 
+static bool test_netr_DsRGetDCName(struct torture_context *tctx,
                                   struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -2380,13 +2510,45 @@ static bool test_netr_DsRGetDCName(struct torture_context *tctx,
        torture_assert_ntstatus_ok(tctx, status, "DsRGetDCName");
        torture_assert_werr_ok(tctx, r.out.result, "DsRGetDCName");
 
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_CONTROLLER)),
+                                DS_DNS_CONTROLLER,
+                                "DsRGetDCName");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_DOMAIN)),
+                                DS_DNS_DOMAIN,
+                                "DsRGetDCName");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_FOREST_ROOT)),
+                                DS_DNS_FOREST_ROOT,
+                                "DsRGetDCName");
+
        r.in.domain_name        = lpcfg_workgroup(tctx->lp_ctx);
+       r.in.flags              = 0;
 
        status = dcerpc_netr_DsRGetDCName_r(b, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "DsRGetDCName");
        torture_assert_werr_ok(tctx, r.out.result, "DsRGetDCName");
 
-       return test_netr_DsRGetSiteName(p, tctx, 
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_CONTROLLER)), 0,
+                                "DsRGetDCName");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_DOMAIN)), 0,
+                                "DsRGetDCName");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_FOREST_ROOT)),
+                                DS_DNS_FOREST_ROOT,
+                                "DsRGetDCName");
+
+       if (strcasecmp(info->dc_site_name, info->client_site_name) == 0) {
+               torture_assert_int_equal(tctx,
+                                        (info->dc_flags & (DS_SERVER_CLOSEST)),
+                                        DS_SERVER_CLOSEST,
+                                        "DsRGetDCName");
+       }
+
+       return test_netr_DsRGetSiteName(p, tctx,
                                       info->dc_unc,
                                       info->dc_site_name);
 }
@@ -2394,7 +2556,7 @@ static bool test_netr_DsRGetDCName(struct torture_context *tctx,
 /*
   try a netlogon netr_DsRGetDCNameEx
 */
-static bool test_netr_DsRGetDCNameEx(struct torture_context *tctx, 
+static bool test_netr_DsRGetDCNameEx(struct torture_context *tctx,
                                     struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -2413,12 +2575,44 @@ static bool test_netr_DsRGetDCNameEx(struct torture_context *tctx,
        torture_assert_ntstatus_ok(tctx, status, "netr_DsRGetDCNameEx");
        torture_assert_werr_ok(tctx, r.out.result, "netr_DsRGetDCNameEx");
 
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_CONTROLLER)),
+                                DS_DNS_CONTROLLER,
+                                "DsRGetDCNameEx");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_DOMAIN)),
+                                DS_DNS_DOMAIN,
+                                "DsRGetDCNameEx");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_FOREST_ROOT)),
+                                DS_DNS_FOREST_ROOT,
+                                "DsRGetDCNameEx");
+
        r.in.domain_name        = lpcfg_workgroup(tctx->lp_ctx);
+       r.in.flags              = 0;
 
        status = dcerpc_netr_DsRGetDCNameEx_r(b, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "netr_DsRGetDCNameEx");
        torture_assert_werr_ok(tctx, r.out.result, "netr_DsRGetDCNameEx");
 
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_CONTROLLER)), 0,
+                                "DsRGetDCNameEx");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_DOMAIN)), 0,
+                                "DsRGetDCNameEx");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_FOREST_ROOT)),
+                                DS_DNS_FOREST_ROOT,
+                                "DsRGetDCNameEx");
+
+       if (strcasecmp(info->dc_site_name, info->client_site_name) == 0) {
+               torture_assert_int_equal(tctx,
+                                        (info->dc_flags & (DS_SERVER_CLOSEST)),
+                                        DS_SERVER_CLOSEST,
+                                        "DsRGetDCNameEx");
+       }
+
        return test_netr_DsRGetSiteName(p, tctx, info->dc_unc,
                                        info->dc_site_name);
 }
@@ -2426,7 +2620,7 @@ static bool test_netr_DsRGetDCNameEx(struct torture_context *tctx,
 /*
   try a netlogon netr_DsRGetDCNameEx2
 */
-static bool test_netr_DsRGetDCNameEx2(struct torture_context *tctx, 
+static bool test_netr_DsRGetDCNameEx2(struct torture_context *tctx,
                                      struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -2443,6 +2637,19 @@ static bool test_netr_DsRGetDCNameEx2(struct torture_context *tctx,
        torture_assert_ntstatus_ok(tctx, status, "netr_DsRGetDCNameEx2");
        torture_assert_werr_ok(tctx, r.out.result, "netr_DsRGetDCNameEx2");
 
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_CONTROLLER)),
+                                DS_DNS_CONTROLLER,
+                                "DsRGetDCNameEx2");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_DOMAIN)),
+                                DS_DNS_DOMAIN,
+                                "DsRGetDCNameEx2");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_FOREST_ROOT)),
+                                DS_DNS_FOREST_ROOT,
+                                "DsRGetDCNameEx2");
+
        r.in.server_unc         = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.client_account     = NULL;
        r.in.mask               = 0x00000000;
@@ -2459,11 +2666,30 @@ static bool test_netr_DsRGetDCNameEx2(struct torture_context *tctx,
        torture_assert_werr_ok(tctx, r.out.result, "netr_DsRGetDCNameEx2");
 
        r.in.domain_name        = lpcfg_workgroup(tctx->lp_ctx);
+       r.in.flags              = 0;
 
        status = dcerpc_netr_DsRGetDCNameEx2_r(b, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "netr_DsRGetDCNameEx2");
        torture_assert_werr_ok(tctx, r.out.result, "netr_DsRGetDCNameEx2");
 
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_CONTROLLER)), 0,
+                                "DsRGetDCNameEx2");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_DOMAIN)), 0,
+                                "DsRGetDCNameEx2");
+       torture_assert_int_equal(tctx,
+                                (info->dc_flags & (DS_DNS_FOREST_ROOT)),
+                                DS_DNS_FOREST_ROOT,
+                                "DsRGetDCNameEx2");
+
+       if (strcasecmp(info->dc_site_name, info->client_site_name) == 0) {
+               torture_assert_int_equal(tctx,
+                                        (info->dc_flags & (DS_SERVER_CLOSEST)),
+                                        DS_SERVER_CLOSEST,
+                                        "DsRGetDCNameEx2");
+       }
+
        torture_comment(tctx, "Testing netr_DsRGetDCNameEx2 with client account\n");
        r.in.client_account     = TEST_MACHINE_NAME"$";
        r.in.mask               = ACB_SVRTRUST;
@@ -2527,7 +2753,7 @@ failed:
        return NULL;
 }
 
-static bool test_netr_DsrGetDcSiteCoverageW(struct torture_context *tctx, 
+static bool test_netr_DsrGetDcSiteCoverageW(struct torture_context *tctx,
                                            struct dcerpc_pipe *p)
 {
        char *url;
@@ -2929,9 +3155,10 @@ static bool test_netr_DsRAddressToSitenamesExW(struct torture_context *tctx,
        return true;
 }
 
-static bool test_netr_ServerGetTrustInfo(struct torture_context *tctx,
-                                        struct dcerpc_pipe *p,
-                                        struct cli_credentials *machine_credentials)
+static bool test_netr_ServerGetTrustInfo_flags(struct torture_context *tctx,
+                                              struct dcerpc_pipe *p,
+                                              struct cli_credentials *machine_credentials,
+                                              uint32_t negotiate_flags)
 {
        struct netr_ServerGetTrustInfo r;
 
@@ -2944,7 +3171,9 @@ static bool test_netr_ServerGetTrustInfo(struct torture_context *tctx,
        struct netlogon_creds_CredentialState *creds;
        struct dcerpc_binding_handle *b = p->binding_handle;
 
-       if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS,
+       struct samr_Password nt_hash;
+
+       if (!test_SetupCredentials3(p, tctx, negotiate_flags,
                                    machine_credentials, &creds)) {
                return false;
        }
@@ -2967,11 +3196,36 @@ static bool test_netr_ServerGetTrustInfo(struct torture_context *tctx,
        torture_assert_ntstatus_ok(tctx, r.out.result, "ServerGetTrustInfo failed");
        torture_assert(tctx, netlogon_creds_client_check(creds, &return_authenticator.cred), "Credential chaining failed");
 
+       E_md4hash(cli_credentials_get_password(machine_credentials), nt_hash.hash);
+
+       netlogon_creds_des_decrypt(creds, &new_owf_password);
+
+       dump_data(1, new_owf_password.hash, 16);
+       dump_data(1, nt_hash.hash, 16);
+
+       torture_assert_mem_equal(tctx, new_owf_password.hash, nt_hash.hash, 16,
+               "received unexpected owf password\n");
+
        return true;
 }
 
+static bool test_netr_ServerGetTrustInfo(struct torture_context *tctx,
+                                        struct dcerpc_pipe *p,
+                                        struct cli_credentials *machine_credentials)
+{
+       return test_netr_ServerGetTrustInfo_flags(tctx, p, machine_credentials,
+                                                 NETLOGON_NEG_AUTH2_ADS_FLAGS);
+}
+
+static bool test_netr_ServerGetTrustInfo_AES(struct torture_context *tctx,
+                                            struct dcerpc_pipe *p,
+                                            struct cli_credentials *machine_credentials)
+{
+       return test_netr_ServerGetTrustInfo_flags(tctx, p, machine_credentials,
+                                                 NETLOGON_NEG_AUTH2_ADS_FLAGS | NETLOGON_NEG_SUPPORTS_AES);
+}
 
-static bool test_GetDomainInfo(struct torture_context *tctx, 
+static bool test_GetDomainInfo(struct torture_context *tctx,
                               struct dcerpc_pipe *p,
                               struct cli_credentials *machine_credentials)
 {
@@ -2999,7 +3253,7 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
 
        torture_comment(tctx, "Testing netr_LogonGetDomainInfo\n");
 
-       if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS, 
+       if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS,
                                    machine_credentials, &creds)) {
                return false;
        }
@@ -3064,7 +3318,7 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
                                   "(sAMAccountName=%s$)", TEST_MACHINE_NAME);
                old_dnsname =
                        ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL);
-               
+
                /* Gets back the "servicePrincipalName"s in AD */
                spn_el = ldb_msg_find_element(res[0], "servicePrincipalName");
                if (spn_el != NULL) {
@@ -3103,11 +3357,11 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
                           the same in combination with the "servicePrincipalName"s.
                           The DNS hostname should also be returned by our
                           "LogonGetDomainInfo" call (in the domain info structure). */
-                       
+
                        torture_assert_str_equal(tctx,
                                                 ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL),
                                                 old_dnsname, "'DNS hostname' was not set!");
-                       
+
                        spn_el = ldb_msg_find_element(res[0], "servicePrincipalName");
                        torture_assert(tctx, ((spns != NULL) && (spn_el != NULL)),
                                       "'servicePrincipalName's not set!");
@@ -3127,15 +3381,15 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
                           the "servicePrincipalName"s should remain empty and no DNS
                           hostname should be returned by our "LogonGetDomainInfo"
                           call (in the domain info structure). */
-                       
+
                        torture_assert(tctx,
                                       ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL) == NULL,
                                       "'DNS hostname' was set!");
-                       
+
                        spn_el = ldb_msg_find_element(res[0], "servicePrincipalName");
                        torture_assert(tctx, ((spns == NULL) && (spn_el == NULL)),
                                       "'servicePrincipalName's were set!");
-                       
+
                        torture_assert(tctx,
                                       info.domain_info->dns_hostname.string == NULL,
                                       "Out 'DNS host name' was set!");
@@ -3193,7 +3447,7 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
                torture_assert_str_equal(tctx,
                                         ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL),
                                         old_dnsname, "'DNS host name' did change!");
-               
+
                /* Find the two "servicePrincipalName"s which the DC shouldn't have been
                   updated (HOST/<Netbios name> and HOST/<FQDN name>) - see MS-NRPC
                   3.5.4.3.9 */
@@ -3212,7 +3466,7 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
                                break;
                torture_assert(tctx, i != spn_el->num_values,
                               "'servicePrincipalName' HOST/<FQDN name> not found!");
-               
+
                /* Check that the out DNS hostname was set properly */
                torture_assert_str_equal(tctx, info.domain_info->dns_hostname.string,
                                         old_dnsname, "Out 'DNS hostname' doesn't match the old one!");
@@ -3404,7 +3658,7 @@ static bool test_GetDomainInfo(struct torture_context *tctx,
        return true;
 }
 
-static bool test_GetDomainInfo_async(struct torture_context *tctx, 
+static bool test_GetDomainInfo_async(struct torture_context *tctx,
                                     struct dcerpc_pipe *p,
                                     struct cli_credentials *machine_credentials)
 {
@@ -3422,7 +3676,7 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
 
        torture_comment(tctx, "Testing netr_LogonGetDomainInfo - async count %d\n", ASYNC_COUNT);
 
-       if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS, 
+       if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS,
                                    machine_credentials, &creds)) {
                return false;
        }
@@ -3451,10 +3705,10 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
                creds_async[i] = (struct netlogon_creds_CredentialState *)talloc_memdup(creds, creds, sizeof(*creds));
                req[i] = dcerpc_netr_LogonGetDomainInfo_r_send(tctx, tctx->ev, p->binding_handle, &r);
 
-               /* even with this flush per request a w2k3 server seems to 
+               /* even with this flush per request a w2k3 server seems to
                   clag with multiple outstanding requests. bleergh. */
-               torture_assert_int_equal(tctx, event_loop_once(dcerpc_event_context(p)), 0, 
-                                        "event_loop_once failed");
+               torture_assert_int_equal(tctx, tevent_loop_once(dcerpc_event_context(p)), 0,
+                                        "tevent_loop_once failed");
        }
 
        for (i=0;i<ASYNC_COUNT;i++) {
@@ -3464,19 +3718,19 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
                status = dcerpc_netr_LogonGetDomainInfo_r_recv(req[i], tctx);
 
                torture_assert_ntstatus_ok(tctx, status, "netr_LogonGetDomainInfo_async");
-               torture_assert_ntstatus_ok(tctx, r.out.result, "netr_LogonGetDomainInfo_async"); 
+               torture_assert_ntstatus_ok(tctx, r.out.result, "netr_LogonGetDomainInfo_async");
 
-               torture_assert(tctx, netlogon_creds_client_check(creds_async[i], &a.cred), 
+               torture_assert(tctx, netlogon_creds_client_check(creds_async[i], &a.cred),
                        "Credential chaining failed at async");
        }
 
-       torture_comment(tctx, 
+       torture_comment(tctx,
                        "Testing netr_LogonGetDomainInfo - async count %d OK\n", ASYNC_COUNT);
 
        return true;
 }
 
-static bool test_ManyGetDCName(struct torture_context *tctx, 
+static bool test_ManyGetDCName(struct torture_context *tctx,
                               struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -3598,11 +3852,15 @@ struct torture_suite *torture_rpc_netlogon(TALLOC_CTX *mem_ctx)
        tcase = torture_suite_add_machine_bdc_rpc_iface_tcase(suite, "netlogon",
                                                  &ndr_table_netlogon, TEST_MACHINE_NAME);
 
+       torture_rpc_tcase_add_test(tcase, "Broken RPC binding handle",
+                                  test_netr_broken_binding_handle);
+
        torture_rpc_tcase_add_test(tcase, "LogonUasLogon", test_LogonUasLogon);
        torture_rpc_tcase_add_test(tcase, "LogonUasLogoff", test_LogonUasLogoff);
        torture_rpc_tcase_add_test_creds(tcase, "SamLogon", test_SamLogon);
        torture_rpc_tcase_add_test_creds(tcase, "SetPassword", test_SetPassword);
        torture_rpc_tcase_add_test_creds(tcase, "SetPassword2", test_SetPassword2);
+       torture_rpc_tcase_add_test_creds(tcase, "SetPassword2_AES", test_SetPassword2_AES);
        torture_rpc_tcase_add_test_creds(tcase, "GetPassword", test_GetPassword);
        torture_rpc_tcase_add_test_creds(tcase, "GetTrustPasswords", test_GetTrustPasswords);
        torture_rpc_tcase_add_test_creds(tcase, "GetDomainInfo", test_GetDomainInfo);
@@ -3627,6 +3885,7 @@ struct torture_suite *torture_rpc_netlogon(TALLOC_CTX *mem_ctx)
        torture_rpc_tcase_add_test(tcase, "DsRAddressToSitenamesW", test_netr_DsRAddressToSitenamesW);
        torture_rpc_tcase_add_test(tcase, "DsRAddressToSitenamesExW", test_netr_DsRAddressToSitenamesExW);
        torture_rpc_tcase_add_test_creds(tcase, "ServerGetTrustInfo", test_netr_ServerGetTrustInfo);
+       torture_rpc_tcase_add_test_creds(tcase, "ServerGetTrustInfo_AES", test_netr_ServerGetTrustInfo_AES);
        torture_rpc_tcase_add_test_creds(tcase, "GetForestTrustInformation", test_netr_GetForestTrustInformation);
 
        return suite;
@@ -3645,6 +3904,7 @@ struct torture_suite *torture_rpc_netlogon_s3(TALLOC_CTX *mem_ctx)
        torture_rpc_tcase_add_test_creds(tcase, "SetPassword", test_SetPassword);
        torture_rpc_tcase_add_test_creds(tcase, "SetPassword_with_flags", test_SetPassword_with_flags);
        torture_rpc_tcase_add_test_creds(tcase, "SetPassword2", test_SetPassword2);
+       torture_rpc_tcase_add_test_creds(tcase, "SetPassword2_AES", test_SetPassword2_AES);
        torture_rpc_tcase_add_test(tcase, "NetrEnumerateTrustedDomains", test_netr_NetrEnumerateTrustedDomains);
 
        return suite;