r23792: convert Samba4 to GPLv3
[kai/samba-autobuild/.git] / source4 / rpc_server / samr / dcesrv_samr.c
index 40d562fc0c896bf5a1d722eafb5be09423e5e935..cb82ad3ec8736b9405dc2bf9c71d917898f3574c 100644 (file)
@@ -9,7 +9,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
@@ -18,8 +18,7 @@
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
@@ -30,7 +29,7 @@
 #include "system/time.h"
 #include "lib/ldb/include/ldb.h"
 #include "lib/ldb/include/ldb_errors.h"
-#include "ads.h"
+#include "dsdb/common/flags.h"
 #include "dsdb/samdb/samdb.h"
 #include "libcli/ldap/ldap.h"
 #include "libcli/security/security.h"
 
   create a connection to the SAM database
 */
-static NTSTATUS samr_Connect(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_Connect(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                             struct samr_Connect *r)
 {
        struct samr_connect_state *c_state;
@@ -143,7 +142,7 @@ static NTSTATUS samr_Connect(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem
 /* 
   samr_Close 
 */
-static NTSTATUS samr_Close(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_Close(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                           struct samr_Close *r)
 {
        struct dcesrv_handle *h;
@@ -163,7 +162,7 @@ static NTSTATUS samr_Close(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_c
 /* 
   samr_SetSecurity 
 */
-static NTSTATUS samr_SetSecurity(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetSecurity(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                 struct samr_SetSecurity *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -173,7 +172,7 @@ static NTSTATUS samr_SetSecurity(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_QuerySecurity 
 */
-static NTSTATUS samr_QuerySecurity(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QuerySecurity(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                   struct samr_QuerySecurity *r)
 {
        struct dcesrv_handle *h;
@@ -202,7 +201,7 @@ static NTSTATUS samr_QuerySecurity(struct dcesrv_call_state *dce_call, TALLOC_CT
   we refuse this operation completely. If a admin wants to shutdown samr
   in Samba then they should use the samba admin tools to disable the samr pipe
 */
-static NTSTATUS samr_Shutdown(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_Shutdown(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                              struct samr_Shutdown *r)
 {
        return NT_STATUS_ACCESS_DENIED;
@@ -214,7 +213,7 @@ static NTSTATUS samr_Shutdown(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 
   this maps from a domain name to a SID
 */
-static NTSTATUS samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                  struct samr_LookupDomain *r)
 {
        struct samr_connect_state *c_state;
@@ -225,7 +224,7 @@ static NTSTATUS samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX
        struct ldb_message **dom_msgs;
        struct ldb_message **ref_msgs;
        int ret;
-       const struct ldb_dn *partitions_basedn = ldb_dn_string_compose(mem_ctx, samdb_base_dn(mem_ctx), "CN=Partitions,CN=Configuration");
+       struct ldb_dn *partitions_basedn;
 
        r->out.sid = NULL;
 
@@ -237,9 +236,11 @@ static NTSTATUS samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX
                return NT_STATUS_INVALID_PARAMETER;
        }
 
+       partitions_basedn = samdb_partitions_dn(c_state->sam_ctx, mem_ctx);
+
        if (strcasecmp(r->in.domain_name->string, "BUILTIN") == 0) {
                ret = gendb_search(c_state->sam_ctx,
-                                  mem_ctx, samdb_base_dn(mem_ctx), &dom_msgs, dom_attrs,
+                                  mem_ctx, NULL, &dom_msgs, dom_attrs,
                                   "(objectClass=builtinDomain)");
        } else {
                ret = gendb_search(c_state->sam_ctx,
@@ -251,7 +252,7 @@ static NTSTATUS samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX
                }
                
                ret = gendb_search_dn(c_state->sam_ctx, mem_ctx, 
-                                     samdb_result_dn(mem_ctx,
+                                     samdb_result_dn(c_state->sam_ctx, mem_ctx,
                                                      ref_msgs[0], "ncName", NULL), 
                                      &dom_msgs, dom_attrs);
        }
@@ -278,7 +279,7 @@ static NTSTATUS samr_LookupDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX
 
   list the domains in the SAM
 */
-static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                 struct samr_EnumDomains *r)
 {
        struct samr_connect_state *c_state;
@@ -289,7 +290,7 @@ static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX
        const char * const ref_attrs[] = { "nETBIOSName", NULL};
        struct ldb_message **dom_msgs;
        struct ldb_message **ref_msgs;
-       const struct ldb_dn *partitions_basedn = ldb_dn_string_compose(mem_ctx, samdb_base_dn(mem_ctx), "CN=Partitions,CN=Configuration");
+       struct ldb_dn *partitions_basedn;
 
        *r->out.resume_handle = 0;
        r->out.sam = NULL;
@@ -299,8 +300,10 @@ static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX
 
        c_state = h->data;
 
+       partitions_basedn = samdb_partitions_dn(c_state->sam_ctx, mem_ctx);
+
        count = gendb_search(c_state->sam_ctx,
-                            mem_ctx, samdb_base_dn(mem_ctx), &dom_msgs, dom_attrs,
+                            mem_ctx, NULL, &dom_msgs, dom_attrs,
                             "(objectClass=domain)");
        if (count == -1) {
                DEBUG(0,("samdb: no domains found in EnumDomains\n"));
@@ -336,7 +339,7 @@ static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX
                ret = gendb_search(c_state->sam_ctx, mem_ctx, partitions_basedn,
                                   &ref_msgs, ref_attrs, 
                                   "(&(objectClass=crossRef)(ncName=%s))", 
-                                  ldb_dn_linearize(mem_ctx, dom_msgs[i]->dn));
+                                  ldb_dn_get_linearized(dom_msgs[i]->dn));
                if (ret == 1) {
                        array->entries[i].name.string = samdb_result_string(ref_msgs[0], "nETBIOSName", NULL);
                } else {
@@ -355,7 +358,7 @@ static NTSTATUS samr_EnumDomains(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_OpenDomain 
 */
-static NTSTATUS samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                struct samr_OpenDomain *r)
 {
        struct dcesrv_handle *h_conn, *h_domain;
@@ -367,7 +370,7 @@ static NTSTATUS samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *
        struct ldb_message **dom_msgs;
        struct ldb_message **ref_msgs;
        int ret;
-       const struct ldb_dn *partitions_basedn = ldb_dn_string_compose(mem_ctx, samdb_base_dn(mem_ctx), "CN=Partitions,CN=Configuration");
+       struct ldb_dn *partitions_basedn;
 
        ZERO_STRUCTP(r->out.domain_handle);
 
@@ -379,25 +382,32 @@ static NTSTATUS samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *
                return NT_STATUS_INVALID_PARAMETER;
        }
 
+       partitions_basedn = samdb_partitions_dn(c_state->sam_ctx, mem_ctx);
+
        ret = gendb_search(c_state->sam_ctx,
-                          mem_ctx, samdb_base_dn(mem_ctx), &dom_msgs, dom_attrs,
-                          "(&(objectSid=%s)(&(objectclass=domain)))",
+                          mem_ctx, NULL, &dom_msgs, dom_attrs,
+                          "(&(objectSid=%s)(&(|(objectclass=domain)(objectClass=builtinDomain))))",
                           ldap_encode_ndr_dom_sid(mem_ctx, r->in.sid));
-       if (ret != 1) {
+       if (ret == 0) {
+               return NT_STATUS_NO_SUCH_DOMAIN;
+       } else if (ret > 1) {
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       } else if (ret == -1) {
+               DEBUG(1, ("Failed to open domain %s: %s\n", dom_sid_string(mem_ctx, r->in.sid), ldb_errstring(c_state->sam_ctx)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else {
                ret = gendb_search(c_state->sam_ctx,
                                   mem_ctx, partitions_basedn, &ref_msgs, ref_attrs,
                                   "(&(&(nETBIOSName=*)(objectclass=crossRef))(ncName=%s))", 
-                                  ldb_dn_linearize(mem_ctx, dom_msgs[0]->dn));
+                                  ldb_dn_get_linearized(dom_msgs[0]->dn));
                if (ret == 0) {
-                       domain_name = ldb_msg_find_string(dom_msgs[0], "cn", NULL);
+                       domain_name = ldb_msg_find_attr_as_string(dom_msgs[0], "cn", NULL);
                        if (domain_name == NULL) {
                                return NT_STATUS_NO_SUCH_DOMAIN;
                        }
                } else if (ret == 1) {
                
-                       domain_name = ldb_msg_find_string(ref_msgs[0], "nETBIOSName", NULL);
+                       domain_name = ldb_msg_find_attr_as_string(ref_msgs[0], "nETBIOSName", NULL);
                        if (domain_name == NULL) {
                                return NT_STATUS_NO_SUCH_DOMAIN;
                        }
@@ -438,7 +448,7 @@ static NTSTATUS samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *
 /*
   return DomInfo1
 */
-static NTSTATUS samr_info_DomInfo1(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo1(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo1 *info)
@@ -460,22 +470,43 @@ static NTSTATUS samr_info_DomInfo1(struct samr_domain_state *state,
 /*
   return DomInfo2
 */
-static NTSTATUS samr_info_DomInfo2(struct samr_domain_state *state, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_info_DomInfo2(struct samr_domain_state *state, TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo2 *info)
 {
-       info->force_logoff_time = ldb_msg_find_uint64(dom_msgs[0], "forceLogoff", 
+       enum server_role role = lp_server_role();
+
+       /* This pulls the NetBIOS name from the 
+          cn=NTDS Settings,cn=<NETBIOS name of PDC>,....
+          string */
+       info->primary.string = samdb_result_fsmo_name(state->sam_ctx, mem_ctx, dom_msgs[0], "fSMORoleOwner");
+
+       info->force_logoff_time = ldb_msg_find_attr_as_uint64(dom_msgs[0], "forceLogoff", 
                                                            0x8000000000000000LL);
 
        info->comment.string = samdb_result_string(dom_msgs[0], "comment", NULL);
        info->domain_name.string  = state->domain_name;
 
-       /* FIXME:  We should find the name of the real PDC emulator */
-       info->primary.string = lp_netbios_name();
-       info->sequence_num = ldb_msg_find_uint64(dom_msgs[0], "modifiedCount", 
+       info->sequence_num = ldb_msg_find_attr_as_uint64(dom_msgs[0], "modifiedCount", 
                                                 0);
-
-       info->role = lp_server_role();
+       switch (role) {
+       case ROLE_DOMAIN_CONTROLLER:
+               /* This pulls the NetBIOS name from the 
+                  cn=NTDS Settings,cn=<NETBIOS name of PDC>,....
+                  string */
+               if (samdb_is_pdc(state->sam_ctx)) {
+                       info->role = SAMR_ROLE_DOMAIN_PDC;
+               } else {
+                       info->role = SAMR_ROLE_DOMAIN_BDC;
+               }
+               break;
+       case ROLE_DOMAIN_MEMBER:
+               info->role = SAMR_ROLE_DOMAIN_MEMBER;
+               break;
+       case ROLE_STANDALONE:
+               info->role = SAMR_ROLE_STANDALONE;
+               break;
+       }
 
        /* TODO: Should these filter on SID, to avoid counting BUILTIN? */
        info->num_users = samdb_search_count(state->sam_ctx, mem_ctx, state->domain_dn, 
@@ -493,12 +524,12 @@ static NTSTATUS samr_info_DomInfo2(struct samr_domain_state *state, TALLOC_CTX *
 /*
   return DomInfo3
 */
-static NTSTATUS samr_info_DomInfo3(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo3(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo3 *info)
 {
-       info->force_logoff_time = ldb_msg_find_uint64(dom_msgs[0], "forceLogoff", 
+       info->force_logoff_time = ldb_msg_find_attr_as_uint64(dom_msgs[0], "forceLogoff", 
                                                      0x8000000000000000LL);
 
        return NT_STATUS_OK;
@@ -507,7 +538,7 @@ static NTSTATUS samr_info_DomInfo3(struct samr_domain_state *state,
 /*
   return DomInfo4
 */
-static NTSTATUS samr_info_DomInfo4(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo4(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo4 *info)
@@ -520,7 +551,7 @@ static NTSTATUS samr_info_DomInfo4(struct samr_domain_state *state,
 /*
   return DomInfo5
 */
-static NTSTATUS samr_info_DomInfo5(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo5(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo5 *info)
@@ -533,14 +564,16 @@ static NTSTATUS samr_info_DomInfo5(struct samr_domain_state *state,
 /*
   return DomInfo6
 */
-static NTSTATUS samr_info_DomInfo6(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo6(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
-                                   struct ldb_message **dom_msgs,
+                                  struct ldb_message **dom_msgs,
                                   struct samr_DomInfo6 *info)
 {
-
-       /* FIXME:  We should find the name of the real PDC emulator */
-       info->primary.string = lp_netbios_name();
+       /* This pulls the NetBIOS name from the 
+          cn=NTDS Settings,cn=<NETBIOS name of PDC>,....
+          string */
+       info->primary.string = samdb_result_fsmo_name(state->sam_ctx, mem_ctx, 
+                                                     dom_msgs[0], "fSMORoleOwner");
 
        return NT_STATUS_OK;
 }
@@ -548,12 +581,32 @@ static NTSTATUS samr_info_DomInfo6(struct samr_domain_state *state,
 /*
   return DomInfo7
 */
-static NTSTATUS samr_info_DomInfo7(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo7(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo7 *info)
 {
-       info->role = lp_server_role();
+
+       enum server_role role = lp_server_role();
+
+       switch (role) {
+       case ROLE_DOMAIN_CONTROLLER:
+               /* This pulls the NetBIOS name from the 
+                  cn=NTDS Settings,cn=<NETBIOS name of PDC>,....
+                  string */
+               if (samdb_is_pdc(state->sam_ctx)) {
+                       info->role = SAMR_ROLE_DOMAIN_PDC;
+               } else {
+                       info->role = SAMR_ROLE_DOMAIN_BDC;
+               }
+               break;
+       case ROLE_DOMAIN_MEMBER:
+               info->role = SAMR_ROLE_DOMAIN_MEMBER;
+               break;
+       case ROLE_STANDALONE:
+               info->role = SAMR_ROLE_STANDALONE;
+               break;
+       }
 
        return NT_STATUS_OK;
 }
@@ -561,15 +614,15 @@ static NTSTATUS samr_info_DomInfo7(struct samr_domain_state *state,
 /*
   return DomInfo8
 */
-static NTSTATUS samr_info_DomInfo8(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo8(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo8 *info)
 {
-       info->sequence_num = ldb_msg_find_uint64(dom_msgs[0], "modifiedCount", 
+       info->sequence_num = ldb_msg_find_attr_as_uint64(dom_msgs[0], "modifiedCount", 
                                               time(NULL));
 
-       info->domain_create_time = ldb_msg_find_uint(dom_msgs[0], "creationTime",
+       info->domain_create_time = ldb_msg_find_attr_as_uint(dom_msgs[0], "creationTime",
                                                     0x0LL);
 
        return NT_STATUS_OK;
@@ -578,7 +631,7 @@ static NTSTATUS samr_info_DomInfo8(struct samr_domain_state *state,
 /*
   return DomInfo9
 */
-static NTSTATUS samr_info_DomInfo9(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo9(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo9 *info)
@@ -591,22 +644,22 @@ static NTSTATUS samr_info_DomInfo9(struct samr_domain_state *state,
 /*
   return DomInfo11
 */
-static NTSTATUS samr_info_DomInfo11(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo11(struct samr_domain_state *state,
                                    TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                    struct samr_DomInfo11 *info)
 {
        NTSTATUS status;
-       status = samr_info_DomInfo2(state, mem_ctx, dom_msgs, &info->info2);
+       status = dcesrv_samr_info_DomInfo2(state, mem_ctx, dom_msgs, &info->info2);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
        
-       info->lockout_duration = ldb_msg_find_int64(dom_msgs[0], "lockoutDuration", 
+       info->lockout_duration = ldb_msg_find_attr_as_int64(dom_msgs[0], "lockoutDuration", 
                                                    -18000000000LL);
-       info->lockout_window = ldb_msg_find_int64(dom_msgs[0], "lockOutObservationWindow",
+       info->lockout_window = ldb_msg_find_attr_as_int64(dom_msgs[0], "lockOutObservationWindow",
                                                    -18000000000LL);
-       info->lockout_threshold = ldb_msg_find_int64(dom_msgs[0], "lockoutThreshold", 0);
+       info->lockout_threshold = ldb_msg_find_attr_as_int64(dom_msgs[0], "lockoutThreshold", 0);
 
        return NT_STATUS_OK;
 }
@@ -614,16 +667,16 @@ static NTSTATUS samr_info_DomInfo11(struct samr_domain_state *state,
 /*
   return DomInfo12
 */
-static NTSTATUS samr_info_DomInfo12(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo12(struct samr_domain_state *state,
                                   TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                   struct samr_DomInfo12 *info)
 {
-       info->lockout_duration = ldb_msg_find_int64(dom_msgs[0], "lockoutDuration", 
+       info->lockout_duration = ldb_msg_find_attr_as_int64(dom_msgs[0], "lockoutDuration", 
                                                    -18000000000LL);
-       info->lockout_window = ldb_msg_find_int64(dom_msgs[0], "lockOutObservationWindow",
+       info->lockout_window = ldb_msg_find_attr_as_int64(dom_msgs[0], "lockOutObservationWindow",
                                                    -18000000000LL);
-       info->lockout_threshold = ldb_msg_find_int64(dom_msgs[0], "lockoutThreshold", 0);
+       info->lockout_threshold = ldb_msg_find_attr_as_int64(dom_msgs[0], "lockoutThreshold", 0);
 
        return NT_STATUS_OK;
 }
@@ -631,15 +684,15 @@ static NTSTATUS samr_info_DomInfo12(struct samr_domain_state *state,
 /*
   return DomInfo13
 */
-static NTSTATUS samr_info_DomInfo13(struct samr_domain_state *state,
+static NTSTATUS dcesrv_samr_info_DomInfo13(struct samr_domain_state *state,
                                    TALLOC_CTX *mem_ctx,
                                    struct ldb_message **dom_msgs,
                                    struct samr_DomInfo13 *info)
 {
-       info->sequence_num = ldb_msg_find_uint64(dom_msgs[0], "modifiedCount", 
+       info->sequence_num = ldb_msg_find_attr_as_uint64(dom_msgs[0], "modifiedCount", 
                                               time(NULL));
 
-       info->domain_create_time = ldb_msg_find_uint(dom_msgs[0], "creationTime",
+       info->domain_create_time = ldb_msg_find_attr_as_uint(dom_msgs[0], "creationTime",
                                                     0x0LL);
 
        info->unknown1 = 0;
@@ -651,7 +704,7 @@ static NTSTATUS samr_info_DomInfo13(struct samr_domain_state *state,
 /* 
   samr_QueryDomainInfo 
 */
-static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                     struct samr_QueryDomainInfo *r)
 {
        struct dcesrv_handle *h;
@@ -684,24 +737,38 @@ static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_
        {
                static const char * const attrs2[] = {"forceLogoff",
                                                      "comment", 
-                                                     "modifiedCount"};
+                                                     "modifiedCount", 
+                                                     "fSMORoleOwner",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 3:
        {
-               static const char * const attrs2[] = {"forceLogoff"};
+               static const char * const attrs2[] = {"forceLogoff", 
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 4:
        {
-               static const char * const attrs2[] = {"comment"};
+               static const char * const attrs2[] = {"comment", 
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 5:
+       {
+               attrs = NULL;
+               break;
+       }
        case 6:
+       {
+               static const char * const attrs2[] = {"fSMORoleOwner", 
+                                                     NULL};
+               attrs = attrs2;
+               break;
+       }
        case 7:
        {
                attrs = NULL;
@@ -709,7 +776,9 @@ static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_
        }
        case 8:
        {
-               static const char * const attrs2[] = { "modifiedCount", "creationTime", NULL };
+               static const char * const attrs2[] = { "modifiedCount", 
+                                                      "creationTime", 
+                                                      NULL };
                attrs = attrs2;
                break;
        }
@@ -722,7 +791,8 @@ static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_
                                                       "modifiedCount", 
                                                       "lockoutDuration", 
                                                       "lockOutObservationWindow", 
-                                                      "lockoutThreshold", NULL};
+                                                      "lockoutThreshold", 
+                                                      NULL};
                attrs = attrs2;
                break;
        }
@@ -730,13 +800,16 @@ static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_
        {
                static const char * const attrs2[] = { "lockoutDuration", 
                                                       "lockOutObservationWindow", 
-                                                      "lockoutThreshold", NULL};
+                                                      "lockoutThreshold", 
+                                                      NULL};
                attrs = attrs2;
                break;
        }
        case 13:
        {
-               static const char * const attrs2[] = { "modifiedCount", "creationTime", NULL };
+               static const char * const attrs2[] = { "modifiedCount", 
+                                                      "creationTime", 
+                                                      NULL };
                attrs = attrs2;
                break;
        }
@@ -756,40 +829,40 @@ static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_
 
        switch (r->in.level) {
        case 1:
-               return samr_info_DomInfo1(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo1(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info1);
        case 2:
-               return samr_info_DomInfo2(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo2(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info2);
        case 3:
-               return samr_info_DomInfo3(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo3(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info3);
        case 4:
-               return samr_info_DomInfo4(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo4(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info4);
        case 5:
-               return samr_info_DomInfo5(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo5(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info5);
        case 6:
-               return samr_info_DomInfo6(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo6(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info6);
        case 7:
-               return samr_info_DomInfo7(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo7(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info7);
        case 8:
-               return samr_info_DomInfo8(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo8(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info8);
        case 9:
-               return samr_info_DomInfo9(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo9(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info9);
        case 11:
-               return samr_info_DomInfo11(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo11(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info11);
        case 12:
-               return samr_info_DomInfo12(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo12(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info12);
        case 13:
-               return samr_info_DomInfo13(d_state, mem_ctx, dom_msgs, 
+               return dcesrv_samr_info_DomInfo13(d_state, mem_ctx, dom_msgs, 
                                          &r->out.info->info13);
        }
 
@@ -800,7 +873,7 @@ static NTSTATUS samr_QueryDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_
 /* 
   samr_SetDomainInfo 
 */
-static NTSTATUS samr_SetDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_SetDomainInfo *r)
 {
        struct dcesrv_handle *h;
@@ -861,7 +934,7 @@ static NTSTATUS samr_SetDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
        ret = samdb_replace(sam_ctx, mem_ctx, msg);
        if (ret != 0) {
                DEBUG(1,("Failed to modify record %s: %s\n",
-                        ldb_dn_linearize(mem_ctx, d_state->domain_dn),
+                        ldb_dn_get_linearized(d_state->domain_dn),
                         ldb_errstring(sam_ctx)));
 
                /* we really need samdb.c to return NTSTATUS */
@@ -874,7 +947,7 @@ static NTSTATUS samr_SetDomainInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
 /* 
   samr_CreateDomainGroup 
 */
-static NTSTATUS samr_CreateDomainGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_CreateDomainGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                       struct samr_CreateDomainGroup *r)
 {
        struct samr_domain_state *d_state;
@@ -915,8 +988,8 @@ static NTSTATUS samr_CreateDomainGroup(struct dcesrv_call_state *dce_call, TALLO
        }
 
        /* add core elements to the ldb_message for the user */
-       msg->dn = ldb_dn_string_compose(mem_ctx, d_state->domain_dn,
-                                       "CN=%s,CN=Users", groupname);
+       msg->dn = ldb_dn_copy(mem_ctx, d_state->domain_dn);
+       ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=Users", groupname);
        if (!msg->dn) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -925,9 +998,23 @@ static NTSTATUS samr_CreateDomainGroup(struct dcesrv_call_state *dce_call, TALLO
                             
        /* create the group */
        ret = samdb_add(d_state->sam_ctx, mem_ctx, msg);
-       if (ret != 0) {
-               DEBUG(0,("Failed to create group record %s\n",
-                        ldb_dn_linearize(mem_ctx, msg->dn)));
+       switch (ret) {
+       case  LDB_SUCCESS:
+               break;
+       case  LDB_ERR_ENTRY_ALREADY_EXISTS:
+               DEBUG(0,("Failed to create group record %s: %s\n",
+                        ldb_dn_get_linearized(msg->dn),
+                        ldb_errstring(d_state->sam_ctx)));
+               return NT_STATUS_GROUP_EXISTS;
+       case  LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS:
+               DEBUG(0,("Failed to create group record %s: %s\n",
+                        ldb_dn_get_linearized(msg->dn),
+                        ldb_errstring(d_state->sam_ctx)));
+               return NT_STATUS_ACCESS_DENIED;
+       default:
+               DEBUG(0,("Failed to create group record %s: %s\n",
+                        ldb_dn_get_linearized(msg->dn),
+                        ldb_errstring(d_state->sam_ctx)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -978,7 +1065,7 @@ static int compare_SamEntry(struct samr_SamEntry *e1, struct samr_SamEntry *e2)
 /* 
   samr_EnumDomainGroups 
 */
-static NTSTATUS samr_EnumDomainGroups(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_EnumDomainGroups(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                      struct samr_EnumDomainGroups *r)
 {
        struct dcesrv_handle *h;
@@ -1076,7 +1163,7 @@ static NTSTATUS samr_EnumDomainGroups(struct dcesrv_call_state *dce_call, TALLOC
   user while we are processing this, and to ensure the user either
   completly exists, or does not.
 */
-static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                 struct samr_CreateUser2 *r)
 {
        struct samr_domain_state *d_state;
@@ -1124,7 +1211,7 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
        }
 
        /* check if the user already exists */
-       name = samdb_search_string(d_state->sam_ctx, mem_ctx, samdb_base_dn(mem_ctx)
+       name = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL
                                   "sAMAccountName", 
                                   "(&(sAMAccountName=%s)(objectclass=user))", 
                                   ldb_binary_encode_string(mem_ctx, account_name));
@@ -1178,11 +1265,12 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
        }
 
        /* add core elements to the ldb_message for the user */
-       msg->dn = ldb_dn_build_child(mem_ctx, "CN", cn_name, ldb_dn_build_child(mem_ctx, "CN", container, d_state->domain_dn));
-       if (!msg->dn) {
+       msg->dn = ldb_dn_copy(mem_ctx, d_state->domain_dn);
+       if ( ! ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=%s", cn_name, container)) {
                ldb_transaction_cancel(d_state->sam_ctx);
-               return NT_STATUS_NO_MEMORY;             
+               return NT_STATUS_FOOBAR;
        }
+
        samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "sAMAccountName", account_name);
        samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "objectClass", obj_class);
        
@@ -1196,13 +1284,19 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
        case  LDB_ERR_ENTRY_ALREADY_EXISTS:
                ldb_transaction_cancel(d_state->sam_ctx);
                DEBUG(0,("Failed to create user record %s: %s\n",
-                        ldb_dn_linearize(mem_ctx, msg->dn),
+                        ldb_dn_get_linearized(msg->dn),
                         ldb_errstring(d_state->sam_ctx)));
                return NT_STATUS_USER_EXISTS;
+       case  LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS:
+               ldb_transaction_cancel(d_state->sam_ctx);
+               DEBUG(0,("Failed to create user record %s: %s\n",
+                        ldb_dn_get_linearized(msg->dn),
+                        ldb_errstring(d_state->sam_ctx)));
+               return NT_STATUS_ACCESS_DENIED;
        default:
                ldb_transaction_cancel(d_state->sam_ctx);
                DEBUG(0,("Failed to create user record %s: %s\n",
-                        ldb_dn_linearize(mem_ctx, msg->dn),
+                        ldb_dn_get_linearized(msg->dn),
                         ldb_errstring(d_state->sam_ctx)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -1224,12 +1318,14 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
        if (ret != 1) {
                ldb_transaction_cancel(d_state->sam_ctx);
                DEBUG(0,("Apparently we failed to create an account record, as %s now doesn't exist\n",
-                        ldb_dn_linearize(mem_ctx, msg->dn)));
+                        ldb_dn_get_linearized(msg->dn)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
        sid = samdb_result_dom_sid(mem_ctx, msgs[0], "objectSid");
        if (sid == NULL) {
                ldb_transaction_cancel(d_state->sam_ctx);
+               DEBUG(0,("Apparently we failed to get the objectSid of the just created account record %s\n",
+                        ldb_dn_get_linearized(msg->dn)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -1263,7 +1359,7 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
        ret = samdb_replace(a_state->sam_ctx, mem_ctx, msg);
        if (ret != 0) {
                DEBUG(0,("Failed to modify account record %s to set userAccountControl: %s\n",
-                        ldb_dn_linearize(mem_ctx, msg->dn),
+                        ldb_dn_get_linearized(msg->dn),
                         ldb_errstring(d_state->sam_ctx)));
                ldb_transaction_cancel(d_state->sam_ctx);
 
@@ -1274,7 +1370,7 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
        ret = ldb_transaction_commit(d_state->sam_ctx);
        if (ret != 0) {
                DEBUG(0,("Failed to commit transaction to add and modify account record %s: %s\n",
-                        ldb_dn_linearize(mem_ctx, msg->dn),
+                        ldb_dn_get_linearized(msg->dn),
                         ldb_errstring(d_state->sam_ctx)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -1304,7 +1400,7 @@ static NTSTATUS samr_CreateUser2(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_CreateUser 
 */
-static NTSTATUS samr_CreateUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_CreateUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                struct samr_CreateUser *r)
 {
        struct samr_CreateUser2 r2;
@@ -1320,13 +1416,13 @@ static NTSTATUS samr_CreateUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *
        r2.out.access_granted = &access_granted;
        r2.out.rid = r->out.rid;
 
-       return samr_CreateUser2(dce_call, mem_ctx, &r2);
+       return dcesrv_samr_CreateUser2(dce_call, mem_ctx, &r2);
 }
 
 /* 
   samr_EnumDomainUsers 
 */
-static NTSTATUS samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                     struct samr_EnumDomainUsers *r)
 {
        struct dcesrv_handle *h;
@@ -1404,7 +1500,7 @@ static NTSTATUS samr_EnumDomainUsers(struct dcesrv_call_state *dce_call, TALLOC_
 /* 
   samr_CreateDomAlias 
 */
-static NTSTATUS samr_CreateDomAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_CreateDomAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_CreateDomAlias *r)
 {
        struct samr_domain_state *d_state;
@@ -1445,8 +1541,8 @@ static NTSTATUS samr_CreateDomAlias(struct dcesrv_call_state *dce_call, TALLOC_C
        }
 
        /* add core elements to the ldb_message for the alias */
-       msg->dn = ldb_dn_string_compose(mem_ctx, d_state->domain_dn,
-                                       "CN=%s, CN=Users", alias_name);
+       msg->dn = ldb_dn_copy(mem_ctx, d_state->domain_dn);
+       ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=Users", alias_name);
        if (!msg->dn) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1462,9 +1558,11 @@ static NTSTATUS samr_CreateDomAlias(struct dcesrv_call_state *dce_call, TALLOC_C
                break;
        case LDB_ERR_ENTRY_ALREADY_EXISTS:
                return NT_STATUS_ALIAS_EXISTS;
+       case LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS:
+               return NT_STATUS_ACCESS_DENIED;
        default:
                DEBUG(0,("Failed to create alias record %s: %s\n",
-                        ldb_dn_linearize(mem_ctx, msg->dn),
+                        ldb_dn_get_linearized(msg->dn),
                         ldb_errstring(d_state->sam_ctx)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -1506,7 +1604,7 @@ static NTSTATUS samr_CreateDomAlias(struct dcesrv_call_state *dce_call, TALLOC_C
 /* 
   samr_EnumDomainAliases 
 */
-static NTSTATUS samr_EnumDomainAliases(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_EnumDomainAliases(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_EnumDomainAliases *r)
 {
        struct dcesrv_handle *h;
@@ -1602,7 +1700,7 @@ static NTSTATUS samr_EnumDomainAliases(struct dcesrv_call_state *dce_call, TALLO
 /* 
   samr_GetAliasMembership 
 */
-static NTSTATUS samr_GetAliasMembership(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetAliasMembership(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetAliasMembership *r)
 {
        struct dcesrv_handle *h;
@@ -1631,7 +1729,7 @@ static NTSTATUS samr_GetAliasMembership(struct dcesrv_call_state *dce_call, TALL
 
                        memberdn = 
                                samdb_search_string(d_state->sam_ctx,
-                                                   mem_ctx, samdb_base_dn(mem_ctx), "distinguishedName",
+                                                   mem_ctx, NULL, "distinguishedName",
                                                    "(objectSid=%s)",
                                                    ldap_encode_ndr_dom_sid(mem_ctx, 
                                                                            r->in.sids->sids[i].sid));
@@ -1679,12 +1777,12 @@ static NTSTATUS samr_GetAliasMembership(struct dcesrv_call_state *dce_call, TALL
 /* 
   samr_LookupNames 
 */
-static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                 struct samr_LookupNames *r)
 {
        struct dcesrv_handle *h;
        struct samr_domain_state *d_state;
-       int i;
+       int i, num_mapped;
        NTSTATUS status = NT_STATUS_OK;
        const char * const attrs[] = { "sAMAccountType", "objectSid", NULL };
        int count;
@@ -1708,6 +1806,8 @@ static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX
        r->out.rids.count = r->in.num_names;
        r->out.types.count = r->in.num_names;
 
+       num_mapped = 0;
+
        for (i=0;i<r->in.num_names;i++) {
                struct ldb_message **res;
                struct dom_sid *sid;
@@ -1745,9 +1845,12 @@ static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX
 
                r->out.rids.ids[i] = sid->sub_auths[sid->num_auths-1];
                r->out.types.ids[i] = rtype;
+               num_mapped++;
        }
        
-
+       if (num_mapped == 0) {
+               return NT_STATUS_NONE_MAPPED;
+       }
        return status;
 }
 
@@ -1755,7 +1858,7 @@ static NTSTATUS samr_LookupNames(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_LookupRids 
 */
-static NTSTATUS samr_LookupRids(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_LookupRids(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_LookupRids *r)
 {
        struct dcesrv_handle *h;
@@ -1840,7 +1943,7 @@ static NTSTATUS samr_LookupRids(struct dcesrv_call_state *dce_call, TALLOC_CTX *
 /* 
   samr_OpenGroup 
 */
-static NTSTATUS samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_OpenGroup *r)
 {
        struct samr_domain_state *d_state;
@@ -1918,7 +2021,7 @@ static NTSTATUS samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
 /* 
   samr_QueryGroupInfo 
 */
-static NTSTATUS samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryGroupInfo *r)
 {
        struct dcesrv_handle *h;
@@ -1984,7 +2087,7 @@ static NTSTATUS samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_C
 /* 
   samr_SetGroupInfo 
 */
-static NTSTATUS samr_SetGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                  struct samr_SetGroupInfo *r)
 {
        struct dcesrv_handle *h;
@@ -2019,7 +2122,7 @@ static NTSTATUS samr_SetGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
                break;
        case GROUPINFOATTRIBUTES:
                /* This does not do anything obviously visible in W2k3 LDAP */
-               break;
+               return NT_STATUS_OK;
        default:
                return NT_STATUS_INVALID_INFO_CLASS;
        }
@@ -2038,7 +2141,7 @@ static NTSTATUS samr_SetGroupInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_AddGroupMember 
 */
-static NTSTATUS samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_AddGroupMember *r)
 {
        struct dcesrv_handle *h;
@@ -2049,7 +2152,6 @@ static NTSTATUS samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_C
        const char *memberdn;
        struct ldb_result *res;
        const char * const attrs[] = { NULL };
-       const char *filter;
        int ret;
 
        DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
@@ -2061,18 +2163,16 @@ static NTSTATUS samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_C
        if (membersid == NULL)
                return NT_STATUS_NO_MEMORY;
 
-       filter = talloc_asprintf(mem_ctx, "(&(objectSid=%s)(objectclass=user))",
-                                ldap_encode_ndr_dom_sid(mem_ctx, membersid));
-
        /* In native mode, AD can also nest domain groups. Not sure yet
         * whether this is also available via RPC. */
-       ret = ldb_search(d_state->sam_ctx, d_state->domain_dn, LDB_SCOPE_SUBTREE,
-                        filter, attrs, &res);
+       ret = ldb_search_exp_fmt(d_state->sam_ctx, mem_ctx, &res,
+                                d_state->domain_dn, LDB_SCOPE_SUBTREE, attrs,
+                                "(&(objectSid=%s)(objectclass=user))",
+                                ldap_encode_ndr_dom_sid(mem_ctx, membersid));
 
        if (ret != 0) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
-       talloc_steal(mem_ctx, res);
 
        if (res->count == 0) {
                return NT_STATUS_NO_SUCH_USER;
@@ -2082,7 +2182,7 @@ static NTSTATUS samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_C
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       memberdn = ldb_dn_linearize(mem_ctx, res->msgs[0]->dn);
+       memberdn = ldb_dn_alloc_linearized(mem_ctx, res->msgs[0]->dn);
 
        if (memberdn == NULL)
                return NT_STATUS_NO_MEMORY;
@@ -2104,6 +2204,8 @@ static NTSTATUS samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_C
                return NT_STATUS_OK;
        case LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS:
                return NT_STATUS_MEMBER_IN_GROUP;
+       case LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS:
+               return NT_STATUS_ACCESS_DENIED;
        default:
                return NT_STATUS_UNSUCCESSFUL;
        }
@@ -2114,7 +2216,7 @@ static NTSTATUS samr_AddGroupMember(struct dcesrv_call_state *dce_call, TALLOC_C
 /* 
   samr_DeleteDomainGroup 
 */
-static NTSTATUS samr_DeleteDomainGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_DeleteDomainGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_DeleteDomainGroup *r)
 {
        struct dcesrv_handle *h;
@@ -2141,7 +2243,7 @@ static NTSTATUS samr_DeleteDomainGroup(struct dcesrv_call_state *dce_call, TALLO
 /* 
   samr_DeleteGroupMember 
 */
-static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_DeleteGroupMember *r)
 {
        struct dcesrv_handle *h;
@@ -2152,7 +2254,6 @@ static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLO
        const char *memberdn;
        struct ldb_result *res;
        const char * const attrs[] = { NULL };
-       const char *filter;
        int ret;
 
        DCESRV_PULL_HANDLE(h, r->in.group_handle, SAMR_HANDLE_GROUP);
@@ -2164,18 +2265,16 @@ static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLO
        if (membersid == NULL)
                return NT_STATUS_NO_MEMORY;
 
-       filter = talloc_asprintf(mem_ctx, "(&(objectSid=%s)(objectclass=user))",
-                                ldap_encode_ndr_dom_sid(mem_ctx, membersid));
-
        /* In native mode, AD can also nest domain groups. Not sure yet
         * whether this is also available via RPC. */
-       ret = ldb_search(d_state->sam_ctx, d_state->domain_dn, LDB_SCOPE_SUBTREE,
-                        filter, attrs, &res);
+       ret = ldb_search_exp_fmt(d_state->sam_ctx, mem_ctx, &res,
+                                d_state->domain_dn, LDB_SCOPE_SUBTREE, attrs,
+                                "(&(objectSid=%s)(objectclass=user))",
+                                ldap_encode_ndr_dom_sid(mem_ctx, membersid));
 
        if (ret != 0) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
-       talloc_steal(mem_ctx, res);
 
        if (res->count == 0) {
                return NT_STATUS_NO_SUCH_USER;
@@ -2185,7 +2284,7 @@ static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLO
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       memberdn = ldb_dn_linearize(mem_ctx, res->msgs[0]->dn);
+       memberdn = ldb_dn_alloc_linearized(mem_ctx, res->msgs[0]->dn);
 
        if (memberdn == NULL)
                return NT_STATUS_NO_MEMORY;
@@ -2208,6 +2307,8 @@ static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLO
                return NT_STATUS_OK;
        case LDB_ERR_NO_SUCH_ATTRIBUTE:
                return NT_STATUS_MEMBER_NOT_IN_GROUP;
+       case LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS:
+               return NT_STATUS_ACCESS_DENIED;
        default:
                return NT_STATUS_UNSUCCESSFUL;
        }
@@ -2218,7 +2319,7 @@ static NTSTATUS samr_DeleteGroupMember(struct dcesrv_call_state *dce_call, TALLO
 /* 
   samr_QueryGroupMember 
 */
-static NTSTATUS samr_QueryGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryGroupMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                      struct samr_QueryGroupMember *r)
 {
        struct dcesrv_handle *h;
@@ -2269,7 +2370,7 @@ static NTSTATUS samr_QueryGroupMember(struct dcesrv_call_state *dce_call, TALLOC
                        struct ldb_message **res2;
                        const char * const attrs2[2] = { "objectSid", NULL };
                        ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
-                                          ldb_dn_explode(mem_ctx, (const char *)el->values[i].data),
+                                          ldb_dn_new(mem_ctx, a_state->sam_ctx, (const char *)el->values[i].data),
                                           &res2, attrs2);
                        if (ret != 1)
                                return NT_STATUS_INTERNAL_DB_CORRUPTION;
@@ -2294,7 +2395,7 @@ static NTSTATUS samr_QueryGroupMember(struct dcesrv_call_state *dce_call, TALLOC
 /* 
   samr_SetMemberAttributesOfGroup 
 */
-static NTSTATUS samr_SetMemberAttributesOfGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetMemberAttributesOfGroup(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_SetMemberAttributesOfGroup *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -2304,7 +2405,7 @@ static NTSTATUS samr_SetMemberAttributesOfGroup(struct dcesrv_call_state *dce_ca
 /* 
   samr_OpenAlias 
 */
-static NTSTATUS samr_OpenAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_OpenAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_OpenAlias *r)
 {
        struct samr_domain_state *d_state;
@@ -2383,7 +2484,7 @@ static NTSTATUS samr_OpenAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
 /* 
   samr_QueryAliasInfo 
 */
-static NTSTATUS samr_QueryAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryAliasInfo *r)
 {
        struct dcesrv_handle *h;
@@ -2438,7 +2539,7 @@ static NTSTATUS samr_QueryAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_C
 /* 
   samr_SetAliasInfo 
 */
-static NTSTATUS samr_SetAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_SetAliasInfo *r)
 {
        struct dcesrv_handle *h;
@@ -2489,7 +2590,7 @@ static NTSTATUS samr_SetAliasInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_DeleteDomAlias 
 */
-static NTSTATUS samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_DeleteDomAlias *r)
 {
        struct dcesrv_handle *h;
@@ -2516,7 +2617,7 @@ static NTSTATUS samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, TALLOC_C
 /* 
   samr_AddAliasMember 
 */
-static NTSTATUS samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_AddAliasMember *r)
 {
        struct dcesrv_handle *h;
@@ -2527,13 +2628,14 @@ static NTSTATUS samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_C
        const char * const attrs[] = { NULL };
        struct ldb_dn *memberdn = NULL;
        int ret;
+       NTSTATUS status;
 
        DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
 
        a_state = h->data;
        d_state = a_state->domain_state;
 
-       ret = gendb_search(d_state->sam_ctx, mem_ctx, samdb_base_dn(mem_ctx),
+       ret = gendb_search(d_state->sam_ctx, mem_ctx, NULL,
                           &msgs, attrs, "(objectsid=%s)", 
                           ldap_encode_ndr_dom_sid(mem_ctx, r->in.sid));
 
@@ -2544,58 +2646,13 @@ static NTSTATUS samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_C
                         ret, dom_sid_string(mem_ctx, r->in.sid)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               struct ldb_message *msg;
-               struct ldb_dn *basedn;
-               const char *sidstr;
-
-               sidstr = dom_sid_string(mem_ctx, r->in.sid);
-               NT_STATUS_HAVE_NO_MEMORY(sidstr);
-
-               /* We might have to create a ForeignSecurityPrincipal, even if this user
-                * is in our own domain */
-
-               msg = ldb_msg_new(mem_ctx);
-               if (msg == NULL) {
-                       return NT_STATUS_NO_MEMORY;
-               }
-
-               /* TODO: Hmmm. This feels wrong. How do I find the base dn to
-                * put the ForeignSecurityPrincipals? d_state->domain_dn does
-                * not work, this is wrong for the Builtin domain, there's no
-                * cn=For...,cn=Builtin,dc={BASEDN}.  -- vl
-                */
-
-               basedn = samdb_search_dn(d_state->sam_ctx, mem_ctx, samdb_base_dn(mem_ctx),
-                                        "(&(objectClass=container)(cn=ForeignSecurityPrincipals))");
-
-               if (basedn == NULL) {
-                       DEBUG(0, ("Failed to find DN for "
-                                 "ForeignSecurityPrincipal container\n"));
-                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
-               }
-
-               /* add core elements to the ldb_message for the alias */
-               msg->dn = ldb_dn_build_child(mem_ctx, "CN", sidstr, basedn);
-               if (msg->dn == NULL)
-                       return NT_STATUS_NO_MEMORY;
-
-               memberdn = msg->dn;
-
-               samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg,
-                                    "objectClass",
-                                    "foreignSecurityPrincipal");
-
-               /* create the alias */
-               ret = samdb_add(d_state->sam_ctx, mem_ctx, msg);
-               if (ret != 0) {
-                       DEBUG(0,("Failed to create foreignSecurityPrincipal "
-                                "record %s: %s\n", 
-                                ldb_dn_linearize(mem_ctx, msg->dn),
-                                ldb_errstring(d_state->sam_ctx)));
-                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               status = samdb_create_foreign_security_principal(d_state->sam_ctx, mem_ctx, 
+                                                                r->in.sid, &memberdn);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
        } else {
-               DEBUG(0, ("samdb_search returned %d\n", ret));
+               DEBUG(0, ("samdb_search returned %d: %s\n", ret, ldb_errstring(d_state->sam_ctx)));
        }
 
        if (memberdn == NULL) {
@@ -2611,7 +2668,7 @@ static NTSTATUS samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_C
        mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
 
        if (samdb_msg_add_addval(d_state->sam_ctx, mem_ctx, mod, "member",
-                                ldb_dn_linearize(mem_ctx, memberdn)) != 0)
+                                ldb_dn_alloc_linearized(mem_ctx, memberdn)) != 0)
                return NT_STATUS_UNSUCCESSFUL;
 
        if (samdb_modify(a_state->sam_ctx, mem_ctx, mod) != 0)
@@ -2624,7 +2681,7 @@ static NTSTATUS samr_AddAliasMember(struct dcesrv_call_state *dce_call, TALLOC_C
 /* 
   samr_DeleteAliasMember 
 */
-static NTSTATUS samr_DeleteAliasMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_DeleteAliasMember(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_DeleteAliasMember *r)
 {
        struct dcesrv_handle *h;
@@ -2638,7 +2695,7 @@ static NTSTATUS samr_DeleteAliasMember(struct dcesrv_call_state *dce_call, TALLO
        a_state = h->data;
        d_state = a_state->domain_state;
 
-       memberdn = samdb_search_string(d_state->sam_ctx, mem_ctx, samdb_base_dn(mem_ctx),
+       memberdn = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL,
                                       "distinguishedName", "(objectSid=%s)", 
                                       ldap_encode_ndr_dom_sid(mem_ctx, r->in.sid));
 
@@ -2666,7 +2723,7 @@ static NTSTATUS samr_DeleteAliasMember(struct dcesrv_call_state *dce_call, TALLO
 /* 
   samr_GetMembersInAlias 
 */
-static NTSTATUS samr_GetMembersInAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetMembersInAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetMembersInAlias *r)
 {
        struct dcesrv_handle *h;
@@ -2707,7 +2764,7 @@ static NTSTATUS samr_GetMembersInAlias(struct dcesrv_call_state *dce_call, TALLO
                        struct ldb_message **msgs2;
                        const char * const attrs2[2] = { "objectSid", NULL };
                        ret = gendb_search_dn(a_state->sam_ctx, mem_ctx,
-                                          ldb_dn_explode(mem_ctx, (const char *)el->values[i].data),
+                                          ldb_dn_new(mem_ctx, a_state->sam_ctx, (const char *)el->values[i].data),
                                           &msgs2, attrs2);
                        if (ret != 1)
                                return NT_STATUS_INTERNAL_DB_CORRUPTION;
@@ -2728,7 +2785,7 @@ static NTSTATUS samr_GetMembersInAlias(struct dcesrv_call_state *dce_call, TALLO
 /* 
   samr_OpenUser 
 */
-static NTSTATUS samr_OpenUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_OpenUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                              struct samr_OpenUser *r)
 {
        struct samr_domain_state *d_state;
@@ -2806,7 +2863,7 @@ static NTSTATUS samr_OpenUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 /* 
   samr_DeleteUser 
 */
-static NTSTATUS samr_DeleteUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_DeleteUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                struct samr_DeleteUser *r)
 {
        struct dcesrv_handle *h;
@@ -2833,7 +2890,7 @@ static NTSTATUS samr_DeleteUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *
 /* 
   samr_QueryUserInfo 
 */
-static NTSTATUS samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                   struct samr_QueryUserInfo *r)
 {
        struct dcesrv_handle *h;
@@ -3187,7 +3244,7 @@ static NTSTATUS samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
 /* 
   samr_SetUserInfo 
 */
-static NTSTATUS samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                 struct samr_SetUserInfo *r)
 {
        struct dcesrv_handle *h;
@@ -3264,6 +3321,10 @@ static NTSTATUS samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
                SET_AFLAGS(msg, info16.acct_flags,             "userAccountControl");
                break;
 
+       case 17:
+               SET_UINT64(msg, info17.acct_expiry,            "accountExpires");
+               break;
+
        case 20:
                SET_STRING(msg, info20.parameters.string,      "userParameters");
                break;
@@ -3271,29 +3332,33 @@ static NTSTATUS samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
        case 21:
 #define IFSET(bit) if (bit & r->in.info->info21.fields_present)
                IFSET(SAMR_FIELD_ACCOUNT_NAME)         
-                       SET_STRING(msg, info21.account_name.string, "samAccountName");
-               IFSET(SAMR_FIELD_FULL_NAME)         
-                       SET_STRING(msg, info21.full_name.string,    "displayName");
-               IFSET(SAMR_FIELD_DESCRIPTION)  
-                       SET_STRING(msg, info21.description.string,  "description");
-               IFSET(SAMR_FIELD_COMMENT)      
-                       SET_STRING(msg, info21.comment.string,      "comment");
-               IFSET(SAMR_FIELD_LOGON_SCRIPT) 
-                       SET_STRING(msg, info21.logon_script.string, "scriptPath");
-               IFSET(SAMR_FIELD_PROFILE_PATH)      
-                       SET_STRING(msg, info21.profile_path.string, "profilePath");
-               IFSET(SAMR_FIELD_WORKSTATIONS)  
-                       SET_STRING(msg, info21.workstations.string, "userWorkstations");
-               IFSET(SAMR_FIELD_LOGON_HOURS)  
-                       SET_LHOURS(msg, info21.logon_hours,         "logonHours");
-               IFSET(SAMR_FIELD_ACCT_FLAGS)     
-                       SET_AFLAGS(msg, info21.acct_flags,          "userAccountControl");
-               IFSET(SAMR_FIELD_PARAMETERS)     
-                       SET_STRING(msg, info21.parameters.string,   "userParameters");
-               IFSET(SAMR_FIELD_COUNTRY_CODE) 
-                       SET_UINT  (msg, info21.country_code,        "countryCode");
-               IFSET(SAMR_FIELD_CODE_PAGE)    
-                       SET_UINT  (msg, info21.code_page,           "codePage");
+                       SET_STRING(msg, info21.account_name.string,   "samAccountName");
+               IFSET(SAMR_FIELD_FULL_NAME) 
+                       SET_STRING(msg, info21.full_name.string,      "displayName");
+               IFSET(SAMR_FIELD_DESCRIPTION)
+                       SET_STRING(msg, info21.description.string,    "description");
+               IFSET(SAMR_FIELD_COMMENT)
+                       SET_STRING(msg, info21.comment.string,        "comment");
+               IFSET(SAMR_FIELD_LOGON_SCRIPT)
+                       SET_STRING(msg, info21.logon_script.string,   "scriptPath");
+               IFSET(SAMR_FIELD_PROFILE_PATH)
+                       SET_STRING(msg, info21.profile_path.string,   "profilePath");
+               IFSET(SAMR_FIELD_HOME_DIRECTORY)
+                       SET_STRING(msg, info21.home_directory.string, "homeDirectory");
+               IFSET(SAMR_FIELD_HOME_DRIVE)
+                       SET_STRING(msg, info21.home_drive.string,     "homeDrive");
+               IFSET(SAMR_FIELD_WORKSTATIONS)
+                       SET_STRING(msg, info21.workstations.string,   "userWorkstations");
+               IFSET(SAMR_FIELD_LOGON_HOURS)
+                       SET_LHOURS(msg, info21.logon_hours,           "logonHours");
+               IFSET(SAMR_FIELD_ACCT_FLAGS)
+                       SET_AFLAGS(msg, info21.acct_flags,            "userAccountControl");
+               IFSET(SAMR_FIELD_PARAMETERS)   
+                       SET_STRING(msg, info21.parameters.string,     "userParameters");
+               IFSET(SAMR_FIELD_COUNTRY_CODE)
+                       SET_UINT  (msg, info21.country_code,          "countryCode");
+               IFSET(SAMR_FIELD_CODE_PAGE)
+                       SET_UINT  (msg, info21.code_page,             "codePage");
 
 
                /* Any reason the rest of these can't be set? */
@@ -3422,7 +3487,7 @@ static NTSTATUS samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
        ret = samdb_replace(a_state->sam_ctx, mem_ctx, msg);
        if (ret != 0) {
                DEBUG(1,("Failed to modify record %s: %s\n",
-                        ldb_dn_linearize(mem_ctx, a_state->account_dn),
+                        ldb_dn_get_linearized(a_state->account_dn),
                         ldb_errstring(a_state->sam_ctx)));
 
                /* we really need samdb.c to return NTSTATUS */
@@ -3436,7 +3501,7 @@ static NTSTATUS samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_GetGroupsForUser 
 */
-static NTSTATUS samr_GetGroupsForUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetGroupsForUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetGroupsForUser *r)
 {
        struct dcesrv_handle *h;
@@ -3455,7 +3520,7 @@ static NTSTATUS samr_GetGroupsForUser(struct dcesrv_call_state *dce_call, TALLOC
        count = samdb_search_domain(a_state->sam_ctx, mem_ctx, d_state->domain_dn, &res,
                                    attrs, d_state->domain_sid,
                                    "(&(member=%s)(grouptype=%d)(objectclass=group))",
-                                   ldb_dn_linearize(mem_ctx, a_state->account_dn),
+                                   ldb_dn_get_linearized(a_state->account_dn),
                                    GTYPE_SECURITY_GLOBAL_GROUP);
        if (count < 0)
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
@@ -3501,7 +3566,7 @@ static NTSTATUS samr_GetGroupsForUser(struct dcesrv_call_state *dce_call, TALLOC
 /* 
   samr_QueryDisplayInfo 
 */
-static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryDisplayInfo *r)
 {
        struct dcesrv_handle *h;
@@ -3511,6 +3576,7 @@ static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC
        const char * const attrs[4] = { "objectSid", "sAMAccountName",
                                        "description", NULL };
        struct samr_DispEntryFull *entriesFull = NULL;
+       struct samr_DispEntryFullGroup *entriesFullGroup = NULL;
        struct samr_DispEntryAscii *entriesAscii = NULL;
        struct samr_DispEntryGeneral * entriesGeneral = NULL;
        const char *filter;
@@ -3560,11 +3626,15 @@ static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC
                                                ldb_cnt);
                break;
        case 2:
-       case 3:
                entriesFull = talloc_array(mem_ctx,
                                             struct samr_DispEntryFull,
                                             ldb_cnt);
                break;
+       case 3:
+               entriesFullGroup = talloc_array(mem_ctx,
+                                            struct samr_DispEntryFullGroup,
+                                            ldb_cnt);
+               break;
        case 4:
        case 5:
                entriesAscii = talloc_array(mem_ctx,
@@ -3574,7 +3644,7 @@ static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC
        }
 
        if ((entriesGeneral == NULL) && (entriesFull == NULL) &&
-           (entriesAscii == NULL))
+           (entriesAscii == NULL) && (entriesFullGroup == NULL))
                return NT_STATUS_NO_MEMORY;
 
        count = 0;
@@ -3604,23 +3674,34 @@ static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC
                                samdb_result_string(res[i], "description", "");
                        break;
                case 2:
-               case 3:
                        entriesFull[count].idx = count + 1;
                        entriesFull[count].rid =
                                objectsid->sub_auths[objectsid->num_auths-1];
                        entriesFull[count].acct_flags =
                                samdb_result_acct_flags(res[i], 
                                                        "userAccountControl");
-                       if (r->in.level == 3) {
-                               /* We get a "7" here for groups */
-                               entriesFull[count].acct_flags = 7;
-                       }
                        entriesFull[count].account_name.string =
                                samdb_result_string(res[i], "sAMAccountName",
                                                    "");
                        entriesFull[count].description.string =
                                samdb_result_string(res[i], "description", "");
                        break;
+               case 3:
+                       entriesFullGroup[count].idx = count + 1;
+                       entriesFullGroup[count].rid =
+                               objectsid->sub_auths[objectsid->num_auths-1];
+                       entriesFullGroup[count].acct_flags =
+                               samdb_result_acct_flags(res[i], 
+                                                       "userAccountControl");
+                       /* We get a "7" here for groups */
+                       entriesFullGroup[count].acct_flags
+                               = SE_GROUP_MANDATORY | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED;
+                       entriesFullGroup[count].account_name.string =
+                               samdb_result_string(res[i], "sAMAccountName",
+                                                   "");
+                       entriesFullGroup[count].description.string =
+                               samdb_result_string(res[i], "description", "");
+                       break;
                case 4:
                case 5:
                        entriesAscii[count].idx = count + 1;
@@ -3676,7 +3757,7 @@ static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC
                case 3:
                        r->out.info.info3.count = r->out.returned_size;
                        r->out.info.info3.entries =
-                               &(entriesFull[r->in.start_idx]);
+                               &(entriesFullGroup[r->in.start_idx]);
                        break;
                case 4:
                        r->out.info.info4.count = r->out.returned_size;
@@ -3699,7 +3780,7 @@ static NTSTATUS samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call, TALLOC
 /* 
   samr_GetDisplayEnumerationIndex 
 */
-static NTSTATUS samr_GetDisplayEnumerationIndex(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetDisplayEnumerationIndex(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetDisplayEnumerationIndex *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -3709,7 +3790,7 @@ static NTSTATUS samr_GetDisplayEnumerationIndex(struct dcesrv_call_state *dce_ca
 /* 
   samr_TestPrivateFunctionsDomain 
 */
-static NTSTATUS samr_TestPrivateFunctionsDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_TestPrivateFunctionsDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_TestPrivateFunctionsDomain *r)
 {
        return NT_STATUS_NOT_IMPLEMENTED;
@@ -3719,7 +3800,7 @@ static NTSTATUS samr_TestPrivateFunctionsDomain(struct dcesrv_call_state *dce_ca
 /* 
   samr_TestPrivateFunctionsUser 
 */
-static NTSTATUS samr_TestPrivateFunctionsUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_TestPrivateFunctionsUser(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_TestPrivateFunctionsUser *r)
 {
        return NT_STATUS_NOT_IMPLEMENTED;
@@ -3729,7 +3810,7 @@ static NTSTATUS samr_TestPrivateFunctionsUser(struct dcesrv_call_state *dce_call
 /* 
   samr_GetUserPwInfo 
 */
-static NTSTATUS samr_GetUserPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetUserPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                   struct samr_GetUserPwInfo *r)
 {
        struct dcesrv_handle *h;
@@ -3754,7 +3835,7 @@ static NTSTATUS samr_GetUserPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CT
 /* 
   samr_RemoveMemberFromForeignDomain 
 */
-static NTSTATUS samr_RemoveMemberFromForeignDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_RemoveMemberFromForeignDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_RemoveMemberFromForeignDomain *r)
 {
        struct dcesrv_handle *h;
@@ -3799,7 +3880,7 @@ static NTSTATUS samr_RemoveMemberFromForeignDomain(struct dcesrv_call_state *dce
                        return NT_STATUS_NO_MEMORY;
                }
 
-               mod->dn = samdb_result_dn(mod, res[i], "distinguishedName", NULL);
+               mod->dn = samdb_result_dn(d_state->sam_ctx, mod, res[i], "distinguishedName", NULL);
                if (mod->dn == NULL) {
                        talloc_free(mod);
                        continue;
@@ -3824,7 +3905,7 @@ static NTSTATUS samr_RemoveMemberFromForeignDomain(struct dcesrv_call_state *dce
 
   just an alias for samr_QueryDomainInfo
 */
-static NTSTATUS samr_QueryDomainInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryDomainInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryDomainInfo2 *r)
 {
        struct samr_QueryDomainInfo r1;
@@ -3834,7 +3915,7 @@ static NTSTATUS samr_QueryDomainInfo2(struct dcesrv_call_state *dce_call, TALLOC
        r1.in.domain_handle = r->in.domain_handle;
        r1.in.level  = r->in.level;
        
-       status = samr_QueryDomainInfo(dce_call, mem_ctx, &r1);
+       status = dcesrv_samr_QueryDomainInfo(dce_call, mem_ctx, &r1);
        
        r->out.info = r1.out.info;
 
@@ -3847,7 +3928,7 @@ static NTSTATUS samr_QueryDomainInfo2(struct dcesrv_call_state *dce_call, TALLOC
 
   just an alias for samr_QueryUserInfo
 */
-static NTSTATUS samr_QueryUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                    struct samr_QueryUserInfo2 *r)
 {
        struct samr_QueryUserInfo r1;
@@ -3857,7 +3938,7 @@ static NTSTATUS samr_QueryUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_C
        r1.in.user_handle = r->in.user_handle;
        r1.in.level  = r->in.level;
        
-       status = samr_QueryUserInfo(dce_call, mem_ctx, &r1);
+       status = dcesrv_samr_QueryUserInfo(dce_call, mem_ctx, &r1);
        
        r->out.info = r1.out.info;
 
@@ -3868,7 +3949,7 @@ static NTSTATUS samr_QueryUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_C
 /* 
   samr_QueryDisplayInfo2 
 */
-static NTSTATUS samr_QueryDisplayInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryDisplayInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                       struct samr_QueryDisplayInfo2 *r)
 {
        struct samr_QueryDisplayInfo q;
@@ -3881,7 +3962,7 @@ static NTSTATUS samr_QueryDisplayInfo2(struct dcesrv_call_state *dce_call, TALLO
        q.in.buf_size = r->in.buf_size;
        ZERO_STRUCT(q.out);
 
-       result = samr_QueryDisplayInfo(dce_call, mem_ctx, &q);
+       result = dcesrv_samr_QueryDisplayInfo(dce_call, mem_ctx, &q);
 
        r->out.total_size = q.out.total_size;
        r->out.returned_size = q.out.returned_size;
@@ -3894,7 +3975,7 @@ static NTSTATUS samr_QueryDisplayInfo2(struct dcesrv_call_state *dce_call, TALLO
 /* 
   samr_GetDisplayEnumerationIndex2 
 */
-static NTSTATUS samr_GetDisplayEnumerationIndex2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetDisplayEnumerationIndex2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetDisplayEnumerationIndex2 *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -3904,7 +3985,7 @@ static NTSTATUS samr_GetDisplayEnumerationIndex2(struct dcesrv_call_state *dce_c
 /* 
   samr_QueryDisplayInfo3 
 */
-static NTSTATUS samr_QueryDisplayInfo3(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_QueryDisplayInfo3(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_QueryDisplayInfo3 *r)
 {
        struct samr_QueryDisplayInfo q;
@@ -3917,7 +3998,7 @@ static NTSTATUS samr_QueryDisplayInfo3(struct dcesrv_call_state *dce_call, TALLO
        q.in.buf_size = r->in.buf_size;
        ZERO_STRUCT(q.out);
 
-       result = samr_QueryDisplayInfo(dce_call, mem_ctx, &q);
+       result = dcesrv_samr_QueryDisplayInfo(dce_call, mem_ctx, &q);
 
        r->out.total_size = q.out.total_size;
        r->out.returned_size = q.out.returned_size;
@@ -3930,7 +4011,7 @@ static NTSTATUS samr_QueryDisplayInfo3(struct dcesrv_call_state *dce_call, TALLO
 /* 
   samr_AddMultipleMembersToAlias 
 */
-static NTSTATUS samr_AddMultipleMembersToAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_AddMultipleMembersToAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_AddMultipleMembersToAlias *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -3940,7 +4021,7 @@ static NTSTATUS samr_AddMultipleMembersToAlias(struct dcesrv_call_state *dce_cal
 /* 
   samr_RemoveMultipleMembersFromAlias 
 */
-static NTSTATUS samr_RemoveMultipleMembersFromAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_RemoveMultipleMembersFromAlias(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_RemoveMultipleMembersFromAlias *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -3955,7 +4036,7 @@ static NTSTATUS samr_RemoveMultipleMembersFromAlias(struct dcesrv_call_state *dc
   note that w2k3 completely ignores the domain name in this call, and 
   always returns the information for the servers primary domain
 */
-static NTSTATUS samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                  struct samr_GetDomPwInfo *r)
 {
        struct ldb_message **msgs;
@@ -3972,7 +4053,7 @@ static NTSTATUS samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
 
        /* The domain name in this call is ignored */
        ret = gendb_search_dn(sam_ctx, 
-                          mem_ctx, samdb_base_dn(mem_ctx), &msgs, attrs);
+                          mem_ctx, NULL, &msgs, attrs);
        if (ret <= 0) {
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
@@ -3994,7 +4075,7 @@ static NTSTATUS samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TALLOC_CTX
 /* 
   samr_Connect2 
 */
-static NTSTATUS samr_Connect2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_Connect2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                              struct samr_Connect2 *r)
 {
        struct samr_Connect c;
@@ -4003,7 +4084,7 @@ static NTSTATUS samr_Connect2(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
        c.in.access_mask = r->in.access_mask;
        c.out.connect_handle = r->out.connect_handle;
 
-       return samr_Connect(dce_call, mem_ctx, &c);
+       return dcesrv_samr_Connect(dce_call, mem_ctx, &c);
 }
 
 
@@ -4012,7 +4093,7 @@ static NTSTATUS samr_Connect2(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 
   just an alias for samr_SetUserInfo
 */
-static NTSTATUS samr_SetUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                  struct samr_SetUserInfo2 *r)
 {
        struct samr_SetUserInfo r2;
@@ -4021,14 +4102,14 @@ static NTSTATUS samr_SetUserInfo2(struct dcesrv_call_state *dce_call, TALLOC_CTX
        r2.in.level = r->in.level;
        r2.in.info = r->in.info;
 
-       return samr_SetUserInfo(dce_call, mem_ctx, &r2);
+       return dcesrv_samr_SetUserInfo(dce_call, mem_ctx, &r2);
 }
 
 
 /* 
   samr_SetBootKeyInformation 
 */
-static NTSTATUS samr_SetBootKeyInformation(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetBootKeyInformation(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_SetBootKeyInformation *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -4038,7 +4119,7 @@ static NTSTATUS samr_SetBootKeyInformation(struct dcesrv_call_state *dce_call, T
 /* 
   samr_GetBootKeyInformation 
 */
-static NTSTATUS samr_GetBootKeyInformation(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_GetBootKeyInformation(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_GetBootKeyInformation *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -4048,7 +4129,7 @@ static NTSTATUS samr_GetBootKeyInformation(struct dcesrv_call_state *dce_call, T
 /* 
   samr_Connect3 
 */
-static NTSTATUS samr_Connect3(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_Connect3(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_Connect3 *r)
 {
        struct samr_Connect c;
@@ -4057,14 +4138,14 @@ static NTSTATUS samr_Connect3(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
        c.in.access_mask = r->in.access_mask;
        c.out.connect_handle = r->out.connect_handle;
 
-       return samr_Connect(dce_call, mem_ctx, &c);
+       return dcesrv_samr_Connect(dce_call, mem_ctx, &c);
 }
 
 
 /* 
   samr_Connect4 
 */
-static NTSTATUS samr_Connect4(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_Connect4(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_Connect4 *r)
 {
        struct samr_Connect c;
@@ -4073,14 +4154,14 @@ static NTSTATUS samr_Connect4(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
        c.in.access_mask = r->in.access_mask;
        c.out.connect_handle = r->out.connect_handle;
 
-       return samr_Connect(dce_call, mem_ctx, &c);
+       return dcesrv_samr_Connect(dce_call, mem_ctx, &c);
 }
 
 
 /* 
   samr_Connect5 
 */
-static NTSTATUS samr_Connect5(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_Connect5(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                              struct samr_Connect5 *r)
 {
        struct samr_Connect c;
@@ -4090,7 +4171,7 @@ static NTSTATUS samr_Connect5(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
        c.in.access_mask = r->in.access_mask;
        c.out.connect_handle = r->out.connect_handle;
 
-       status = samr_Connect(dce_call, mem_ctx, &c);
+       status = dcesrv_samr_Connect(dce_call, mem_ctx, &c);
 
        r->out.info->info1.unknown1 = 3;
        r->out.info->info1.unknown2 = 0;
@@ -4103,7 +4184,7 @@ static NTSTATUS samr_Connect5(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 /* 
   samr_RidToSid 
 */
-static NTSTATUS samr_RidToSid(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_RidToSid(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                              struct samr_RidToSid *r)
 {
        struct samr_domain_state *d_state;
@@ -4126,7 +4207,7 @@ static NTSTATUS samr_RidToSid(struct dcesrv_call_state *dce_call, TALLOC_CTX *me
 /* 
   samr_SetDsrmPassword 
 */
-static NTSTATUS samr_SetDsrmPassword(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_SetDsrmPassword(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                       struct samr_SetDsrmPassword *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
@@ -4136,7 +4217,7 @@ static NTSTATUS samr_SetDsrmPassword(struct dcesrv_call_state *dce_call, TALLOC_
 /* 
   samr_ValidatePassword 
 */
-static NTSTATUS samr_ValidatePassword(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
+static NTSTATUS dcesrv_samr_ValidatePassword(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
                                      struct samr_ValidatePassword *r)
 {
        DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);