r23792: convert Samba4 to GPLv3
[kai/samba-autobuild/.git] / source4 / ntvfs / posix / pvfs_open.c
index 3d0e444d29959beee4b6dae945dbd8884136746d..269df13069da5315c9ca81c943a620f20f28d392 100644 (file)
@@ -7,7 +7,7 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 #include "vfs_posix.h"
+#include "system/dir.h"
 #include "system/time.h"
-#include "system/filesys.h"
-#include "dlinklist.h"
-#include "messages.h"
-#include "librpc/gen_ndr/ndr_xattr.h"
-
-/*
-  create file handles with convenient numbers for sniffers
-*/
-#define PVFS_MIN_FILE_FNUM 0x100
-#define PVFS_MIN_NEW_FNUM  0x200
-#define PVFS_MIN_DIR_FNUM  0x300
+#include "lib/util/dlinklist.h"
+#include "messaging/messaging.h"
+#include "librpc/gen_ndr/xattr.h"
 
 /*
   find open file handle given fnum
 */
 struct pvfs_file *pvfs_find_fd(struct pvfs_state *pvfs,
-                              struct smbsrv_request *req, uint16_t fnum)
+                              struct ntvfs_request *req, struct ntvfs_handle *h)
 {
+       void *p;
        struct pvfs_file *f;
 
-       f = idr_find(pvfs->idtree_fnum, fnum);
-       if (f == NULL) {
-               return NULL;
-       }
-
-       if (f->fnum != fnum) {
-               smb_panic("pvfs_find_fd: idtree_fnum corruption\n");
-       }
+       p = ntvfs_handle_get_backend_data(h, pvfs->ntvfs);
+       if (!p) return NULL;
 
-       if (req->session != f->session) {
-               DEBUG(2,("pvfs_find_fd: attempt to use wrong session for fnum %d\n", 
-                        fnum));
-               return NULL;
-       }
+       f = talloc_get_type(p, struct pvfs_file);
+       if (!f) return NULL;
 
        return f;
 }
 
-
 /*
   cleanup a open directory handle
 */
-static int pvfs_dir_handle_destructor(void *p)
+static int pvfs_dir_handle_destructor(struct pvfs_file_handle *h)
 {
-       struct pvfs_file_handle *h = p;
+       int open_count;
+       char *path = NULL;
 
-       if (h->create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) {
-               if (rmdir(h->name->full_name) != 0) {
-                       DEBUG(0,("pvfs_close: failed to rmdir '%s' - %s\n", 
-                                h->name->full_name, strerror(errno)));
+       if (h->name->stream_name == NULL && 
+           pvfs_delete_on_close_set(h->pvfs, h, &open_count, &path) &&
+           open_count == 1) {
+               NTSTATUS status;
+               status = pvfs_xattr_unlink_hook(h->pvfs, path);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0,("Warning: xattr unlink hook failed for '%s' - %s\n",
+                                path, nt_errstr(status)));
+               }
+               if (rmdir(path) != 0) {
+                       DEBUG(0,("pvfs_dir_handle_destructor: failed to rmdir '%s' - %s\n", 
+                                path, strerror(errno)));
                }
        }
 
+       talloc_free(path);
+
+       if (h->have_opendb_entry) {
+               struct odb_lock *lck;
+               NTSTATUS status;
+
+               lck = odb_lock(h, h->pvfs->odb_context, &h->odb_locking_key);
+               if (lck == NULL) {
+                       DEBUG(0,("Unable to lock opendb for close\n"));
+                       return 0;
+               }
+
+               status = odb_close_file(lck, h);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0,("Unable to remove opendb entry for '%s' - %s\n", 
+                                h->name->full_name, nt_errstr(status)));
+               }
+
+               talloc_free(lck);
+       }
+
        return 0;
 }
 
 /*
   cleanup a open directory fnum
 */
-static int pvfs_dir_fnum_destructor(void *p)
+static int pvfs_dir_fnum_destructor(struct pvfs_file *f)
 {
-       struct pvfs_file *f = p;
-       DLIST_REMOVE(f->pvfs->open_files, f);
-       idr_remove(f->pvfs->idtree_fnum, f->fnum);
+       DLIST_REMOVE(f->pvfs->files.list, f);
+       ntvfs_handle_remove_backend_data(f->ntvfs, f->pvfs->ntvfs);
+
        return 0;
 }
 
+/*
+  setup any EAs and the ACL on newly created files/directories
+*/
+static NTSTATUS pvfs_open_setup_eas_acl(struct pvfs_state *pvfs,
+                                       struct ntvfs_request *req,
+                                       struct pvfs_filename *name,
+                                       int fd, struct pvfs_file *f,
+                                       union smb_open *io)
+{
+       NTSTATUS status;
+
+       /* setup any EAs that were asked for */
+       if (io->ntcreatex.in.ea_list) {
+               status = pvfs_setfileinfo_ea_set(pvfs, name, fd, 
+                                                io->ntcreatex.in.ea_list->num_eas,
+                                                io->ntcreatex.in.ea_list->eas);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
+       }
+
+       /* setup an initial sec_desc if requested */
+       if (io->ntcreatex.in.sec_desc) {
+               union smb_setfileinfo set;
+/* 
+ * TODO: set the full ACL! 
+ *       - vista denies the creation of the file with NT_STATUS_PRIVILEGE_NOT_HELD,
+ *         when a SACL is present on the sd,
+ *         but the user doesn't have SeSecurityPrivilege
+ *       - w2k3 allows it
+ */
+               set.set_secdesc.in.file.ntvfs = f->ntvfs;
+               set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
+               set.set_secdesc.in.sd = io->ntcreatex.in.sec_desc;
+
+               status = pvfs_acl_set(pvfs, req, name, fd, SEC_STD_WRITE_DAC, &set);
+       } else {
+               /* otherwise setup an inherited acl from the parent */
+               status = pvfs_acl_inherit(pvfs, req, name, fd);
+       }
+
+       return status;
+}
+
+/*
+  form the lock context used for opendb locking. Note that we must
+  zero here to take account of possible padding on some architectures
+*/
+static NTSTATUS pvfs_locking_key(struct pvfs_filename *name, 
+                                TALLOC_CTX *mem_ctx, DATA_BLOB *key)
+{
+       struct {
+               dev_t device;
+               ino_t inode;
+       } lock_context;
+       ZERO_STRUCT(lock_context);
+
+       lock_context.device = name->st.st_dev;
+       lock_context.inode = name->st.st_ino;
+
+       *key = data_blob_talloc(mem_ctx, &lock_context, sizeof(lock_context));
+       if (key->data == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       
+       return NT_STATUS_OK;
+}
+
 
 /*
   open a directory
 */
 static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs, 
-                                   struct smbsrv_request *req, 
+                                   struct ntvfs_request *req, 
                                    struct pvfs_filename *name, 
                                    union smb_open *io)
 {
        struct pvfs_file *f;
-       int fnum;
+       struct ntvfs_handle *h;
        NTSTATUS status;
        uint32_t create_action;
+       uint32_t access_mask = io->generic.in.access_mask;
+       struct odb_lock *lck;
+       BOOL del_on_close;
+       uint32_t create_options;
+       uint32_t share_access;
+
+       create_options = io->generic.in.create_options;
+       share_access   = io->generic.in.share_access;
 
        if (name->stream_name) {
                return NT_STATUS_NOT_A_DIRECTORY;
@@ -137,45 +226,89 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       f = talloc_p(req, struct pvfs_file);
+       status = ntvfs_handle_new(pvfs->ntvfs, req, &h);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       f = talloc(h, struct pvfs_file);
        if (f == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       f->handle = talloc_p(f, struct pvfs_file_handle);
+       f->handle = talloc(f, struct pvfs_file_handle);
        if (f->handle == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       fnum = idr_get_new_above(pvfs->idtree_fnum, f, PVFS_MIN_DIR_FNUM, UINT16_MAX);
-       if (fnum == -1) {
-               return NT_STATUS_TOO_MANY_OPENED_FILES;
+       if (name->exists) {
+               /* check the security descriptor */
+               status = pvfs_access_check(pvfs, req, name, &access_mask);
+       } else {
+               status = pvfs_access_check_create(pvfs, req, name, &access_mask);
+       }
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       f->fnum          = fnum;
-       f->session       = req->session;
-       f->smbpid        = req->smbpid;
+       f->ntvfs         = h;
        f->pvfs          = pvfs;
        f->pending_list  = NULL;
        f->lock_count    = 0;
        f->share_access  = io->generic.in.share_access;
        f->impersonation = io->generic.in.impersonation;
+       f->access_mask   = access_mask;
+       f->brl_handle    = NULL;
+       f->notify_buffer = NULL;
+       f->search        = NULL;
 
        f->handle->pvfs              = pvfs;
        f->handle->name              = talloc_steal(f->handle, name);
        f->handle->fd                = -1;
        f->handle->odb_locking_key   = data_blob(NULL, 0);
-       f->handle->brl_locking_key   = data_blob(NULL, 0);
        f->handle->create_options    = io->generic.in.create_options;
        f->handle->seek_offset       = 0;
        f->handle->position          = 0;
        f->handle->mode              = 0;
        f->handle->sticky_write_time = False;
+       f->handle->open_completed    = False;
 
-       DLIST_ADD(pvfs->open_files, f);
+       if ((create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) &&
+           pvfs_directory_empty(pvfs, f->handle->name)) {
+               del_on_close = True;
+       } else {
+               del_on_close = False;
+       }
+
+       if (name->exists) {
+               /* form the lock context used for opendb locking */
+               status = pvfs_locking_key(name, f->handle, &f->handle->odb_locking_key);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
+
+               /* get a lock on this file before the actual open */
+               lck = odb_lock(req, pvfs->odb_context, &f->handle->odb_locking_key);
+               if (lck == NULL) {
+                       DEBUG(0,("pvfs_open: failed to lock file '%s' in opendb\n",
+                                name->full_name));
+                       /* we were supposed to do a blocking lock, so something
+                          is badly wrong! */
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               }
+               
+               /* see if we are allowed to open at the same time as existing opens */
+               status = odb_open_file(lck, f->handle, f->handle->name->stream_id,
+                                      share_access, access_mask, del_on_close, 
+                                      name->full_name, OPLOCK_NONE, NULL);
+
+               if (!NT_STATUS_IS_OK(status)) {
+                       talloc_free(lck);
+                       return status;
+               }
+
+               f->handle->have_opendb_entry = True;
+       }
 
-       /* TODO: should we check in the opendb? Do directory opens 
-          follow the share_access rules? */
+       DLIST_ADD(pvfs->files.list, f);
 
        /* setup destructors to avoid leaks on abnormal termination */
        talloc_set_destructor(f->handle, pvfs_dir_handle_destructor);
@@ -184,14 +317,54 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
        if (!name->exists) {
                uint32_t attrib = io->generic.in.file_attr | FILE_ATTRIBUTE_DIRECTORY;
                mode_t mode = pvfs_fileperms(pvfs, attrib);
+
                if (mkdir(name->full_name, mode) == -1) {
                        return pvfs_map_errno(pvfs,errno);
                }
+
+               pvfs_xattr_unlink_hook(pvfs, name->full_name);
+
                status = pvfs_resolve_name(pvfs, req, io->ntcreatex.in.fname, 0, &name);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto cleanup_delete;
+               }
+
+               status = pvfs_open_setup_eas_acl(pvfs, req, name, -1, f, io);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto cleanup_delete;
+               }
+
+               /* form the lock context used for opendb locking */
+               status = pvfs_locking_key(name, f->handle, &f->handle->odb_locking_key);
                if (!NT_STATUS_IS_OK(status)) {
                        return status;
                }
+
+               lck = odb_lock(req, pvfs->odb_context, &f->handle->odb_locking_key);
+               if (lck == NULL) {
+                       DEBUG(0,("pvfs_open: failed to lock file '%s' in opendb\n",
+                                name->full_name));
+                       /* we were supposed to do a blocking lock, so something
+                          is badly wrong! */
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               }
+
+               status = odb_open_file(lck, f->handle, f->handle->name->stream_id,
+                                      share_access, access_mask, del_on_close, 
+                                      name->full_name, OPLOCK_NONE, NULL);
+
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto cleanup_delete;
+               }
+
+               f->handle->have_opendb_entry = True;
+
                create_action = NTCREATEX_ACTION_CREATED;
+
+               notify_trigger(pvfs->notify_context, 
+                              NOTIFY_ACTION_ADDED, 
+                              FILE_NOTIFY_CHANGE_DIR_NAME,
+                              name->full_name);
        } else {
                create_action = NTCREATEX_ACTION_EXISTED;
        }
@@ -201,10 +374,15 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
        }
 
        /* the open succeeded, keep this handle permanently */
-       talloc_steal(pvfs, f);
+       status = ntvfs_handle_set_backend_data(h, pvfs->ntvfs, f);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto cleanup_delete;
+       }
+
+       f->handle->open_completed = True;
 
        io->generic.out.oplock_level  = OPLOCK_NONE;
-       io->generic.out.fnum          = f->fnum;
+       io->generic.out.file.ntvfs    = h;
        io->generic.out.create_action = create_action;
        io->generic.out.create_time   = name->dos.create_time;
        io->generic.out.access_time   = name->dos.access_time;
@@ -218,14 +396,19 @@ static NTSTATUS pvfs_open_directory(struct pvfs_state *pvfs,
        io->generic.out.is_directory  = 1;
 
        return NT_STATUS_OK;
+
+cleanup_delete:
+       rmdir(name->full_name);
+       return status;
 }
 
 /*
   destroy a struct pvfs_file_handle
 */
-static int pvfs_handle_destructor(void *p)
+static int pvfs_handle_destructor(struct pvfs_file_handle *h)
 {
-       struct pvfs_file_handle *h = p;
+       int open_count;
+       char *path = NULL;
 
        /* the write time is no longer sticky */
        if (h->sticky_write_time) {
@@ -255,14 +438,29 @@ static int pvfs_handle_destructor(void *p)
                h->fd = -1;
        }
 
-       if ((h->create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) &&
-           h->name->stream_name == NULL) {
-               if (unlink(h->name->full_name) != 0) {
+       if (h->name->stream_name == NULL && 
+           h->open_completed &&
+           pvfs_delete_on_close_set(h->pvfs, h, &open_count, &path) &&
+           open_count == 1) {
+               NTSTATUS status;
+               status = pvfs_xattr_unlink_hook(h->pvfs, path);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(0,("Warning: xattr unlink hook failed for '%s' - %s\n",
+                                path, nt_errstr(status)));
+               }
+               if (unlink(path) != 0) {
                        DEBUG(0,("pvfs_close: failed to delete '%s' - %s\n", 
-                                h->name->full_name, strerror(errno)));
+                                path, strerror(errno)));
+               } else {
+                       notify_trigger(h->pvfs->notify_context, 
+                                      NOTIFY_ACTION_REMOVED, 
+                                      FILE_NOTIFY_CHANGE_FILE_NAME,
+                                      path);
                }
        }
 
+       talloc_free(path);
+
        if (h->have_opendb_entry) {
                struct odb_lock *lck;
                NTSTATUS status;
@@ -289,121 +487,111 @@ static int pvfs_handle_destructor(void *p)
 /*
   destroy a struct pvfs_file
 */
-static int pvfs_fnum_destructor(void *p)
+static int pvfs_fnum_destructor(struct pvfs_file *f)
 {
-       struct pvfs_file *f = p;
-
-       DLIST_REMOVE(f->pvfs->open_files, f);
+       DLIST_REMOVE(f->pvfs->files.list, f);
        pvfs_lock_close(f->pvfs, f);
-       idr_remove(f->pvfs->idtree_fnum, f->fnum);
+       ntvfs_handle_remove_backend_data(f->ntvfs, f->pvfs->ntvfs);
 
        return 0;
 }
 
 
-/*
-  form the lock context used for opendb locking. Note that we must
-  zero here to take account of possible padding on some architectures
-*/
-static NTSTATUS pvfs_locking_key(struct pvfs_filename *name, 
-                                TALLOC_CTX *mem_ctx, DATA_BLOB *key)
-{
-       struct {
-               dev_t device;
-               ino_t inode;
-       } lock_context;
-       ZERO_STRUCT(lock_context);
-
-       lock_context.device = name->st.st_dev;
-       lock_context.inode = name->st.st_ino;
-
-       *key = data_blob_talloc(mem_ctx, &lock_context, sizeof(lock_context));
-       if (key->data == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       
-       return NT_STATUS_OK;
-}
-
 /*
   form the lock context used for byte range locking. This is separate
   from the locking key used for opendb locking as it needs to take
   account of file streams (each stream is a separate byte range
   locking space)
 */
-static NTSTATUS pvfs_brl_locking_key(struct pvfs_filename *name, 
-                                    TALLOC_CTX *mem_ctx, DATA_BLOB *key)
+static NTSTATUS pvfs_brl_locking_handle(TALLOC_CTX *mem_ctx,
+                                       struct pvfs_filename *name,
+                                       struct ntvfs_handle *ntvfs,
+                                       struct brl_handle **_h)
 {
-       DATA_BLOB odb_key;
+       DATA_BLOB odb_key, key;
        NTSTATUS status;
+       struct brl_handle *h;
+
        status = pvfs_locking_key(name, mem_ctx, &odb_key);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
+       NT_STATUS_NOT_OK_RETURN(status);
+
        if (name->stream_name == NULL) {
-               *key = odb_key;
-               return NT_STATUS_OK;
-       }
-       *key = data_blob_talloc(mem_ctx, NULL, 
-                               odb_key.length + strlen(name->stream_name) + 1);
-       if (key->data == NULL) {
-               return NT_STATUS_NO_MEMORY;
+               key = odb_key;
+       } else {
+               key = data_blob_talloc(mem_ctx, NULL, 
+                                      odb_key.length + strlen(name->stream_name) + 1);
+               NT_STATUS_HAVE_NO_MEMORY(key.data);
+               memcpy(key.data, odb_key.data, odb_key.length);
+               memcpy(key.data + odb_key.length, 
+                      name->stream_name, strlen(name->stream_name) + 1);
+               data_blob_free(&odb_key);
        }
-       memcpy(key->data, odb_key.data, odb_key.length);
-       memcpy(key->data + odb_key.length, 
-              name->stream_name, strlen(name->stream_name)+1);
-       data_blob_free(&odb_key);
+
+       h = brl_create_handle(mem_ctx, ntvfs, &key);
+       NT_STATUS_HAVE_NO_MEMORY(h);
+
+       *_h = h;
        return NT_STATUS_OK;
 }
 
-
 /*
   create a new file
 */
 static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs, 
-                                struct smbsrv_request *req, 
+                                struct ntvfs_request *req, 
                                 struct pvfs_filename *name, 
                                 union smb_open *io)
 {
        struct pvfs_file *f;
        NTSTATUS status;
-       int flags, fnum, fd;
+       struct ntvfs_handle *h;
+       int flags, fd;
        struct odb_lock *lck;
        uint32_t create_options = io->generic.in.create_options;
        uint32_t share_access = io->generic.in.share_access;
        uint32_t access_mask = io->generic.in.access_mask;
        mode_t mode;
        uint32_t attrib;
+       BOOL del_on_close;
+       struct pvfs_filename *parent;
+       uint32_t oplock_level = OPLOCK_NONE, oplock_granted;
 
        if ((io->ntcreatex.in.file_attr & FILE_ATTRIBUTE_READONLY) &&
            (create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE)) {
                return NT_STATUS_CANNOT_DELETE;
        }
        
-       if (access_mask & SEC_RIGHT_MAXIMUM_ALLOWED) {
-               access_mask = GENERIC_RIGHTS_FILE_READ | GENERIC_RIGHTS_FILE_WRITE;
+       status = pvfs_access_check_create(pvfs, req, name, &access_mask);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       /* check that the parent isn't opened with delete on close set */
+       status = pvfs_resolve_parent(pvfs, req, name, &parent);
+       if (NT_STATUS_IS_OK(status)) {
+               DATA_BLOB locking_key;
+               status = pvfs_locking_key(parent, req, &locking_key);
+               NT_STATUS_NOT_OK_RETURN(status);
+               status = odb_get_delete_on_close(pvfs->odb_context, &locking_key, 
+                                                &del_on_close, NULL, NULL);
+               NT_STATUS_NOT_OK_RETURN(status);
+               if (del_on_close) {
+                       return NT_STATUS_DELETE_PENDING;
+               }
        }
 
-       if (access_mask & SA_RIGHT_FILE_WRITE_APPEND) {
+       if (access_mask & (SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA)) {
                flags = O_RDWR;
        } else {
                flags = O_RDONLY;
        }
 
-       f = talloc_p(req, struct pvfs_file);
-       if (f == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       status = ntvfs_handle_new(pvfs->ntvfs, req, &h);
+       NT_STATUS_NOT_OK_RETURN(status);
 
-       f->handle = talloc_p(f, struct pvfs_file_handle);
-       if (f->handle == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       f = talloc(h, struct pvfs_file);
+       NT_STATUS_HAVE_NO_MEMORY(f);
 
-       fnum = idr_get_new_above(pvfs->idtree_fnum, f, PVFS_MIN_NEW_FNUM, UINT16_MAX);
-       if (fnum == -1) {
-               return NT_STATUS_TOO_MANY_OPENED_FILES;
-       }
+       f->handle = talloc(f, struct pvfs_file_handle);
+       NT_STATUS_HAVE_NO_MEMORY(f->handle);
 
        attrib = io->ntcreatex.in.file_attr | FILE_ATTRIBUTE_ARCHIVE;
        mode = pvfs_fileperms(pvfs, attrib);
@@ -411,15 +599,15 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        /* create the file */
        fd = open(name->full_name, flags | O_CREAT | O_EXCL, mode);
        if (fd == -1) {
-               idr_remove(pvfs->idtree_fnum, fnum);
                return pvfs_map_errno(pvfs, errno);
        }
 
+       pvfs_xattr_unlink_hook(pvfs, name->full_name);
+
        /* if this was a stream create then create the stream as well */
        if (name->stream_name) {
                status = pvfs_stream_create(pvfs, name, fd);
                if (!NT_STATUS_IS_OK(status)) {
-                       idr_remove(pvfs->idtree_fnum, fnum);
                        close(fd);
                        return status;
                }
@@ -428,7 +616,6 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        /* re-resolve the open fd */
        status = pvfs_resolve_name_fd(pvfs, fd, name);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, fnum);
                close(fd);
                return status;
        }
@@ -436,55 +623,25 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        name->dos.attrib = attrib;
        status = pvfs_dosattrib_save(pvfs, name, fd);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, fnum);
-               close(fd);
-               return status;
-       }
-
-       /* setup any EAs that were asked for */
-       if (io->ntcreatex.in.ea_list) {
-               int i;
-               for (i=0;i<io->ntcreatex.in.ea_list->num_eas;i++) {
-                       status = pvfs_setfileinfo_ea_set(pvfs, name, fd, 
-                                                        &io->ntcreatex.in.ea_list->eas[i]);
-                       if (!NT_STATUS_IS_OK(status)) {
-                               idr_remove(pvfs->idtree_fnum, fnum);
-                               close(fd);
-                               return status;
-                       }
-               }
+               goto cleanup_delete;
        }
 
-       /* setup an initial sec_desc is required */
-       if (io->ntcreatex.in.sec_desc) {
-               union smb_setfileinfo set;
-
-               set.set_secdesc.file.fnum = fnum;
-               set.set_secdesc.in.secinfo_flags = DACL_SECURITY_INFORMATION;
-               set.set_secdesc.in.sd = io->ntcreatex.in.sec_desc;
 
-               status = pvfs_acl_set(pvfs, req, name, fd, &set);
-               if (!NT_STATUS_IS_OK(status)) {
-                       idr_remove(pvfs->idtree_fnum, fnum);
-                       close(fd);
-                       return status;
-               }
+       status = pvfs_open_setup_eas_acl(pvfs, req, name, fd, f, io);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto cleanup_delete;
        }
 
        /* form the lock context used for byte range locking and
           opendb locking */
        status = pvfs_locking_key(name, f->handle, &f->handle->odb_locking_key);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, fnum);
-               close(fd);
-               return status;
+               goto cleanup_delete;
        }
 
-       status = pvfs_brl_locking_key(name, f->handle, &f->handle->brl_locking_key);
+       status = pvfs_brl_locking_handle(f, name, h, &f->brl_handle);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, fnum);
-               close(fd);
-               return status;
+               goto cleanup_delete;
        }
 
        /* grab a lock on the open file record */
@@ -494,30 +651,49 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
                         name->full_name));
                /* we were supposed to do a blocking lock, so something
                   is badly wrong! */
-               idr_remove(pvfs->idtree_fnum, fnum);
-               close(fd);
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               status = NT_STATUS_INTERNAL_DB_CORRUPTION;
+               goto cleanup_delete;
+       }
+
+       if (create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) {
+               del_on_close = True;
+       } else {
+               del_on_close = False;
+       }
+
+       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
+               oplock_level = OPLOCK_NONE;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_BATCH_OPLOCK) {
+               oplock_level = OPLOCK_BATCH;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_OPLOCK) {
+               oplock_level = OPLOCK_EXCLUSIVE;
        }
 
        status = odb_open_file(lck, f->handle, name->stream_id,
-                              share_access, create_options, access_mask);
+                              share_access, access_mask, del_on_close, 
+                              name->full_name, oplock_level, &oplock_granted);
        talloc_free(lck);
        if (!NT_STATUS_IS_OK(status)) {
-               /* bad news, we must have hit a race */
-               idr_remove(pvfs->idtree_fnum, fnum);
+               /* bad news, we must have hit a race - we don't delete the file
+                  here as the most likely scenario is that someone else created 
+                  the file at the same time */
                close(fd);
                return status;
        }
 
-       f->fnum              = fnum;
-       f->session           = req->session;
-       f->smbpid            = req->smbpid;
+       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
+               oplock_granted = OPLOCK_BATCH;
+       }
+
+       f->ntvfs             = h;
        f->pvfs              = pvfs;
        f->pending_list      = NULL;
        f->lock_count        = 0;
        f->share_access      = io->generic.in.share_access;
        f->access_mask       = access_mask;
        f->impersonation     = io->generic.in.impersonation;
+       f->notify_buffer     = NULL;
+       f->search            = NULL;
 
        f->handle->pvfs              = pvfs;
        f->handle->name              = talloc_steal(f->handle, name);
@@ -528,21 +704,17 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        f->handle->mode              = 0;
        f->handle->have_opendb_entry = True;
        f->handle->sticky_write_time = False;
+       f->handle->open_completed    = False;
 
-       DLIST_ADD(pvfs->open_files, f);
+       DLIST_ADD(pvfs->files.list, f);
 
        /* setup a destructor to avoid file descriptor leaks on
           abnormal termination */
        talloc_set_destructor(f, pvfs_fnum_destructor);
        talloc_set_destructor(f->handle, pvfs_handle_destructor);
 
-       
-       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
-               io->generic.out.oplock_level  = OPLOCK_EXCLUSIVE;
-       } else {
-               io->generic.out.oplock_level  = OPLOCK_NONE;
-       }
-       io->generic.out.fnum          = f->fnum;
+       io->generic.out.oplock_level  = oplock_granted;
+       io->generic.out.file.ntvfs    = f->ntvfs;
        io->generic.out.create_action = NTCREATEX_ACTION_CREATED;
        io->generic.out.create_time   = name->dos.create_time;
        io->generic.out.access_time   = name->dos.access_time;
@@ -556,9 +728,24 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
        io->generic.out.is_directory  = 0;
 
        /* success - keep the file handle */
-       talloc_steal(pvfs, f);
+       status = ntvfs_handle_set_backend_data(h, pvfs->ntvfs, f);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto cleanup_delete;
+       }
+
+       f->handle->open_completed = True;
+
+       notify_trigger(pvfs->notify_context, 
+                      NOTIFY_ACTION_ADDED, 
+                      FILE_NOTIFY_CHANGE_FILE_NAME,
+                      name->full_name);
 
        return NT_STATUS_OK;
+
+cleanup_delete:
+       close(fd);
+       unlink(name->full_name);
+       return status;
 }
 
 
@@ -567,16 +754,15 @@ static NTSTATUS pvfs_create_file(struct pvfs_state *pvfs,
 */
 struct pvfs_open_retry {
        struct ntvfs_module_context *ntvfs;
-       struct smbsrv_request *req;
+       struct ntvfs_request *req;
        union smb_open *io;
        void *wait_handle;
        DATA_BLOB odb_locking_key;
 };
 
 /* destroy a pending open request */
-static int pvfs_retry_destructor(void *ptr)
+static int pvfs_retry_destructor(struct pvfs_open_retry *r)
 {
-       struct pvfs_open_retry *r = ptr;
        struct pvfs_state *pvfs = r->ntvfs->private_data;
        if (r->odb_locking_key.data) {
                struct odb_lock *lck;
@@ -596,7 +782,7 @@ static void pvfs_open_retry(void *private, enum pvfs_wait_notice reason)
 {
        struct pvfs_open_retry *r = private;
        struct ntvfs_module_context *ntvfs = r->ntvfs;
-       struct smbsrv_request *req = r->req;
+       struct ntvfs_request *req = r->req;
        union smb_open *io = r->io;
        NTSTATUS status;
 
@@ -652,12 +838,13 @@ static void pvfs_open_retry(void *private, enum pvfs_wait_notice reason)
   open processing continues.
 */
 static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
-                                  struct smbsrv_request *req, union smb_open *io,
+                                  struct ntvfs_request *req, union smb_open *io,
                                   struct pvfs_file *f, struct odb_lock *lck)
 {
        struct pvfs_state *pvfs = ntvfs->private_data;
        struct pvfs_file *f2;
        struct pvfs_filename *name;
+       NTSTATUS status;
 
        /* search for an existing open with the right parameters. Note
           the magic ntcreatex options flag, which is set in the
@@ -669,15 +856,15 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
           circumstances you actually get the _same_ handle back
           twice, rather than a new handle.
        */
-       for (f2=pvfs->open_files;f2;f2=f2->next) {
+       for (f2=pvfs->files.list;f2;f2=f2->next) {
                if (f2 != f &&
-                   f2->session == req->session &&
-                   f2->smbpid == req->smbpid &&
+                   f2->ntvfs->session_info == req->session_info &&
+                   f2->ntvfs->smbpid == req->smbpid &&
                    (f2->handle->create_options & 
                     (NTCREATEX_OPTIONS_PRIVATE_DENY_DOS |
                      NTCREATEX_OPTIONS_PRIVATE_DENY_FCB)) &&
-                   (f2->access_mask & SA_RIGHT_FILE_WRITE_DATA) &&
-                   StrCaseCmp(f2->handle->name->original_name, 
+                   (f2->access_mask & SEC_FILE_WRITE_DATA) &&
+                   strcasecmp_m(f2->handle->name->original_name, 
                               io->generic.in.fname)==0) {
                        break;
                }
@@ -704,7 +891,7 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
        name = f->handle->name;
 
        io->generic.out.oplock_level  = OPLOCK_NONE;
-       io->generic.out.fnum          = f->fnum;
+       io->generic.out.file.ntvfs    = f->ntvfs;
        io->generic.out.create_action = NTCREATEX_ACTION_EXISTED;
        io->generic.out.create_time   = name->dos.create_time;
        io->generic.out.access_time   = name->dos.access_time;
@@ -716,8 +903,9 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
        io->generic.out.file_type     = FILE_TYPE_DISK;
        io->generic.out.ipc_state     = 0;
        io->generic.out.is_directory  = 0;
-
-       talloc_steal(f->pvfs, f);
+       status = ntvfs_handle_set_backend_data(f->ntvfs, ntvfs, f);
+       NT_STATUS_NOT_OK_RETURN(status);
 
        return NT_STATUS_OK;
 }
@@ -728,7 +916,7 @@ static NTSTATUS pvfs_open_deny_dos(struct ntvfs_module_context *ntvfs,
   setup for a open retry after a sharing violation
 */
 static NTSTATUS pvfs_open_setup_retry(struct ntvfs_module_context *ntvfs,
-                                     struct smbsrv_request *req, 
+                                     struct ntvfs_request *req, 
                                      union smb_open *io,
                                      struct pvfs_file *f,
                                      struct odb_lock *lck)
@@ -748,7 +936,7 @@ static NTSTATUS pvfs_open_setup_retry(struct ntvfs_module_context *ntvfs,
                }
        }
 
-       r = talloc_p(req, struct pvfs_open_retry);
+       r = talloc(req, struct pvfs_open_retry);
        if (r == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -760,7 +948,7 @@ static NTSTATUS pvfs_open_setup_retry(struct ntvfs_module_context *ntvfs,
                                              f->handle->odb_locking_key.data, 
                                              f->handle->odb_locking_key.length);
 
-       end_time = timeval_add(&req->request_time, 0, pvfs->sharing_violation_delay);
+       end_time = timeval_add(&req->statistics.request_time, 0, pvfs->sharing_violation_delay);
 
        /* setup a pending lock */
        status = odb_open_file_pending(lck, r);
@@ -784,65 +972,32 @@ static NTSTATUS pvfs_open_setup_retry(struct ntvfs_module_context *ntvfs,
        return NT_STATUS_OK;
 }
 
-/*
-  special handling for t2open
-*/
-static NTSTATUS pvfs_open_t2open(struct ntvfs_module_context *ntvfs,
-                                struct smbsrv_request *req, union smb_open *io)
-{
-       struct pvfs_state *pvfs = ntvfs->private_data;
-       struct pvfs_filename *name;
-       NTSTATUS status;
-
-       status = pvfs_resolve_name(pvfs, req, io->t2open.in.fname, 0, &name);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       if (io->t2open.in.open_func & OPENX_OPEN_FUNC_CREATE) {
-               if (!name->stream_exists) return NT_STATUS_ACCESS_DENIED;
-       }
-       if (io->t2open.in.open_func & OPENX_OPEN_FUNC_TRUNC) {
-               if (name->stream_exists) return NT_STATUS_ACCESS_DENIED;
-               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
-       }
-       if ((io->t2open.in.open_func & 0xF) == OPENX_OPEN_FUNC_FAIL) {
-               if (!name->stream_exists) return NT_STATUS_ACCESS_DENIED;
-               return NT_STATUS_OBJECT_NAME_COLLISION;
-       }
-
-       talloc_free(name);
-
-       return ntvfs_map_open(req, io, ntvfs);
-}
-
 /*
   open a file
 */
 NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
-                  struct smbsrv_request *req, union smb_open *io)
+                  struct ntvfs_request *req, union smb_open *io)
 {
        struct pvfs_state *pvfs = ntvfs->private_data;
        int flags;
        struct pvfs_filename *name;
        struct pvfs_file *f;
+       struct ntvfs_handle *h;
        NTSTATUS status;
-       int fnum, fd;
+       int fd;
        struct odb_lock *lck;
        uint32_t create_options;
        uint32_t share_access;
        uint32_t access_mask;
-       BOOL stream_existed;
-
-       if (io->generic.level == RAW_OPEN_T2OPEN) {
-               return pvfs_open_t2open(ntvfs, req, io);
-       }
+       BOOL del_on_close;
+       BOOL stream_existed, stream_truncate=False;
+       uint32_t oplock_level = OPLOCK_NONE, oplock_granted;
 
        /* use the generic mapping code to avoid implementing all the
           different open calls. */
        if (io->generic.level != RAW_OPEN_GENERIC &&
            io->generic.level != RAW_OPEN_NTTRANS_CREATE) {
-               return ntvfs_map_open(req, io, ntvfs);
+               return ntvfs_map_open(ntvfs, req, io);
        }
 
        /* resolve the cifs name to a posix name */
@@ -858,31 +1013,30 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return pvfs_open_directory(pvfs, req, name, io);
        }
 
+       /* FILE_ATTRIBUTE_DIRECTORY is ignored if the above test for directory
+          open doesn't match */
+       io->generic.in.file_attr &= ~FILE_ATTRIBUTE_DIRECTORY;
+
        create_options = io->generic.in.create_options;
        share_access   = io->generic.in.share_access;
        access_mask    = io->generic.in.access_mask;
 
-       if (access_mask & SEC_RIGHT_MAXIMUM_ALLOWED) {
-               if (name->exists && (name->dos.attrib & FILE_ATTRIBUTE_READONLY)) {
-                       access_mask = GENERIC_RIGHTS_FILE_READ;
-               } else {
-                       access_mask = GENERIC_RIGHTS_FILE_READ | GENERIC_RIGHTS_FILE_WRITE;
-               }
-       }
-
        /* certain create options are not allowed */
        if ((create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) &&
-           !(access_mask & STD_RIGHT_DELETE_ACCESS)) {
+           !(access_mask & SEC_STD_DELETE)) {
                return NT_STATUS_INVALID_PARAMETER;
        }
 
+       flags = 0;
+
        switch (io->generic.in.open_disposition) {
        case NTCREATEX_DISP_SUPERSEDE:
-               flags = O_TRUNC;
-               break;
-
        case NTCREATEX_DISP_OVERWRITE_IF:
-               flags = O_TRUNC;
+               if (name->stream_name == NULL) {
+                       flags = O_TRUNC;
+               } else {
+                       stream_truncate = True;
+               }
                break;
 
        case NTCREATEX_DISP_OPEN:
@@ -896,7 +1050,11 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                if (!name->stream_exists) {
                        return NT_STATUS_OBJECT_NAME_NOT_FOUND;
                }
-               flags = O_TRUNC;
+               if (name->stream_name == NULL) {
+                       flags = O_TRUNC;
+               } else {
+                       stream_truncate = True;
+               }
                break;
 
        case NTCREATEX_DISP_CREATE:
@@ -914,16 +1072,6 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (access_mask & SA_RIGHT_FILE_WRITE_APPEND) {
-               flags |= O_RDWR;
-       } else {
-               flags |= O_RDONLY;
-       }
-
-       if (io->generic.in.file_attr & FILE_ATTRIBUTE_DIRECTORY) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
        /* handle creating a new file separately */
        if (!name->exists) {
                status = pvfs_create_file(pvfs, req, name, io);
@@ -949,31 +1097,34 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return NT_STATUS_CANNOT_DELETE;
        }
 
-       f = talloc_p(req, struct pvfs_file);
+       /* check the security descriptor */
+       status = pvfs_access_check(pvfs, req, name, &access_mask);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       status = ntvfs_handle_new(pvfs->ntvfs, req, &h);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       f = talloc(h, struct pvfs_file);
        if (f == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       f->handle = talloc_p(f, struct pvfs_file_handle);
+       f->handle = talloc(f, struct pvfs_file_handle);
        if (f->handle == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       /* allocate a fnum */
-       fnum = idr_get_new_above(pvfs->idtree_fnum, f, PVFS_MIN_FILE_FNUM, UINT16_MAX);
-       if (fnum == -1) {
-               return NT_STATUS_TOO_MANY_OPENED_FILES;
-       }
-
-       f->fnum          = fnum;
-       f->session       = req->session;
-       f->smbpid        = req->smbpid;
+       f->ntvfs         = h;
        f->pvfs          = pvfs;
        f->pending_list  = NULL;
        f->lock_count    = 0;
        f->share_access  = io->generic.in.share_access;
        f->access_mask   = access_mask;
        f->impersonation = io->generic.in.impersonation;
+       f->notify_buffer = NULL;
+       f->search        = NULL;
 
        f->handle->pvfs              = pvfs;
        f->handle->fd                = -1;
@@ -984,18 +1135,17 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
        f->handle->mode              = 0;
        f->handle->have_opendb_entry = False;
        f->handle->sticky_write_time = False;
+       f->handle->open_completed    = False;
 
        /* form the lock context used for byte range locking and
           opendb locking */
        status = pvfs_locking_key(name, f->handle, &f->handle->odb_locking_key);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, f->fnum);
                return status;
        }
 
-       status = pvfs_brl_locking_key(name, f->handle, &f->handle->brl_locking_key);
+       status = pvfs_brl_locking_handle(f, name, h, &f->brl_handle);
        if (!NT_STATUS_IS_OK(status)) {
-               idr_remove(pvfs->idtree_fnum, f->fnum);
                return status;
        }
 
@@ -1006,21 +1156,39 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                         name->full_name));
                /* we were supposed to do a blocking lock, so something
                   is badly wrong! */
-               idr_remove(pvfs->idtree_fnum, fnum);
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       DLIST_ADD(pvfs->open_files, f);
+       DLIST_ADD(pvfs->files.list, f);
 
        /* setup a destructor to avoid file descriptor leaks on
           abnormal termination */
        talloc_set_destructor(f, pvfs_fnum_destructor);
        talloc_set_destructor(f->handle, pvfs_handle_destructor);
 
+       /* 
+        * Only SMB2 takes care of the delete_on_close,
+        * on existing files
+        */
+       if (create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE &&
+           req->ctx->protocol == PROTOCOL_SMB2) {
+               del_on_close = True;
+       } else {
+               del_on_close = False;
+       }
+
+       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
+               oplock_level = OPLOCK_NONE;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_BATCH_OPLOCK) {
+               oplock_level = OPLOCK_BATCH;
+       } else if (io->ntcreatex.in.flags & NTCREATEX_FLAGS_REQUEST_OPLOCK) {
+               oplock_level = OPLOCK_EXCLUSIVE;
+       }
 
        /* see if we are allowed to open at the same time as existing opens */
        status = odb_open_file(lck, f->handle, f->handle->name->stream_id,
-                              share_access, create_options, access_mask);
+                              share_access, access_mask, del_on_close,
+                              name->full_name, oplock_level, &oplock_granted);
 
        /* on a sharing violation we need to retry when the file is closed by 
           the other user, or after 1 second */
@@ -1034,8 +1202,18 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                return status;
        }
 
+       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
+               oplock_granted = OPLOCK_BATCH;
+       }
+
        f->handle->have_opendb_entry = True;
 
+       if (access_mask & (SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA)) {
+               flags |= O_RDWR;
+       } else {
+               flags |= O_RDONLY;
+       }
+
        /* do the actual open */
        fd = open(f->handle->name->full_name, flags);
        if (fd == -1) {
@@ -1054,6 +1232,13 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
                        talloc_free(lck);
                        return status;
                }
+               if (stream_truncate) {
+                       status = pvfs_stream_truncate(pvfs, f->handle->name, fd, 0);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               talloc_free(lck);
+                               return status;
+                       }
+               }
        }
 
        /* re-resolve the open fd */
@@ -1083,12 +1268,15 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
            
        talloc_free(lck);
 
-       if (pvfs->flags & PVFS_FLAG_FAKE_OPLOCKS) {
-               io->generic.out.oplock_level  = OPLOCK_EXCLUSIVE;
-       } else {
-               io->generic.out.oplock_level  = OPLOCK_NONE;
-       }
-       io->generic.out.fnum          = f->fnum;
+       status = ntvfs_handle_set_backend_data(h, ntvfs, f);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       /* mark the open as having completed fully, so delete on close
+          can now be used */
+       f->handle->open_completed     = True;
+
+       io->generic.out.oplock_level  = oplock_granted;
+       io->generic.out.file.ntvfs    = h;
        io->generic.out.create_action = stream_existed?
                NTCREATEX_ACTION_EXISTED:NTCREATEX_ACTION_CREATED;
        io->generic.out.create_time   = name->dos.create_time;
@@ -1102,9 +1290,6 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
        io->generic.out.ipc_state     = 0;
        io->generic.out.is_directory  = 0;
 
-       /* success - keep the file handle */
-       talloc_steal(f->pvfs, f);
-
        return NT_STATUS_OK;
 }
 
@@ -1113,21 +1298,21 @@ NTSTATUS pvfs_open(struct ntvfs_module_context *ntvfs,
   close a file
 */
 NTSTATUS pvfs_close(struct ntvfs_module_context *ntvfs,
-                   struct smbsrv_request *req, union smb_close *io)
+                   struct ntvfs_request *req, union smb_close *io)
 {
        struct pvfs_state *pvfs = ntvfs->private_data;
        struct pvfs_file *f;
        struct utimbuf unix_times;
 
        if (io->generic.level == RAW_CLOSE_SPLCLOSE) {
-               return NT_STATUS_UNSUCCESSFUL;
+               return NT_STATUS_DOS(ERRSRV, ERRerror);
        }
 
        if (io->generic.level != RAW_CLOSE_CLOSE) {
-               return ntvfs_map_close(req, io, ntvfs);
+               return ntvfs_map_close(ntvfs, req, io);
        }
 
-       f = pvfs_find_fd(pvfs, req, io->close.in.fnum);
+       f = pvfs_find_fd(pvfs, req, io->close.in.file.ntvfs);
        if (!f) {
                return NT_STATUS_INVALID_HANDLE;
        }
@@ -1152,14 +1337,14 @@ NTSTATUS pvfs_close(struct ntvfs_module_context *ntvfs,
   logoff - close all file descriptors open by a vuid
 */
 NTSTATUS pvfs_logoff(struct ntvfs_module_context *ntvfs,
-                    struct smbsrv_request *req)
+                    struct ntvfs_request *req)
 {
        struct pvfs_state *pvfs = ntvfs->private_data;
        struct pvfs_file *f, *next;
 
-       for (f=pvfs->open_files;f;f=next) {
+       for (f=pvfs->files.list;f;f=next) {
                next = f->next;
-               if (f->session == req->session) {
+               if (f->ntvfs->session_info == req->session_info) {
                        talloc_free(f);
                }
        }
@@ -1172,14 +1357,15 @@ NTSTATUS pvfs_logoff(struct ntvfs_module_context *ntvfs,
   exit - close files for the current pid
 */
 NTSTATUS pvfs_exit(struct ntvfs_module_context *ntvfs,
-                  struct smbsrv_request *req)
+                  struct ntvfs_request *req)
 {
        struct pvfs_state *pvfs = ntvfs->private_data;
        struct pvfs_file *f, *next;
 
-       for (f=pvfs->open_files;f;f=next) {
+       for (f=pvfs->files.list;f;f=next) {
                next = f->next;
-               if (f->smbpid == req->smbpid) {
+               if (f->ntvfs->session_info == req->session_info &&
+                   f->ntvfs->smbpid == req->smbpid) {
                        talloc_free(f);
                }
        }
@@ -1189,33 +1375,38 @@ NTSTATUS pvfs_exit(struct ntvfs_module_context *ntvfs,
 
 
 /*
-  change the create options on an already open file
+  change the delete on close flag on an already open file
 */
-NTSTATUS pvfs_change_create_options(struct pvfs_state *pvfs,
-                                   struct smbsrv_request *req, 
-                                   struct pvfs_file *f, uint32_t create_options)
+NTSTATUS pvfs_set_delete_on_close(struct pvfs_state *pvfs,
+                                 struct ntvfs_request *req, 
+                                 struct pvfs_file *f, BOOL del_on_close)
 {
        struct odb_lock *lck;
        NTSTATUS status;
 
-       if (f->handle->create_options == create_options) {
-               return NT_STATUS_OK;
-       }
-
-       if ((f->handle->name->dos.attrib & FILE_ATTRIBUTE_READONLY) &&
-           (create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE)) {
+       if ((f->handle->name->dos.attrib & FILE_ATTRIBUTE_READONLY) && del_on_close) {
                return NT_STATUS_CANNOT_DELETE;
        }
+       
+       if ((f->handle->name->dos.attrib & FILE_ATTRIBUTE_DIRECTORY) &&
+           !pvfs_directory_empty(pvfs, f->handle->name)) {
+               return NT_STATUS_DIRECTORY_NOT_EMPTY;
+       }
 
+       if (del_on_close) {
+               f->handle->create_options |= NTCREATEX_OPTIONS_DELETE_ON_CLOSE;
+       } else {
+               f->handle->create_options &= ~NTCREATEX_OPTIONS_DELETE_ON_CLOSE;
+       }
+       
        lck = odb_lock(req, pvfs->odb_context, &f->handle->odb_locking_key);
        if (lck == NULL) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       status = odb_set_create_options(lck, f->handle, create_options);
-       if (NT_STATUS_IS_OK(status)) {
-               f->handle->create_options = create_options;
-       }
+       status = odb_set_delete_on_close(lck, del_on_close);
+
+       talloc_free(lck);
 
        return status;
 }
@@ -1225,22 +1416,43 @@ NTSTATUS pvfs_change_create_options(struct pvfs_state *pvfs,
   determine if a file can be deleted, or if it is prevented by an
   already open file
 */
-NTSTATUS pvfs_can_delete(struct pvfs_state *pvfs, struct pvfs_filename *name)
+NTSTATUS pvfs_can_delete(struct pvfs_state *pvfs, 
+                        struct ntvfs_request *req,
+                        struct pvfs_filename *name,
+                        struct odb_lock **lckp)
 {
        NTSTATUS status;
        DATA_BLOB key;
+       struct odb_lock *lck;
 
        status = pvfs_locking_key(name, name, &key);
        if (!NT_STATUS_IS_OK(status)) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       status = odb_can_open(pvfs->odb_context, &key, 
+       lck = odb_lock(req, pvfs->odb_context, &key);
+       if (lck == NULL) {
+               DEBUG(0,("Unable to lock opendb for can_delete\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       status = odb_can_open(lck,
                              NTCREATEX_SHARE_ACCESS_READ |
                              NTCREATEX_SHARE_ACCESS_WRITE | 
                              NTCREATEX_SHARE_ACCESS_DELETE, 
                              NTCREATEX_OPTIONS_DELETE_ON_CLOSE, 
-                             STD_RIGHT_DELETE_ACCESS);
+                             SEC_STD_DELETE);
+
+       if (NT_STATUS_IS_OK(status)) {
+               status = pvfs_access_check_simple(pvfs, req, name, SEC_STD_DELETE);
+       }
+
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(lck);
+               *lckp = lck;
+       } else if (lckp != NULL) {
+               *lckp = lck;
+       }
 
        return status;
 }
@@ -1249,21 +1461,89 @@ NTSTATUS pvfs_can_delete(struct pvfs_state *pvfs, struct pvfs_filename *name)
   determine if a file can be renamed, or if it is prevented by an
   already open file
 */
-NTSTATUS pvfs_can_rename(struct pvfs_state *pvfs, struct pvfs_filename *name)
+NTSTATUS pvfs_can_rename(struct pvfs_state *pvfs, 
+                        struct ntvfs_request *req,
+                        struct pvfs_filename *name,
+                        struct odb_lock **lckp)
 {
        NTSTATUS status;
        DATA_BLOB key;
+       struct odb_lock *lck;
 
        status = pvfs_locking_key(name, name, &key);
        if (!NT_STATUS_IS_OK(status)) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       status = odb_can_open(pvfs->odb_context, &key, 
+       lck = odb_lock(req, pvfs->odb_context, &key);
+       if (lck == NULL) {
+               DEBUG(0,("Unable to lock opendb for can_stat\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       status = odb_can_open(lck,
                              NTCREATEX_SHARE_ACCESS_READ |
                              NTCREATEX_SHARE_ACCESS_WRITE,
                              0,
-                             STD_RIGHT_DELETE_ACCESS);
+                             SEC_STD_DELETE);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(lck);
+               *lckp = lck;
+       } else if (lckp != NULL) {
+               *lckp = lck;
+       }
+
+       return status;
+}
+
+/*
+  determine if file meta data can be accessed, or if it is prevented by an
+  already open file
+*/
+NTSTATUS pvfs_can_stat(struct pvfs_state *pvfs, 
+                      struct ntvfs_request *req,
+                      struct pvfs_filename *name)
+{
+       NTSTATUS status;
+       DATA_BLOB key;
+       struct odb_lock *lck;
+
+       status = pvfs_locking_key(name, name, &key);
+       if (!NT_STATUS_IS_OK(status)) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       lck = odb_lock(req, pvfs->odb_context, &key);
+       if (lck == NULL) {
+               DEBUG(0,("Unable to lock opendb for can_stat\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       status = odb_can_open(lck,
+                             NTCREATEX_SHARE_ACCESS_READ |
+                             NTCREATEX_SHARE_ACCESS_WRITE,
+                             0, 0);
 
        return status;
 }
+
+
+/*
+  determine if delete on close is set on 
+*/
+BOOL pvfs_delete_on_close_set(struct pvfs_state *pvfs, struct pvfs_file_handle *h, 
+                             int *open_count, char **path)
+{
+       NTSTATUS status;
+       BOOL del_on_close;
+
+       status = odb_get_delete_on_close(pvfs->odb_context, &h->odb_locking_key, 
+                                        &del_on_close, open_count, path);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(1,("WARNING: unable to determine delete on close status for open file\n"));
+               return False;
+       }
+
+       return del_on_close;
+}