libcli/security Provide a common, top level libcli/security/security.h
[sfrench/samba-autobuild/.git] / source3 / passdb / pdb_interface.c
index bd85ded138a0d479d33d63b9a69670672ef3786f..a0913a3ea926ba2cc23ac0a4562f84f3de3eaf91 100644 (file)
 */
 
 #include "includes.h"
+#include "secrets.h"
+#include "../librpc/gen_ndr/samr.h"
+#include "memcache.h"
+#include "nsswitch/winbind_client.h"
+#include "../libcli/security/security.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_PASSDB
@@ -216,14 +221,107 @@ struct pdb_domain_info *pdb_get_domain_info(TALLOC_CTX *mem_ctx)
        return pdb->get_domain_info(pdb, mem_ctx);
 }
 
+/**
+ * @brief Check if the user account has been locked out and try to unlock it.
+ *
+ * If the user has been automatically locked out and a lockout duration is set,
+ * then check if we can unlock the account and reset the bad password values.
+ *
+ * @param[in]  sampass  The sam user to check.
+ *
+ * @return              True if the function was successfull, false on an error.
+ */
+static bool pdb_try_account_unlock(struct samu *sampass)
+{
+       uint32_t acb_info = pdb_get_acct_ctrl(sampass);
+
+       if (acb_info & (ACB_NORMAL|ACB_AUTOLOCK)) {
+               uint32_t lockout_duration;
+               time_t bad_password_time;
+               time_t now = time(NULL);
+               bool ok;
+
+               ok = pdb_get_account_policy(PDB_POLICY_LOCK_ACCOUNT_DURATION,
+                                           &lockout_duration);
+               if (!ok) {
+                       DEBUG(0, ("pdb_try_account_unlock: "
+                                 "pdb_get_account_policy failed.\n"));
+                       return false;
+               }
+
+               if (lockout_duration == (uint32_t) -1 ||
+                   lockout_duration == 0) {
+                       DEBUG(9, ("pdb_try_account_unlock: No reset duration, "
+                                 "can't reset autolock\n"));
+                       return false;
+               }
+               lockout_duration *= 60;
+
+               bad_password_time = pdb_get_bad_password_time(sampass);
+               if (bad_password_time == (time_t) 0) {
+                       DEBUG(2, ("pdb_try_account_unlock: Account %s "
+                                 "administratively locked out "
+                                 "with no bad password "
+                                 "time. Leaving locked out.\n",
+                                 pdb_get_username(sampass)));
+                       return true;
+               }
+
+               if ((bad_password_time +
+                    convert_uint32_t_to_time_t(lockout_duration)) < now) {
+                       NTSTATUS status;
+
+                       pdb_set_acct_ctrl(sampass, acb_info & ~ACB_AUTOLOCK,
+                                         PDB_CHANGED);
+                       pdb_set_bad_password_count(sampass, 0, PDB_CHANGED);
+                       pdb_set_bad_password_time(sampass, 0, PDB_CHANGED);
+
+                       become_root();
+                       status = pdb_update_sam_account(sampass);
+                       unbecome_root();
+                       if (!NT_STATUS_IS_OK(status)) {
+                               DEBUG(0, ("_samr_OpenUser: Couldn't "
+                                         "update account %s - %s\n",
+                                         pdb_get_username(sampass),
+                                         nt_errstr(status)));
+                               return false;
+                       }
+               }
+       }
+
+       return true;
+}
+
+/**
+ * @brief Get a sam user structure by the given username.
+ *
+ * This functions also checks if the account has been automatically locked out
+ * and unlocks it if a lockout duration time has been defined and the time has
+ * elapsed.
+ *
+ * @param[in]  sam_acct  The sam user structure to fill.
+ *
+ * @param[in]  username  The username to look for.
+ *
+ * @return               True on success, false on error.
+ */
 bool pdb_getsampwnam(struct samu *sam_acct, const char *username) 
 {
        struct pdb_methods *pdb = pdb_get_methods();
        struct samu *for_cache;
        const struct dom_sid *user_sid;
+       NTSTATUS status;
+       bool ok;
 
-       if (!NT_STATUS_IS_OK(pdb->getsampwnam(pdb, sam_acct, username))) {
-               return False;
+       status = pdb->getsampwnam(pdb, sam_acct, username);
+       if (!NT_STATUS_IS_OK(status)) {
+               return false;
+       }
+
+       ok = pdb_try_account_unlock(sam_acct);
+       if (!ok) {
+               DEBUG(1, ("pdb_getsampwnam: Failed to unlock account %s\n",
+                         username));
        }
 
        for_cache = samu_new(NULL);
@@ -248,13 +346,14 @@ bool pdb_getsampwnam(struct samu *sam_acct, const char *username)
 /**********************************************************************
 **********************************************************************/
 
-bool guest_user_info( struct samu *user )
+static bool guest_user_info( struct samu *user )
 {
        struct passwd *pwd;
        NTSTATUS result;
        const char *guestname = lp_guestaccount();
 
-       if ( !(pwd = getpwnam_alloc(talloc_autofree_context(), guestname ) ) ) {
+       pwd = getpwnam_alloc(talloc_tos(), guestname);
+       if (pwd == NULL) {
                DEBUG(0,("guest_user_info: Unable to locate guest account [%s]!\n", 
                        guestname));
                return False;
@@ -267,21 +366,33 @@ bool guest_user_info( struct samu *user )
        return NT_STATUS_IS_OK( result );
 }
 
-/**********************************************************************
-**********************************************************************/
-
-bool pdb_getsampwsid(struct samu *sam_acct, const DOM_SID *sid) 
+/**
+ * @brief Get a sam user structure by the given username.
+ *
+ * This functions also checks if the account has been automatically locked out
+ * and unlocks it if a lockout duration time has been defined and the time has
+ * elapsed.
+ *
+ *
+ * @param[in]  sam_acct  The sam user structure to fill.
+ *
+ * @param[in]  sid       The user SDI to look up.
+ *
+ * @return               True on success, false on error.
+ */
+bool pdb_getsampwsid(struct samu *sam_acct, const struct dom_sid *sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
-       uint32 rid;
+       uint32_t rid;
        void *cache_data;
+       bool ok = false;
 
        /* hard code the Guest RID of 501 */
 
        if ( !sid_peek_check_rid( get_global_sam_sid(), sid, &rid ) )
                return False;
 
-       if ( rid == DOMAIN_USER_RID_GUEST ) {
+       if ( rid == DOMAIN_RID_GUEST ) {
                DEBUG(6,("pdb_getsampwsid: Building guest account\n"));
                return guest_user_info( sam_acct );
        }
@@ -295,15 +406,27 @@ bool pdb_getsampwsid(struct samu *sam_acct, const DOM_SID *sid)
                struct samu *cache_copy = talloc_get_type_abort(
                        cache_data, struct samu);
 
-               return pdb_copy_sam_account(sam_acct, cache_copy);
+               ok = pdb_copy_sam_account(sam_acct, cache_copy);
+       } else {
+               ok = NT_STATUS_IS_OK(pdb->getsampwsid(pdb, sam_acct, sid));
+       }
+
+       if (!ok) {
+               return false;
        }
 
-       return NT_STATUS_IS_OK(pdb->getsampwsid(pdb, sam_acct, sid));
+       ok = pdb_try_account_unlock(sam_acct);
+       if (!ok) {
+               DEBUG(1, ("pdb_getsampwsid: Failed to unlock account %s\n",
+                         sam_acct->username));
+       }
+
+       return true;
 }
 
 static NTSTATUS pdb_default_create_user(struct pdb_methods *methods,
                                        TALLOC_CTX *tmp_ctx, const char *name,
-                                       uint32 acb_info, uint32 *rid)
+                                       uint32_t acb_info, uint32_t *rid)
 {
        struct samu *sam_pass;
        NTSTATUS status;
@@ -389,8 +512,8 @@ static NTSTATUS pdb_default_create_user(struct pdb_methods *methods,
        return status;
 }
 
-NTSTATUS pdb_create_user(TALLOC_CTX *mem_ctx, const char *name, uint32 flags,
-                        uint32 *rid)
+NTSTATUS pdb_create_user(TALLOC_CTX *mem_ctx, const char *name, uint32_t flags,
+                        uint32_t *rid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->create_user(pdb, mem_ctx, name, flags, rid);
@@ -537,7 +660,7 @@ NTSTATUS pdb_update_login_attempts(struct samu *sam_acct, bool success)
        return pdb->update_login_attempts(pdb, sam_acct, success);
 }
 
-bool pdb_getgrsid(GROUP_MAP *map, DOM_SID sid)
+bool pdb_getgrsid(GROUP_MAP *map, struct dom_sid sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return NT_STATUS_IS_OK(pdb->getgrsid(pdb, map, sid));
@@ -558,9 +681,9 @@ bool pdb_getgrnam(GROUP_MAP *map, const char *name)
 static NTSTATUS pdb_default_create_dom_group(struct pdb_methods *methods,
                                             TALLOC_CTX *mem_ctx,
                                             const char *name,
-                                            uint32 *rid)
+                                            uint32_t *rid)
 {
-       DOM_SID group_sid;
+       struct dom_sid group_sid;
        struct group *grp;
        fstring tmp;
 
@@ -595,7 +718,7 @@ static NTSTATUS pdb_default_create_dom_group(struct pdb_methods *methods,
 }
 
 NTSTATUS pdb_create_dom_group(TALLOC_CTX *mem_ctx, const char *name,
-                             uint32 *rid)
+                             uint32_t *rid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->create_dom_group(pdb, mem_ctx, name, rid);
@@ -603,9 +726,9 @@ NTSTATUS pdb_create_dom_group(TALLOC_CTX *mem_ctx, const char *name,
 
 static NTSTATUS pdb_default_delete_dom_group(struct pdb_methods *methods,
                                             TALLOC_CTX *mem_ctx,
-                                            uint32 rid)
+                                            uint32_t rid)
 {
-       DOM_SID group_sid;
+       struct dom_sid group_sid;
        GROUP_MAP map;
        NTSTATUS status;
        struct group *grp;
@@ -652,7 +775,7 @@ static NTSTATUS pdb_default_delete_dom_group(struct pdb_methods *methods,
        return NT_STATUS_OK;
 }
 
-NTSTATUS pdb_delete_dom_group(TALLOC_CTX *mem_ctx, uint32 rid)
+NTSTATUS pdb_delete_dom_group(TALLOC_CTX *mem_ctx, uint32_t rid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->delete_dom_group(pdb, mem_ctx, rid);
@@ -670,13 +793,13 @@ NTSTATUS pdb_update_group_mapping_entry(GROUP_MAP *map)
        return pdb->update_group_mapping_entry(pdb, map);
 }
 
-NTSTATUS pdb_delete_group_mapping_entry(DOM_SID sid)
+NTSTATUS pdb_delete_group_mapping_entry(struct dom_sid sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->delete_group_mapping_entry(pdb, sid);
 }
 
-bool pdb_enum_group_mapping(const DOM_SID *sid, enum lsa_SidType sid_name_use, GROUP_MAP **pp_rmap,
+bool pdb_enum_group_mapping(const struct dom_sid *sid, enum lsa_SidType sid_name_use, GROUP_MAP **pp_rmap,
                            size_t *p_num_entries, bool unix_only)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -685,8 +808,8 @@ bool pdb_enum_group_mapping(const DOM_SID *sid, enum lsa_SidType sid_name_use, G
 }
 
 NTSTATUS pdb_enum_group_members(TALLOC_CTX *mem_ctx,
-                               const DOM_SID *sid,
-                               uint32 **pp_member_rids,
+                               const struct dom_sid *sid,
+                               uint32_t **pp_member_rids,
                                size_t *p_num_members)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -698,11 +821,11 @@ NTSTATUS pdb_enum_group_members(TALLOC_CTX *mem_ctx,
        /* special check for rid 513 */
 
        if ( !NT_STATUS_IS_OK( result ) ) {
-               uint32 rid;
+               uint32_t rid;
 
                sid_peek_rid( sid, &rid );
 
-               if ( rid == DOMAIN_GROUP_RID_USERS ) {
+               if ( rid == DOMAIN_RID_USERS ) {
                        *p_num_members = 0;
                        *pp_member_rids = NULL;
 
@@ -714,7 +837,7 @@ NTSTATUS pdb_enum_group_members(TALLOC_CTX *mem_ctx,
 }
 
 NTSTATUS pdb_enum_group_memberships(TALLOC_CTX *mem_ctx, struct samu *user,
-                                   DOM_SID **pp_sids, gid_t **pp_gids,
+                                   struct dom_sid **pp_sids, gid_t **pp_gids,
                                    size_t *p_num_groups)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -756,9 +879,9 @@ NTSTATUS pdb_set_unix_primary_group(TALLOC_CTX *mem_ctx, struct samu *user)
  */
 
 static bool pdb_user_in_group(TALLOC_CTX *mem_ctx, struct samu *account,
-                             const DOM_SID *group_sid)
+                             const struct dom_sid *group_sid)
 {
-       DOM_SID *sids;
+       struct dom_sid *sids;
        gid_t *gids;
        size_t i, num_groups;
 
@@ -769,7 +892,7 @@ static bool pdb_user_in_group(TALLOC_CTX *mem_ctx, struct samu *account,
        }
 
        for (i=0; i<num_groups; i++) {
-               if (sid_equal(group_sid, &sids[i])) {
+               if (dom_sid_equal(group_sid, &sids[i])) {
                        return True;
                }
        }
@@ -778,10 +901,10 @@ static bool pdb_user_in_group(TALLOC_CTX *mem_ctx, struct samu *account,
 
 static NTSTATUS pdb_default_add_groupmem(struct pdb_methods *methods,
                                         TALLOC_CTX *mem_ctx,
-                                        uint32 group_rid,
-                                        uint32 member_rid)
+                                        uint32_t group_rid,
+                                        uint32_t member_rid)
 {
-       DOM_SID group_sid, member_sid;
+       struct dom_sid group_sid, member_sid;
        struct samu *account = NULL;
        GROUP_MAP map;
        struct group *grp;
@@ -834,8 +957,8 @@ static NTSTATUS pdb_default_add_groupmem(struct pdb_methods *methods,
        return NT_STATUS_OK;
 }
 
-NTSTATUS pdb_add_groupmem(TALLOC_CTX *mem_ctx, uint32 group_rid,
-                         uint32 member_rid)
+NTSTATUS pdb_add_groupmem(TALLOC_CTX *mem_ctx, uint32_t group_rid,
+                         uint32_t member_rid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->add_groupmem(pdb, mem_ctx, group_rid, member_rid);
@@ -843,10 +966,10 @@ NTSTATUS pdb_add_groupmem(TALLOC_CTX *mem_ctx, uint32 group_rid,
 
 static NTSTATUS pdb_default_del_groupmem(struct pdb_methods *methods,
                                         TALLOC_CTX *mem_ctx,
-                                        uint32 group_rid,
-                                        uint32 member_rid)
+                                        uint32_t group_rid,
+                                        uint32_t member_rid)
 {
-       DOM_SID group_sid, member_sid;
+       struct dom_sid group_sid, member_sid;
        struct samu *account = NULL;
        GROUP_MAP map;
        struct group *grp;
@@ -896,51 +1019,51 @@ static NTSTATUS pdb_default_del_groupmem(struct pdb_methods *methods,
        return NT_STATUS_OK;
 }
 
-NTSTATUS pdb_del_groupmem(TALLOC_CTX *mem_ctx, uint32 group_rid,
-                         uint32 member_rid)
+NTSTATUS pdb_del_groupmem(TALLOC_CTX *mem_ctx, uint32_t group_rid,
+                         uint32_t member_rid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->del_groupmem(pdb, mem_ctx, group_rid, member_rid);
 }
 
-NTSTATUS pdb_create_alias(const char *name, uint32 *rid)
+NTSTATUS pdb_create_alias(const char *name, uint32_t *rid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->create_alias(pdb, name, rid);
 }
 
-NTSTATUS pdb_delete_alias(const DOM_SID *sid)
+NTSTATUS pdb_delete_alias(const struct dom_sid *sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->delete_alias(pdb, sid);
 }
 
-NTSTATUS pdb_get_aliasinfo(const DOM_SID *sid, struct acct_info *info)
+NTSTATUS pdb_get_aliasinfo(const struct dom_sid *sid, struct acct_info *info)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->get_aliasinfo(pdb, sid, info);
 }
 
-NTSTATUS pdb_set_aliasinfo(const DOM_SID *sid, struct acct_info *info)
+NTSTATUS pdb_set_aliasinfo(const struct dom_sid *sid, struct acct_info *info)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->set_aliasinfo(pdb, sid, info);
 }
 
-NTSTATUS pdb_add_aliasmem(const DOM_SID *alias, const DOM_SID *member)
+NTSTATUS pdb_add_aliasmem(const struct dom_sid *alias, const struct dom_sid *member)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->add_aliasmem(pdb, alias, member);
 }
 
-NTSTATUS pdb_del_aliasmem(const DOM_SID *alias, const DOM_SID *member)
+NTSTATUS pdb_del_aliasmem(const struct dom_sid *alias, const struct dom_sid *member)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->del_aliasmem(pdb, alias, member);
 }
 
-NTSTATUS pdb_enum_aliasmem(const DOM_SID *alias, TALLOC_CTX *mem_ctx,
-                          DOM_SID **pp_members, size_t *p_num_members)
+NTSTATUS pdb_enum_aliasmem(const struct dom_sid *alias, TALLOC_CTX *mem_ctx,
+                          struct dom_sid **pp_members, size_t *p_num_members)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->enum_aliasmem(pdb, alias, mem_ctx, pp_members,
@@ -948,9 +1071,9 @@ NTSTATUS pdb_enum_aliasmem(const DOM_SID *alias, TALLOC_CTX *mem_ctx,
 }
 
 NTSTATUS pdb_enum_alias_memberships(TALLOC_CTX *mem_ctx,
-                                   const DOM_SID *domain_sid,
-                                   const DOM_SID *members, size_t num_members,
-                                   uint32 **pp_alias_rids,
+                                   const struct dom_sid *domain_sid,
+                                   const struct dom_sid *members, size_t num_members,
+                                   uint32_t **pp_alias_rids,
                                    size_t *p_num_alias_rids)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -961,9 +1084,9 @@ NTSTATUS pdb_enum_alias_memberships(TALLOC_CTX *mem_ctx,
                                                       p_num_alias_rids);
 }
 
-NTSTATUS pdb_lookup_rids(const DOM_SID *domain_sid,
+NTSTATUS pdb_lookup_rids(const struct dom_sid *domain_sid,
                         int num_rids,
-                        uint32 *rids,
+                        uint32_t *rids,
                         const char **names,
                         enum lsa_SidType *attrs)
 {
@@ -983,10 +1106,10 @@ NTSTATUS pdb_lookup_rids(const DOM_SID *domain_sid,
  *       used in this context some day. 
  */
 #if 0
-NTSTATUS pdb_lookup_names(const DOM_SID *domain_sid,
+NTSTATUS pdb_lookup_names(const struct dom_sid *domain_sid,
                          int num_names,
                          const char **names,
-                         uint32 *rids,
+                         uint32_t *rids,
                          enum lsa_SidType *attrs)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -1024,19 +1147,19 @@ bool pdb_get_seq_num(time_t *seq_num)
        return NT_STATUS_IS_OK(pdb->get_seq_num(pdb, seq_num));
 }
 
-bool pdb_uid_to_sid(uid_t uid, DOM_SID *sid)
+bool pdb_uid_to_sid(uid_t uid, struct dom_sid *sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->uid_to_sid(pdb, uid, sid);
 }
 
-bool pdb_gid_to_sid(gid_t gid, DOM_SID *sid)
+bool pdb_gid_to_sid(gid_t gid, struct dom_sid *sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->gid_to_sid(pdb, gid, sid);
 }
 
-bool pdb_sid_to_id(const DOM_SID *sid, union unid_t *id,
+bool pdb_sid_to_id(const struct dom_sid *sid, union unid_t *id,
                   enum lsa_SidType *type)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -1056,12 +1179,12 @@ uint32_t pdb_capabilities(void)
  with add RIDs (assigned from previous algorithmic mappings)
 ********************************************************************/
 
-bool pdb_new_rid(uint32 *rid)
+bool pdb_new_rid(uint32_t *rid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        const char *name = NULL;
        enum lsa_SidType type;
-       uint32 allocated_rid = 0;
+       uint32_t allocated_rid = 0;
        int i;
        TALLOC_CTX *ctx;
 
@@ -1136,7 +1259,7 @@ static NTSTATUS pdb_default_getsampwnam (struct pdb_methods *methods, struct sam
        return NT_STATUS_NO_SUCH_USER;
 }
 
-static NTSTATUS pdb_default_getsampwsid(struct pdb_methods *my_methods, struct samu * user, const DOM_SID *sid)
+static NTSTATUS pdb_default_getsampwsid(struct pdb_methods *my_methods, struct samu * user, const struct dom_sid *sid)
 {
        return NT_STATUS_NO_SUCH_USER;
 }
@@ -1185,7 +1308,7 @@ static NTSTATUS pdb_default_get_seq_num(struct pdb_methods *methods, time_t *seq
 }
 
 static bool pdb_default_uid_to_sid(struct pdb_methods *methods, uid_t uid,
-                                  DOM_SID *sid)
+                                  struct dom_sid *sid)
 {
        struct samu *sampw = NULL;
        struct passwd *unix_pw;
@@ -1224,7 +1347,7 @@ static bool pdb_default_uid_to_sid(struct pdb_methods *methods, uid_t uid,
 }
 
 static bool pdb_default_gid_to_sid(struct pdb_methods *methods, gid_t gid,
-                                  DOM_SID *sid)
+                                  struct dom_sid *sid)
 {
        GROUP_MAP map;
 
@@ -1237,13 +1360,13 @@ static bool pdb_default_gid_to_sid(struct pdb_methods *methods, gid_t gid,
 }
 
 static bool pdb_default_sid_to_id(struct pdb_methods *methods,
-                                 const DOM_SID *sid,
+                                 const struct dom_sid *sid,
                                  union unid_t *id, enum lsa_SidType *type)
 {
        TALLOC_CTX *mem_ctx;
        bool ret = False;
        const char *name;
-       uint32 rid;
+       uint32_t rid;
 
        mem_ctx = talloc_new(NULL);
 
@@ -1367,8 +1490,8 @@ static bool get_memberuids(TALLOC_CTX *mem_ctx, gid_t gid, uid_t **pp_uids, size
 
 static NTSTATUS pdb_default_enum_group_members(struct pdb_methods *methods,
                                               TALLOC_CTX *mem_ctx,
-                                              const DOM_SID *group,
-                                              uint32 **pp_member_rids,
+                                              const struct dom_sid *group,
+                                              uint32_t **pp_member_rids,
                                               size_t *p_num_members)
 {
        gid_t gid;
@@ -1387,10 +1510,10 @@ static NTSTATUS pdb_default_enum_group_members(struct pdb_methods *methods,
        if (num_uids == 0)
                return NT_STATUS_OK;
 
-       *pp_member_rids = TALLOC_ZERO_ARRAY(mem_ctx, uint32, num_uids);
+       *pp_member_rids = TALLOC_ZERO_ARRAY(mem_ctx, uint32_t, num_uids);
 
        for (i=0; i<num_uids; i++) {
-               DOM_SID sid;
+               struct dom_sid sid;
 
                uid_to_sid(&sid, uids[i]);
 
@@ -1410,7 +1533,7 @@ static NTSTATUS pdb_default_enum_group_members(struct pdb_methods *methods,
 static NTSTATUS pdb_default_enum_group_memberships(struct pdb_methods *methods,
                                                   TALLOC_CTX *mem_ctx,
                                                   struct samu *user,
-                                                  DOM_SID **pp_sids,
+                                                  struct dom_sid **pp_sids,
                                                   gid_t **pp_gids,
                                                   size_t *p_num_groups)
 {
@@ -1439,7 +1562,7 @@ static NTSTATUS pdb_default_enum_group_memberships(struct pdb_methods *methods,
                smb_panic("primary group missing");
        }
 
-       *pp_sids = TALLOC_ARRAY(mem_ctx, DOM_SID, *p_num_groups);
+       *pp_sids = TALLOC_ARRAY(mem_ctx, struct dom_sid, *p_num_groups);
 
        if (*pp_sids == NULL) {
                TALLOC_FREE(*pp_gids);
@@ -1457,7 +1580,7 @@ static NTSTATUS pdb_default_enum_group_memberships(struct pdb_methods *methods,
  Look up a rid in the SAM we're responsible for (i.e. passdb)
  ********************************************************************/
 
-static bool lookup_global_sam_rid(TALLOC_CTX *mem_ctx, uint32 rid,
+static bool lookup_global_sam_rid(TALLOC_CTX *mem_ctx, uint32_t rid,
                                  const char **name,
                                  enum lsa_SidType *psid_name_use,
                                  union unid_t *unix_id)
@@ -1465,7 +1588,7 @@ static bool lookup_global_sam_rid(TALLOC_CTX *mem_ctx, uint32 rid,
        struct samu *sam_account = NULL;
        GROUP_MAP map;
        bool ret;
-       DOM_SID sid;
+       struct dom_sid sid;
 
        *psid_name_use = SID_NAME_UNKNOWN;
 
@@ -1480,7 +1603,7 @@ static bool lookup_global_sam_rid(TALLOC_CTX *mem_ctx, uint32 rid,
                return False;
        }
 
-       /* BEING ROOT BLLOCK */
+       /* BEING ROOT BLOCK */
        become_root();
        if (pdb_getsampwsid(sam_account, &sid)) {
                struct passwd *pw;
@@ -1536,7 +1659,7 @@ static bool lookup_global_sam_rid(TALLOC_CTX *mem_ctx, uint32 rid,
                return False;
        }
 
-       if ( rid == DOMAIN_GROUP_RID_USERS ) {
+       if ( rid == DOMAIN_RID_USERS ) {
                *name = talloc_strdup(mem_ctx, "None" );
                *psid_name_use = SID_NAME_DOM_GRP;
 
@@ -1547,9 +1670,9 @@ static bool lookup_global_sam_rid(TALLOC_CTX *mem_ctx, uint32 rid,
 }
 
 static NTSTATUS pdb_default_lookup_rids(struct pdb_methods *methods,
-                                       const DOM_SID *domain_sid,
+                                       const struct dom_sid *domain_sid,
                                        int num_rids,
-                                       uint32 *rids,
+                                       uint32_t *rids,
                                        const char **names,
                                        enum lsa_SidType *attrs)
 {
@@ -1611,10 +1734,10 @@ static NTSTATUS pdb_default_lookup_rids(struct pdb_methods *methods,
 
 #if 0
 static NTSTATUS pdb_default_lookup_names(struct pdb_methods *methods,
-                                        const DOM_SID *domain_sid,
+                                        const struct dom_sid *domain_sid,
                                         int num_names,
                                         const char **names,
-                                        uint32 *rids,
+                                        uint32_t *rids,
                                         enum lsa_SidType *attrs)
 {
        int i;
@@ -1625,7 +1748,7 @@ static NTSTATUS pdb_default_lookup_names(struct pdb_methods *methods,
        if (sid_check_is_builtin(domain_sid)) {
 
                for (i=0; i<num_names; i++) {
-                       uint32 rid;
+                       uint32_t rid;
 
                        if (lookup_builtin_name(names[i], &rid)) {
                                attrs[i] = SID_NAME_ALIAS;
@@ -1703,8 +1826,8 @@ struct pdb_search *pdb_search_init(TALLOC_CTX *mem_ctx,
        return result;
 }
 
-static void fill_displayentry(TALLOC_CTX *mem_ctx, uint32 rid,
-                             uint16 acct_flags,
+static void fill_displayentry(TALLOC_CTX *mem_ctx, uint32_t rid,
+                             uint16_t acct_flags,
                              const char *account_name,
                              const char *fullname,
                              const char *description,
@@ -1738,7 +1861,7 @@ static bool next_entry_groups(struct pdb_search *s,
                              struct samr_displayentry *entry)
 {
        struct group_search *state = (struct group_search *)s->private_data;
-       uint32 rid;
+       uint32_t rid;
        GROUP_MAP *map = &state->groups[state->current_group];
 
        if (state->current_group == state->num_groups)
@@ -1760,7 +1883,7 @@ static void search_end_groups(struct pdb_search *search)
 }
 
 static bool pdb_search_grouptype(struct pdb_search *search,
-                                const DOM_SID *sid, enum lsa_SidType type)
+                                const struct dom_sid *sid, enum lsa_SidType type)
 {
        struct group_search *state;
 
@@ -1791,14 +1914,14 @@ static bool pdb_default_search_groups(struct pdb_methods *methods,
 
 static bool pdb_default_search_aliases(struct pdb_methods *methods,
                                       struct pdb_search *search,
-                                      const DOM_SID *sid)
+                                      const struct dom_sid *sid)
 {
 
        return pdb_search_grouptype(search, sid, SID_NAME_ALIAS);
 }
 
 static struct samr_displayentry *pdb_search_getentry(struct pdb_search *search,
-                                                    uint32 idx)
+                                                    uint32_t idx)
 {
        if (idx < search->num_entries)
                return &search->cache[idx];
@@ -1823,7 +1946,7 @@ static struct samr_displayentry *pdb_search_getentry(struct pdb_search *search,
        return (search->num_entries > idx) ? &search->cache[idx] : NULL;
 }
 
-struct pdb_search *pdb_search_users(TALLOC_CTX *mem_ctx, uint32 acct_flags)
+struct pdb_search *pdb_search_users(TALLOC_CTX *mem_ctx, uint32_t acct_flags)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        struct pdb_search *result;
@@ -1857,7 +1980,7 @@ struct pdb_search *pdb_search_groups(TALLOC_CTX *mem_ctx)
        return result;
 }
 
-struct pdb_search *pdb_search_aliases(TALLOC_CTX *mem_ctx, const DOM_SID *sid)
+struct pdb_search *pdb_search_aliases(TALLOC_CTX *mem_ctx, const struct dom_sid *sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        struct pdb_search *result;
@@ -1876,12 +1999,12 @@ struct pdb_search *pdb_search_aliases(TALLOC_CTX *mem_ctx, const DOM_SID *sid)
        return result;
 }
 
-uint32 pdb_search_entries(struct pdb_search *search,
-                         uint32 start_idx, uint32 max_entries,
+uint32_t pdb_search_entries(struct pdb_search *search,
+                         uint32_t start_idx, uint32_t max_entries,
                          struct samr_displayentry **result)
 {
        struct samr_displayentry *end_entry;
-       uint32 end_idx = start_idx+max_entries-1;
+       uint32_t end_idx = start_idx+max_entries-1;
 
        /* The first entry needs to be searched after the last. Otherwise the
         * first entry might have moved due to a realloc during the search for
@@ -1903,7 +2026,7 @@ uint32 pdb_search_entries(struct pdb_search *search,
  trustdom methods
  *******************************************************************/
 
-bool pdb_get_trusteddom_pw(const char *domain, char** pwd, DOM_SID *sid, 
+bool pdb_get_trusteddom_pw(const char *domain, char** pwd, struct dom_sid *sid,
                           time_t *pass_last_set_time)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -1912,7 +2035,7 @@ bool pdb_get_trusteddom_pw(const char *domain, char** pwd, DOM_SID *sid,
 }
 
 bool pdb_set_trusteddom_pw(const char* domain, const char* pwd,
-                          const DOM_SID *sid)
+                          const struct dom_sid *sid)
 {
        struct pdb_methods *pdb = pdb_get_methods();
        return pdb->set_trusteddom_pw(pdb, domain, pwd, sid);
@@ -1924,7 +2047,7 @@ bool pdb_del_trusteddom_pw(const char *domain)
        return pdb->del_trusteddom_pw(pdb, domain);
 }
 
-NTSTATUS pdb_enum_trusteddoms(TALLOC_CTX *mem_ctx, uint32 *num_domains,
+NTSTATUS pdb_enum_trusteddoms(TALLOC_CTX *mem_ctx, uint32_t *num_domains,
                              struct trustdom_info ***domains)
 {
        struct pdb_methods *pdb = pdb_get_methods();
@@ -1940,7 +2063,7 @@ NTSTATUS pdb_enum_trusteddoms(TALLOC_CTX *mem_ctx, uint32 *num_domains,
 static bool pdb_default_get_trusteddom_pw(struct pdb_methods *methods,
                                          const char *domain, 
                                          char** pwd, 
-                                         DOM_SID *sid, 
+                                         struct dom_sid *sid,
                                          time_t *pass_last_set_time)
 {
        return secrets_fetch_trusted_domain_password(domain, pwd,
@@ -1951,7 +2074,7 @@ static bool pdb_default_get_trusteddom_pw(struct pdb_methods *methods,
 static bool pdb_default_set_trusteddom_pw(struct pdb_methods *methods, 
                                          const char* domain, 
                                          const char* pwd,
-                                         const DOM_SID *sid)
+                                         const struct dom_sid *sid)
 {
        return secrets_store_trusted_domain_password(domain, pwd, sid);
 }
@@ -1964,7 +2087,7 @@ static bool pdb_default_del_trusteddom_pw(struct pdb_methods *methods,
 
 static NTSTATUS pdb_default_enum_trusteddoms(struct pdb_methods *methods,
                                             TALLOC_CTX *mem_ctx, 
-                                            uint32 *num_domains,
+                                            uint32_t *num_domains,
                                             struct trustdom_info ***domains)
 {
        return secrets_trusted_domains(mem_ctx, num_domains, domains);
@@ -1987,7 +2110,7 @@ NTSTATUS make_pdb_method( struct pdb_methods **methods )
 {
        /* allocate memory for the structure as its own talloc CTX */
 
-       *methods = talloc_zero(talloc_autofree_context(), struct pdb_methods);
+       *methods = talloc_zero(NULL, struct pdb_methods);
        if (*methods == NULL) {
                return NT_STATUS_NO_MEMORY;
        }