r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
[vlendec/samba-autobuild/.git] / source3 / client / client.c
index 9a09d50cc08000e9363860d3b0e961541a16ccf2..99fffa712321cf921dcffdc173297be0371c886a 100644 (file)
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
-#define NO_SYSLOG
-
 #include "includes.h"
 #include "client/client_proto.h"
 #ifndef REGISTER
 #define REGISTER 0
 #endif
 
+extern BOOL AllowDebugChange;
+extern BOOL override_logfile;
+extern char tar_type;
 extern BOOL in_client;
 static int port = 0;
 pstring cur_dir = "\\";
@@ -70,8 +71,6 @@ extern BOOL tar_reset;
 
 static BOOL prompt = True;
 
-static int printmode = 1;
-
 static BOOL recurse = False;
 BOOL lowercase = False;
 
@@ -219,6 +218,7 @@ static int do_dskattr(void)
 
        if ( !cli_resolve_path( "", cli, cur_dir, &targetcli, targetpath ) ) {
                d_printf("Error in dskattr: %s\n", cli_errstr(cli));
+               return 1;
        }
 
        if (!cli_dskattr(targetcli, &bsize, &total, &avail)) {
@@ -256,6 +256,7 @@ static int do_cd(char *newdir)
        struct cli_state *targetcli;
        SMB_STRUCT_STAT sbuf;
        uint32 attributes;
+       int ret = 1;
       
        dos_format(newdir);
 
@@ -268,7 +269,7 @@ static int do_cd(char *newdir)
        else
                pstrcat(cur_dir,p);
 
-       if (*(cur_dir+strlen(cur_dir)-1) != '\\') {
+       if ((cur_dir[0] != '\0') && (*(cur_dir+strlen(cur_dir)-1) != '\\')) {
                pstrcat(cur_dir, "\\");
        }
        
@@ -287,9 +288,10 @@ static int do_cd(char *newdir)
        if ( strequal(targetpath,"\\" ) )
                return 0;   
                
-       /* use a trans2_qpathinfo to test directories for modern servers */
+       /* Use a trans2_qpathinfo to test directories for modern servers.
+          Except Win9x doesn't support the qpathinfo_basic() call..... */ 
        
-       if ( targetcli->protocol >= PROTOCOL_LANMAN2 ) {
+       if ( targetcli->protocol >  PROTOCOL_LANMAN2 && !targetcli->win95 ) {
                if ( !cli_qpathinfo_basic( targetcli, targetpath, &sbuf, &attributes ) ) {
                        d_printf("cd %s: %s\n", dname, cli_errstr(targetcli));
                        pstrcpy(cur_dir,saved_dir);
@@ -301,21 +303,23 @@ static int do_cd(char *newdir)
                        pstrcpy(cur_dir,saved_dir);
                        goto out;
                }               
-       }
-       else {
+       } else {
                pstrcat( targetpath, "\\" );
                dos_clean_name( targetpath );
                
                if ( !cli_chkpath(targetcli, targetpath) ) {
                        d_printf("cd %s: %s\n", dname, cli_errstr(targetcli));
                        pstrcpy(cur_dir,saved_dir);
+                       goto out;
                }
        }
 
+       ret = 0;
+
 out:
+       
        pstrcpy(cd_path,cur_dir);
-
-       return 0;
+       return ret;
 }
 
 /****************************************************************************
@@ -375,7 +379,7 @@ static void display_finfo(file_info *finfo)
                         finfo->name,
                         attrib_string(finfo->mode),
                         (double)finfo->size,
-                        asctime(LocalTime(&t)));
+                        time_to_asc(&t));
                dir_total += finfo->size;
        }
 }
@@ -443,7 +447,14 @@ static void adjust_do_list_queue(void)
         * If the starting point of the queue is more than half way through,
         * move everything toward the beginning.
         */
-       if (do_list_queue && (do_list_queue_start == do_list_queue_end)) {
+
+       if (do_list_queue == NULL) {
+               DEBUG(4,("do_list_queue is empty\n"));
+               do_list_queue_start = do_list_queue_end = 0;
+               return;
+       }
+               
+       if (do_list_queue_start == do_list_queue_end) {
                DEBUG(4,("do_list_queue is empty\n"));
                do_list_queue_start = do_list_queue_end = 0;
                *do_list_queue = '\0';
@@ -459,19 +470,17 @@ static void adjust_do_list_queue(void)
 
 static void add_to_do_list_queue(const char* entry)
 {
-       char *dlq;
        long new_end = do_list_queue_end + ((long)strlen(entry)) + 1;
        while (new_end > do_list_queue_size) {
                do_list_queue_size *= 2;
                DEBUG(4,("enlarging do_list_queue to %d\n",
                         (int)do_list_queue_size));
-               dlq = SMB_REALLOC(do_list_queue, do_list_queue_size);
-               if (! dlq) {
+               do_list_queue = SMB_REALLOC(do_list_queue, do_list_queue_size);
+               if (! do_list_queue) {
                        d_printf("failure enlarging do_list_queue to %d bytes\n",
                                 (int)do_list_queue_size);
                        reset_do_list_queue();
                } else {
-                       do_list_queue = dlq;
                        memset(do_list_queue + do_list_queue_size / 2,
                               0, do_list_queue_size / 2);
                }
@@ -511,6 +520,14 @@ static int do_list_queue_empty(void)
 
 static void do_list_helper(const char *mntpoint, file_info *f, const char *mask, void *state)
 {
+       char *dir_end;
+
+       /* save the directory */
+       pstrcpy( f->dir, mask );
+       if ( (dir_end = strrchr( f->dir, '\\' )) != NULL ) {
+               *dir_end = '\0';
+       }
+
        if (f->mode & aDIR) {
                if (do_list_dirs && do_this_one(f)) {
                        do_list_fn(f);
@@ -637,7 +654,7 @@ static int cmd_dir(void)
        dir_total = 0;
        if (strcmp(cur_dir, "\\") != 0) {
                pstrcpy(mask,cur_dir);
-               if(mask[strlen(mask)-1]!='\\')
+               if ((mask[0] != '\0') && (mask[strlen(mask)-1]!='\\'))
                        pstrcat(mask,"\\");
        } else {
                pstrcpy(mask, "\\");
@@ -676,7 +693,7 @@ static int cmd_du(void)
        
        dir_total = 0;
        pstrcpy(mask,cur_dir);
-       if(mask[strlen(mask)-1]!='\\')
+       if ((mask[0] != '\0') && (mask[strlen(mask)-1]!='\\'))
                pstrcat(mask,"\\");
        
        if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
@@ -710,7 +727,7 @@ static int do_get(char *rname, char *lname, BOOL reget)
        struct timeval tp_start;
        int read_size = io_bufsize;
        uint16 attr;
-       size_t size;
+       SMB_OFF_T size;
        off_t start = 0;
        off_t nread = 0;
        int rc = 0;
@@ -727,9 +744,19 @@ static int do_get(char *rname, char *lname, BOOL reget)
                return 1;
        }
 
-
        GetTimeOfDay(&tp_start);
        
+       if ( targetcli->dfsroot ) {
+               pstring path;
+
+               /* we need to refer to the full \server\share\path format 
+                  for dfs shares */
+
+               pstrcpy( path, targetname );
+               cli_dfs_make_full_path( targetname, targetcli->desthost, 
+                       targetcli->share, path);
+       }
+
        fnum = cli_open(targetcli, targetname, O_RDONLY, DENY_NONE);
 
        if (fnum == -1) {
@@ -988,7 +1015,7 @@ static int cmd_mget(void)
 
        while (next_token_nr(NULL,p,NULL,sizeof(buf))) {
                pstrcpy(mget_mask,cur_dir);
-               if(mget_mask[strlen(mget_mask)-1]!='\\')
+               if ((mget_mask[0] != '\0') && (mget_mask[strlen(mget_mask)-1]!='\\'))
                        pstrcat(mget_mask,"\\");
                
                if (*p == '\\')
@@ -1134,7 +1161,7 @@ static int do_put(char *rname, char *lname, BOOL reput)
 {
        int fnum;
        XFILE *f;
-       size_t start = 0;
+       SMB_OFF_T start = 0;
        off_t nread = 0;
        char *buf = NULL;
        int maxwrite = io_bufsize;
@@ -1316,15 +1343,15 @@ static struct file_list {
  Free a file_list structure.
 ****************************************************************************/
 
-static void free_file_list (struct file_list * list)
+static void free_file_list (struct file_list *list_head)
 {
-       struct file_list *tmp;
+       struct file_list *list, *next;
        
-       while (list) {
-               tmp = list;
-               DLIST_REMOVE(list, list);
-               SAFE_FREE(tmp->file_path);
-               SAFE_FREE(tmp);
+       for (list = list_head; list; list = next) {
+               next = list->next;
+               DLIST_REMOVE(list_head, list);
+               SAFE_FREE(list->file_path);
+               SAFE_FREE(list);
        }
 }
 
@@ -1366,7 +1393,7 @@ static int cmd_select(void)
 static int file_find(struct file_list **list, const char *directory, 
                      const char *expression, BOOL match)
 {
-       DIR *dir;
+       SMB_STRUCT_DIR *dir;
        struct file_list *entry;
         struct stat statbuf;
         int ret;
@@ -1374,7 +1401,7 @@ static int file_find(struct file_list **list, const char *directory,
        BOOL isdir;
        const char *dname;
 
-        dir = opendir(directory);
+        dir = sys_opendir(directory);
        if (!dir)
                return -1;
        
@@ -1403,14 +1430,14 @@ static int file_find(struct file_list **list, const char *directory,
                                
                                if (ret == -1) {
                                        SAFE_FREE(path);
-                                       closedir(dir);
+                                       sys_closedir(dir);
                                        return -1;
                                }
                        }
                        entry = SMB_MALLOC_P(struct file_list);
                        if (!entry) {
                                d_printf("Out of memory in file_find\n");
-                               closedir(dir);
+                               sys_closedir(dir);
                                return -1;
                        }
                        entry->file_path = path;
@@ -1421,7 +1448,7 @@ static int file_find(struct file_list **list, const char *directory,
                }
         }
 
-       closedir(dir);
+       sys_closedir(dir);
        return 0;
 }
 
@@ -1600,8 +1627,7 @@ static void do_del(file_info *finfo)
 {
        pstring mask;
 
-       pstrcpy(mask,cur_dir);
-       pstrcat(mask,finfo->name);
+       pstr_sprintf( mask, "%s\\%s", finfo->dir, finfo->name );
 
        if (finfo->mode & aDIR) 
                return;
@@ -2092,6 +2118,7 @@ static int cmd_stat(void)
        fstring mode_str;
        SMB_STRUCT_STAT sbuf;
        struct cli_state *targetcli;
+       struct tm *lt;
        pstring targetname;
  
        if (!SERVER_HAS_UNIX_CIFS(cli)) {
@@ -2146,13 +2173,28 @@ static int cmd_stat(void)
                (unsigned int)sbuf.st_uid, 
                (unsigned int)sbuf.st_gid);
 
-       strftime(mode_str, sizeof(mode_str), "%F %T %z", localtime(&sbuf.st_atime));
+       lt = localtime(&sbuf.st_atime);
+       if (lt) {
+               strftime(mode_str, sizeof(mode_str), "%F %T %z", lt);
+       } else {
+               fstrcpy(mode_str, "unknown");
+       }
        d_printf("Access: %s\n", mode_str);
 
-       strftime(mode_str, sizeof(mode_str), "%F %T %z", localtime(&sbuf.st_mtime));
+       lt = localtime(&sbuf.st_mtime);
+       if (lt) {
+               strftime(mode_str, sizeof(mode_str), "%F %T %z", lt);
+       } else {
+               fstrcpy(mode_str, "unknown");
+       }
        d_printf("Modify: %s\n", mode_str);
 
-       strftime(mode_str, sizeof(mode_str), "%F %T %z", localtime(&sbuf.st_ctime));
+       lt = localtime(&sbuf.st_ctime);
+       if (lt) {
+               strftime(mode_str, sizeof(mode_str), "%F %T %z", lt);
+       } else {
+               fstrcpy(mode_str, "unknown");
+       }
        d_printf("Change: %s\n", mode_str);
        
        return 0;
@@ -2234,6 +2276,25 @@ static int cmd_rename(void)
        return 0;
 }
 
+/****************************************************************************
+ Print the volume name.
+****************************************************************************/
+
+static int cmd_volume(void)
+{
+       fstring volname;
+       uint32 serial_num;
+       time_t create_date;
+  
+       if (!cli_get_fs_volume_info(cli, volname, &serial_num, &create_date)) {
+               d_printf("Errr %s getting volume info\n",cli_errstr(cli));
+               return 1;
+       }
+       
+       d_printf("Volume: |%s| serial number 0x%x\n", volname, (unsigned int)serial_num);
+       return 0;
+}
+
 /****************************************************************************
  Hard link files using the NT call.
 ****************************************************************************/
@@ -2301,7 +2362,7 @@ static int cmd_newer(void)
        if (ok && (sys_stat(buf,&sbuf) == 0)) {
                newer_than = sbuf.st_mtime;
                DEBUG(1,("Getting files newer than %s",
-                        asctime(LocalTime(&newer_than))));
+                        time_to_asc(&newer_than)));
        } else {
                newer_than = 0;
        }
@@ -2382,43 +2443,6 @@ static int cmd_translate(void)
        return 0;
 }
 
-/****************************************************************************
- Do a printmode command.
-****************************************************************************/
-
-static int cmd_printmode(void)
-{
-       fstring buf;
-       fstring mode;
-
-       if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
-               if (strequal(buf,"text")) {
-                       printmode = 0;      
-               } else {
-                       if (strequal(buf,"graphics"))
-                               printmode = 1;
-                       else
-                               printmode = atoi(buf);
-               }
-       }
-
-       switch(printmode) {
-               case 0: 
-                       fstrcpy(mode,"text");
-                       break;
-               case 1: 
-                       fstrcpy(mode,"graphics");
-                       break;
-               default: 
-                       slprintf(mode,sizeof(mode)-1,"%d",printmode);
-                       break;
-       }
-       
-       DEBUG(2,("the printmode is now %s\n",mode));
-
-       return 0;
-}
-
 /****************************************************************************
  Do the lcd command.
  ****************************************************************************/
@@ -2509,7 +2533,7 @@ static void browse_fn(const char *name, uint32 m,
 
         *typestr=0;
 
-        switch (m)
+        switch (m & 7)
         {
           case STYPE_DISKTREE:
             fstrcpy(typestr,"Disk"); break;
@@ -2531,6 +2555,57 @@ static void browse_fn(const char *name, uint32 m,
        }
 }
 
+static BOOL browse_host_rpc(BOOL sort)
+{
+       NTSTATUS status;
+       struct rpc_pipe_client *pipe_hnd;
+       TALLOC_CTX *mem_ctx;
+       ENUM_HND enum_hnd;
+       WERROR werr;
+       SRV_SHARE_INFO_CTR ctr;
+       int i;
+
+       mem_ctx = talloc_new(NULL);
+       if (mem_ctx == NULL) {
+               DEBUG(0, ("talloc_new failed\n"));
+               return False;
+       }
+
+       init_enum_hnd(&enum_hnd, 0);
+
+       pipe_hnd = cli_rpc_pipe_open_noauth(cli, PI_SRVSVC, &status);
+
+       if (pipe_hnd == NULL) {
+               DEBUG(10, ("Could not connect to srvsvc pipe: %s\n",
+                          nt_errstr(status)));
+               TALLOC_FREE(mem_ctx);
+               return False;
+       }
+
+       werr = rpccli_srvsvc_net_share_enum(pipe_hnd, mem_ctx, 1, &ctr,
+                                           0xffffffff, &enum_hnd);
+
+       if (!W_ERROR_IS_OK(werr)) {
+               TALLOC_FREE(mem_ctx);
+               cli_rpc_pipe_close(pipe_hnd);
+               return False;
+       }
+
+       for (i=0; i<ctr.num_entries; i++) {
+               SRV_SHARE_INFO_1 *info = &ctr.share.info1[i];
+               char *name, *comment;
+               name = rpcstr_pull_unistr2_talloc(
+                       mem_ctx, &info->info_1_str.uni_netname);
+               comment = rpcstr_pull_unistr2_talloc(
+                       mem_ctx, &info->info_1_str.uni_remark);
+               browse_fn(name, info->info_1.type, comment, NULL);
+       }
+
+       TALLOC_FREE(mem_ctx);
+       cli_rpc_pipe_close(pipe_hnd);
+       return True;
+}
+
 /****************************************************************************
  Try and browse available connections on a host.
 ****************************************************************************/
@@ -2543,6 +2618,10 @@ static BOOL browse_host(BOOL sort)
                d_printf("\t---------       ----      -------\n");
        }
 
+       if (browse_host_rpc(sort)) {
+               return True;
+       }
+
        if((ret = cli_RNetShareEnum(cli, browse_fn, NULL)) == -1)
                d_printf("Error returning browse list: %s\n", cli_errstr(cli));
 
@@ -2727,7 +2806,6 @@ static struct
   {"newer",cmd_newer,"<file> only mget files newer than the specified local file",{COMPL_LOCAL,COMPL_NONE}},
   {"open",cmd_open,"<mask> open a file",{COMPL_REMOTE,COMPL_NONE}},
   {"print",cmd_print,"<file name> print a file",{COMPL_NONE,COMPL_NONE}},
-  {"printmode",cmd_printmode,"<graphics or text> set the print mode",{COMPL_NONE,COMPL_NONE}},
   {"prompt",cmd_prompt,"toggle prompting for filenames for mget and mput",{COMPL_NONE,COMPL_NONE}},  
   {"put",cmd_put,"<local name> [remote name] put a file",{COMPL_LOCAL,COMPL_REMOTE}},
   {"pwd",cmd_pwd,"show current remote directory (same as 'cd' with no args)",{COMPL_NONE,COMPL_NONE}},
@@ -2747,6 +2825,7 @@ static struct
   {"tar",cmd_tar,"tar <c|x>[IXFqbgNan] current directory to/from <file name>",{COMPL_NONE,COMPL_NONE}},
   {"tarmode",cmd_tarmode,"<full|inc|reset|noreset> tar's behaviour towards archive bits",{COMPL_NONE,COMPL_NONE}},
   {"translate",cmd_translate,"toggle text translation for printing",{COMPL_NONE,COMPL_NONE}},
+  {"volume",cmd_volume,"print the volume name",{COMPL_NONE,COMPL_NONE}},
   {"vuid",cmd_vuid,"change current vuid",{COMPL_NONE,COMPL_NONE}},
   {"logon",cmd_logon,"establish new logon",{COMPL_NONE,COMPL_NONE}},
   {"listconnect",cmd_list_connect,"list open connections",{COMPL_NONE,COMPL_NONE}},
@@ -2918,16 +2997,22 @@ static char **remote_completion(const char *text, int len)
        info.text = text;
        info.len = len;
                
-       if (len >= PATH_MAX)
+       if (len >= MIN(PATH_MAX,sizeof(pstring))) {
                return(NULL);
+       }
 
        info.matches = SMB_MALLOC_ARRAY(char *,MAX_COMPLETIONS);
-       if (!info.matches) return NULL;
+       if (!info.matches) {
+               return NULL;
+       }
        info.matches[0] = NULL;
 
-       for (i = len-1; i >= 0; i--)
-               if ((text[i] == '/') || (text[i] == '\\'))
+       for (i = len-1; i >= 0; i--) {
+               if ((text[i] == '/') || (text[i] == '\\')) {
                        break;
+               }
+       }
+
        info.text = text+i+1;
        info.samelen = info.len = len-i-1;
 
@@ -2935,8 +3020,9 @@ static char **remote_completion(const char *text, int len)
                strncpy(info.dirmask, text, i+1);
                info.dirmask[i+1] = 0;
                pstr_sprintf(dirmask, "%s%*s*", cur_dir, i-1, text);
-       } else
+       } else {
                pstr_sprintf(dirmask, "%s*", cur_dir);
+       }
 
        if (cli_list(cli, dirmask, aDIR | aSYSTEM | aHIDDEN, completion_remote_filter, &info) < 0)
                goto cleanup;
@@ -3081,11 +3167,20 @@ static void readline_callback(void)
           session keepalives and then drop them here.
        */
        if (FD_ISSET(cli->fd,&fds)) {
-               receive_smb(cli->fd,cli->inbuf,0);
+               if (!receive_smb(cli->fd,cli->inbuf,0)) {
+                       DEBUG(0, ("Read from server failed, maybe it closed the "
+                               "connection\n"));
+                       return;
+               }
                goto again;
        }
       
-       cli_chkpath(cli, "\\");
+       /* Ping the server to keep the connection alive using SMBecho. */
+       {
+               unsigned char garbage[16];
+               memset(garbage, 0xf0, sizeof(garbage));
+               cli_echo(cli, garbage, sizeof(garbage));
+       }
 }
 
 /****************************************************************************
@@ -3146,7 +3241,13 @@ static int process(char *base_directory)
                return 1;
        }
 
-       if (*base_directory) do_cd(base_directory);
+       if (*base_directory) {
+               rc = do_cd(base_directory);
+               if (rc) {
+                       cli_cm_shutdown();
+                       return rc;
+               }
+       }
        
        if (cmdstr) {
                rc = process_command_string(cmdstr);
@@ -3209,7 +3310,13 @@ static int do_tar_op(char *base_directory)
 
        recurse=True;
 
-       if (*base_directory) do_cd(base_directory);
+       if (*base_directory)  {
+               ret = do_cd(base_directory);
+               if (ret) {
+                       cli_cm_shutdown();
+                       return ret;
+               }
+       }
        
        ret=process_tar();
 
@@ -3228,6 +3335,7 @@ static int do_message_op(void)
        struct nmb_name called, calling;
        fstring server_name;
        char name_type_hex[10];
+       int msg_port;
 
        make_nmb_name(&calling, calling_name, 0x0);
        make_nmb_name(&called , desthost, name_type);
@@ -3240,7 +3348,11 @@ static int do_message_op(void)
        if (have_ip) 
                ip = dest_ip;
 
-       if (!(cli=cli_initialise(NULL)) || (cli_set_port(cli, port) != port) ||
+       /* we can only do messages over port 139 (to windows clients at least) */
+
+       msg_port = port ? port : 139;
+
+       if (!(cli=cli_initialise()) || (cli_set_port(cli, msg_port) != msg_port) ||
            !cli_connect(cli, server_name, &ip)) {
                d_printf("Connection to %s failed\n", desthost);
                return 1;
@@ -3265,13 +3377,10 @@ static int do_message_op(void)
 
  int main(int argc,char *argv[])
 {
-       extern BOOL AllowDebugChange;
-       extern BOOL override_logfile;
        pstring base_directory;
        int opt;
        pstring query_host;
        BOOL message = False;
-       extern char tar_type;
        pstring term_code;
        static const char *new_name_resolve_order = NULL;
        poptContext pc;
@@ -3300,6 +3409,7 @@ static int do_message_op(void)
                POPT_TABLEEND
        };
        
+       load_case_tables();
 
 #ifdef KANJI
        pstrcpy(term_code, KANJI);
@@ -3319,8 +3429,9 @@ static int do_message_op(void)
         /* set default debug level to 0 regardless of what smb.conf sets */
        setup_logging( "smbclient", True );
        DEBUGLEVEL_CLASS[DBGC_ALL] = 1;
-       dbf = x_stderr;
-       x_setbuf( x_stderr, NULL );
+       if ((dbf = x_fdup(x_stderr))) {
+               x_setbuf( dbf, NULL );
+       }
 
        pc = poptGetContext("smbclient", argc, (const char **) argv, long_options, 
                                POPT_CONTEXT_KEEP_FIRST);
@@ -3353,6 +3464,9 @@ static int do_message_op(void)
                        }
                        break;
                case 'E':
+                       if (dbf) {
+                               x_fclose(dbf);
+                       }
                        dbf = x_stderr;
                        display_set_stderr();
                        break;
@@ -3399,8 +3513,11 @@ static int do_message_op(void)
 
        poptGetArg(pc);
 
-       if ( have_ip )
-       
+       /* check for the -P option */
+
+       if ( port != 0 )
+               cli_cm_set_port( port );
+
        /*
         * Don't load debug level from smb.conf. It should be
         * set by cmdline arg or remain default (0)
@@ -3419,7 +3536,7 @@ static int do_message_op(void)
        if ( override_logfile )
                setup_logging( lp_logfile(), False );
        
-       if (!lp_load(dyn_CONFIGFILE,True,False,False)) {
+       if (!lp_load(dyn_CONFIGFILE,True,False,False,True)) {
                fprintf(stderr, "%s: Can't load %s - run testparm to debug it\n",
                        argv[0], dyn_CONFIGFILE);
        }
@@ -3431,6 +3548,8 @@ static int do_message_op(void)
 
        if ( strlen(calling_name) != 0 )
                set_global_myname( calling_name );
+       else
+               pstrcpy( calling_name, global_myname() );
 
        if(poptPeekArg(pc)) {
                pstrcpy(service,poptGetArg(pc));