can: j1939: j1939_can_recv(): ignore messages with invalid source address

[sfrench/cifs-2.6.git] / net / can / j1939 / main.c

diff --git a/net/can/j1939/main.c b/net/can/j1939/main.c
index 9bc55ecb37f9fafa751e46d4a6914b9f05d0f805..8452b0fbb78c9a4b327fbb0f998d2df0eab12495 100644 (file)
--- a/net/can/j1939/main.c
+++ b/net/can/j1939/main.c
@@ -75,6 +75,13 @@ static void j1939_can_recv(struct sk_buff *iskb, void *data)
        skcb->addr.pgn = (cf->can_id >> 8) & J1939_PGN_MAX;
        /* set default message type */
        skcb->addr.type = J1939_TP;
+
+       if (!j1939_address_is_valid(skcb->addr.sa)) {
+               netdev_err_once(priv->ndev, "%s: sa is broadcast address, ignoring!\n",
+                               __func__);
+               goto done;
+       }
+
        if (j1939_pgn_is_pdu1(skcb->addr.pgn)) {
                /* Type 1: with destination address */
                skcb->addr.da = skcb->addr.pgn;