Have tap listeners specify whether the "packet" routine requires
[obnox/wireshark/wip.git] / gtk / voip_calls_dlg.c
index 20752fe29201ae3023d424857f78e5e32c52d87e..75ed4c5fdcf199ba834d36005d27bfd49e058a29 100644 (file)
@@ -1,5 +1,5 @@
 /* voip_calls_dlg.c
- * VoIP calls summary addition for ethereal
+ * VoIP calls summary addition for Wireshark
  *
  * $Id$
  *
@@ -14,8 +14,8 @@
  * By Alejandro Vaquero, alejandro.vaquero@verso.com
  * Copyright 2005, Verso Technologies Inc.
  *
- * Ethereal - Network traffic analyzer
- * By Gerald Combs <gerald@ethereal.com>
+ * Wireshark - Network traffic analyzer
+ * By Gerald Combs <gerald@wireshark.org>
  * Copyright 1998 Gerald Combs
  *
  * This program is free software; you can redistribute it and/or
 #ifdef HAVE_CONFIG_H
 #  include <config.h>
 #endif
+#include <string.h>
+#include <ctype.h>
 
-#include "register.h"
+#include "gtk/gtk.h"
 
-#include "graph_analysis.h"
-#include "voip_calls_dlg.h"
-#include "voip_calls.h"
-
-#include "globals.h"
+#include <epan/epan.h>
+#include <epan/packet.h>
 #include "epan/filesystem.h"
-
-#include "tap_menu.h"
-#include "dlg_utils.h"
-#include "ui_util.h"
-#include "compat_macros.h"
-#include "gtkglobals.h"
+#include <epan/tap.h>
+#include <epan/stat_cmd_args.h>
+#include <epan/to_str.h>
+#include <epan/address.h>
+#include <epan/addr_resolv.h>
+#include <epan/dissectors/packet-h248.h>
+
+#include "../register.h"
+#include "../globals.h"
+#include "../stat_menu.h"
+
+#include "gtk/graph_analysis.h"
+#include "gtk/voip_calls_dlg.h"
+#include "gtk/voip_calls.h"
+#include "gtk/gui_stat_menu.h"
+#include "gtk/dlg_utils.h"
+#include "gtk/gui_utils.h"
+#include "gtk/gtkglobals.h"
 
 #include "image/clist_ascend.xpm"
 #include "image/clist_descend.xpm"
 #include "simple_dialog.h"
 
-#include <epan/to_str.h>
+#ifdef HAVE_LIBPORTAUDIO
+#include "gtk/rtp_analysis.h"
+#include "gtk/rtp_player.h"
+#endif /* HAVE_LIBPORTAUDIO */
 
-static const gchar FWD_LABEL_TEXT[] = "Select one call.";
 
 /****************************************************************************/
 /* pointer to the one and only dialog window */
@@ -67,12 +80,13 @@ static GtkWidget *voip_calls_dlg = NULL;
 static GtkWidget *clist = NULL;
 static GtkWidget *top_label = NULL;
 static GtkWidget *status_label = NULL;
-static GtkWidget *label_fwd = NULL;
 
 /*static GtkWidet *bt_unselect = NULL;*/
 static GtkWidget *bt_filter = NULL;
 static GtkWidget *bt_graph = NULL;
-
+#ifdef HAVE_LIBPORTAUDIO
+static GtkWidget *bt_player = NULL;
+#endif /* HAVE_LIBPORTAUDIO */
 
 static voip_calls_info_t* selected_call_fwd = NULL;  /* current selection */
 static GList *last_list = NULL;
@@ -80,9 +94,21 @@ static GList *last_list = NULL;
 static guint32 calls_nb = 0;     /* number of displayed calls */
 static guint32 calls_ns = 0;     /* number of selected calls */
 
-static graph_analysis_data_t *graph_analysis_data;
+static graph_analysis_data_t *graph_analysis_data = NULL;
 
 #define NUM_COLS 9
+#define CALL_COL_START_TIME            0
+#define CALL_COL_STOP_TIME             1
+#define CALL_COL_INITIAL_SPEAKER       2
+#define CALL_COL_FROM                  3
+#define CALL_COL_TO                    4
+#define CALL_COL_PROTOCOL              5
+#define CALL_COL_PACKETS               6
+#define CALL_COL_STATE                 7
+#define CALL_COL_COMMENTS              8
+static const GdkColor COLOR_SELECT = {0, 0x00ff, 0x80ff, 0x80ff};
+static const GdkColor COLOR_DEFAULT = {0, 0xffff, 0xffff, 0xffff};
+static const GdkColor COLOR_FOREGROUND = {0, 0x0000, 0x0000, 0x0000};
 
 /****************************************************************************/
 /* append a line to clist */
@@ -96,27 +122,30 @@ static void add_to_clist(voip_calls_info_t* strinfo)
        isup_calls_info_t *tmp_isupinfo;
        h323_calls_info_t *tmp_h323info;
        gboolean tmp_bool = FALSE;
+       GdkColor bg_color = COLOR_SELECT;
+       GdkColor fg_color = COLOR_FOREGROUND;
        for (c=0;c<NUM_COLS;c++){
                data[c]=&field[c][0];
        }
 
+/*     strinfo->selected = FALSE;*/
 
-       g_snprintf(field[0], 15, "%i.%2i", strinfo->start_sec, strinfo->start_usec/10000);
-       g_snprintf(field[1], 15, "%i.%2i", strinfo->stop_sec, strinfo->stop_usec/10000);
-/*     xxx display_signed_time(data[0], sizeof(field[0]), strinfo->start_sec, strinfo->start_usec, USECS); */
-/*     display_signed_time(data[1], sizeof(field[0]), strinfo->stop_sec, strinfo->stop_usec, USECS); */
-       g_snprintf(field[2], 30, "%s", ip_to_str((const guint8*)&(strinfo->initial_speaker)));
-       g_snprintf(field[3], 50, "%s", strinfo->from_identity);
-       g_snprintf(field[4], 50, "%s", strinfo->to_identity);
-       g_snprintf(field[5], 15, "%s", voip_protocol_name[strinfo->protocol]);
-       g_snprintf(field[6], 15, "%u", strinfo->npackets);
-       g_snprintf(field[7], 15, "%s", voip_call_state_name[strinfo->call_state]);
+       g_snprintf(field[CALL_COL_START_TIME], 15, "%i.%03i", strinfo->start_sec, strinfo->start_usec/1000);
+       g_snprintf(field[CALL_COL_STOP_TIME], 15, "%i.%03i", strinfo->stop_sec, strinfo->stop_usec/1000);
+/*     xxx display_signed_time(data[0], sizeof(field[CALL_COL_START_TIME]), strinfo->start_sec, strinfo->start_usec, USECS); */
+/*     display_signed_time(data[1], sizeof(field[CALL_COL_STOP_TIME]), strinfo->stop_sec, strinfo->stop_usec, USECS); */
+       g_snprintf(field[CALL_COL_INITIAL_SPEAKER], 30, "%s", get_addr_name(&(strinfo->initial_speaker)));
+       g_snprintf(field[CALL_COL_FROM], 50, "%s", strinfo->from_identity);
+       g_snprintf(field[CALL_COL_TO], 50, "%s", strinfo->to_identity);
+       g_snprintf(field[CALL_COL_PROTOCOL], 15, "%s", ((strinfo->protocol==VOIP_COMMON)&&strinfo->protocol_name)?strinfo->protocol_name:voip_protocol_name[strinfo->protocol]);
+       g_snprintf(field[CALL_COL_PACKETS], 15, "%u", strinfo->npackets);
+       g_snprintf(field[CALL_COL_STATE], 15, "%s", voip_call_state_name[strinfo->call_state]);
 
        /* Add comments based on the protocol */
        switch(strinfo->protocol){
                case VOIP_ISUP:
                        tmp_isupinfo = strinfo->prot_info;
-                       g_snprintf(field[8],30, "%i-%i -> %i-%i", tmp_isupinfo->ni, tmp_isupinfo->opc,
+                       g_snprintf(field[CALL_COL_COMMENTS],30, "%i-%i -> %i-%i", tmp_isupinfo->ni, tmp_isupinfo->opc,
                                tmp_isupinfo->ni, tmp_isupinfo->dpc);
                        break;
                case VOIP_H323:
@@ -125,16 +154,28 @@ static void add_to_clist(voip_calls_info_t* strinfo)
                                tmp_bool = tmp_h323info->is_faststart_Setup;
                        else
                                if ((tmp_h323info->is_faststart_Setup == TRUE) && (tmp_h323info->is_faststart_Proc == TRUE)) tmp_bool = TRUE; 
-                       g_snprintf(field[8],35, "Tunneling: %s  Fast Start: %s", (tmp_h323info->is_h245Tunneling==TRUE?"ON":"OFF"), 
+                       g_snprintf(field[CALL_COL_COMMENTS],35, "Tunneling: %s  Fast Start: %s", (tmp_h323info->is_h245Tunneling==TRUE?"ON":"OFF"), 
                                (tmp_bool==TRUE?"ON":"OFF"));
                        break;
+               case VOIP_COMMON:
+                       field[CALL_COL_COMMENTS][0]='\0';
+                       if (strinfo->call_comment)
+                               g_snprintf(field[CALL_COL_COMMENTS],30, "%s", strinfo->call_comment);
+                       break;
                default:
-                       field[8][0]='\0';
+                       field[CALL_COL_COMMENTS][0]='\0';
        }
 
        
        added_row = gtk_clist_append(GTK_CLIST(clist), data);
 
+       /* set the background color if selected */
+       if (strinfo->selected) { 
+               calls_ns++;
+               gtk_clist_set_background(GTK_CLIST(clist), added_row, &bg_color);
+               gtk_clist_set_foreground(GTK_CLIST(clist), added_row, &fg_color);
+       }
+
        /* set data pointer of last row to point to user data for that row */
        gtk_clist_set_row_data(GTK_CLIST(clist), added_row, strinfo);
 
@@ -146,20 +187,20 @@ static void add_to_clist(voip_calls_info_t* strinfo)
                plurality(calls_nb, "Call", "Calls"),
                calls_ns,
                plurality(calls_ns, "Call", "Calls"));
-       gtk_label_set(GTK_LABEL(top_label), label_text);
+        gtk_label_set_text(GTK_LABEL(top_label), label_text);
 
        /* Update the status label with the number of total messages */
         g_snprintf(label_text, 256,
                        "Total: Calls: %d   Start packets: %d   Completed calls: %d   Rejected calls: %d",
-                       g_list_length(voip_calls_get_info()->strinfo_list),
+                       g_list_length(voip_calls_get_info()->callsinfo_list),
                        voip_calls_get_info()->start_packets, 
                        voip_calls_get_info()->completed_calls,
                        voip_calls_get_info()->rejected_calls);
-        gtk_label_set(GTK_LABEL(status_label), label_text);
+         gtk_label_set_text(GTK_LABEL(status_label), label_text);
 }
 
 
-void voip_calls_remove_tap_listener()
+static void voip_calls_remove_tap_listener(void)
 {
        /* Remove the calls tap listener */
        remove_tap_listener_sip_calls();
@@ -168,8 +209,22 @@ void voip_calls_remove_tap_listener()
        remove_tap_listener_h225_calls();
        remove_tap_listener_h245dg_calls();
        remove_tap_listener_q931_calls();
+       remove_tap_listener_h248_calls();
+       remove_tap_listener_sccp_calls();
        remove_tap_listener_sdp_calls();
        remove_tap_listener_rtp();
+       if (find_tap_id("unistim")) {
+               remove_tap_listener_unistim_calls();
+       }
+       if (find_tap_id("voip")) {
+               remove_tap_listener_voip_calls();
+       }
+       remove_tap_listener_rtp_event();
+       remove_tap_listener_mgcp_calls();
+       remove_tap_listener_actrace_calls();
+       remove_tap_listener_t38();
+       remove_tap_listener_skinny_calls();
+       remove_tap_listener_iax2_calls();
 }
 
 /****************************************************************************/
@@ -183,10 +238,12 @@ voip_calls_on_destroy                      (GtkObject       *object _U_,
        voip_calls_remove_tap_listener();
 
        /* Clean up memory used by calls tap */
-       voip_calls_reset((voip_calls_tapinfo_t*) voip_calls_get_info());
+       voip_calls_dlg_reset(NULL);
 
        /* Note that we no longer have a "VoIP Calls" dialog box. */
        voip_calls_dlg = NULL;
+
+       graph_analysis_data = NULL;
 }
 
 
@@ -197,10 +254,14 @@ voip_calls_on_unselect                  (GtkButton       *button _U_,
 {
        selected_call_fwd = NULL;
        gtk_clist_unselect_all(GTK_CLIST(clist));
-       gtk_label_set_text(GTK_LABEL(label_fwd), FWD_LABEL_TEXT);
-
+/*     gtk_label_set_text(GTK_LABEL(label_fwd), FWD_LABEL_TEXT);
+*/
        /*gtk_widget_set_sensitive(bt_unselect, FALSE);*/
        gtk_widget_set_sensitive(bt_filter, FALSE);
+       gtk_widget_set_sensitive(bt_graph, FALSE);
+#ifdef HAVE_LIBPORTAUDIO
+       gtk_widget_set_sensitive(bt_player, FALSE);
+#endif /* HAVE_LIBPORTAUDIO */
 }
 
 
@@ -212,17 +273,23 @@ voip_calls_on_filter                    (GtkButton       *button _U_,
        const gchar *filter_string;
        gchar c;
        GString *filter_string_fwd;
-       gchar *filter_prepend;
+       const gchar *filter_prepend;
+       gboolean isFirst = TRUE;
+       GList* list;
+       size_t filter_length = 0;
+       size_t max_filter_length = 2048;
        sip_calls_info_t *tmp_sipinfo;
        isup_calls_info_t *tmp_isupinfo;
        h323_calls_info_t *tmp_h323info;
        h245_address_t *h245_add = NULL;
-       GList* list;
+
+       graph_analysis_item_t *gai;
 
        if (selected_call_fwd==NULL)
                return;
 
        filter_string=gtk_entry_get_text(GTK_ENTRY(main_display_filter_widget));
+       filter_length = strlen(filter_string);
        filter_prepend = "";
        while ((c = *filter_string++) != '\0') {
                if (!isspace((guchar)c)) {
@@ -234,56 +301,102 @@ voip_calls_on_filter                    (GtkButton       *button _U_,
        }
                
        filter_string_fwd = g_string_new(filter_prepend);
-       switch(selected_call_fwd->protocol){
-               case VOIP_SIP:
-                       tmp_sipinfo = selected_call_fwd->prot_info;
-                       g_string_sprintfa(filter_string_fwd,
-                          "(sip.Call-ID == \"%s\") ",
-                          tmp_sipinfo->call_identifier 
-                          );
-                       gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), filter_string_fwd->str);
-                       break;
-               case VOIP_ISUP:
-                       tmp_isupinfo = selected_call_fwd->prot_info;
-                       g_string_sprintfa(filter_string_fwd,
-                          "(isup.cic == %i and frame.number >=%i and frame.number<=%i and mtp3.network_indicator == %i and ((mtp3.dpc == %i) and (mtp3.opc == %i)) or((mtp3.dpc == %i) and (mtp3.opc == %i))) ",
-                          tmp_isupinfo->cic,selected_call_fwd->first_frame_num,
-                          selected_call_fwd->last_frame_num, 
-                          tmp_isupinfo->ni, tmp_isupinfo->dpc, tmp_isupinfo->opc, 
-                          tmp_isupinfo->opc, tmp_isupinfo->dpc
-                          );
-                       gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), filter_string_fwd->str);
-                       break;
-               case VOIP_H323:
-                       tmp_h323info = selected_call_fwd->prot_info;
-                       g_string_sprintfa(filter_string_fwd,
-                          "((h225.guid == %x:%x:%x:%x:%x:%x:%x:%x:%x:%x:%x:%x:%x:%x:%x:%x || q931.call_ref == %x:%x || q931.call_ref == %x:%x) ",
-                          (guint8)tmp_h323info->guid[0], (guint8)tmp_h323info->guid[1], (guint8)tmp_h323info->guid[2],
-                          (guint8)tmp_h323info->guid[3], (guint8)tmp_h323info->guid[4], (guint8)tmp_h323info->guid[5], (guint8)tmp_h323info->guid[6],
-                          (guint8)tmp_h323info->guid[7], (guint8)tmp_h323info->guid[8], (guint8)tmp_h323info->guid[9], (guint8)tmp_h323info->guid[10],
-                          (guint8)tmp_h323info->guid[11], (guint8)tmp_h323info->guid[12], (guint8)tmp_h323info->guid[13], (guint8)tmp_h323info->guid[14],
-                          (guint8)tmp_h323info->guid[15], (guint8)(tmp_h323info->q931_crv & 0xff), (guint8)((tmp_h323info->q931_crv & 0xff00)>>8)
-                          , (guint8)(tmp_h323info->q931_crv2 & 0xff), (guint8)((tmp_h323info->q931_crv2 & 0xff00)>>8));
-
-                       list = g_list_first(tmp_h323info->h245_list);
-                       while (list)
-                       {
-                               h245_add=list->data;
-                               g_string_sprintfa(filter_string_fwd,
-                                       " || (ip.addr == %s && tcp.port == %d && h245) ", 
-                                       ip_to_str((guint8 *)&(h245_add->h245_address)), h245_add->h245_port);
+       
+       /* look in the Graph and get all the frame_num for this call */
+       g_string_append_printf(filter_string_fwd, " (");
+       list = g_list_first(voip_calls_get_info()->graph_analysis->list);
+       while (list)
+       {
+               gai = list->data;
+               if (gai->conv_num == selected_call_fwd->call_num){
+                       g_string_append_printf(filter_string_fwd,"%sframe.number == %d", isFirst?"":" or ", gai->frame_num );
+                       isFirst = FALSE;
+               }               
+               list = g_list_next (list);
+       }
+       g_string_append_printf(filter_string_fwd, ") ");
+       filter_length = filter_length + filter_string_fwd->len;
+
+       if (filter_length < max_filter_length){
+               gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), filter_string_fwd->str);
+       } else {
+               g_string_free(filter_string_fwd, TRUE);
+               filter_string_fwd = g_string_new(filter_prepend);
+
+               switch(selected_call_fwd->protocol){
+                       case VOIP_SIP:
+                               tmp_sipinfo = selected_call_fwd->prot_info;
+                               g_string_append_printf(filter_string_fwd,
+                                  "(sip.Call-ID == \"%s\") ",
+                                  tmp_sipinfo->call_identifier 
+                                  );
+                               gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), filter_string_fwd->str);
+                               break;
+                       case VOIP_ISUP:
+                               tmp_isupinfo = selected_call_fwd->prot_info;
+                               g_string_append_printf(filter_string_fwd,
+                                  "(isup.cic == %i and frame.number >=%i and frame.number<=%i and mtp3.network_indicator == %i and ((mtp3.dpc == %i) and (mtp3.opc == %i)) or((mtp3.dpc == %i) and (mtp3.opc == %i))) ",
+                                  tmp_isupinfo->cic,selected_call_fwd->first_frame_num,
+                                  selected_call_fwd->last_frame_num, 
+                                  tmp_isupinfo->ni, tmp_isupinfo->dpc, tmp_isupinfo->opc, 
+                                  tmp_isupinfo->opc, tmp_isupinfo->dpc
+                                  );
+                               gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), filter_string_fwd->str);
+                               break;
+                       case VOIP_H323:
+                               tmp_h323info = selected_call_fwd->prot_info;
+                               g_string_append_printf(filter_string_fwd,
+                                  "((h225.guid == %s || q931.call_ref == %x:%x || q931.call_ref == %x:%x) ",
+                                  guid_to_str(&tmp_h323info->guid[0]),
+                                  (guint8)(tmp_h323info->q931_crv & 0xff),
+                                  (guint8)((tmp_h323info->q931_crv & 0xff00)>>8),
+                                  (guint8)(tmp_h323info->q931_crv2 & 0xff),
+                                  (guint8)((tmp_h323info->q931_crv2 & 0xff00)>>8));
+                               list = g_list_first(tmp_h323info->h245_list);
+                               while (list)
+                               {
+                                       h245_add=list->data;
+                                       g_string_append_printf(filter_string_fwd,
+                                               " || (ip.addr == %s && tcp.port == %d && h245) ", 
+                                               ip_to_str((guint8 *)&(h245_add->h245_address)), h245_add->h245_port);
                                list = g_list_next(list);
+                               }
+                               g_string_append_printf(filter_string_fwd, ") ");
+                               gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), filter_string_fwd->str);
+                               break;
+                       case TEL_H248: {
+                               const gcp_ctx_t* ctx = selected_call_fwd->prot_info;
+                               gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), ep_strdup_printf("h248.ctx == 0x%x", ctx->id ));
+                               break;
                        }
-                       g_string_sprintfa(filter_string_fwd, ") ");
-                       gtk_entry_append_text(GTK_ENTRY(main_display_filter_widget), filter_string_fwd->str);
-                       break;
-
+                       case TEL_SCCP:
+                       case VOIP_MGCP:
+                       case VOIP_AC_ISDN:
+                       case VOIP_AC_CAS:
+                       case MEDIA_T38:
+                       case TEL_BSSMAP:
+                       case TEL_RANAP:
+                       case VOIP_UNISTIM:
+                       case VOIP_SKINNY:
+                       case VOIP_IAX2:
+                       case VOIP_COMMON:
+                               /* XXX - not supported */
+                               break;
+               }
+               
        }
+       
        g_string_free(filter_string_fwd, TRUE);
 }
 
 
-
+/****************************************************************************/
+static void
+voip_calls_on_select_all                    (GtkButton       *button _U_,
+                                        gpointer         user_data _U_)
+{
+       gtk_clist_select_all(GTK_CLIST(clist));
+}
 
 /****************************************************************************/
 static void
@@ -305,7 +418,7 @@ on_graph_bt_clicked                    (GtkButton       *button _U_,
 
 
        /* set the display for selected calls */
-       list = g_list_first(voip_calls_get_info()->strinfo_list);
+       list = g_list_first(voip_calls_get_info()->callsinfo_list);
        while (list){
                tmp_listinfo=list->data;
                if (tmp_listinfo->selected){
@@ -328,8 +441,15 @@ on_graph_bt_clicked                    (GtkButton       *button _U_,
                graph_analysis_update(graph_analysis_data);             /* refresh it */
 }
 
-static const GdkColor COLOR_SELECT = {0, 0x00ff, 0x80ff, 0x80ff};
-static const GdkColor COLOR_DEFAULT = {0, 0xffff, 0xffff, 0xffff};
+#ifdef HAVE_LIBPORTAUDIO
+/****************************************************************************/
+static void
+on_player_bt_clicked                    (GtkButton       *button _U_,
+                                        gpointer         user_data _U_)
+{
+       rtp_player_init(voip_calls_get_info());
+}
+#endif /* HAVE_LIBPORTAUDIO */
 
 /****************************************************************************/
 /* when the user selects a row in the calls list */
@@ -340,47 +460,119 @@ voip_calls_on_select_row(GtkCList *clist,
                                             GdkEventButton *event _U_,
                                             gpointer user_data _U_)
 {
-       GdkColor color = COLOR_DEFAULT;
+/*     GdkColor color = COLOR_DEFAULT;*/
        gchar label_text[80];
+       GList* list;
+       voip_calls_info_t *listinfo;
        
        selected_call_fwd = gtk_clist_get_row_data(GTK_CLIST(clist), row);
 
-       if (!selected_call_fwd->selected)
-               calls_ns++;
-       else
-               calls_ns--;
+       if (selected_call_fwd==NULL)
+               return;
 
-       g_snprintf(label_text, 256,
+       selected_call_fwd->selected=TRUE;
+
+        /* count the selected calls */
+       calls_ns = 0;
+        list = g_list_first(voip_calls_get_info()->callsinfo_list);
+        while (list){
+                listinfo=list->data;
+                if (listinfo->selected){
+                       calls_ns++;     
+                }
+                list = g_list_next(list);
+        }
+
+       g_snprintf(label_text, 80,
                "Detected %d VoIP %s. Selected %d %s.",
                calls_nb, 
             plurality(calls_nb, "Call", "Calls"),
                        calls_ns,
                        plurality(calls_ns, "Call", "Calls"));
-       gtk_label_set(GTK_LABEL(top_label), label_text);
-
-       g_snprintf(label_text, 80, "Selected Call: From  %s  To %s, starting time %i.%i",
-               selected_call_fwd->from_identity,
-               selected_call_fwd->to_identity,
-               selected_call_fwd->start_sec, 
-               selected_call_fwd->start_usec
-       );
-       gtk_label_set_text(GTK_LABEL(label_fwd), label_text);
-
-       selected_call_fwd->selected=!selected_call_fwd->selected;
-       if (selected_call_fwd->selected)
-               color = COLOR_SELECT;
-       else
-               color = COLOR_DEFAULT;
+        gtk_label_set_text(GTK_LABEL(top_label), label_text);
+
 
-       gtk_clist_set_background(GTK_CLIST(clist), row, &color);
+       if      (calls_ns > 0) {
+               gtk_widget_set_sensitive(bt_filter, TRUE);
+               gtk_widget_set_sensitive(bt_graph, TRUE);
+#ifdef HAVE_LIBPORTAUDIO
+               gtk_widget_set_sensitive(bt_player, TRUE);
+#endif /* HAVE_LIBPORTAUDIO */
+       } else {
+               gtk_widget_set_sensitive(bt_filter, FALSE);
+               gtk_widget_set_sensitive(bt_graph, FALSE);
+#ifdef HAVE_LIBPORTAUDIO
+               gtk_widget_set_sensitive(bt_player, FALSE);
+#endif /* HAVE_LIBPORTAUDIO */
+       }
+
+       /* TODO: activate other buttons when implemented */
+}
+
+
+/****************************************************************************/
+/* when the user selects a row in the calls list */
+static void
+voip_calls_on_unselect_row(GtkCList *clist,
+                                            gint row _U_,
+                                            gint column _U_,
+                                            GdkEventButton *event _U_,
+                                            gpointer user_data _U_)
+{
+       gchar label_text[80];
+       GList* list;
+       voip_calls_info_t *listinfo;
        
-       /*gtk_widget_set_sensitive(bt_unselect, TRUE);*/
-       gtk_widget_set_sensitive(bt_filter, TRUE);
+       selected_call_fwd = gtk_clist_get_row_data(GTK_CLIST(clist), row);
+
+       if (selected_call_fwd==NULL)
+               return;
+
+       selected_call_fwd->selected=FALSE;
+
+        /* count the selected calls */
+       calls_ns = 0;
+        list = g_list_first(voip_calls_get_info()->callsinfo_list);
+        while (list){
+                listinfo=list->data;
+                if (listinfo->selected){
+                       calls_ns++;     
+                }
+                list = g_list_next(list);
+        }
+
+       g_snprintf(label_text, 80,
+               "Detected %d VoIP %s. Selected %d %s.",
+               calls_nb, 
+            plurality(calls_nb, "Call", "Calls"),
+                       calls_ns,
+                       plurality(calls_ns, "Call", "Calls"));
+        gtk_label_set_text(GTK_LABEL(top_label), label_text);
+
+       if      (calls_ns > 0) {
+               gtk_widget_set_sensitive(bt_filter, TRUE);
+               gtk_widget_set_sensitive(bt_graph, TRUE);
+#ifdef HAVE_LIBPORTAUDIO
+               gtk_widget_set_sensitive(bt_player, TRUE);
+#endif /* HAVE_LIBPORTAUDIO */
+       } else {
+               gtk_widget_set_sensitive(bt_filter, FALSE);
+               gtk_widget_set_sensitive(bt_graph, FALSE);
+#ifdef HAVE_LIBPORTAUDIO
+               gtk_widget_set_sensitive(bt_player, FALSE);
+#endif /* HAVE_LIBPORTAUDIO */
+       }
 
        /* TODO: activate other buttons when implemented */
 }
 
 
+
+
+
+
+
+
 /****************************************************************************/
 
 typedef struct column_arrows {
@@ -429,7 +621,7 @@ voip_calls_sort_column(GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2)
 {
        char *text1 = NULL;
        char *text2 = NULL;
-       int i1, i2;
+       guint i1, i2, i3, i4;
 
        const GtkCListRow *row1 = (const GtkCListRow *) ptr1;
        const GtkCListRow *row2 = (const GtkCListRow *) ptr2;
@@ -438,14 +630,25 @@ voip_calls_sort_column(GtkCList *clist, gconstpointer ptr1, gconstpointer ptr2)
        text2 = GTK_CELL_TEXT (row2->cell[clist->sort_column])->text;
 
        switch(clist->sort_column){
-       case 0:
-       case 1:
-       case 2:
-       case 3:
-       case 4:
-       case 5:
+       case CALL_COL_START_TIME:
+       case CALL_COL_STOP_TIME:
+               if ((sscanf(text1, "%u.%u", &i1, &i2) != 2) ||
+                       (sscanf(text2, "%u.%u", &i3, &i4) != 2) ){
+                               return 0;
+                       }
+               if (i1>i3)
+                       return 1;
+               if (i1<i3)
+                       return -1;
+               return (i3-i4);
+       case CALL_COL_INITIAL_SPEAKER:
+       case CALL_COL_FROM:
+       case CALL_COL_TO:
+       case CALL_COL_PROTOCOL:
+       case CALL_COL_STATE:
+       case CALL_COL_COMMENTS:
                return strcmp (text1, text2);
-       case 6:
+       case CALL_COL_PACKETS:
                i1=atoi(text1);
                i2=atoi(text2);
                return i1-i2;
@@ -466,14 +669,19 @@ static void voip_calls_dlg_create (void)
        GtkWidget *scrolledwindow;
        GtkWidget *hbuttonbox;
        GtkWidget *bt_close;
+       GtkWidget *bt_select_all;
        GtkTooltips *tooltips = gtk_tooltips_new();
+       const gchar *title_name_ptr;
+       gchar   *win_name;
 
-       gchar *titles[NUM_COLS] =  {"Start Time", "Stop Time", "Initial Speaker", "From",  "To", "Protocol", "Packets", "State", "Comments"};
+       const gchar *titles[NUM_COLS] =  {"Start Time", "Stop Time", "Initial Speaker", "From",  "To", "Protocol", "Packets", "State", "Comments"};
        column_arrows *col_arrows;
        GtkWidget *column_lb;
        int i;
 
-       voip_calls_dlg_w=window_new(GTK_WINDOW_TOPLEVEL, "Ethereal: VoIP Calls");
+       title_name_ptr = cf_get_display_name(&cfile);
+       win_name = g_strdup_printf("%s - VoIP Calls", title_name_ptr);
+       voip_calls_dlg_w=window_new(GTK_WINDOW_TOPLEVEL, win_name);
 
        gtk_window_set_default_size(GTK_WINDOW(voip_calls_dlg_w), 840, 350);
 
@@ -488,27 +696,29 @@ static void voip_calls_dlg_create (void)
        gtk_box_pack_start (GTK_BOX (main_vb), scrolledwindow, TRUE, TRUE, 0);
 
        clist = gtk_clist_new (NUM_COLS);
+       gtk_clist_set_selection_mode(GTK_CLIST (clist), GTK_SELECTION_MULTIPLE);
+
        gtk_container_add (GTK_CONTAINER (scrolledwindow), clist);
 
-       gtk_clist_set_column_width (GTK_CLIST (clist), 0, 60);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 1, 60);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 2, 80);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 3, 130);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 4, 130);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 5, 50);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 6, 45);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 7, 60);
-       gtk_clist_set_column_width (GTK_CLIST (clist), 8, 100);
-
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 0, GTK_JUSTIFY_LEFT);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 1, GTK_JUSTIFY_LEFT);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 2, GTK_JUSTIFY_LEFT);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 3, GTK_JUSTIFY_LEFT);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 4, GTK_JUSTIFY_LEFT);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 5, GTK_JUSTIFY_CENTER);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 6, GTK_JUSTIFY_CENTER);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 7, GTK_JUSTIFY_LEFT);
-       gtk_clist_set_column_justification(GTK_CLIST(clist), 8, GTK_JUSTIFY_LEFT);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_START_TIME, 60);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_STOP_TIME, 60);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_INITIAL_SPEAKER, 80);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_FROM, 130);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_TO, 130);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_PROTOCOL, 50);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_PACKETS, 45);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_STATE, 60);
+       gtk_clist_set_column_width (GTK_CLIST (clist), CALL_COL_COMMENTS, 100);
+
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_START_TIME, GTK_JUSTIFY_LEFT);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_STOP_TIME, GTK_JUSTIFY_LEFT);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_INITIAL_SPEAKER, GTK_JUSTIFY_LEFT);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_FROM, GTK_JUSTIFY_LEFT);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_TO, GTK_JUSTIFY_LEFT);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_PROTOCOL, GTK_JUSTIFY_CENTER);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_PACKETS, GTK_JUSTIFY_CENTER);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_STATE, GTK_JUSTIFY_LEFT);
+       gtk_clist_set_column_justification(GTK_CLIST(clist), CALL_COL_COMMENTS, GTK_JUSTIFY_LEFT);
 
        gtk_clist_column_titles_show (GTK_CLIST (clist));
 
@@ -540,11 +750,11 @@ static void voip_calls_dlg_create (void)
                gtk_widget_show(col_arrows[i].table);
        }
 
-       SIGNAL_CONNECT(clist, "click-column", voip_calls_click_column_cb, col_arrows);
+       g_signal_connect(clist, "click-column", G_CALLBACK(voip_calls_click_column_cb), col_arrows);
 
-       label_fwd = gtk_label_new (FWD_LABEL_TEXT);
+/*     label_fwd = gtk_label_new (FWD_LABEL_TEXT);
        gtk_box_pack_start (GTK_BOX (main_vb), label_fwd, FALSE, FALSE, 0);
-
+*/
        status_label = gtk_label_new ("Total: Calls: 0   Start packets: 0   Completed calls: 0   Rejected calls: 0");
        gtk_box_pack_start (GTK_BOX (main_vb), status_label, FALSE, FALSE, 8);
 
@@ -552,34 +762,50 @@ static void voip_calls_dlg_create (void)
        hbuttonbox = gtk_hbutton_box_new ();
        gtk_box_pack_start (GTK_BOX (main_vb), hbuttonbox, FALSE, FALSE, 0);
        gtk_button_box_set_layout (GTK_BUTTON_BOX (hbuttonbox), GTK_BUTTONBOX_SPREAD);
-       gtk_button_box_set_spacing (GTK_BUTTON_BOX (hbuttonbox), 30);
+       gtk_box_set_spacing (GTK_BOX (hbuttonbox), 30);
 
        /*bt_unselect = gtk_button_new_with_label ("Unselect");
        gtk_container_add (GTK_CONTAINER (hbuttonbox), bt_unselect);
        gtk_tooltips_set_tip (tooltips, bt_unselect, "Unselect this conversation", NULL);*/
 
-       bt_filter = gtk_button_new_with_label ("Prepare filter");
+       bt_filter = gtk_button_new_with_label ("Prepare Filter");
        gtk_container_add (GTK_CONTAINER (hbuttonbox), bt_filter);
        gtk_tooltips_set_tip (tooltips, bt_filter, "Prepare a display filter of the selected conversation", NULL);
 
        bt_graph = gtk_button_new_with_label("Graph");
        gtk_container_add(GTK_CONTAINER(hbuttonbox), bt_graph);
        gtk_widget_show(bt_graph);
-       SIGNAL_CONNECT(bt_graph, "clicked", on_graph_bt_clicked, NULL);
-
-       bt_close = BUTTON_NEW_FROM_STOCK(GTK_STOCK_CLOSE);
+       g_signal_connect(bt_graph, "clicked", G_CALLBACK(on_graph_bt_clicked), NULL);
+       gtk_tooltips_set_tip (tooltips, bt_graph, "Show a flow graph of the selected calls.", NULL);
+
+#ifdef HAVE_LIBPORTAUDIO
+       bt_player = gtk_button_new_with_label("Player");
+       gtk_container_add(GTK_CONTAINER(hbuttonbox), bt_player);
+       gtk_widget_show(bt_player);
+       g_signal_connect(bt_player, "clicked", G_CALLBACK(on_player_bt_clicked), NULL);
+       gtk_tooltips_set_tip (tooltips, bt_player, "Launch the RTP player to listen the selected calls.", NULL);
+#endif /* HAVE_LIBPORTAUDIO */
+
+       bt_select_all = gtk_button_new_with_label("Select All");
+       gtk_container_add (GTK_CONTAINER (hbuttonbox), bt_select_all);
+       GTK_WIDGET_SET_FLAGS(bt_select_all, GTK_CAN_DEFAULT);
+       gtk_tooltips_set_tip (tooltips, bt_select_all, "Select all the calls", NULL);
+
+       bt_close = gtk_button_new_from_stock(GTK_STOCK_CLOSE);
        gtk_container_add (GTK_CONTAINER (hbuttonbox), bt_close);
        GTK_WIDGET_SET_FLAGS(bt_close, GTK_CAN_DEFAULT);
        gtk_tooltips_set_tip (tooltips, bt_close, "Close this dialog", NULL);
 
-       SIGNAL_CONNECT(clist, "select_row", voip_calls_on_select_row, NULL);
-       /*SIGNAL_CONNECT(bt_unselect, "clicked", voip_calls_on_unselect, NULL);*/
-       SIGNAL_CONNECT(bt_filter, "clicked", voip_calls_on_filter, NULL);
+       g_signal_connect(clist, "select_row", G_CALLBACK(voip_calls_on_select_row), NULL);
+       g_signal_connect(clist, "unselect_row", G_CALLBACK(voip_calls_on_unselect_row), NULL);
+       /*g_signal_connect(bt_unselect, "clicked", G_CALLBACK(voip_calls_on_unselect), NULL);*/
+       g_signal_connect(bt_filter, "clicked", G_CALLBACK(voip_calls_on_filter), NULL);
 
        window_set_cancel_button(voip_calls_dlg_w, bt_close, window_cancel_button_cb);
 
-       SIGNAL_CONNECT(voip_calls_dlg_w, "delete_event", window_delete_event_cb, NULL);
-       SIGNAL_CONNECT(voip_calls_dlg_w, "destroy", voip_calls_on_destroy, NULL);
+       g_signal_connect(voip_calls_dlg_w, "delete_event", G_CALLBACK(window_delete_event_cb), NULL);
+       g_signal_connect(voip_calls_dlg_w, "destroy", G_CALLBACK(voip_calls_on_destroy), NULL);
+       g_signal_connect(bt_select_all, "clicked", G_CALLBACK(voip_calls_on_select_all), NULL);
 
        gtk_widget_show_all(voip_calls_dlg_w);
        window_present(voip_calls_dlg_w);
@@ -587,6 +813,8 @@ static void voip_calls_dlg_create (void)
        voip_calls_on_unselect(NULL, NULL);
 
        voip_calls_dlg = voip_calls_dlg_w;
+
+       g_free(win_name); 
 }
 
 
@@ -601,26 +829,27 @@ static void voip_calls_dlg_create (void)
 void voip_calls_dlg_update(GList *list)
 {
        gchar label_text[256];
-guint foo;
        if (voip_calls_dlg != NULL) {
-               gtk_clist_clear(GTK_CLIST(clist));
                calls_nb = 0;
                calls_ns = 0;
-               g_snprintf(label_text, 256,
-                       "Total: Calls: %d   Start packets: %d   Completed calls: %d   Rejected calls: %d",
-                       g_list_length(voip_calls_get_info()->strinfo_list),
-                       voip_calls_get_info()->start_packets, 
+
+               g_snprintf(label_text, 256,
+                       "Total: Calls: %d   Start packets: %d   Completed calls: %d   Rejected calls: %d",
+                       g_list_length(voip_calls_get_info()->callsinfo_list),
+                       voip_calls_get_info()->start_packets, 
                        voip_calls_get_info()->completed_calls,
                        voip_calls_get_info()->rejected_calls);
-               gtk_label_set(GTK_LABEL(status_label), label_text);
+                gtk_label_set_text(GTK_LABEL(status_label), label_text);
 
-               foo=    g_list_length(list);
+               gtk_clist_freeze(GTK_CLIST(clist));
+               gtk_clist_clear(GTK_CLIST(clist));
                list = g_list_first(list);
                while (list)
                {
                        add_to_clist((voip_calls_info_t*)(list->data));
                        list = g_list_next(list);
                }
+               gtk_clist_thaw(GTK_CLIST(clist));
 
                g_snprintf(label_text, 256,
                        "Detected %d VoIP %s. Selected %d %s.",
@@ -628,9 +857,7 @@ guint foo;
                        plurality(calls_nb, "Call", "Calls"),
                        calls_ns,
                        plurality(calls_ns, "Call", "Calls"));
-               gtk_label_set(GTK_LABEL(top_label), label_text);
-
-               voip_calls_on_unselect(NULL, NULL);
+                gtk_label_set_text(GTK_LABEL(top_label), label_text);
        }
 
        last_list = list;
@@ -641,7 +868,10 @@ guint foo;
 /* draw function for tap listeners to keep the window up to date */
 void voip_calls_dlg_draw(void *ptr _U_)
 {
-       voip_calls_dlg_update(voip_calls_get_info()->strinfo_list);
+       if (voip_calls_get_info()->redraw) {
+               voip_calls_dlg_update(voip_calls_get_info()->callsinfo_list);
+               voip_calls_get_info()->redraw = FALSE;
+       }
 }
 
 /* reset function for tap listeners to clear window, if necessary */
@@ -649,13 +879,29 @@ void voip_calls_dlg_reset(void *ptr _U_)
 {
        /* Clean up memory used by calls tap */
        voip_calls_reset((voip_calls_tapinfo_t*) voip_calls_get_info());
+
+       /* close the graph window if open */
+       if (graph_analysis_data && graph_analysis_data->dlg.window != NULL) {
+               window_cancel_button_cb(NULL, graph_analysis_data->dlg.window);
+               graph_analysis_data->dlg.window = NULL;
+       }
 }
 
 /* init function for tap */
-static void
-voip_calls_init_tap(char *dummy _U_)
+/* Made extern only for "Fax T38 Analysis..." */
+void
+voip_calls_init_tap(const char *dummy _U_, void* userdata _U_)
 {
-       graph_analysis_data_init();
+       gint c;
+       gchar *data[NUM_COLS];
+       gchar field[NUM_COLS][50];
+
+       if (graph_analysis_data == NULL) {
+               graph_analysis_data_init();
+               /* init the Graph Analysys */
+               graph_analysis_data = graph_analysis_init();
+               graph_analysis_data->graph_info = voip_calls_get_info()->graph_analysis;
+       }
 
        /* Clean up memory used by calls tap */
        voip_calls_reset((voip_calls_tapinfo_t*) voip_calls_get_info());
@@ -667,12 +913,23 @@ voip_calls_init_tap(char *dummy _U_)
        h225_calls_init_tap();
        h245dg_calls_init_tap();
        q931_calls_init_tap();
+       h248_calls_init_tap();
+       sccp_calls_init_tap();
        sdp_calls_init_tap();
+       /* We don't register this tap, if we don't have the unistim plugin loaded.*/
+       if (find_tap_id("unistim")) {
+               unistim_calls_init_tap();
+       }
+       if (find_tap_id("voip")) {
+               VoIPcalls_init_tap();
+       }
        rtp_init_tap();
-       
-       /* init the Graph Analysys */
-       graph_analysis_data = graph_analysis_init();
-       graph_analysis_data->graph_info = voip_calls_get_info()->graph_analysis;
+       rtp_event_init_tap();
+       mgcp_calls_init_tap();
+       actrace_calls_init_tap();
+       t38_init_tap();
+       skinny_calls_init_tap();
+       iax2_calls_init_tap();
 
        /* create dialog box if necessary */
        if (voip_calls_dlg == NULL) {
@@ -681,27 +938,36 @@ voip_calls_init_tap(char *dummy _U_)
                /* There's already a dialog box; reactivate it. */
                reactivate_window(voip_calls_dlg);
        }
+
+       voip_calls_get_info()->redraw = TRUE;
+       voip_calls_dlg_draw(NULL);
+       voip_calls_get_info()->redraw = TRUE;
+       for (c=0;c<NUM_COLS;c++){
+               data[c]=&field[c][0];
+               field[c][0] = '\0';
+       }
+       g_snprintf(field[3], 50, "Please wait...");
+       gtk_clist_append(GTK_CLIST(clist), data);
        
        /* Scan for VoIP calls calls (redissect all packets) */
        cf_retap_packets(&cfile);
-       
+       gdk_window_raise(voip_calls_dlg->window);
        /* Tap listener will be removed and cleaned up in voip_calls_on_destroy */
 }
 
 
 /****************************************************************************/
 /* entry point when called via the GTK menu */
-void voip_calls_launch(GtkWidget *w _U_, gpointer data _U_)
+static void voip_calls_launch(GtkWidget *w _U_, gpointer data _U_)
 {
-       voip_calls_init_tap("");
+       voip_calls_init_tap("",NULL);
 }
 
 /****************************************************************************/
 void
 register_tap_listener_voip_calls_dlg(void)
 {
-       register_ethereal_tap("voip,calls",voip_calls_init_tap);
-       register_tap_menu_item("VoIP Calls...", REGISTER_TAP_GROUP_NONE,
-           voip_calls_launch, NULL, NULL, NULL);
-           
+       register_stat_cmd_arg("voip,calls",voip_calls_init_tap,NULL);
+       register_stat_menu_item("VoIP Calls", REGISTER_STAT_GROUP_TELEPHONY,
+           voip_calls_launch, NULL, NULL, NULL);    
 }