Merge tag 'input-for-v6.9-rc0' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor...
[sfrench/cifs-2.6.git] / drivers / input / touchscreen / imagis.c
index 07111ca2445561702980070c2afe0655919bd808..074dd6c342ecb9291fc225b3d22c639ae29fb508 100644 (file)
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
+#include <linux/bitfield.h>
 #include <linux/bits.h>
 #include <linux/delay.h>
 #include <linux/i2c.h>
 #include <linux/property.h>
 #include <linux/regulator/consumer.h>
 
+#define IST3032C_WHOAMI                        0x32c
+
+#define IST3038B_REG_STATUS            0x20
+#define IST3038B_REG_CHIPID            0x30
+#define IST3038B_WHOAMI                        0x30380b
+
 #define IST3038C_HIB_ACCESS            (0x800B << 16)
 #define IST3038C_DIRECT_ACCESS         BIT(31)
-#define IST3038C_REG_CHIPID            0x40001000
+#define IST3038C_REG_CHIPID            (0x40001000 | IST3038C_DIRECT_ACCESS)
 #define IST3038C_REG_HIB_BASE          0x30000100
 #define IST3038C_REG_TOUCH_STATUS      (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS)
 #define IST3038C_REG_TOUCH_COORD       (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS | 0x8)
 #define IST3038C_I2C_RETRY_COUNT       3
 #define IST3038C_MAX_FINGER_NUM                10
 #define IST3038C_X_MASK                        GENMASK(23, 12)
-#define IST3038C_X_SHIFT               12
 #define IST3038C_Y_MASK                        GENMASK(11, 0)
 #define IST3038C_AREA_MASK             GENMASK(27, 24)
-#define IST3038C_AREA_SHIFT            24
 #define IST3038C_FINGER_COUNT_MASK     GENMASK(15, 12)
-#define IST3038C_FINGER_COUNT_SHIFT    12
 #define IST3038C_FINGER_STATUS_MASK    GENMASK(9, 0)
+#define IST3032C_KEY_STATUS_MASK       GENMASK(20, 16)
+
+struct imagis_properties {
+       unsigned int interrupt_msg_cmd;
+       unsigned int touch_coord_cmd;
+       unsigned int whoami_cmd;
+       unsigned int whoami_val;
+       bool protocol_b;
+       bool touch_keys_supported;
+};
 
 struct imagis_ts {
        struct i2c_client *client;
+       const struct imagis_properties *tdata;
        struct input_dev *input_dev;
        struct touchscreen_properties prop;
        struct regulator_bulk_data supplies[2];
+       u32 keycodes[5];
+       int num_keycodes;
 };
 
 static int imagis_i2c_read_reg(struct imagis_ts *ts,
@@ -80,20 +97,18 @@ static irqreturn_t imagis_interrupt(int irq, void *dev_id)
 {
        struct imagis_ts *ts = dev_id;
        u32 intr_message, finger_status;
-       unsigned int finger_count, finger_pressed;
+       unsigned int finger_count, finger_pressed, key_pressed;
        int i;
        int error;
 
-       error = imagis_i2c_read_reg(ts, IST3038C_REG_INTR_MESSAGE,
-                                   &intr_message);
+       error = imagis_i2c_read_reg(ts, ts->tdata->interrupt_msg_cmd, &intr_message);
        if (error) {
                dev_err(&ts->client->dev,
                        "failed to read the interrupt message: %d\n", error);
                goto out;
        }
 
-       finger_count = (intr_message & IST3038C_FINGER_COUNT_MASK) >>
-                               IST3038C_FINGER_COUNT_SHIFT;
+       finger_count = FIELD_GET(IST3038C_FINGER_COUNT_MASK, intr_message);
        if (finger_count > IST3038C_MAX_FINGER_NUM) {
                dev_err(&ts->client->dev,
                        "finger count %d is more than maximum supported\n",
@@ -101,12 +116,16 @@ static irqreturn_t imagis_interrupt(int irq, void *dev_id)
                goto out;
        }
 
-       finger_pressed = intr_message & IST3038C_FINGER_STATUS_MASK;
+       finger_pressed = FIELD_GET(IST3038C_FINGER_STATUS_MASK, intr_message);
 
        for (i = 0; i < finger_count; i++) {
-               error = imagis_i2c_read_reg(ts,
-                                           IST3038C_REG_TOUCH_COORD + (i * 4),
-                                           &finger_status);
+               if (ts->tdata->protocol_b)
+                       error = imagis_i2c_read_reg(ts,
+                                                   ts->tdata->touch_coord_cmd, &finger_status);
+               else
+                       error = imagis_i2c_read_reg(ts,
+                                                   ts->tdata->touch_coord_cmd + (i * 4),
+                                                   &finger_status);
                if (error) {
                        dev_err(&ts->client->dev,
                                "failed to read coordinates for finger %d: %d\n",
@@ -118,14 +137,19 @@ static irqreturn_t imagis_interrupt(int irq, void *dev_id)
                input_mt_report_slot_state(ts->input_dev, MT_TOOL_FINGER,
                                           finger_pressed & BIT(i));
                touchscreen_report_pos(ts->input_dev, &ts->prop,
-                                      (finger_status & IST3038C_X_MASK) >>
-                                               IST3038C_X_SHIFT,
-                                      finger_status & IST3038C_Y_MASK, 1);
+                                      FIELD_GET(IST3038C_X_MASK, finger_status),
+                                      FIELD_GET(IST3038C_Y_MASK, finger_status),
+                                      true);
                input_report_abs(ts->input_dev, ABS_MT_TOUCH_MAJOR,
-                                (finger_status & IST3038C_AREA_MASK) >>
-                                       IST3038C_AREA_SHIFT);
+                                FIELD_GET(IST3038C_AREA_MASK, finger_status));
        }
 
+       key_pressed = FIELD_GET(IST3032C_KEY_STATUS_MASK, intr_message);
+
+       for (int i = 0; i < ts->num_keycodes; i++)
+               input_report_key(ts->input_dev, ts->keycodes[i],
+                                key_pressed & BIT(i));
+
        input_mt_sync_frame(ts->input_dev);
        input_sync(ts->input_dev);
 
@@ -210,7 +234,24 @@ static int imagis_init_input_dev(struct imagis_ts *ts)
 
        input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_X);
        input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_Y);
-       input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
+       input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR, 0, 16, 0, 0);
+       if (ts->tdata->touch_keys_supported) {
+               ts->num_keycodes = of_property_read_variable_u32_array(
+                               ts->client->dev.of_node, "linux,keycodes",
+                               ts->keycodes, 0, ARRAY_SIZE(ts->keycodes));
+               if (ts->num_keycodes <= 0) {
+                       ts->keycodes[0] = KEY_APPSELECT;
+                       ts->keycodes[1] = KEY_BACK;
+                       ts->num_keycodes = 2;
+               }
+
+               input_dev->keycodemax = ts->num_keycodes;
+               input_dev->keycodesize = sizeof(ts->keycodes[0]);
+               input_dev->keycode = ts->keycodes;
+       }
+
+       for (int i = 0; i < ts->num_keycodes; i++)
+               input_set_capability(input_dev, EV_KEY, ts->keycodes[i]);
 
        touchscreen_parse_properties(input_dev, true, &ts->prop);
        if (!ts->prop.max_x || !ts->prop.max_y) {
@@ -261,6 +302,12 @@ static int imagis_probe(struct i2c_client *i2c)
 
        ts->client = i2c;
 
+       ts->tdata = device_get_match_data(dev);
+       if (!ts->tdata) {
+               dev_err(dev, "missing chip data\n");
+               return -EINVAL;
+       }
+
        error = imagis_init_regulators(ts);
        if (error) {
                dev_err(dev, "regulator init error: %d\n", error);
@@ -279,15 +326,13 @@ static int imagis_probe(struct i2c_client *i2c)
                return error;
        }
 
-       error = imagis_i2c_read_reg(ts,
-                       IST3038C_REG_CHIPID | IST3038C_DIRECT_ACCESS,
-                       &chip_id);
+       error = imagis_i2c_read_reg(ts, ts->tdata->whoami_cmd, &chip_id);
        if (error) {
                dev_err(dev, "chip ID read failure: %d\n", error);
                return error;
        }
 
-       if (chip_id != IST3038C_WHOAMI) {
+       if (chip_id != ts->tdata->whoami_val) {
                dev_err(dev, "unknown chip ID: 0x%x\n", chip_id);
                return -EINVAL;
        }
@@ -343,9 +388,34 @@ static int imagis_resume(struct device *dev)
 
 static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume);
 
+static const struct imagis_properties imagis_3032c_data = {
+       .interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
+       .touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
+       .whoami_cmd = IST3038C_REG_CHIPID,
+       .whoami_val = IST3032C_WHOAMI,
+       .touch_keys_supported = true,
+};
+
+static const struct imagis_properties imagis_3038b_data = {
+       .interrupt_msg_cmd = IST3038B_REG_STATUS,
+       .touch_coord_cmd = IST3038B_REG_STATUS,
+       .whoami_cmd = IST3038B_REG_CHIPID,
+       .whoami_val = IST3038B_WHOAMI,
+       .protocol_b = true,
+};
+
+static const struct imagis_properties imagis_3038c_data = {
+       .interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
+       .touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
+       .whoami_cmd = IST3038C_REG_CHIPID,
+       .whoami_val = IST3038C_WHOAMI,
+};
+
 #ifdef CONFIG_OF
 static const struct of_device_id imagis_of_match[] = {
-       { .compatible = "imagis,ist3038c", },
+       { .compatible = "imagis,ist3032c", .data = &imagis_3032c_data },
+       { .compatible = "imagis,ist3038b", .data = &imagis_3038b_data },
+       { .compatible = "imagis,ist3038c", .data = &imagis_3038c_data },
        { },
 };
 MODULE_DEVICE_TABLE(of, imagis_of_match);