1 // SPDX-License-Identifier: GPL-2.0
2 #ifndef NO_BCACHEFS_CHARDEV
5 #include "bcachefs_ioctl.h"
10 #include "recovery_passes.h"
14 #include "thread_with_file.h"
16 #include <linux/cdev.h>
17 #include <linux/device.h>
19 #include <linux/ioctl.h>
20 #include <linux/major.h>
21 #include <linux/sched/task.h>
22 #include <linux/slab.h>
23 #include <linux/uaccess.h>
25 /* returns with ref on ca->ref */
26 static struct bch_dev *bch2_device_lookup(struct bch_fs *c, u64 dev,
31 if (flags & BCH_BY_INDEX) {
32 if (dev >= c->sb.nr_devices)
33 return ERR_PTR(-EINVAL);
36 ca = rcu_dereference(c->devs[dev]);
38 percpu_ref_get(&ca->ref);
42 return ERR_PTR(-EINVAL);
46 path = strndup_user((const char __user *)
47 (unsigned long) dev, PATH_MAX);
49 return ERR_CAST(path);
51 ca = bch2_dev_lookup(c, path);
59 static long bch2_ioctl_assemble(struct bch_ioctl_assemble __user *user_arg)
61 struct bch_ioctl_assemble arg;
63 u64 *user_devs = NULL;
68 if (copy_from_user(&arg, user_arg, sizeof(arg)))
71 if (arg.flags || arg.pad)
74 user_devs = kmalloc_array(arg.nr_devs, sizeof(u64), GFP_KERNEL);
78 devs = kcalloc(arg.nr_devs, sizeof(char *), GFP_KERNEL);
80 if (copy_from_user(user_devs, user_arg->devs,
81 sizeof(u64) * arg.nr_devs))
84 for (i = 0; i < arg.nr_devs; i++) {
85 devs[i] = strndup_user((const char __user *)(unsigned long)
88 ret= PTR_ERR_OR_ZERO(devs[i]);
93 c = bch2_fs_open(devs, arg.nr_devs, bch2_opts_empty());
94 ret = PTR_ERR_OR_ZERO(c);
99 for (i = 0; i < arg.nr_devs; i++)
105 static long bch2_ioctl_incremental(struct bch_ioctl_incremental __user *user_arg)
107 struct bch_ioctl_incremental arg;
111 if (copy_from_user(&arg, user_arg, sizeof(arg)))
114 if (arg.flags || arg.pad)
117 path = strndup_user((const char __user *)(unsigned long) arg.dev, PATH_MAX);
118 ret = PTR_ERR_OR_ZERO(path);
122 err = bch2_fs_open_incremental(path);
126 pr_err("Could not register bcachefs devices: %s", err);
135 struct thread_with_stdio thr;
139 struct bch_opts opts;
142 static void bch2_fsck_thread_exit(struct thread_with_stdio *_thr)
144 struct fsck_thread *thr = container_of(_thr, struct fsck_thread, thr);
146 for (size_t i = 0; i < thr->nr_devs; i++)
152 static int bch2_fsck_offline_thread_fn(struct thread_with_stdio *stdio)
154 struct fsck_thread *thr = container_of(stdio, struct fsck_thread, thr);
155 struct bch_fs *c = bch2_fs_open(thr->devs, thr->nr_devs, thr->opts);
161 if (test_bit(BCH_FS_errors_fixed, &c->flags))
163 if (test_bit(BCH_FS_error, &c->flags))
169 bch2_stdio_redirect_printf(&stdio->stdio, false, "%s: errors fixed\n", c->name);
171 bch2_stdio_redirect_printf(&stdio->stdio, false, "%s: still has errors\n", c->name);
176 static const struct thread_with_stdio_ops bch2_offline_fsck_ops = {
177 .exit = bch2_fsck_thread_exit,
178 .fn = bch2_fsck_offline_thread_fn,
181 static long bch2_ioctl_fsck_offline(struct bch_ioctl_fsck_offline __user *user_arg)
183 struct bch_ioctl_fsck_offline arg;
184 struct fsck_thread *thr = NULL;
188 if (copy_from_user(&arg, user_arg, sizeof(arg)))
194 if (!capable(CAP_SYS_ADMIN))
197 if (!(devs = kcalloc(arg.nr_devs, sizeof(*devs), GFP_KERNEL)) ||
198 !(thr = kzalloc(sizeof(*thr), GFP_KERNEL)) ||
199 !(thr->devs = kcalloc(arg.nr_devs, sizeof(*thr->devs), GFP_KERNEL))) {
204 thr->opts = bch2_opts_empty();
205 thr->nr_devs = arg.nr_devs;
207 if (copy_from_user(devs, &user_arg->devs[0],
208 array_size(sizeof(user_arg->devs[0]), arg.nr_devs))) {
213 for (size_t i = 0; i < arg.nr_devs; i++) {
214 thr->devs[i] = strndup_user((char __user *)(unsigned long) devs[i], PATH_MAX);
215 ret = PTR_ERR_OR_ZERO(thr->devs[i]);
221 char *optstr = strndup_user((char __user *)(unsigned long) arg.opts, 1 << 16);
223 ret = PTR_ERR_OR_ZERO(optstr) ?:
224 bch2_parse_mount_opts(NULL, &thr->opts, optstr);
231 opt_set(thr->opts, stdio, (u64)(unsigned long)&thr->thr.stdio);
233 ret = bch2_run_thread_with_stdio(&thr->thr, &bch2_offline_fsck_ops);
237 bch2_fsck_thread_exit(&thr->thr);
238 pr_err("ret %s", bch2_err_str(ret));
244 static long bch2_global_ioctl(unsigned cmd, void __user *arg)
250 case BCH_IOCTL_ASSEMBLE:
251 return bch2_ioctl_assemble(arg);
252 case BCH_IOCTL_INCREMENTAL:
253 return bch2_ioctl_incremental(arg);
255 case BCH_IOCTL_FSCK_OFFLINE: {
256 ret = bch2_ioctl_fsck_offline(arg);
265 ret = bch2_err_class(ret);
269 static long bch2_ioctl_query_uuid(struct bch_fs *c,
270 struct bch_ioctl_query_uuid __user *user_arg)
272 return copy_to_user_errcode(&user_arg->uuid, &c->sb.user_uuid,
273 sizeof(c->sb.user_uuid));
277 static long bch2_ioctl_start(struct bch_fs *c, struct bch_ioctl_start arg)
279 if (!capable(CAP_SYS_ADMIN))
282 if (arg.flags || arg.pad)
285 return bch2_fs_start(c);
288 static long bch2_ioctl_stop(struct bch_fs *c)
290 if (!capable(CAP_SYS_ADMIN))
298 static long bch2_ioctl_disk_add(struct bch_fs *c, struct bch_ioctl_disk arg)
303 if (!capable(CAP_SYS_ADMIN))
306 if (arg.flags || arg.pad)
309 path = strndup_user((const char __user *)(unsigned long) arg.dev, PATH_MAX);
310 ret = PTR_ERR_OR_ZERO(path);
314 ret = bch2_dev_add(c, path);
320 static long bch2_ioctl_disk_remove(struct bch_fs *c, struct bch_ioctl_disk arg)
324 if (!capable(CAP_SYS_ADMIN))
327 if ((arg.flags & ~(BCH_FORCE_IF_DATA_LOST|
328 BCH_FORCE_IF_METADATA_LOST|
329 BCH_FORCE_IF_DEGRADED|
334 ca = bch2_device_lookup(c, arg.dev, arg.flags);
338 return bch2_dev_remove(c, ca, arg.flags);
341 static long bch2_ioctl_disk_online(struct bch_fs *c, struct bch_ioctl_disk arg)
346 if (!capable(CAP_SYS_ADMIN))
349 if (arg.flags || arg.pad)
352 path = strndup_user((const char __user *)(unsigned long) arg.dev, PATH_MAX);
353 ret = PTR_ERR_OR_ZERO(path);
357 ret = bch2_dev_online(c, path);
362 static long bch2_ioctl_disk_offline(struct bch_fs *c, struct bch_ioctl_disk arg)
367 if (!capable(CAP_SYS_ADMIN))
370 if ((arg.flags & ~(BCH_FORCE_IF_DATA_LOST|
371 BCH_FORCE_IF_METADATA_LOST|
372 BCH_FORCE_IF_DEGRADED|
377 ca = bch2_device_lookup(c, arg.dev, arg.flags);
381 ret = bch2_dev_offline(c, ca, arg.flags);
382 percpu_ref_put(&ca->ref);
386 static long bch2_ioctl_disk_set_state(struct bch_fs *c,
387 struct bch_ioctl_disk_set_state arg)
392 if (!capable(CAP_SYS_ADMIN))
395 if ((arg.flags & ~(BCH_FORCE_IF_DATA_LOST|
396 BCH_FORCE_IF_METADATA_LOST|
397 BCH_FORCE_IF_DEGRADED|
399 arg.pad[0] || arg.pad[1] || arg.pad[2] ||
400 arg.new_state >= BCH_MEMBER_STATE_NR)
403 ca = bch2_device_lookup(c, arg.dev, arg.flags);
407 ret = bch2_dev_set_state(c, ca, arg.new_state, arg.flags);
409 bch_err(c, "Error setting device state: %s", bch2_err_str(ret));
411 percpu_ref_put(&ca->ref);
415 struct bch_data_ctx {
416 struct thread_with_file thr;
419 struct bch_ioctl_data arg;
420 struct bch_move_stats stats;
423 static int bch2_data_thread(void *arg)
425 struct bch_data_ctx *ctx = container_of(arg, struct bch_data_ctx, thr);
427 ctx->thr.ret = bch2_data_job(ctx->c, &ctx->stats, ctx->arg);
428 ctx->stats.data_type = U8_MAX;
432 static int bch2_data_job_release(struct inode *inode, struct file *file)
434 struct bch_data_ctx *ctx = container_of(file->private_data, struct bch_data_ctx, thr);
436 bch2_thread_with_file_exit(&ctx->thr);
441 static ssize_t bch2_data_job_read(struct file *file, char __user *buf,
442 size_t len, loff_t *ppos)
444 struct bch_data_ctx *ctx = container_of(file->private_data, struct bch_data_ctx, thr);
445 struct bch_fs *c = ctx->c;
446 struct bch_ioctl_data_event e = {
447 .type = BCH_DATA_EVENT_PROGRESS,
448 .p.data_type = ctx->stats.data_type,
449 .p.btree_id = ctx->stats.pos.btree,
450 .p.pos = ctx->stats.pos.pos,
451 .p.sectors_done = atomic64_read(&ctx->stats.sectors_seen),
452 .p.sectors_total = bch2_fs_usage_read_short(c).used,
458 return copy_to_user_errcode(buf, &e, sizeof(e)) ?: sizeof(e);
461 static const struct file_operations bcachefs_data_ops = {
462 .release = bch2_data_job_release,
463 .read = bch2_data_job_read,
467 static long bch2_ioctl_data(struct bch_fs *c,
468 struct bch_ioctl_data arg)
470 struct bch_data_ctx *ctx;
473 if (!capable(CAP_SYS_ADMIN))
476 if (arg.op >= BCH_DATA_OP_NR || arg.flags)
479 ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
486 ret = bch2_run_thread_with_file(&ctx->thr,
494 static long bch2_ioctl_fs_usage(struct bch_fs *c,
495 struct bch_ioctl_fs_usage __user *user_arg)
497 struct bch_ioctl_fs_usage *arg = NULL;
498 struct bch_replicas_usage *dst_e, *dst_end;
499 struct bch_fs_usage_online *src;
500 u32 replica_entries_bytes;
504 if (!test_bit(BCH_FS_started, &c->flags))
507 if (get_user(replica_entries_bytes, &user_arg->replica_entries_bytes))
510 arg = kzalloc(size_add(sizeof(*arg), replica_entries_bytes), GFP_KERNEL);
514 src = bch2_fs_usage_read(c);
520 arg->capacity = c->capacity;
521 arg->used = bch2_fs_sectors_used(c, src);
522 arg->online_reserved = src->online_reserved;
524 for (i = 0; i < BCH_REPLICAS_MAX; i++)
525 arg->persistent_reserved[i] = src->u.persistent_reserved[i];
527 dst_e = arg->replicas;
528 dst_end = (void *) arg->replicas + replica_entries_bytes;
530 for (i = 0; i < c->replicas.nr; i++) {
531 struct bch_replicas_entry_v1 *src_e =
532 cpu_replicas_entry(&c->replicas, i);
534 /* check that we have enough space for one replicas entry */
535 if (dst_e + 1 > dst_end) {
540 dst_e->sectors = src->u.replicas[i];
543 /* recheck after setting nr_devs: */
544 if (replicas_usage_next(dst_e) > dst_end) {
549 memcpy(dst_e->r.devs, src_e->devs, src_e->nr_devs);
551 dst_e = replicas_usage_next(dst_e);
554 arg->replica_entries_bytes = (void *) dst_e - (void *) arg->replicas;
556 percpu_up_read(&c->mark_lock);
562 ret = copy_to_user_errcode(user_arg, arg,
563 sizeof(*arg) + arg->replica_entries_bytes);
569 /* obsolete, didn't allow for new data types: */
570 static long bch2_ioctl_dev_usage(struct bch_fs *c,
571 struct bch_ioctl_dev_usage __user *user_arg)
573 struct bch_ioctl_dev_usage arg;
574 struct bch_dev_usage src;
578 if (!test_bit(BCH_FS_started, &c->flags))
581 if (copy_from_user(&arg, user_arg, sizeof(arg)))
584 if ((arg.flags & ~BCH_BY_INDEX) ||
590 ca = bch2_device_lookup(c, arg.dev, arg.flags);
594 src = bch2_dev_usage_read(ca);
596 arg.state = ca->mi.state;
597 arg.bucket_size = ca->mi.bucket_size;
598 arg.nr_buckets = ca->mi.nbuckets - ca->mi.first_bucket;
600 for (i = 0; i < BCH_DATA_NR; i++) {
601 arg.d[i].buckets = src.d[i].buckets;
602 arg.d[i].sectors = src.d[i].sectors;
603 arg.d[i].fragmented = src.d[i].fragmented;
606 percpu_ref_put(&ca->ref);
608 return copy_to_user_errcode(user_arg, &arg, sizeof(arg));
611 static long bch2_ioctl_dev_usage_v2(struct bch_fs *c,
612 struct bch_ioctl_dev_usage_v2 __user *user_arg)
614 struct bch_ioctl_dev_usage_v2 arg;
615 struct bch_dev_usage src;
619 if (!test_bit(BCH_FS_started, &c->flags))
622 if (copy_from_user(&arg, user_arg, sizeof(arg)))
625 if ((arg.flags & ~BCH_BY_INDEX) ||
631 ca = bch2_device_lookup(c, arg.dev, arg.flags);
635 src = bch2_dev_usage_read(ca);
637 arg.state = ca->mi.state;
638 arg.bucket_size = ca->mi.bucket_size;
639 arg.nr_data_types = min(arg.nr_data_types, BCH_DATA_NR);
640 arg.nr_buckets = ca->mi.nbuckets - ca->mi.first_bucket;
642 ret = copy_to_user_errcode(user_arg, &arg, sizeof(arg));
646 for (unsigned i = 0; i < arg.nr_data_types; i++) {
647 struct bch_ioctl_dev_usage_type t = {
648 .buckets = src.d[i].buckets,
649 .sectors = src.d[i].sectors,
650 .fragmented = src.d[i].fragmented,
653 ret = copy_to_user_errcode(&user_arg->d[i], &t, sizeof(t));
658 percpu_ref_put(&ca->ref);
662 static long bch2_ioctl_read_super(struct bch_fs *c,
663 struct bch_ioctl_read_super arg)
665 struct bch_dev *ca = NULL;
669 if (!capable(CAP_SYS_ADMIN))
672 if ((arg.flags & ~(BCH_BY_INDEX|BCH_READ_DEV)) ||
676 mutex_lock(&c->sb_lock);
678 if (arg.flags & BCH_READ_DEV) {
679 ca = bch2_device_lookup(c, arg.dev, arg.flags);
691 if (vstruct_bytes(sb) > arg.size) {
696 ret = copy_to_user_errcode((void __user *)(unsigned long)arg.sb, sb,
699 if (!IS_ERR_OR_NULL(ca))
700 percpu_ref_put(&ca->ref);
701 mutex_unlock(&c->sb_lock);
705 static long bch2_ioctl_disk_get_idx(struct bch_fs *c,
706 struct bch_ioctl_disk_get_idx arg)
708 dev_t dev = huge_decode_dev(arg.dev);
710 if (!capable(CAP_SYS_ADMIN))
716 for_each_online_member(c, ca)
717 if (ca->dev == dev) {
718 percpu_ref_put(&ca->io_ref);
722 return -BCH_ERR_ENOENT_dev_idx_not_found;
725 static long bch2_ioctl_disk_resize(struct bch_fs *c,
726 struct bch_ioctl_disk_resize arg)
731 if (!capable(CAP_SYS_ADMIN))
734 if ((arg.flags & ~BCH_BY_INDEX) ||
738 ca = bch2_device_lookup(c, arg.dev, arg.flags);
742 ret = bch2_dev_resize(c, ca, arg.nbuckets);
744 percpu_ref_put(&ca->ref);
748 static long bch2_ioctl_disk_resize_journal(struct bch_fs *c,
749 struct bch_ioctl_disk_resize_journal arg)
754 if (!capable(CAP_SYS_ADMIN))
757 if ((arg.flags & ~BCH_BY_INDEX) ||
761 if (arg.nbuckets > U32_MAX)
764 ca = bch2_device_lookup(c, arg.dev, arg.flags);
768 ret = bch2_set_nr_journal_buckets(c, ca, arg.nbuckets);
770 percpu_ref_put(&ca->ref);
774 static int bch2_fsck_online_thread_fn(struct thread_with_stdio *stdio)
776 struct fsck_thread *thr = container_of(stdio, struct fsck_thread, thr);
777 struct bch_fs *c = thr->c;
779 c->stdio_filter = current;
780 c->stdio = &thr->thr.stdio;
783 * XXX: can we figure out a way to do this without mucking with c->opts?
785 unsigned old_fix_errors = c->opts.fix_errors;
786 if (opt_defined(thr->opts, fix_errors))
787 c->opts.fix_errors = thr->opts.fix_errors;
789 c->opts.fix_errors = FSCK_FIX_ask;
792 set_bit(BCH_FS_fsck_running, &c->flags);
794 c->curr_recovery_pass = BCH_RECOVERY_PASS_check_alloc_info;
795 int ret = bch2_run_online_recovery_passes(c);
797 clear_bit(BCH_FS_fsck_running, &c->flags);
801 c->stdio_filter = NULL;
802 c->opts.fix_errors = old_fix_errors;
804 up(&c->online_fsck_mutex);
809 static const struct thread_with_stdio_ops bch2_online_fsck_ops = {
810 .exit = bch2_fsck_thread_exit,
811 .fn = bch2_fsck_online_thread_fn,
814 static long bch2_ioctl_fsck_online(struct bch_fs *c,
815 struct bch_ioctl_fsck_online arg)
817 struct fsck_thread *thr = NULL;
823 if (!capable(CAP_SYS_ADMIN))
826 if (!bch2_ro_ref_tryget(c))
829 if (down_trylock(&c->online_fsck_mutex)) {
834 thr = kzalloc(sizeof(*thr), GFP_KERNEL);
841 thr->opts = bch2_opts_empty();
844 char *optstr = strndup_user((char __user *)(unsigned long) arg.opts, 1 << 16);
846 ret = PTR_ERR_OR_ZERO(optstr) ?:
847 bch2_parse_mount_opts(c, &thr->opts, optstr);
854 ret = bch2_run_thread_with_stdio(&thr->thr, &bch2_online_fsck_ops);
859 bch2_fsck_thread_exit(&thr->thr);
860 up(&c->online_fsck_mutex);
866 #define BCH_IOCTL(_name, _argtype) \
870 if (copy_from_user(&i, arg, sizeof(i))) \
872 ret = bch2_ioctl_##_name(c, i); \
876 long bch2_fs_ioctl(struct bch_fs *c, unsigned cmd, void __user *arg)
881 case BCH_IOCTL_QUERY_UUID:
882 return bch2_ioctl_query_uuid(c, arg);
883 case BCH_IOCTL_FS_USAGE:
884 return bch2_ioctl_fs_usage(c, arg);
885 case BCH_IOCTL_DEV_USAGE:
886 return bch2_ioctl_dev_usage(c, arg);
887 case BCH_IOCTL_DEV_USAGE_V2:
888 return bch2_ioctl_dev_usage_v2(c, arg);
890 case BCH_IOCTL_START:
891 BCH_IOCTL(start, struct bch_ioctl_start);
893 return bch2_ioctl_stop(c);
895 case BCH_IOCTL_READ_SUPER:
896 BCH_IOCTL(read_super, struct bch_ioctl_read_super);
897 case BCH_IOCTL_DISK_GET_IDX:
898 BCH_IOCTL(disk_get_idx, struct bch_ioctl_disk_get_idx);
901 if (!test_bit(BCH_FS_started, &c->flags))
905 case BCH_IOCTL_DISK_ADD:
906 BCH_IOCTL(disk_add, struct bch_ioctl_disk);
907 case BCH_IOCTL_DISK_REMOVE:
908 BCH_IOCTL(disk_remove, struct bch_ioctl_disk);
909 case BCH_IOCTL_DISK_ONLINE:
910 BCH_IOCTL(disk_online, struct bch_ioctl_disk);
911 case BCH_IOCTL_DISK_OFFLINE:
912 BCH_IOCTL(disk_offline, struct bch_ioctl_disk);
913 case BCH_IOCTL_DISK_SET_STATE:
914 BCH_IOCTL(disk_set_state, struct bch_ioctl_disk_set_state);
916 BCH_IOCTL(data, struct bch_ioctl_data);
917 case BCH_IOCTL_DISK_RESIZE:
918 BCH_IOCTL(disk_resize, struct bch_ioctl_disk_resize);
919 case BCH_IOCTL_DISK_RESIZE_JOURNAL:
920 BCH_IOCTL(disk_resize_journal, struct bch_ioctl_disk_resize_journal);
921 case BCH_IOCTL_FSCK_ONLINE:
922 BCH_IOCTL(fsck_online, struct bch_ioctl_fsck_online);
928 ret = bch2_err_class(ret);
932 static DEFINE_IDR(bch_chardev_minor);
934 static long bch2_chardev_ioctl(struct file *filp, unsigned cmd, unsigned long v)
936 unsigned minor = iminor(file_inode(filp));
937 struct bch_fs *c = minor < U8_MAX ? idr_find(&bch_chardev_minor, minor) : NULL;
938 void __user *arg = (void __user *) v;
941 ? bch2_fs_ioctl(c, cmd, arg)
942 : bch2_global_ioctl(cmd, arg);
945 static const struct file_operations bch_chardev_fops = {
946 .owner = THIS_MODULE,
947 .unlocked_ioctl = bch2_chardev_ioctl,
948 .open = nonseekable_open,
951 static int bch_chardev_major;
952 static struct class *bch_chardev_class;
953 static struct device *bch_chardev;
955 void bch2_fs_chardev_exit(struct bch_fs *c)
957 if (!IS_ERR_OR_NULL(c->chardev))
958 device_unregister(c->chardev);
960 idr_remove(&bch_chardev_minor, c->minor);
963 int bch2_fs_chardev_init(struct bch_fs *c)
965 c->minor = idr_alloc(&bch_chardev_minor, c, 0, 0, GFP_KERNEL);
969 c->chardev = device_create(bch_chardev_class, NULL,
970 MKDEV(bch_chardev_major, c->minor), c,
971 "bcachefs%u-ctl", c->minor);
972 if (IS_ERR(c->chardev))
973 return PTR_ERR(c->chardev);
978 void bch2_chardev_exit(void)
980 if (!IS_ERR_OR_NULL(bch_chardev_class))
981 device_destroy(bch_chardev_class,
982 MKDEV(bch_chardev_major, U8_MAX));
983 if (!IS_ERR_OR_NULL(bch_chardev_class))
984 class_destroy(bch_chardev_class);
985 if (bch_chardev_major > 0)
986 unregister_chrdev(bch_chardev_major, "bcachefs");
989 int __init bch2_chardev_init(void)
991 bch_chardev_major = register_chrdev(0, "bcachefs-ctl", &bch_chardev_fops);
992 if (bch_chardev_major < 0)
993 return bch_chardev_major;
995 bch_chardev_class = class_create("bcachefs");
996 if (IS_ERR(bch_chardev_class))
997 return PTR_ERR(bch_chardev_class);
999 bch_chardev = device_create(bch_chardev_class, NULL,
1000 MKDEV(bch_chardev_major, U8_MAX),
1001 NULL, "bcachefs-ctl");
1002 if (IS_ERR(bch_chardev))
1003 return PTR_ERR(bch_chardev);
1008 #endif /* NO_BCACHEFS_CHARDEV */