drivers/hwmon/asus_wmi_ec_sensors.c

   1 // SPDX-License-Identifier: GPL-2.0-or-later
   2 /*
   3  * HWMON driver for ASUS B550/X570 motherboards that publish sensor
   4  * values via the embedded controller registers.
   5  *
   6  * Copyright (C) 2021 Eugene Shalygin <eugene.shalygin@gmail.com>
   7  * Copyright (C) 2018-2019 Ed Brindley <kernel@maidavale.org>
   8  *
   9  * EC provides:
  10  * - Chipset temperature
  11  * - CPU temperature
  12  * - Motherboard temperature
  13  * - T_Sensor temperature
  14  * - VRM temperature
  15  * - Water In temperature
  16  * - Water Out temperature
  17  * - CPU Optional Fan RPM
  18  * - Chipset Fan RPM
  19  * - Water Flow Fan RPM
  20  * - CPU current
  21  */
  22
  23 #include <linux/acpi.h>
  24 #include <linux/dmi.h>
  25 #include <linux/hwmon.h>
  26 #include <linux/init.h>
  27 #include <linux/jiffies.h>
  28 #include <linux/kernel.h>
  29 #include <linux/module.h>
  30 #include <linux/mutex.h>
  31 #include <linux/nls.h>
  32 #include <linux/units.h>
  33 #include <linux/wmi.h>
  34
  35 #include <asm/unaligned.h>
  36
  37 #define ASUSWMI_MONITORING_GUID         "466747A0-70EC-11DE-8A39-0800200C9A66"
  38 #define ASUSWMI_METHODID_BLOCK_READ_EC  0x42524543 /* BREC */
  39 /* From the ASUS DSDT source */
  40 #define ASUSWMI_BREC_REGISTERS_MAX      16
  41 #define ASUSWMI_MAX_BUF_LEN             128
  42 #define SENSOR_LABEL_LEN                16
  43
  44 static u32 hwmon_attributes[hwmon_max] = {
  45         [hwmon_chip]    = HWMON_C_REGISTER_TZ,
  46         [hwmon_temp]    = HWMON_T_INPUT | HWMON_T_LABEL,
  47         [hwmon_in]      = HWMON_I_INPUT | HWMON_I_LABEL,
  48         [hwmon_curr]    = HWMON_C_INPUT | HWMON_C_LABEL,
  49         [hwmon_fan]     = HWMON_F_INPUT | HWMON_F_LABEL,
  50 };
  51
  52 struct asus_wmi_ec_sensor_address {
  53         u8 index;
  54         u8 bank;
  55         u8 size;
  56 };
  57
  58 #define MAKE_SENSOR_ADDRESS(size_i, bank_i, index_i) {  \
  59         .size = size_i,                                 \
  60         .bank = bank_i,                                 \
  61         .index = index_i,                               \
  62 }
  63
  64 struct ec_sensor_info {
  65         struct asus_wmi_ec_sensor_address addr;
  66         char label[SENSOR_LABEL_LEN];
  67         enum hwmon_sensor_types type;
  68 };
  69
  70 #define EC_SENSOR(sensor_label, sensor_type, size, bank, index) {       \
  71         .addr = MAKE_SENSOR_ADDRESS(size, bank, index),                 \
  72         .label = sensor_label,                                          \
  73         .type = sensor_type,                                            \
  74 }
  75
  76 enum known_ec_sensor {
  77         SENSOR_TEMP_CHIPSET,
  78         SENSOR_TEMP_CPU,
  79         SENSOR_TEMP_MB,
  80         SENSOR_TEMP_T_SENSOR,
  81         SENSOR_TEMP_VRM,
  82         SENSOR_FAN_CPU_OPT,
  83         SENSOR_FAN_CHIPSET,
  84         SENSOR_FAN_VRM_HS,
  85         SENSOR_FAN_WATER_FLOW,
  86         SENSOR_CURR_CPU,
  87         SENSOR_TEMP_WATER_IN,
  88         SENSOR_TEMP_WATER_OUT,
  89         SENSOR_MAX
  90 };
  91
  92 /* All known sensors for ASUS EC controllers */
  93 static const struct ec_sensor_info known_ec_sensors[] = {
  94         [SENSOR_TEMP_CHIPSET]   = EC_SENSOR("Chipset", hwmon_temp, 1, 0x00, 0x3a),
  95         [SENSOR_TEMP_CPU]       = EC_SENSOR("CPU", hwmon_temp, 1, 0x00, 0x3b),
  96         [SENSOR_TEMP_MB]        = EC_SENSOR("Motherboard", hwmon_temp, 1, 0x00, 0x3c),
  97         [SENSOR_TEMP_T_SENSOR]  = EC_SENSOR("T_Sensor", hwmon_temp, 1, 0x00, 0x3d),
  98         [SENSOR_TEMP_VRM]       = EC_SENSOR("VRM", hwmon_temp, 1, 0x00, 0x3e),
  99         [SENSOR_FAN_CPU_OPT]    = EC_SENSOR("CPU_Opt", hwmon_fan, 2, 0x00, 0xb0),
 100         [SENSOR_FAN_VRM_HS]     = EC_SENSOR("VRM HS", hwmon_fan, 2, 0x00, 0xb2),
 101         [SENSOR_FAN_CHIPSET]    = EC_SENSOR("Chipset", hwmon_fan, 2, 0x00, 0xb4),
 102         [SENSOR_FAN_WATER_FLOW] = EC_SENSOR("Water_Flow", hwmon_fan, 2, 0x00, 0xbc),
 103         [SENSOR_CURR_CPU]       = EC_SENSOR("CPU", hwmon_curr, 1, 0x00, 0xf4),
 104         [SENSOR_TEMP_WATER_IN]  = EC_SENSOR("Water_In", hwmon_temp, 1, 0x01, 0x00),
 105         [SENSOR_TEMP_WATER_OUT] = EC_SENSOR("Water_Out", hwmon_temp, 1, 0x01, 0x01),
 106 };
 107
 108 struct asus_wmi_data {
 109         const enum known_ec_sensor known_board_sensors[SENSOR_MAX + 1];
 110 };
 111
 112 /* boards with EC support */
 113 static struct asus_wmi_data sensors_board_PW_X570_P = {
 114         .known_board_sensors = {
 115                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB, SENSOR_TEMP_VRM,
 116                 SENSOR_FAN_CHIPSET,
 117                 SENSOR_MAX
 118         },
 119 };
 120
 121 static struct asus_wmi_data sensors_board_PW_X570_A = {
 122         .known_board_sensors = {
 123                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB, SENSOR_TEMP_VRM,
 124                 SENSOR_FAN_CHIPSET,
 125                 SENSOR_CURR_CPU,
 126                 SENSOR_MAX
 127         },
 128 };
 129
 130 static struct asus_wmi_data sensors_board_R_C8H = {
 131         .known_board_sensors = {
 132                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
 133                 SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
 134                 SENSOR_TEMP_WATER_IN, SENSOR_TEMP_WATER_OUT,
 135                 SENSOR_FAN_CPU_OPT, SENSOR_FAN_CHIPSET, SENSOR_FAN_WATER_FLOW,
 136                 SENSOR_CURR_CPU,
 137                 SENSOR_MAX
 138         },
 139 };
 140
 141 /* Same as Hero but without chipset fan */
 142 static struct asus_wmi_data sensors_board_R_C8DH = {
 143         .known_board_sensors = {
 144                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
 145                 SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
 146                 SENSOR_TEMP_WATER_IN, SENSOR_TEMP_WATER_OUT,
 147                 SENSOR_FAN_CPU_OPT, SENSOR_FAN_WATER_FLOW,
 148                 SENSOR_CURR_CPU,
 149                 SENSOR_MAX
 150         },
 151 };
 152
 153 /* Same as Hero but without water */
 154 static struct asus_wmi_data sensors_board_R_C8F = {
 155         .known_board_sensors = {
 156                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
 157                 SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
 158                 SENSOR_FAN_CPU_OPT, SENSOR_FAN_CHIPSET,
 159                 SENSOR_CURR_CPU,
 160                 SENSOR_MAX
 161         },
 162 };
 163
 164 static struct asus_wmi_data sensors_board_RS_B550_E_G = {
 165         .known_board_sensors = {
 166                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
 167                 SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
 168                 SENSOR_FAN_CPU_OPT,
 169                 SENSOR_MAX
 170         },
 171 };
 172
 173 static struct asus_wmi_data sensors_board_RS_B550_I_G = {
 174         .known_board_sensors = {
 175                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
 176                 SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
 177                 SENSOR_FAN_VRM_HS,
 178                 SENSOR_CURR_CPU,
 179                 SENSOR_MAX
 180         },
 181 };
 182
 183 static struct asus_wmi_data sensors_board_RS_X570_E_G = {
 184         .known_board_sensors = {
 185                 SENSOR_TEMP_CHIPSET, SENSOR_TEMP_CPU, SENSOR_TEMP_MB,
 186                 SENSOR_TEMP_T_SENSOR, SENSOR_TEMP_VRM,
 187                 SENSOR_FAN_CHIPSET,
 188                 SENSOR_CURR_CPU,
 189                 SENSOR_MAX
 190         },
 191 };
 192
 193 #define DMI_EXACT_MATCH_ASUS_BOARD_NAME(name, sensors) {                        \
 194         .matches = {                                                            \
 195                 DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),     \
 196                 DMI_EXACT_MATCH(DMI_BOARD_NAME, name),                          \
 197         },                                                                      \
 198         .driver_data = sensors,                                                 \
 199 }
 200
 201 static const struct dmi_system_id asus_wmi_ec_dmi_table[] = {
 202         DMI_EXACT_MATCH_ASUS_BOARD_NAME("PRIME X570-PRO", &sensors_board_PW_X570_P),
 203         DMI_EXACT_MATCH_ASUS_BOARD_NAME("Pro WS X570-ACE", &sensors_board_PW_X570_A),
 204         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VIII DARK HERO", &sensors_board_R_C8DH),
 205         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VIII FORMULA", &sensors_board_R_C8F),
 206         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VIII HERO", &sensors_board_R_C8H),
 207         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG STRIX B550-E GAMING", &sensors_board_RS_B550_E_G),
 208         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG STRIX B550-I GAMING", &sensors_board_RS_B550_I_G),
 209         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG STRIX X570-E GAMING", &sensors_board_RS_X570_E_G),
 210         {}
 211 };
 212 MODULE_DEVICE_TABLE(dmi, asus_wmi_ec_dmi_table);
 213
 214 struct ec_sensor {
 215         enum known_ec_sensor info_index;
 216         long cached_value;
 217 };
 218
 219 /**
 220  * struct asus_wmi_ec_info - sensor info.
 221  * @sensors: list of sensors.
 222  * @read_arg: UTF-16LE string to pass to BRxx() WMI function.
 223  * @read_buffer: decoded output from WMI result.
 224  * @nr_sensors: number of board EC sensors.
 225  * @nr_registers: number of EC registers to read (sensor might span more than 1 register).
 226  * @last_updated: in jiffies.
 227  */
 228 struct asus_wmi_ec_info {
 229         struct ec_sensor sensors[SENSOR_MAX];
 230         char read_arg[(ASUSWMI_BREC_REGISTERS_MAX * 4 + 1) * 2];
 231         u8 read_buffer[ASUSWMI_BREC_REGISTERS_MAX];
 232         unsigned int nr_sensors;
 233         unsigned int nr_registers;
 234         unsigned long last_updated;
 235 };
 236
 237 struct asus_wmi_sensors {
 238         struct asus_wmi_ec_info ec;
 239         /* lock access to internal cache */
 240         struct mutex lock;
 241 };
 242
 243 static int asus_wmi_ec_fill_board_sensors(struct asus_wmi_ec_info *ec,
 244                                           const enum known_ec_sensor *bsi)
 245 {
 246         struct ec_sensor *s = ec->sensors;
 247         int i;
 248
 249         ec->nr_sensors = 0;
 250         ec->nr_registers = 0;
 251
 252         for (i = 0; bsi[i] != SENSOR_MAX; i++) {
 253                 s[i].info_index = bsi[i];
 254                 ec->nr_sensors++;
 255                 ec->nr_registers += known_ec_sensors[bsi[i]].addr.size;
 256         }
 257
 258         return 0;
 259 }
 260
 261 /*
 262  * The next four functions convert to or from BRxx string argument format.
 263  * The format of the string is as follows:
 264  * - The string consists of two-byte UTF-16LE characters.
 265  * - The value of the very first byte in the string is equal to the total
 266  *   length of the next string in bytes, thus excluding the first two-byte
 267  *   character.
 268  * - The rest of the string encodes the pairs of (bank, index) pairs, where
 269  *   both values are byte-long (0x00 to 0xFF).
 270  * - Numbers are encoded as UTF-16LE hex values.
 271  */
 272 static int asus_wmi_ec_decode_reply_buffer(const u8 *in, u32 length, u8 *out)
 273 {
 274         char buffer[ASUSWMI_MAX_BUF_LEN * 2];
 275         u32 len = min_t(u32, get_unaligned_le16(in), length - 2);
 276
 277         utf16s_to_utf8s((wchar_t *)(in + 2), len / 2, UTF16_LITTLE_ENDIAN, buffer, sizeof(buffer));
 278
 279         return hex2bin(out, buffer, len / 4);
 280 }
 281
 282 static void asus_wmi_ec_encode_registers(const u8 *in, u32 len, char *out)
 283 {
 284         char buffer[ASUSWMI_MAX_BUF_LEN * 2];
 285
 286         bin2hex(buffer, in, len);
 287
 288         utf8s_to_utf16s(buffer, len * 2, UTF16_LITTLE_ENDIAN, (wchar_t *)(out + 2), len * 2);
 289
 290         put_unaligned_le16(len * 4, out);
 291 }
 292
 293 static void asus_wmi_ec_make_block_read_query(struct asus_wmi_ec_info *ec)
 294 {
 295         u8 registers[ASUSWMI_BREC_REGISTERS_MAX * 2];
 296         const struct ec_sensor_info *si;
 297         int i, j, offset;
 298
 299         offset = 0;
 300         for (i = 0; i < ec->nr_sensors; i++) {
 301                 si = &known_ec_sensors[ec->sensors[i].info_index];
 302                 for (j = 0; j < si->addr.size; j++) {
 303                         registers[offset++] = si->addr.bank;
 304                         registers[offset++] = si->addr.index + j;
 305                 }
 306         }
 307
 308         asus_wmi_ec_encode_registers(registers, offset, ec->read_arg);
 309 }
 310
 311 static int asus_wmi_ec_block_read(u32 method_id, char *query, u8 *out)
 312 {
 313         struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
 314         struct acpi_buffer input;
 315         union acpi_object *obj;
 316         acpi_status status;
 317         int ret;
 318
 319         /* The first byte of the BRxx() argument string has to be the string size. */
 320         input.length = query[0] + 2;
 321         input.pointer = query;
 322         status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input, &output);
 323         if (ACPI_FAILURE(status))
 324                 return -EIO;
 325
 326         obj = output.pointer;
 327         if (!obj)
 328                 return -EIO;
 329
 330         if (obj->type != ACPI_TYPE_BUFFER || obj->buffer.length < 2) {
 331                 ret = -EIO;
 332                 goto out_free_obj;
 333         }
 334
 335         ret = asus_wmi_ec_decode_reply_buffer(obj->buffer.pointer, obj->buffer.length, out);
 336
 337 out_free_obj:
 338         ACPI_FREE(obj);
 339         return ret;
 340 }
 341
 342 static inline long get_sensor_value(const struct ec_sensor_info *si, u8 *data)
 343 {
 344         switch (si->addr.size) {
 345         case 1:
 346                 return *data;
 347         case 2:
 348                 return get_unaligned_be16(data);
 349         case 4:
 350                 return get_unaligned_be32(data);
 351         default:
 352                 return 0;
 353         }
 354 }
 355
 356 static void asus_wmi_ec_update_ec_sensors(struct asus_wmi_ec_info *ec)
 357 {
 358         const struct ec_sensor_info *si;
 359         struct ec_sensor *s;
 360         u8 i_sensor;
 361         u8 *data;
 362
 363         data = ec->read_buffer;
 364         for (i_sensor = 0; i_sensor < ec->nr_sensors; i_sensor++) {
 365                 s = &ec->sensors[i_sensor];
 366                 si = &known_ec_sensors[s->info_index];
 367                 s->cached_value = get_sensor_value(si, data);
 368                 data += si->addr.size;
 369         }
 370 }
 371
 372 static long asus_wmi_ec_scale_sensor_value(long value, int data_type)
 373 {
 374         switch (data_type) {
 375         case hwmon_curr:
 376         case hwmon_temp:
 377         case hwmon_in:
 378                 return value * MILLI;
 379         default:
 380                 return value;
 381         }
 382 }
 383
 384 static int asus_wmi_ec_find_sensor_index(const struct asus_wmi_ec_info *ec,
 385                                          enum hwmon_sensor_types type, int channel)
 386 {
 387         int i;
 388
 389         for (i = 0; i < ec->nr_sensors; i++) {
 390                 if (known_ec_sensors[ec->sensors[i].info_index].type == type) {
 391                         if (channel == 0)
 392                                 return i;
 393
 394                         channel--;
 395                 }
 396         }
 397         return -EINVAL;
 398 }
 399
 400 static int asus_wmi_ec_get_cached_value_or_update(struct asus_wmi_sensors *sensor_data,
 401                                                   int sensor_index,
 402                                                   long *value)
 403 {
 404         struct asus_wmi_ec_info *ec = &sensor_data->ec;
 405         int ret = 0;
 406
 407         mutex_lock(&sensor_data->lock);
 408
 409         if (time_after(jiffies, ec->last_updated + HZ)) {
 410                 ret = asus_wmi_ec_block_read(ASUSWMI_METHODID_BLOCK_READ_EC,
 411                                              ec->read_arg, ec->read_buffer);
 412                 if (ret)
 413                         goto unlock;
 414
 415                 asus_wmi_ec_update_ec_sensors(ec);
 416                 ec->last_updated = jiffies;
 417         }
 418
 419         *value = ec->sensors[sensor_index].cached_value;
 420
 421 unlock:
 422         mutex_unlock(&sensor_data->lock);
 423
 424         return ret;
 425 }
 426
 427 /* Now follow the functions that implement the hwmon interface */
 428
 429 static int asus_wmi_ec_hwmon_read(struct device *dev, enum hwmon_sensor_types type,
 430                                   u32 attr, int channel, long *val)
 431 {
 432         struct asus_wmi_sensors *sensor_data = dev_get_drvdata(dev);
 433         struct asus_wmi_ec_info *ec = &sensor_data->ec;
 434         int ret, sidx, info_index;
 435         long value = 0;
 436
 437         sidx = asus_wmi_ec_find_sensor_index(ec, type, channel);
 438         if (sidx < 0)
 439                 return sidx;
 440
 441         ret = asus_wmi_ec_get_cached_value_or_update(sensor_data, sidx, &value);
 442         if (ret)
 443                 return ret;
 444
 445         info_index = ec->sensors[sidx].info_index;
 446         *val = asus_wmi_ec_scale_sensor_value(value, known_ec_sensors[info_index].type);
 447
 448         return ret;
 449 }
 450
 451 static int asus_wmi_ec_hwmon_read_string(struct device *dev,
 452                                          enum hwmon_sensor_types type, u32 attr,
 453                                          int channel, const char **str)
 454 {
 455         struct asus_wmi_sensors *sensor_data = dev_get_drvdata(dev);
 456         struct asus_wmi_ec_info *ec = &sensor_data->ec;
 457         int sensor_index;
 458
 459         sensor_index = asus_wmi_ec_find_sensor_index(ec, type, channel);
 460         *str = known_ec_sensors[ec->sensors[sensor_index].info_index].label;
 461
 462         return 0;
 463 }
 464
 465 static umode_t asus_wmi_ec_hwmon_is_visible(const void *drvdata,
 466                                             enum hwmon_sensor_types type, u32 attr,
 467                                             int channel)
 468 {
 469         const struct asus_wmi_sensors *sensor_data = drvdata;
 470         const struct asus_wmi_ec_info *ec = &sensor_data->ec;
 471         int index;
 472
 473         index = asus_wmi_ec_find_sensor_index(ec, type, channel);
 474
 475         return index < 0 ? 0 : 0444;
 476 }
 477
 478 static int asus_wmi_hwmon_add_chan_info(struct hwmon_channel_info *asus_wmi_hwmon_chan,
 479                                         struct device *dev, int num,
 480                                         enum hwmon_sensor_types type, u32 config)
 481 {
 482         u32 *cfg;
 483
 484         cfg = devm_kcalloc(dev, num + 1, sizeof(*cfg), GFP_KERNEL);
 485         if (!cfg)
 486                 return -ENOMEM;
 487
 488         asus_wmi_hwmon_chan->type = type;
 489         asus_wmi_hwmon_chan->config = cfg;
 490         memset32(cfg, config, num);
 491
 492         return 0;
 493 }
 494
 495 static const struct hwmon_ops asus_wmi_ec_hwmon_ops = {
 496         .is_visible = asus_wmi_ec_hwmon_is_visible,
 497         .read = asus_wmi_ec_hwmon_read,
 498         .read_string = asus_wmi_ec_hwmon_read_string,
 499 };
 500
 501 static struct hwmon_chip_info asus_wmi_ec_chip_info = {
 502         .ops = &asus_wmi_ec_hwmon_ops,
 503 };
 504
 505 static int asus_wmi_ec_configure_sensor_setup(struct device *dev,
 506                                               const enum known_ec_sensor *bsi)
 507 {
 508         struct asus_wmi_sensors *sensor_data = dev_get_drvdata(dev);
 509         struct asus_wmi_ec_info *ec = &sensor_data->ec;
 510         struct hwmon_channel_info *asus_wmi_hwmon_chan;
 511         const struct hwmon_channel_info **asus_wmi_ci;
 512         int nr_count[hwmon_max] = {}, nr_types = 0;
 513         const struct hwmon_chip_info *chip_info;
 514         const struct ec_sensor_info *si;
 515         enum hwmon_sensor_types type;
 516         struct device *hwdev;
 517         int i, ret;
 518
 519         ret = asus_wmi_ec_fill_board_sensors(ec, bsi);
 520         if (ret)
 521                 return ret;
 522
 523         if (!sensor_data->ec.nr_sensors)
 524                 return -ENODEV;
 525
 526         for (i = 0; i < ec->nr_sensors; i++) {
 527                 si = &known_ec_sensors[ec->sensors[i].info_index];
 528                 if (!nr_count[si->type])
 529                         nr_types++;
 530                 nr_count[si->type]++;
 531         }
 532
 533         if (nr_count[hwmon_temp]) {
 534                 nr_count[hwmon_chip]++;
 535                 nr_types++;
 536         }
 537
 538         /*
 539          * If we can get values for all the registers in a single query,
 540          * the query will not change from call to call.
 541          */
 542         asus_wmi_ec_make_block_read_query(ec);
 543
 544         asus_wmi_hwmon_chan = devm_kcalloc(dev, nr_types, sizeof(*asus_wmi_hwmon_chan),
 545                                            GFP_KERNEL);
 546         if (!asus_wmi_hwmon_chan)
 547                 return -ENOMEM;
 548
 549         asus_wmi_ci = devm_kcalloc(dev, nr_types + 1, sizeof(*asus_wmi_ci), GFP_KERNEL);
 550         if (!asus_wmi_ci)
 551                 return -ENOMEM;
 552
 553         asus_wmi_ec_chip_info.info = asus_wmi_ci;
 554         chip_info = &asus_wmi_ec_chip_info;
 555
 556         for (type = 0; type < hwmon_max; type++) {
 557                 if (!nr_count[type])
 558                         continue;
 559
 560                 ret = asus_wmi_hwmon_add_chan_info(asus_wmi_hwmon_chan, dev,
 561                                                    nr_count[type], type,
 562                                                    hwmon_attributes[type]);
 563                 if (ret)
 564                         return ret;
 565
 566                 *asus_wmi_ci++ = asus_wmi_hwmon_chan++;
 567         }
 568
 569         dev_dbg(dev, "board has %d EC sensors that span %d registers",
 570                 ec->nr_sensors, ec->nr_registers);
 571
 572         hwdev = devm_hwmon_device_register_with_info(dev, "asus_wmi_ec_sensors",
 573                                                      sensor_data, chip_info, NULL);
 574
 575         return PTR_ERR_OR_ZERO(hwdev);
 576 }
 577
 578 static int asus_wmi_probe(struct wmi_device *wdev, const void *context)
 579 {
 580         struct asus_wmi_sensors *sensor_data;
 581         struct asus_wmi_data *board_sensors;
 582         const struct dmi_system_id *dmi_id;
 583         const enum known_ec_sensor *bsi;
 584         struct device *dev = &wdev->dev;
 585
 586         dmi_id = dmi_first_match(asus_wmi_ec_dmi_table);
 587         if (!dmi_id)
 588                 return -ENODEV;
 589
 590         board_sensors = dmi_id->driver_data;
 591         bsi = board_sensors->known_board_sensors;
 592
 593         sensor_data = devm_kzalloc(dev, sizeof(*sensor_data), GFP_KERNEL);
 594         if (!sensor_data)
 595                 return -ENOMEM;
 596
 597         mutex_init(&sensor_data->lock);
 598
 599         dev_set_drvdata(dev, sensor_data);
 600
 601         return asus_wmi_ec_configure_sensor_setup(dev, bsi);
 602 }
 603
 604 static const struct wmi_device_id asus_ec_wmi_id_table[] = {
 605         { ASUSWMI_MONITORING_GUID, NULL },
 606         { }
 607 };
 608
 609 static struct wmi_driver asus_sensors_wmi_driver = {
 610         .driver = {
 611                 .name = "asus_wmi_ec_sensors",
 612         },
 613         .id_table = asus_ec_wmi_id_table,
 614         .probe = asus_wmi_probe,
 615 };
 616 module_wmi_driver(asus_sensors_wmi_driver);
 617
 618 MODULE_AUTHOR("Ed Brindley <kernel@maidavale.org>");
 619 MODULE_AUTHOR("Eugene Shalygin <eugene.shalygin@gmail.com>");
 620 MODULE_DESCRIPTION("Asus WMI Sensors Driver");
 621 MODULE_LICENSE("GPL");