Revert "usb: dwc3: don't reset device side if dwc3 was configured as host-only"
authorThinh Nguyen <Thinh.Nguyen@synopsys.com>
Fri, 22 Dec 2023 22:11:33 +0000 (22:11 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Jan 2024 13:40:42 +0000 (14:40 +0100)
commitafe28cd686aeb77e8d9140d50fb1cf06a7ecb731
tree90543735073210afbc95487ca9072bcf77b6a413
parent7059fbebcb00554c3f31e5b5d93ef6d2d96dc7b4
Revert "usb: dwc3: don't reset device side if dwc3 was configured as host-only"

This reverts commit e835c0a4e23c38531dcee5ef77e8d1cf462658c7.

Don't omit soft-reset. During initialization, the driver may need to
perform a soft reset to ensure the phy is ready when the controller
updates the GCTL.PRTCAPDIR or other settings by issuing phy soft-reset.
Many platforms often have access to DCTL register for soft-reset despite
being host-only. If there are actual reported issues from the platforms
that don't expose DCTL registers, then we will need to revisit (perhaps
to teach dwc3 to perform xhci's soft-reset USBCMD.HCRST).

Cc: <stable@vger.kernel.org>
Fixes: e835c0a4e23c ("usb: dwc3: don't reset device side if dwc3 was configured as host-only")
Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/7668ab11a48f260820825274976eb41fec7f54d1.1703282469.git.Thinh.Nguyen@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/core.c