samba.git
12 years agos4-messaging: fixed the removal of messaging sockets in child tasks
Andrew Tridgell [Fri, 22 Jul 2011 04:55:32 +0000 (14:55 +1000)]
s4-messaging: fixed the removal of messaging sockets in child tasks

when a child task exits we were firing a destructor on any inherited
messaging contexts, which could trigger a removal of the parents
message socket and messaging database entry.

This adds a new auto_remove flag to imessaging_init(), and exposes the
cleanup code for use by the stream service.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jul 22 08:09:06 CEST 2011 on sn-devel-104

12 years agoFix const warning.
Jeremy Allison [Thu, 21 Jul 2011 21:02:10 +0000 (14:02 -0700)]
Fix const warning.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jul 22 01:58:39 CEST 2011 on sn-devel-104

12 years agos3-rpc_server: Do not set msg_ctx twice
Simo Sorce [Thu, 21 Jul 2011 21:10:06 +0000 (17:10 -0400)]
s3-rpc_server: Do not set msg_ctx twice

msg_ctx was already passed to make_base_pipes_struct,
no need to set it again.

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Fri Jul 22 00:47:28 CEST 2011 on sn-devel-104

12 years agos3:winbindd_cm: remove unused checks for address family
Stefan Metzmacher [Thu, 21 Jul 2011 19:51:11 +0000 (21:51 +0200)]
s3:winbindd_cm: remove unused checks for address family

If we got a connection, we don't need to check what
address family it uses.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jul 21 23:33:48 CEST 2011 on sn-devel-104

12 years agos3:libsmb: replace cli_initialise[_ex]() by cli_state_create()
Stefan Metzmacher [Thu, 21 Jul 2011 19:47:36 +0000 (21:47 +0200)]
s3:libsmb: replace cli_initialise[_ex]() by cli_state_create()

This makes sure cli_state->src_ss and cli_state->dest_ss are always
initialized.

metze

12 years agos3:include: remove unused cli_state->called and cli_state->calling
Stefan Metzmacher [Thu, 21 Jul 2011 19:18:27 +0000 (21:18 +0200)]
s3:include: remove unused cli_state->called and cli_state->calling

metze

12 years agos3:libsmb: don't pass cli->called.name to NTLMv2_generate_names_blob()
Stefan Metzmacher [Thu, 21 Jul 2011 19:15:38 +0000 (21:15 +0200)]
s3:libsmb: don't pass cli->called.name to NTLMv2_generate_names_blob()

cli->called.name is never initialized, so this change doesn't change
the behavior. And this behavior seems to be correct, see
commit 29c0c37691da10bf061ba90a5b31482bda2fa486
s4/libcli: do not use netbios name in NTLMv2 blobs w/o spnego.

metze

12 years agos3:libsmb: move cli->vuid to cli->smb1.uid and hide it behind cli_state_[g|s]et_uid()
Stefan Metzmacher [Thu, 21 Jul 2011 07:20:43 +0000 (09:20 +0200)]
s3:libsmb: move cli->vuid to cli->smb1.uid and hide it behind cli_state_[g|s]et_uid()

metze

12 years agos3:libsmb: add cli_state_encryption_on()
Stefan Metzmacher [Mon, 18 Jul 2011 17:46:59 +0000 (19:46 +0200)]
s3:libsmb: add cli_state_encryption_on()

metze

12 years agos3-rpc_server: Pass msg_ctx to make_base_pipes_struct().
Andreas Schneider [Thu, 21 Jul 2011 17:54:01 +0000 (19:54 +0200)]
s3-rpc_server: Pass msg_ctx to make_base_pipes_struct().

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul 21 21:08:32 CEST 2011 on sn-devel-104

12 years agos3-rpc_server: Create common function to allocate pipes_struct
Simo Sorce [Thu, 21 Jul 2011 15:02:59 +0000 (11:02 -0400)]
s3-rpc_server: Create common function to allocate pipes_struct

Avoid code duplication and fix bug where a new pipe was not added to
InternalPipes upon creation in make_server_pipes_struct()

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul 21 19:50:02 CEST 2011 on sn-devel-104

12 years agos3-rpc_server: Move pipe/handles functions
Simo Sorce [Thu, 21 Jul 2011 13:53:10 +0000 (09:53 -0400)]
s3-rpc_server: Move pipe/handles functions

Put InternalPipes related functions in rpc_handles.c and out of rpc_ncacn_np.c
rpc_handles.c is the only file that really uses them after all and ncacn_np.c
is the wrong place for that stuff.
While ther remove unnecessary wrapper functions now that the InternalPipes
static variable is directly accessible.

Also move all pipes_struct related header stuff in its own rpc_pipes.h header.

Signed-off-by: Andreas Schneider <asn@samba.org>
12 years agos3-rpc_server: Fixed header define.
Andreas Schneider [Fri, 27 May 2011 09:55:41 +0000 (11:55 +0200)]
s3-rpc_server: Fixed header define.

12 years agos3-rpc_server: Remove unused endpoint information.
Andreas Schneider [Fri, 15 Jul 2011 16:03:47 +0000 (18:03 +0200)]
s3-rpc_server: Remove unused endpoint information.

12 years agos3-rpc_server: We need to copy the session_info for external pipes.
Andreas Schneider [Thu, 21 Jul 2011 15:58:41 +0000 (17:58 +0200)]
s3-rpc_server: We need to copy the session_info for external pipes.

Andrew please check!

12 years agos3-rpc_server: Duplicate the pipe name.
Andreas Schneider [Thu, 21 Jul 2011 09:21:30 +0000 (11:21 +0200)]
s3-rpc_server: Duplicate the pipe name.

12 years agos3-rpc_server: Free the np dir.
Andreas Schneider [Thu, 21 Jul 2011 09:11:51 +0000 (11:11 +0200)]
s3-rpc_server: Free the np dir.

12 years agos3-rpc_server: Fix messaging context in the pipes struct.
Andreas Schneider [Thu, 21 Jul 2011 08:43:56 +0000 (10:43 +0200)]
s3-rpc_server: Fix messaging context in the pipes struct.

12 years agos3-rpc_server: Add my copyright.
Andreas Schneider [Thu, 21 Jul 2011 11:13:35 +0000 (13:13 +0200)]
s3-rpc_server: Add my copyright.

12 years agos3:loadparm: fix an implicit cast warning in string intialization in init_globals()
Michael Adam [Thu, 21 Jul 2011 15:22:22 +0000 (17:22 +0200)]
s3:loadparm: fix an implicit cast warning in string intialization in init_globals()

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Jul 21 18:39:15 CEST 2011 on sn-devel-104

12 years agos3:loadparm: add support for P_BYTES to lp_do_parameter() - fix a build warning
Michael Adam [Thu, 21 Jul 2011 15:20:16 +0000 (17:20 +0200)]
s3:loadparm: add support for P_BYTES to lp_do_parameter() - fix a build warning

(taken from s4 loadparm)

12 years agos3:loadparm: add support for P_CMDLIST to lp_do_parameter - fix a build warning
Michael Adam [Thu, 21 Jul 2011 15:18:40 +0000 (17:18 +0200)]
s3:loadparm: add support for P_CMDLIST to lp_do_parameter - fix a build warning

12 years agos3:loadparm: add support for P_CMDLIST to lp_save_defaults() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:15:31 +0000 (17:15 +0200)]
s3:loadparm: add support for P_CMDLIST to lp_save_defaults() - fix build warning

12 years agos3:loadparm: add support for P_BYTES to lp_save_defaults - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:14:56 +0000 (17:14 +0200)]
s3:loadparm: add support for P_BYTES to lp_save_defaults - fix build warning

12 years agos3:loadparm: add support for P_CMDLIST to is_default() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:13:44 +0000 (17:13 +0200)]
s3:loadparm: add support for P_CMDLIST to is_default() - fix build warning

12 years agos3:loadparm: add support for P_BYTES to is_default() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:13:24 +0000 (17:13 +0200)]
s3:loadparm: add support for P_BYTES to is_default() - fix build warning

12 years agos3:loadparm: add support for P_CMDLIST to print_parameter - fix build warning.
Michael Adam [Thu, 21 Jul 2011 15:11:44 +0000 (17:11 +0200)]
s3:loadparm: add support for P_CMDLIST to print_parameter - fix build warning.

12 years agos3:loadparm: add support for P_BYTES to print_parameter() - fix build warning.
Michael Adam [Thu, 21 Jul 2011 15:05:46 +0000 (17:05 +0200)]
s3:loadparm: add support for P_BYTES to print_parameter() - fix build warning.

12 years agos3:loadparm: add support for P_CMDLIST to equal_parameter() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:04:16 +0000 (17:04 +0200)]
s3:loadparm: add support for P_CMDLIST to equal_parameter() - fix build warning

12 years agos3:loadparm: add suppor for P_BYTES to equal_parameter() - fix build warning
Michael Adam [Thu, 21 Jul 2011 15:03:58 +0000 (17:03 +0200)]
s3:loadparm: add suppor for P_BYTES to equal_parameter() - fix build warning

12 years agos3:loadparm: szNetbiosAliases is now a const char ** - cast properly
Michael Adam [Thu, 21 Jul 2011 15:02:14 +0000 (17:02 +0200)]
s3:loadparm: szNetbiosAliases is now a const char ** - cast properly

12 years agos3:loadparm: szWinbindNssInfo is now a const char ** instead of a char ** - cast...
Michael Adam [Thu, 21 Jul 2011 15:01:38 +0000 (17:01 +0200)]
s3:loadparm: szWinbindNssInfo is now a const char ** instead of a char ** - cast properly

12 years agos3:loadparm: fix a check that was accidentially an assignment in lp_servicebynum()
Michael Adam [Thu, 21 Jul 2011 12:10:50 +0000 (14:10 +0200)]
s3:loadparm: fix a check that was accidentially an assignment in lp_servicebynum()

12 years agos3:loadparm: untangle assignment from check in do_section()
Michael Adam [Wed, 20 Jul 2011 14:48:07 +0000 (16:48 +0200)]
s3:loadparm: untangle assignment from check in do_section()

12 years agos3-waf: fix a libcrypto configure check
Christian Ambach [Thu, 21 Jul 2011 12:13:20 +0000 (14:13 +0200)]
s3-waf: fix a libcrypto configure check

the parameters to conf.CHECK_FUNCS_IN were in the wrong order

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Jul 21 16:49:52 CEST 2011 on sn-devel-104

12 years agos3:winbindd remove an unused variable
Christian Ambach [Thu, 21 Jul 2011 12:48:24 +0000 (14:48 +0200)]
s3:winbindd remove an unused variable

fixes a compiler warning

12 years agos3:utils fix a compiler warning
Christian Ambach [Thu, 21 Jul 2011 12:47:38 +0000 (14:47 +0200)]
s3:utils fix a compiler warning

fix a compiler warning about missing prototypes

12 years agos3:modules/vfs_afsacl fix a compiler warning
Christian Ambach [Fri, 15 Jul 2011 14:16:11 +0000 (16:16 +0200)]
s3:modules/vfs_afsacl fix a compiler warning

12 years agos3:afs make path argument to afs_syscall const
Christian Ambach [Fri, 15 Jul 2011 14:14:33 +0000 (16:14 +0200)]
s3:afs make path argument to afs_syscall const

12 years agos3:modules/vfs_afsacl fix a compiler warning
Christian Ambach [Fri, 15 Jul 2011 14:12:46 +0000 (16:12 +0200)]
s3:modules/vfs_afsacl fix a compiler warning

12 years agos3:modules/vfs_afsacl use stdbool types
Christian Ambach [Fri, 15 Jul 2011 13:58:40 +0000 (15:58 +0200)]
s3:modules/vfs_afsacl use stdbool types

12 years agos3:modules/vfs_afsacl remove some unnecessary whitespace
Christian Ambach [Fri, 15 Jul 2011 13:57:26 +0000 (15:57 +0200)]
s3:modules/vfs_afsacl remove some unnecessary whitespace

12 years agos3:lib/afs fix the build with --with-vfs-afsacl
Christian Ambach [Fri, 15 Jul 2011 13:54:25 +0000 (15:54 +0200)]
s3:lib/afs fix the build with --with-vfs-afsacl

This fixes the second piece of Bug #8263

12 years agos3:lib/afs use stdbool types
Christian Ambach [Fri, 15 Jul 2011 13:35:18 +0000 (15:35 +0200)]
s3:lib/afs use stdbool types

12 years agos3:utils/net_afs fix compiler warnings
Christian Ambach [Fri, 15 Jul 2011 13:44:36 +0000 (15:44 +0200)]
s3:utils/net_afs fix compiler warnings

12 years agos3:lib/afs_settoken fix some compiler warnings
Christian Ambach [Fri, 15 Jul 2011 13:34:29 +0000 (15:34 +0200)]
s3:lib/afs_settoken fix some compiler warnings

12 years agos3:lib/afs fix some compiler warnings
Christian Ambach [Fri, 15 Jul 2011 13:30:14 +0000 (15:30 +0200)]
s3:lib/afs fix some compiler warnings

12 years agos3:lib/afs fix the build with --with-fake-kaserver
Christian Ambach [Fri, 15 Jul 2011 13:27:07 +0000 (15:27 +0200)]
s3:lib/afs fix the build with --with-fake-kaserver

This fixes one piece of Bug #8263

12 years agoselftest: use "state directory" and "cache directory" options
Björn Baumbach [Wed, 20 Jul 2011 11:02:22 +0000 (13:02 +0200)]
selftest: use "state directory" and "cache directory" options

instead of "state dir" and "cache dir"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jul 21 10:06:32 CEST 2011 on sn-devel-104

12 years agos4-param: use "state directory" and "cache directory" options
Björn Baumbach [Wed, 20 Jul 2011 10:56:22 +0000 (12:56 +0200)]
s4-param: use "state directory" and "cache directory" options

instead of "state dir" and "cache dir" in order be compatible
with the source3 code.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agosamba-tool: make sure we exit with an error on a bad command
Andrew Tridgell [Thu, 21 Jul 2011 00:29:21 +0000 (10:29 +1000)]
samba-tool: make sure we exit with an error on a bad command

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Jul 21 04:58:01 CEST 2011 on sn-devel-104

12 years agodbcheck: mark the dbcheck as known-fail
Andrew Tridgell [Tue, 19 Jul 2011 02:57:59 +0000 (12:57 +1000)]
dbcheck: mark the dbcheck as known-fail

this will fail till we correctly update backlinks to deleted objects

12 years agosamba-tool: fixed some more calls to samba_tool join to be 'domain join'
Andrew Tridgell [Tue, 19 Jul 2011 02:54:37 +0000 (12:54 +1000)]
samba-tool: fixed some more calls to samba_tool join to be 'domain join'

12 years agos4-selftest: added undump.sh script
Andrew Tridgell [Thu, 14 Jul 2011 04:03:53 +0000 (14:03 +1000)]
s4-selftest: added undump.sh script

used to unpack a dumped set of provision files for selftest

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agotdb: remove 'EOF' print from tdbrestore
Andrew Tridgell [Thu, 14 Jul 2011 04:03:15 +0000 (14:03 +1000)]
tdb: remove 'EOF' print from tdbrestore

the EOF message is pointless, and makes for noisy scripts

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agodbcheck: use string DN in delete when fixing broken strings DNs
Andrew Tridgell [Thu, 14 Jul 2011 04:02:38 +0000 (14:02 +1000)]
dbcheck: use string DN in delete when fixing broken strings DNs

this prevents the extended_dn_in module from 'fixing' the DN for us

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos4-provision: run dbcheck on a minimal set of objects in provision
Andrew Tridgell [Thu, 14 Jul 2011 03:35:14 +0000 (13:35 +1000)]
s4-provision: run dbcheck on a minimal set of objects in provision

this speeds up the dbcheck in provision to fix only the objects that
we know will need fixing

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos4-kcc: use dsdb_delete() instead of ldb_delete()
Andrew Tridgell [Thu, 14 Jul 2011 03:18:48 +0000 (13:18 +1000)]
s4-kcc: use dsdb_delete() instead of ldb_delete()

this adds the DSDB_SEARCH_SHOW_DELETED flag, which fixes deletion of
deleted objects

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos4-dsdb: added dsdb_delete() function
Andrew Tridgell [Thu, 14 Jul 2011 03:18:17 +0000 (13:18 +1000)]
s4-dsdb: added dsdb_delete() function

this gives us a delete function that takes the standard set of dsdb
flags

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agopyldb: use dn.is_child_of() instead of dn.compare_base()
Andrew Tridgell [Thu, 14 Jul 2011 03:17:49 +0000 (13:17 +1000)]
pyldb: use dn.is_child_of() instead of dn.compare_base()

the compare_base() C API doesn't really fit well in python, as it
returns 0 for true. Better to have a boolean function for the python
interface.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba_backup: check that directory really exists
Matthieu Patou [Sat, 11 Jun 2011 20:40:31 +0000 (00:40 +0400)]
samba_backup: check that directory really exists

12 years agotests: Add alpha13 dumped provision
Matthieu Patou [Wed, 8 Jun 2011 21:01:25 +0000 (01:01 +0400)]
tests: Add alpha13 dumped provision

12 years agos4-dsdb: Use controls provided during the request while searching for object to delete
Matthieu Patou [Wed, 8 Jun 2011 08:20:32 +0000 (12:20 +0400)]
s4-dsdb: Use controls provided during the request while searching for object to delete

If the parent request specify the show_deleted control we must use it in
order to be able to see the deleted objects.

Also we just allow to trusted connections with the system account to
remove deleted objects, others receive an unwilling to perform.

12 years agos4-dsdb: check group membership only for non deleted objects
Matthieu Patou [Sat, 4 Jun 2011 20:42:35 +0000 (00:42 +0400)]
s4-dsdb: check group membership only for non deleted objects

Group membership has been already removed on deleted objects so there is
no mean doing something on this kind of object.

12 years agos4-dsdb: change the samba3sam test to add the show_deleted module
Andrew Tridgell [Wed, 20 Jul 2011 05:31:42 +0000 (15:31 +1000)]
s4-dsdb: change the samba3sam test to add the show_deleted module

this is needed now that the samldb module adds the show deleted
control

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agopyldb: add unit test for ldbDn.compare_base
Matthieu Patou [Sat, 11 Jun 2011 14:31:28 +0000 (18:31 +0400)]
pyldb: add unit test for ldbDn.compare_base

12 years agoldb-python: add a function to Dn object to compare the Dn with a base DN
Matthieu Patou [Mon, 23 May 2011 21:30:15 +0000 (01:30 +0400)]
ldb-python: add a function to Dn object to compare the Dn with a base DN

12 years agoupdate/add my copyright
Matthieu Patou [Sun, 22 May 2011 19:41:56 +0000 (23:41 +0400)]
update/add my copyright

12 years agos4-dsdb: In rootdse add extended dn info on all values for a given attribute
Matthieu Patou [Fri, 13 May 2011 09:31:13 +0000 (13:31 +0400)]
s4-dsdb: In rootdse add extended dn info on all values for a given attribute

And not only on the fist value as it was the case up to this changeset.

12 years agos4-dsdb: add dsdb_module_extended function similar to other dsdb_module_* functions
Matthieu Patou [Fri, 13 May 2011 20:26:26 +0000 (00:26 +0400)]
s4-dsdb: add dsdb_module_extended function similar to other dsdb_module_* functions

12 years agos4-schema: add systemFlags to dsdb classes objects
Matthieu Patou [Tue, 3 May 2011 16:38:13 +0000 (20:38 +0400)]
s4-schema: add systemFlags to dsdb classes objects

12 years agos4-test: don't fix broken objects during dbcheck test
Andrew Tridgell [Wed, 13 Jul 2011 09:37:42 +0000 (19:37 +1000)]
s4-test: don't fix broken objects during dbcheck test

this leaves the database as-is, which makes it easier to examine the
problem

12 years agodbcheck: test the --reindex option
Andrew Tridgell [Wed, 13 Jul 2011 07:26:59 +0000 (17:26 +1000)]
dbcheck: test the --reindex option

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos4-test: added dbcheck run to test suite
Andrew Tridgell [Wed, 13 Jul 2011 00:50:24 +0000 (10:50 +1000)]
s4-test: added dbcheck run to test suite

This should catch corruption that happens during a test run

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba-tool: nicer error in passwordsettings with no settings
Andrew Tridgell [Tue, 19 Jul 2011 01:39:52 +0000 (11:39 +1000)]
samba-tool: nicer error in passwordsettings with no settings

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba-tool: testparm doesn't take any credentials
Andrew Tridgell [Tue, 19 Jul 2011 01:19:59 +0000 (11:19 +1000)]
samba-tool: testparm doesn't take any credentials

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba-tool: use 'exportkeytab' instead of 'dumpkeys'
Andrew Tridgell [Tue, 19 Jul 2011 01:03:44 +0000 (11:03 +1000)]
samba-tool: use 'exportkeytab' instead of 'dumpkeys'

a 'keytab' is a particular format known to administrators, whereas
'keys' is a bit too vague

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba-tool: Fix __doc_ in base classes
Giampaolo Lauria [Mon, 18 Jul 2011 22:34:45 +0000 (18:34 -0400)]
samba-tool: Fix __doc_ in base classes

Changed prog to samba-tool as prog is only meaningful in Parser

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: removed synopsis code in base class
Giampaolo Lauria [Mon, 18 Jul 2011 21:46:02 +0000 (17:46 -0400)]
samba-tool: removed synopsis code in base class

As it is not always possible to determine the usage of a command solely based on the list of required and optional args, it is best
to have the subclasses always define it, rather than displaying an incorrect usage statement. Currently, all commands are subclassing the synopsis.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: Fixed bugs to determine min and max # of allowed arguments
Giampaolo Lauria [Mon, 18 Jul 2011 20:48:03 +0000 (16:48 -0400)]
samba-tool: Fixed bugs to determine min and max # of allowed arguments

Fixed the bugs in the code to determine both the min and the max # of allowed arguments
Changed the argument suffix convention from "*" to "+" to represent one or more arguments as:
 1. It follows the Regular expression convention ("*" means 0 or more)
 2. It is what was missing in terms of functionality
NB Currently, no command is using the "*/+", but it is a good thing to have to help out the validation of the args if/when in the future
we have such need

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: Improved --help functionality
Giampaolo Lauria [Mon, 18 Jul 2011 19:45:39 +0000 (15:45 -0400)]
samba-tool: Improved --help functionality

Added a new --help msg
Return an error when no subcommand is specified

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: fixed __doc__ in base classes
Giampaolo Lauria [Mon, 18 Jul 2011 15:50:48 +0000 (11:50 -0400)]
samba-tool: fixed __doc__ in base classes

Replaced the "net" word with %prog in all instances

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: Fix error handling in SuperCommand class
Giampaolo Lauria [Mon, 18 Jul 2011 15:30:23 +0000 (11:30 -0400)]
samba-tool: Fix error handling in SuperCommand class

Created show_command_error method to handle errors in SuperCommand
Removed statement in SuperCommand to raise exception

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: improved Option list for all user commands
Giampaolo Lauria [Mon, 18 Jul 2011 14:03:16 +0000 (10:03 -0400)]
samba-tool: improved Option list for all user commands

Added metavar values for -H and added some default values for other options

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: added error handling for the user command
Giampaolo Lauria [Fri, 15 Jul 2011 19:23:36 +0000 (15:23 -0400)]
samba-tool: added error handling for the user command

Caught exception whenever possible, added new check for newpassword to make sure it contains some chars

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: fixed drs commands synopsis
Giampaolo Lauria [Fri, 15 Jul 2011 18:20:03 +0000 (14:20 -0400)]
samba-tool: fixed drs commands synopsis

Added [options] as needed

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: fixed samba-tool user syntax
Andrew Tridgell [Thu, 21 Jul 2011 00:29:40 +0000 (10:29 +1000)]
samba-tool: fixed samba-tool user syntax

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba-tool: fixed synopsis on user commands
Giampaolo Lauria [Fri, 15 Jul 2011 17:58:00 +0000 (13:58 -0400)]
samba-tool: fixed synopsis on user commands

Fixed all synopsis to contain [options], filter, and username

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: fixed synopsis on all "user" commands
Giampaolo Lauria [Fri, 15 Jul 2011 17:46:27 +0000 (13:46 -0400)]
samba-tool: fixed synopsis on all "user" commands

Added [options] where needed, fixed others where filter or username was needed, renamed name to username

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: moved takes_optiongroups definition to Command base class
Giampaolo Lauria [Fri, 15 Jul 2011 16:07:03 +0000 (12:07 -0400)]
samba-tool: moved takes_optiongroups definition to Command base class

The option groups should be defined at the Command base class level as they are in common across all samba-tool commands.
Major move advantages:
1. more OOP approach
2. enforcing consistency across commands
3. avoiding the need of declaring for every new command

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: removed the assignment to parser.prog
Giampaolo Lauria [Fri, 15 Jul 2011 13:47:51 +0000 (09:47 -0400)]
samba-tool: removed the assignment to parser.prog

The prog should only be set if we want it to be different than the name of the program that executed it. I think that for better portability we should not set it and let it default to samba-tool.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: fixed prog name in samba-tool
Giampaolo Lauria [Wed, 6 Jul 2011 18:13:39 +0000 (14:13 -0400)]
samba-tool: fixed prog name in samba-tool

Changed the prog name from net to samba-tool so that the usage statement is now correct

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: update vampire.py message
Giampaolo Lauria [Tue, 28 Jun 2011 19:14:16 +0000 (15:14 -0400)]
samba-tool: update vampire.py message

The update was necessary to reflect the move from join to domain join as part of the object-action work

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: removed join as it has been replaced by domain join
Giampaolo Lauria [Tue, 28 Jun 2011 19:09:04 +0000 (15:09 -0400)]
samba-tool: removed join as it has been replaced by domain join

This is part of the samba-tool work to fit the object-action model

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: moved join to domain join
Giampaolo Lauria [Tue, 28 Jun 2011 19:06:41 +0000 (15:06 -0400)]
samba-tool: moved join to domain join

This is part of the samba-tool work to fit the object-action model

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: updated test suite for the new domain dumpkeys option
Giampaolo Lauria [Tue, 28 Jun 2011 16:29:09 +0000 (12:29 -0400)]
samba-tool: updated test suite for the new domain dumpkeys option

The test suite has been changed to reflect the move from export to "domain dumpkeys" to reflect the object-action model

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: removed export as it has been moved to domain dumpkeys
Giampaolo Lauria [Tue, 28 Jun 2011 16:22:39 +0000 (12:22 -0400)]
samba-tool: removed export as it has been moved to domain dumpkeys

The functionality of export has been moved to domain dumpkeys to fit the object-action model

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: moved export to domain dumpkeys
Giampaolo Lauria [Tue, 28 Jun 2011 16:19:08 +0000 (12:19 -0400)]
samba-tool: moved export to domain dumpkeys

This is part of the samba-tool work to fit the object-action model

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: updated test suite to reflect the move from domainlevel to domain level
Giampaolo Lauria [Tue, 28 Jun 2011 15:53:15 +0000 (11:53 -0400)]
samba-tool: updated test suite to reflect the move from domainlevel to domain level

The test suite needs to reflect the change from domailevel to "domain level" to fit the object-action model

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agosamba-tool: removed domainlevel as it has been moved to domain level
Giampaolo Lauria [Tue, 28 Jun 2011 15:48:13 +0000 (11:48 -0400)]
samba-tool: removed domainlevel as it has been moved to domain level

The functionality of domainlevel has been moved the "domain level" to fit the object-action model

Signed-off-by: Andrew Tridgell <tridge@samba.org>