From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 28 Apr 2014 09:03:40 +0000 (+1200)
Subject: winbindd: Remove pointless if statement
X-Git-Tag: tdb-1.3.1~1130
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=e85ab6851893c9d3cef2272268d69cad3ef30ee7

winbindd: Remove pointless if statement

Change-Id: I7d2646078f6e7ba596b92da7d37c285d10ad38c0
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index e5504349423..78843d62a46 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -46,13 +46,11 @@ static NTSTATUS open_internal_samr_pipe(TALLOC_CTX *mem_ctx,
 	struct auth_session_info *session_info = NULL;
 	NTSTATUS status;
 
-	if (session_info == NULL) {
-		status = make_session_info_system(mem_ctx, &session_info);
-		if (!NT_STATUS_IS_OK(status)) {
-			DEBUG(0, ("open_samr_pipe: Could not create auth_session_info: %s\n",
-				  nt_errstr(status)));
-			return status;
-		}
+	status = make_session_info_system(mem_ctx, &session_info);
+	if (!NT_STATUS_IS_OK(status)) {
+		DEBUG(0, ("open_samr_pipe: Could not create auth_session_info: %s\n",
+			  nt_errstr(status)));
+		return status;
 	}
 
 	/* create a samr connection */
@@ -123,13 +121,11 @@ static NTSTATUS open_internal_lsa_pipe(TALLOC_CTX *mem_ctx,
 	struct auth_session_info *session_info = NULL;
 	NTSTATUS status;
 
-	if (session_info == NULL) {
-		status = make_session_info_system(mem_ctx, &session_info);
-		if (!NT_STATUS_IS_OK(status)) {
-			DEBUG(0, ("open_lsa_pipe: Could not create auth_session_info: %s\n",
-				  nt_errstr(status)));
-			return status;
-		}
+	status = make_session_info_system(mem_ctx, &session_info);
+	if (!NT_STATUS_IS_OK(status)) {
+		DEBUG(0, ("open_lsa_pipe: Could not create auth_session_info: %s\n",
+			  nt_errstr(status)));
+		return status;
 	}
 
 	/* create a lsa connection */