git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e35d54f) | patch
s3:libsmb_xattr: ace_compare() uses NUMERIC_CMP()
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 4 Apr 2024 01:33:47 +0000 (14:33 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 10 Apr 2024 23:58:12 +0000 (23:58 +0000)
commit81598b42455d6758941da532c668b6d4e969cc40
tree319f25ea47c90798b725c68f1fc4139ea0921396tree
parente35d54fd4d381df67ab9b4f8390e2109b2142678commit | diff
s3:libsmb_xattr: ace_compare() uses NUMERIC_CMP()

the access_mask is the easiest to overflow with subtraction -- other
fields are 8 or 16 bit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Apr 10 23:58:12 UTC 2024 on atb-devel-224
source3/libsmb/libsmb_xattr.c diff | blob | history
Samba Shared Repository