s3:libads: Remove ‘unicodePwd’ attribute from ads_find_machine_acct() search
authorJo Sutton <josutton@catalyst.net.nz>
Thu, 18 Jan 2024 23:38:24 +0000 (12:38 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 16 Feb 2024 02:41:36 +0000 (02:41 +0000)
commit635f6baf7bccc64da5fa8591dee41c379f83601b
tree97e51f6d24c7d7fe5f93a2f2b0dd8a3914659f96
parent059cb760b033ae1e570128a9c546acbdc9a43ec2
s3:libads: Remove ‘unicodePwd’ attribute from ads_find_machine_acct() search

This attribute was added to the search in commit
4f389c1f78cdc2424795e3b2a1ce43818c400c2d. But it’s not clear to me that
anything actually retrieves the unicodePwd from the result (excluding
inconsequential things like ads_dump()).

Furthermore, this being a search over LDAP, it will never return a
unicodePwd.

Removing this attribute from the search means that we no longer have to
worry about the account possibly being a Group Managed Service Account
and the unicodePwd being out‐of‐date.

Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/libads/ldap.c