s3: modules: gluster. Fix the error I made in preventing talloc leaks from a function.
authorJeremy Allison <jra@samba.org>
Tue, 10 Nov 2020 18:18:18 +0000 (10:18 -0800)
committerGünther Deschner <gd@samba.org>
Wed, 11 Nov 2020 15:02:27 +0000 (15:02 +0000)
commit457b49c67803dd95abc8502c2a410fac273f6fba
treeed870ace866b683ba3cfcf4024cc349c1c36444b
parent31c703766fd2b89737826fb7e9a707f0622bb8cd
s3: modules: gluster. Fix the error I made in preventing talloc leaks from a function.

file_lines_parse() plays horrible tricks with
the passed-in talloc pointers and the hierarcy
which makes freeing hard to get right.

As we know mem_ctx is freed by the caller, after
calling file_lines_parse don't free on exit and let the caller
handle it. This violates good Samba coding practice
but we know we're not leaking here.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Nov 11 15:02:27 UTC 2020 on sn-devel-184
source3/modules/vfs_glusterfs.c