smbclient: fix string formatting in print command

[samba.git] / source4 / client / client.c

diff --git a/source4/client/client.c b/source4/client/client.c
index 4807123b50fc56f99099af4a06d79aae359c2509..cfc85cde2aa3c3add899cc8617d5678aa8d6cf92 100644 (file)
--- a/source4/client/client.c
+++ b/source4/client/client.c
@@ -1534,15 +1534,26 @@ static int cmd_print(struct smbclient_context *ctx, const char **args)
        }
 
        lname = talloc_strdup(ctx, args[1]);
+       if (lname == NULL) {
+               d_printf("Out of memory in cmd_print\n");
+               return 1;
+       }
 
-       rname = talloc_strdup(ctx, lname);
-       p = strrchr_m(rname,'/');
-       if (p) {
-               slprintf(rname, sizeof(rname)-1, "%s-%d", p+1, (int)getpid());
+       if (strequal(lname, "-")) {
+               rname = talloc_asprintf(ctx, "stdin-%d", (int)getpid());
+       } else {
+               p = strrchr_m(lname, '/');
+               if (p) {
+                       rname = talloc_asprintf(ctx, "%s-%d", p + 1,
+                                               (int)getpid());
+               } else {
+                       rname = talloc_strdup(ctx, lname);
+               }
        }
 
-       if (strequal(lname,"-")) {
-               slprintf(rname, sizeof(rname)-1, "stdin-%d", (int)getpid());
+       if (rname == NULL) {
+               d_printf("Out of memory in cmd_print (stdin)\n");
+               return 1;
        }
 
        return do_put(ctx, rname, lname, false);