updated the 3.0 branch from the head branch - ready for alpha18

[samba.git] / source3 / CodingSuggestions

diff --git a/source3/CodingSuggestions b/source3/CodingSuggestions
index 48c51281f524a507c300e8565a945456bc778080..eda2bee6d009c193acc99cad94bd6f2bdc833b8c 100644 (file)
--- a/source3/CodingSuggestions
+++ b/source3/CodingSuggestions
@@ -59,6 +59,11 @@ Here are some other suggestions:
 6) explicitly add const qualifiers on parm passing in functions where parm
    is input only (somewhat controversial but const can be #defined away)
 
+7) when passing a va_list as an arg, or assigning one to another
+   please use the VA_COPY() macro
+       reason: on some platforms, va_list is a struct that must be 
+               initialized in each function...can SEGV if you don't.
+
 8) discourage use of threads
         reason: portability (also see architecture.doc)