ctdb-common: Fix signed/unsigned comparisons by casting

[samba.git] / ctdb / common / ctdb_util.c

diff --git a/ctdb/common/ctdb_util.c b/ctdb/common/ctdb_util.c
index 0f367c2100ed6e3f2c0988122ee141359d69dbc2..3f8fff925f0d2b2368d521700d3269880f337e80 100644 (file)
--- a/ctdb/common/ctdb_util.c
+++ b/ctdb/common/ctdb_util.c
@@ -111,7 +111,10 @@ bool ctdb_set_helper(const char *type, char *helper, size_t size,
                              ("Unable to set %s - dir is NULL\n", type));
                return false;
        } else {
-               if (snprintf(helper, size, "%s/%s", dir, file) >= size) {
+               int ret;
+
+               ret = snprintf(helper, size, "%s/%s", dir, file);
+               if (ret < 0 || (size_t)ret >= size) {
                        DEBUG(DEBUG_ERR,
                              ("Unable to set %s - path too long\n", type));
                        return false;