git.samba.org
/
mat
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4dd97c7
)
s4-dsdb: Add a warning about dsdb_module_rename that locks if olddn == newdn
author
Matthieu Patou
<mat@matws.net>
Fri, 13 May 2011 00:15:22 +0000
(
04:15
+0400)
committer
Matthieu Patou
<mat@matws.net>
Sun, 22 May 2011 19:35:54 +0000
(23:35 +0400)
source4/dsdb/samdb/ldb_modules/util.c
patch
|
blob
|
history
diff --git
a/source4/dsdb/samdb/ldb_modules/util.c
b/source4/dsdb/samdb/ldb_modules/util.c
index 49939e2ff457b75dbc681866192209a679f31621..97e41e783985e175b7e4b75d41cd6419cca08a99 100644
(file)
--- a/
source4/dsdb/samdb/ldb_modules/util.c
+++ b/
source4/dsdb/samdb/ldb_modules/util.c
@@
-336,6
+336,8
@@
int dsdb_module_modify(struct ldb_module *module,
/*
a ldb_rename request operating on modules below the
current module
+ FIXME we have a bug here when olddn == newdn as we are
+ blocked in a wait event and can never escape
*/
int dsdb_module_rename(struct ldb_module *module,
struct ldb_dn *olddn, struct ldb_dn *newdn,