dm io: fix a race condition in the wake up code for sync_io
authorJoe Thornber <thornber@redhat.com>
Fri, 27 Jun 2014 19:29:04 +0000 (15:29 -0400)
committerMike Snitzer <snitzer@redhat.com>
Thu, 10 Jul 2014 20:44:14 +0000 (16:44 -0400)
commit10f1d5d111e8aed46a0f1179faf9a3cf422f689e
tree5f91052d29b60c0959ea135708f2791d6fda6639
parentbf14299f1ce96c9d632533c4557303f8a74afc9e
dm io: fix a race condition in the wake up code for sync_io

There's a race condition between the atomic_dec_and_test(&io->count)
in dec_count() and the waking of the sync_io() thread.  If the thread
is spuriously woken immediately after the decrement it may exit,
making the on stack io struct invalid, yet the dec_count could still
be using it.

Fix this race by using a completion in sync_io() and dec_count().

Reported-by: Minfei Huang <huangminfei@ucloud.cn>
Signed-off-by: Joe Thornber <thornber@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-io.c