From 0e0514f6215101a221e387824fec97c691b99970 Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Wed, 3 Dec 2014 00:07:56 +0000 Subject: [PATCH] Remove some code from _py3_compat. --- dulwich/_py3_compat.py | 12 ------------ dulwich/objects.py | 3 --- dulwich/refs.py | 3 +-- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/dulwich/_py3_compat.py b/dulwich/_py3_compat.py index d999e07e..b6287a67 100644 --- a/dulwich/_py3_compat.py +++ b/dulwich/_py3_compat.py @@ -25,18 +25,11 @@ PY3 = sys.version_info[0] == 3 if PY2: text_type = unicode - #string_types = (str, unicode) - #unichr = unichr - integer_types = (int, long) else: text_type = str - #string_types = (str,) - #unichr = chr - integer_types = (int, ) if PY2: - int2byte = chr def byte2int(bs): return ord(bs[0]) def indexbytes(buf, i): @@ -44,18 +37,13 @@ if PY2: def iterbytes(buf): return (ord(byte) for byte in buf) else: - int2byte = operator.methodcaller("to_bytes", 1, "big") byte2int = operator.itemgetter(0) indexbytes = operator.getitem iterbytes = iter if PY2: - keys = lambda d: d.iterkeys() - values = lambda d: d.itervalues() items = lambda d: d.iteritems() else: - keys = lambda d: d.keys() - values = lambda d: d.values() items = lambda d: d.items() diff --git a/dulwich/objects.py b/dulwich/objects.py index 10ff8ff2..75538242 100644 --- a/dulwich/objects.py +++ b/dulwich/objects.py @@ -41,7 +41,6 @@ from dulwich.file import GitFile from dulwich._py3_compat import ( byte2int, indexbytes, - integer_types, iterbytes, items, text_type, @@ -821,8 +820,6 @@ def sorted_tree_items(entries, name_order): for name, entry in sorted(items(entries), key=key_func): mode, hexsha = entry # Stricter type checks than normal to mirror checks in the C version. - if not isinstance(mode, integer_types): - raise TypeError('Expected integer/long for mode, got %r' % mode) mode = int(mode) if not isinstance(hexsha, bytes): raise TypeError('Expected bytes for SHA, got %r' % hexsha) diff --git a/dulwich/refs.py b/dulwich/refs.py index 6eea4639..20b71112 100644 --- a/dulwich/refs.py +++ b/dulwich/refs.py @@ -39,7 +39,6 @@ from dulwich.file import ( from dulwich._py3_compat import ( iterbytes, items, - keys, ) @@ -733,7 +732,7 @@ def write_packed_refs(f, packed_refs, peeled_refs=None): peeled_refs = {} else: f.write(b'# pack-refs with: peeled\n') - for refname in sorted(keys(packed_refs)): + for refname in sorted(packed_refs.keys()): f.write(git_line(packed_refs[refname], refname)) if refname in peeled_refs: f.write(b'^' + peeled_refs[refname] + b'\n') -- 2.34.1