mount.cifs: check_newline returns EX_USAGE on error, not -1
authorJeff Layton <jlayton@samba.org>
Fri, 29 Jul 2011 11:12:48 +0000 (07:12 -0400)
committerJeff Layton <jlayton@samba.org>
Fri, 29 Jul 2011 11:12:48 +0000 (07:12 -0400)
Reported-by: Jan Lieskovsky <jlieskov@redhat.com>
Signed-off-by: Jeff Layton <jlayton@samba.org>
mount.cifs.c

index 107a5a5..aa4581f 100644 (file)
@@ -1419,8 +1419,7 @@ static int check_newline(const char *progname, const char *name)
 static int check_mtab(const char *progname, const char *devname,
                      const char *dir)
 {
-       if (check_newline(progname, devname) == -1 ||
-           check_newline(progname, dir) == -1)
+       if (check_newline(progname, devname) || check_newline(progname, dir))
                return EX_USAGE;
        return 0;
 }