s3: Avoid a ton of registry writes at startup

[amitay/samba.git] / source3 / services / services_db.c

diff --git a/source3/services/services_db.c b/source3/services/services_db.c
index ca375d22d48a8c9cc3a53bacf706221adcee50b1..03f7951b7c20fc39a43a6d41355fbb0b75dfd9e4 100644 (file)
--- a/source3/services/services_db.c
+++ b/source3/services/services_db.c
@@ -270,6 +270,24 @@ static WERROR svcctl_setvalue(struct registry_key *key,
                              struct registry_value *value)
 {
        WERROR wresult;
+       struct registry_value *existing;
+
+       wresult = reg_queryvalue(talloc_tos(), key, name, &existing);
+       if (W_ERROR_IS_OK(wresult)) {
+               bool exists;
+
+               exists = ((value->type == existing->type) &&
+                         (data_blob_cmp(&value->data, &existing->data) == 0));
+
+               TALLOC_FREE(existing);
+
+               if (exists) {
+                       /*
+                        * Avoid an expensive write when not necessary
+                        */
+                       return WERR_OK;
+               }
+       }
 
        wresult = reg_setvalue(key, name, value);
        if (!W_ERROR_IS_OK(wresult)) {