r20090: Fix a class of bugs found by James Peach. Ensure

[amitay/samba.git] / source3 / lib / system_smbd.c

diff --git a/source3/lib/system_smbd.c b/source3/lib/system_smbd.c
index fc506c901db624dc41f50ea787e9b271d4c301fc..509b2bbcb1e9e960cc9f3f6ab097b61921d2dc94 100644 (file)
--- a/source3/lib/system_smbd.c
+++ b/source3/lib/system_smbd.c
@@ -181,11 +181,18 @@ BOOL getgroups_unix_user(TALLOC_CTX *mem_ctx, const char *user,
        groups = NULL;
 
        /* Add in primary group first */
-       add_gid_to_array_unique(mem_ctx, primary_gid, &groups, &ngrp);
+       if (!add_gid_to_array_unique(mem_ctx, primary_gid, &groups, &ngrp)) {
+               SAFE_FREE(temp_groups);
+               return False;
+       }
 
-       for (i=0; i<max_grp; i++)
-               add_gid_to_array_unique(mem_ctx, temp_groups[i],
-                                       &groups, &ngrp);
+       for (i=0; i<max_grp; i++) {
+               if (!add_gid_to_array_unique(mem_ctx, temp_groups[i],
+                                       &groups, &ngrp)) {
+                       SAFE_FREE(temp_groups);
+                       return False;
+               }
+       }
 
        *p_ngroups = ngrp;
        *ret_groups = groups;