abartlet/samba.git/.git
16 years agor23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Jeremy Allison [Wed, 11 Jul 2007 21:01:06 +0000 (21:01 +0000)]
r23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Doing a DFS traverse through a deep link could fail (not using
explorer).
Jeremy.
(This used to be commit cd93f0cb00207098014e41e0ba16210cb150b895)

16 years agor23842: Attempt to fix the build with LDAP.
Günther Deschner [Wed, 11 Jul 2007 15:46:01 +0000 (15:46 +0000)]
r23842: Attempt to fix the build with LDAP.

Guenther
(This used to be commit efd817ae118da51058106ae97854572547e113d3)

16 years agor23841: Show all acl types when displaying a security descriptor.
Günther Deschner [Wed, 11 Jul 2007 15:23:51 +0000 (15:23 +0000)]
r23841: Show all acl types when displaying a security descriptor.

Guenther
(This used to be commit 06418a63a0bf5df0e0e76172137d5dff026feaa6)

16 years agor23840: Fix the build.
Günther Deschner [Wed, 11 Jul 2007 14:35:48 +0000 (14:35 +0000)]
r23840: Fix the build.

Guenther
(This used to be commit 07bce671214359ac3016fd03979edd88c2ceb24b)

16 years agor23839: Try to get the attribute name from schema GUIDs or the display name from
Günther Deschner [Wed, 11 Jul 2007 13:41:04 +0000 (13:41 +0000)]
r23839: Try to get the attribute name from schema GUIDs or the display name from
extended rights GUID from ad while dumping the security descriptors's aces.

This would perform much better with a guid cache, but for the rare cases where
it is used

net ads search cn=mymachine ntSecurityDescriptor -U user%pass

it should be ok for now.

Guenther
(This used to be commit b36913433eb74203b29f2b7d412a86e60591ea22)

16 years agor23838: Allow to store schema and config path in ADS_STRUCT config.
Günther Deschner [Wed, 11 Jul 2007 13:32:57 +0000 (13:32 +0000)]
r23838: Allow to store schema and config path in ADS_STRUCT config.

Guenther
(This used to be commit 1d5b08326fa72bd3423b377a4e6243466e778622)

16 years agor23837: Pass ADS_STRUCT and TALLOC_CTX down to ads_disp_sd.
Günther Deschner [Wed, 11 Jul 2007 13:30:38 +0000 (13:30 +0000)]
r23837: Pass ADS_STRUCT and TALLOC_CTX down to ads_disp_sd.

Guenther
(This used to be commit ad0a6d5703c35d48ab5bbfa8d6506d42e0cfb61d)

16 years agor23836: Add ads_config_path() and ads_get_extended_right_name_by_guid().
Günther Deschner [Wed, 11 Jul 2007 13:26:04 +0000 (13:26 +0000)]
r23836: Add ads_config_path() and ads_get_extended_right_name_by_guid().

Guenther
(This used to be commit 4d62f1191b52569fcdbe674773b07a44aa469520)

16 years agor23835: Pass down a struct GUID to ads_get_attrname_by_guid() directly.
Günther Deschner [Wed, 11 Jul 2007 13:23:56 +0000 (13:23 +0000)]
r23835: Pass down a struct GUID to ads_get_attrname_by_guid() directly.

Guenther
(This used to be commit a4d5206d0bcbee713790834f119b182e0b419e8c)

16 years agor23834: Allow to pass an ADS_STRUCT pointer down to the dump function callback in
Günther Deschner [Wed, 11 Jul 2007 13:21:32 +0000 (13:21 +0000)]
r23834: Allow to pass an ADS_STRUCT pointer down to the dump function callback in
libads.

Guenther
(This used to be commit 311bbbafa6d860b7b632beac6d9249b0a2fafb86)

16 years agor23833: Document ads_find_samaccount().
Günther Deschner [Wed, 11 Jul 2007 13:17:42 +0000 (13:17 +0000)]
r23833: Document ads_find_samaccount().

Guenther
(This used to be commit 3effd1c3461301f9ccf7c55386810c36f4ee3ccc)

16 years agor23831: Fix vfs_readahead: transparent modules should always pass through
Alexander Bokovoy [Wed, 11 Jul 2007 12:04:55 +0000 (12:04 +0000)]
r23831: Fix vfs_readahead: transparent modules should always pass through
(This used to be commit 800cf5c81c12985922f34610473d746458c85f90)

16 years agor23829: Add ads_get_attrname_by_guid().
Günther Deschner [Wed, 11 Jul 2007 10:26:02 +0000 (10:26 +0000)]
r23829: Add ads_get_attrname_by_guid().

Guenther
(This used to be commit a84fd8300661fd895ed7a8a104b743628718dfc8)

16 years agor23828: Add entry and exit debug statments to tdb_validate
Michael Adam [Wed, 11 Jul 2007 10:08:17 +0000 (10:08 +0000)]
r23828: Add entry and exit debug statments to tdb_validate
at a lower debug level.

Michael
(This used to be commit b636f8cdad72a9a9bc1d302d8d681dca2da6105a)

16 years agor23827: Fix schema dump.
Günther Deschner [Wed, 11 Jul 2007 09:49:10 +0000 (09:49 +0000)]
r23827: Fix schema dump.

Guenther
(This used to be commit e3d6dabcb9786ae81f2736815a3b576a962eef3b)

16 years agor23826: Fix gpo security filtering by matching the security descriptor ace's for the
Günther Deschner [Wed, 11 Jul 2007 09:39:08 +0000 (09:39 +0000)]
r23826: Fix gpo security filtering by matching the security descriptor ace's for the
extended apply group policy right.

Guenther
(This used to be commit d832014a6fef657f484412372b5d09047552b183)

16 years agor23825: Add ".." command as an alias to "cd ..".
Günther Deschner [Wed, 11 Jul 2007 08:43:08 +0000 (08:43 +0000)]
r23825: Add ".." command as an alias to "cd ..".

Guenther
(This used to be commit c254c5e2549b2a4fe4895b467c4802f4b8ddb2f3)

16 years agor23824: Add ls alias for lazy typers like me.
Günther Deschner [Wed, 11 Jul 2007 08:31:03 +0000 (08:31 +0000)]
r23824: Add ls alias for lazy typers like me.

Guenther
(This used to be commit cdec09956c941d7ea9d67dc03959f2bdf9a37cb2)

16 years agor23823: Memory leak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Volker Lendecke [Wed, 11 Jul 2007 06:18:32 +0000 (06:18 +0000)]
r23823: Memory leak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>

Thanks!

Volker
(This used to be commit 17b875ae5bab9473f0f896e63fff4a65588c2fb8)

16 years agor23822: Clean some debugging output (as well in content and
Michael Adam [Tue, 10 Jul 2007 23:00:04 +0000 (23:00 +0000)]
r23822: Clean some debugging output (as well in content and
amount as in source code formatting...)

Michael
(This used to be commit 9794b94ebf79686da2e1b3ae343953581e3459a1)

16 years agor23820: Display security_ace_object in LDAP security descriptors for debugging.
Günther Deschner [Tue, 10 Jul 2007 21:04:57 +0000 (21:04 +0000)]
r23820: Display security_ace_object in LDAP security descriptors for debugging.

Guenther
(This used to be commit 3925e85812b2aded356866925382b1beb718cd44)

16 years agor23819: It is currently unnecessary to pass the extended validation status
Michael Adam [Tue, 10 Jul 2007 16:41:26 +0000 (16:41 +0000)]
r23819: It is currently unnecessary to pass the extended validation status
from the validating child process down to the parent though the
pipe. All the parent evaluates is the overall success, so the exit
status should do.

Michael
(This used to be commit 9415ea0fde2ff0c801d043ce77b778fceedb6592)

16 years agor23818: support LDAP_SERVER_SEARCH_OPTIONS_OID in adssearch.
Günther Deschner [Tue, 10 Jul 2007 15:14:32 +0000 (15:14 +0000)]
r23818: support LDAP_SERVER_SEARCH_OPTIONS_OID in adssearch.

Guenther
(This used to be commit 0f0200c43cdf3f7ced17e2dffdce7f4a4e8f533f)

16 years agor23817: Dump some more guids in adssearch.pl.
Günther Deschner [Tue, 10 Jul 2007 15:13:13 +0000 (15:13 +0000)]
r23817: Dump some more guids in adssearch.pl.

Guenther
(This used to be commit 3f0ac6a27f03c5115f51d1b0a740f5f8ee0fb793)

16 years agor23814: Fix a couple of comments and debug messages.
Michael Adam [Tue, 10 Jul 2007 12:34:12 +0000 (12:34 +0000)]
r23814: Fix a couple of comments and debug messages.
(This used to be commit ef40ef67649c8793921619c128e2923e20aa68da)

16 years agor23813: Remove unused global variable
Volker Lendecke [Tue, 10 Jul 2007 12:22:44 +0000 (12:22 +0000)]
r23813: Remove unused global variable
(This used to be commit 3b811134c02ff9b24d3e36c1ff94b32946c6183c)

16 years agor23808: Make us a bit more C++ friendly. Thanks to Constantine Vetoshev
Volker Lendecke [Tue, 10 Jul 2007 08:56:13 +0000 (08:56 +0000)]
r23808: Make us a bit more C++ friendly. Thanks to Constantine Vetoshev
<gepardcv@yahoo.com> for checking.
(This used to be commit 84b8a56fe9aef1e0583cf5f5abb037199cf21fd9)

16 years agor23804: here too
Andrew Tridgell [Tue, 10 Jul 2007 07:19:47 +0000 (07:19 +0000)]
r23804: here too
(This used to be commit e5d18768a014753c439ba6be24a52b04fed63b31)

16 years agor23802: fixed URL in XML
Andrew Tridgell [Tue, 10 Jul 2007 05:42:52 +0000 (05:42 +0000)]
r23802: fixed URL in XML
(This used to be commit 256301a21a1f393b5a2b89d4dce47b7d4f7bf9be)

16 years agor23801: The FSF has moved around a lot. This fixes their Mass Ave address.
Andrew Tridgell [Tue, 10 Jul 2007 05:23:25 +0000 (05:23 +0000)]
r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)

16 years agor23800: LGPL is now called GNU Lesser General Public License
Andrew Tridgell [Tue, 10 Jul 2007 04:04:46 +0000 (04:04 +0000)]
r23800: LGPL is now called GNU Lesser General Public License
not GNU Library General Public License
(This used to be commit 727a6cf2cba8da6b40610409b264e86e6908eb0c)

16 years agor23799: updated old Franklin Street FSF addresses to new URL
Andrew Tridgell [Tue, 10 Jul 2007 03:52:17 +0000 (03:52 +0000)]
r23799: updated old Franklin Street FSF addresses to new URL
(This used to be commit 43cd589773148fe3d243892768ce187604dd0c33)

16 years agor23798: updated old Temple Place FSF addresses to new URL
Andrew Tridgell [Tue, 10 Jul 2007 03:42:26 +0000 (03:42 +0000)]
r23798: updated old Temple Place FSF addresses to new URL
(This used to be commit c676a971142d7176fd5dbf21405fca14515a0a76)

16 years agor23797: started fixing old FSF addresses. Fixed pcap2nbench COPYING file
Andrew Tridgell [Tue, 10 Jul 2007 03:17:46 +0000 (03:17 +0000)]
r23797: started fixing old FSF addresses. Fixed pcap2nbench COPYING file
(This used to be commit e87bb12093dc78eb539fac0a171379a8cb5cd416)

16 years agor23795: more v2->v3 conversion
Andrew Tridgell [Tue, 10 Jul 2007 02:46:15 +0000 (02:46 +0000)]
r23795: more v2->v3 conversion
(This used to be commit c14aba93c06348a1f84fc1dd9791ff1159d22c4b)

16 years agor23794: convert more code from LGPLv2+ to LGPLv3+
Andrew Tridgell [Tue, 10 Jul 2007 02:31:50 +0000 (02:31 +0000)]
r23794: convert more code from LGPLv2+ to LGPLv3+
(This used to be commit f3df6cd87e1927f41e95af51d750a71278282e15)

16 years agor23793: fixed incorrect v2-only licensing template for debian packaging files
Andrew Tridgell [Tue, 10 Jul 2007 02:13:59 +0000 (02:13 +0000)]
r23793: fixed incorrect v2-only licensing template for debian packaging files
(This used to be commit 5b65d85a24e93cc01870f330dfe5c21bb4abee7e)

16 years agor23791: found some more v2->v3 conversions
Andrew Tridgell [Tue, 10 Jul 2007 01:52:05 +0000 (01:52 +0000)]
r23791: found some more v2->v3 conversions
(This used to be commit b6cbac3db3b478d5c7991cee78c6695fc8d22681)

16 years agor23790: LGPLv3+ conversion for our LGPLv2+ library code
Andrew Tridgell [Tue, 10 Jul 2007 01:44:42 +0000 (01:44 +0000)]
r23790: LGPLv3+ conversion for our LGPLv2+ library code
(This used to be commit 1b78cace504f60c0f525765fbf59d9cc6506cd4d)

16 years agor23789: more pcp files under v2-only
Andrew Tridgell [Tue, 10 Jul 2007 01:39:08 +0000 (01:39 +0000)]
r23789: more pcp files under v2-only
(This used to be commit daf19b11d5ff84c1ad63a21094c19b1e3c25f8b3)

16 years agor23788: the pcp Makefile is also GPLv2 only.
Andrew Tridgell [Tue, 10 Jul 2007 01:36:33 +0000 (01:36 +0000)]
r23788: the pcp Makefile is also GPLv2 only.
(This used to be commit 9c83de5593ad91f1d4997148c680067fd2b6d12d)

16 years agor23787: Remove the pcp example code until SGI have given us approval to use it
Andrew Tridgell [Tue, 10 Jul 2007 01:18:53 +0000 (01:18 +0000)]
r23787: Remove the pcp example code until SGI have given us approval to use it
under GPLv3
(This used to be commit 5c5d5bdf7f2fbe02a185b12989c88b18d7758fcb)

16 years agor23786: Use linux/dqblk_xfs.h rather than a private copy of this header in the
Andrew Tridgell [Tue, 10 Jul 2007 01:15:57 +0000 (01:15 +0000)]
r23786: Use linux/dqblk_xfs.h rather than a private copy of this header in the
Samba3 tree.

This is neater, plus it avoids the need to get legal approval from SGI
to use their GPLv2-only code under GPLv3.

If/when SGI legal sort things out, we could consider adding back this
header for very old systems where linux/dqblk_xfs.h is not available.
(This used to be commit cb435543f84955be75368a3294bc6b627414d876)

16 years agor23785: use the GPLv3 boilerplate as recommended by the FSF and the license text
Andrew Tridgell [Tue, 10 Jul 2007 00:57:11 +0000 (00:57 +0000)]
r23785: use the GPLv3 boilerplate as recommended by the FSF and the license text
(This used to be commit d0e89d246d8e5e64196d6c1d16d39a70579ca42f)

16 years agor23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
Andrew Tridgell [Tue, 10 Jul 2007 00:52:41 +0000 (00:52 +0000)]
r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)

16 years agor23783: Processing the UAS change message was causing problems on ppc64 Linux
Andrew Tridgell [Tue, 10 Jul 2007 00:47:40 +0000 (00:47 +0000)]
r23783: Processing the UAS change message was causing problems on ppc64 Linux
systems. Rather than trying to fix this, it's much better just to
remove the code, as it serves no purpose at all (the message that is
generated is ignored by smbd).

This sort of parsing should really be done by PIDL generated code.
(This used to be commit 22e8404cef4961f7468a9f24e23024c827233b84)

16 years agor23782: I tested this against NT4 PDC, W2K Server, W2K3 Dc, and a Win XP std alone
Simo Sorce [Mon, 9 Jul 2007 22:15:22 +0000 (22:15 +0000)]
r23782: I tested this against NT4 PDC, W2K Server, W2K3 Dc, and a Win XP std alone
client and they all work with this code.
(This used to be commit 44e22581d731572d3fa260b92063922c59ce75db)

16 years agor23780: Find and fix more GPL2 -> GPL3.
Jeremy Allison [Mon, 9 Jul 2007 19:46:27 +0000 (19:46 +0000)]
r23780: Find and fix more GPL2 -> GPL3.
Jeremy.
(This used to be commit c2f7ab1c175ecff0cf44d0bbc4763ba9f7d7803f)

16 years agor23779: Change from v2 or later to v3 or later.
Jeremy Allison [Mon, 9 Jul 2007 19:25:36 +0000 (19:25 +0000)]
r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)

16 years agor23778: Change to GPLv3. Now to go through all internal source
Jeremy Allison [Mon, 9 Jul 2007 18:59:33 +0000 (18:59 +0000)]
r23778: Change to GPLv3. Now to go through all internal source
and headers. Probably will be a long day.... :-).
Jeremy.
(This used to be commit 2c713978a0c676b898db53bd307dd1585d3a5f84)

16 years agor23777: Set template release note files
Gerald Carter [Mon, 9 Jul 2007 18:28:46 +0000 (18:28 +0000)]
r23777: Set template release note files
(This used to be commit 4ff00a74f61eef03d513ee6142c94c717c1c9a85)

16 years agor23776: Setting version in 3.2 branch to 3.2.1pre1-SVN
Gerald Carter [Mon, 9 Jul 2007 18:26:53 +0000 (18:26 +0000)]
r23776: Setting version in 3.2 branch to 3.2.1pre1-SVN
Setting version in 3.2.0 branch to 3.2.0pre1-SVN
(This used to be commit 240b19c8caf3af35189e70e056c480112f0d5077)

16 years agor23773: One pstring a day...
Volker Lendecke [Mon, 9 Jul 2007 16:27:13 +0000 (16:27 +0000)]
r23773: One pstring a day...
(This used to be commit 0c3016d32b5277b901788b13aa7d3f4b647728f2)

16 years agor23772: Add ads_find_samaccount() helper function.
Günther Deschner [Mon, 9 Jul 2007 16:03:00 +0000 (16:03 +0000)]
r23772: Add ads_find_samaccount() helper function.

Guenther
(This used to be commit 6fafa64bea4ce6a7a5917fa02ed9c564a7c93ffb)

16 years agor23771: Merge useful W_ERROR_NOT_OK_RETURN macro from samba4.
Günther Deschner [Mon, 9 Jul 2007 15:53:08 +0000 (15:53 +0000)]
r23771: Merge useful W_ERROR_NOT_OK_RETURN macro from samba4.

Guenther
(This used to be commit 31d689b2486b23d73618f36febde3e17cba5ca59)

16 years agor23770: Some minor cleanups in libgpo
Günther Deschner [Mon, 9 Jul 2007 15:48:17 +0000 (15:48 +0000)]
r23770: Some minor cleanups in libgpo
(including some valgrind errors, uninitialized vars, etc.)

Guenther
(This used to be commit 1a2878db2d2fcdc53fa74fea48b82a1903e6a1f1)

16 years agor23769: Move removal of the tdb from the generic tdb_validate function
Michael Adam [Mon, 9 Jul 2007 15:34:46 +0000 (15:34 +0000)]
r23769: Move removal of the tdb from the generic tdb_validate function
to the caller (winbindd_validate_cache in this case).
Next, there will be a backup handling for the tdb files.

Michael
(This used to be commit 821bc84109625c9d85edee38fa26d16f9f0a0fe2)

16 years agor23768: Get rid of the three global variables for the case semantics. I think
Volker Lendecke [Mon, 9 Jul 2007 14:43:36 +0000 (14:43 +0000)]
r23768: Get rid of the three global variables for the case semantics. I think
this is really not worth globals.

Jeremy, please check for 3.0.26.
(This used to be commit 6e655500c05f2584094329a95ad5791160147fd9)

16 years agor23767: Add GTYPE_SECURITY_UNIVERSAL_GROUP to adsearch.pl as well.
Günther Deschner [Mon, 9 Jul 2007 13:31:32 +0000 (13:31 +0000)]
r23767: Add GTYPE_SECURITY_UNIVERSAL_GROUP to adsearch.pl as well.

Guenther
(This used to be commit 9535866f6ffda866d644855f44f8b987378c4395)

16 years agor23766: Add GTYPE_SECURITY_UNIVERSAL_GROUP define.
Günther Deschner [Mon, 9 Jul 2007 13:28:46 +0000 (13:28 +0000)]
r23766: Add GTYPE_SECURITY_UNIVERSAL_GROUP define.

Guenther
(This used to be commit 964acb2716e230172e716d8d24ee2f888930130d)

16 years agor23765: Another error-path restore_case_semantics().
Volker Lendecke [Mon, 9 Jul 2007 13:24:31 +0000 (13:24 +0000)]
r23765: Another error-path restore_case_semantics().
(This used to be commit a3e5fe1693a3e1830561d60254d6a3bfc0c30686)

16 years agor23764: Do restore_case_semantics in an error path. Jeremy, please check!
Volker Lendecke [Mon, 9 Jul 2007 13:04:44 +0000 (13:04 +0000)]
r23764: Do restore_case_semantics in an error path. Jeremy, please check!
(This used to be commit 3b5422c9a401321788d824c68da31a39d85aece1)

16 years agor23763: Fix a typo in DEBUG message.
Michael Adam [Mon, 9 Jul 2007 12:59:17 +0000 (12:59 +0000)]
r23763: Fix a typo in DEBUG message.
Thanks to Karolin Seeger (ks@sernet.de)
(This used to be commit 0ae6ae4ee8098abdfefc9fe7c3880bfbb6da52a8)

16 years agor23761: Rename reduce_name to check_reduced_name
Volker Lendecke [Mon, 9 Jul 2007 09:43:41 +0000 (09:43 +0000)]
r23761: Rename reduce_name to check_reduced_name

The function name reduce_name is misleading, making the user believe it
changes an argument.
(This used to be commit 68234f0bc6fb4d6d99ae94ff067db118c60804aa)

16 years agor23760: Untangle use of strrchr_m and strequal and add some checks
Michael Adam [Mon, 9 Jul 2007 09:35:03 +0000 (09:35 +0000)]
r23760: Untangle use of strrchr_m and strequal and add some checks
for the validity of the given registry key name.

Michael
(This used to be commit 4b4ba7724ee77a93e32cd7f3c5884d965fe9bcaa)

16 years agor23759: Fix make test -- sorry
Volker Lendecke [Mon, 9 Jul 2007 08:45:14 +0000 (08:45 +0000)]
r23759: Fix make test -- sorry
(This used to be commit cbbc70604e815f4ffd25d040ca0a4ef58e651523)

16 years agor23758: Fix Coverity id 385
Volker Lendecke [Mon, 9 Jul 2007 08:04:43 +0000 (08:04 +0000)]
r23758: Fix Coverity id 385
(This used to be commit 4d9f627cc8081307da3f84f784602533bd20c1e6)

16 years agor23757: Fix Coverity id 386
Volker Lendecke [Mon, 9 Jul 2007 08:00:50 +0000 (08:00 +0000)]
r23757: Fix Coverity id 386
(This used to be commit 91be38f7ab42991e04a41e91132137a834c10996)

16 years agor23756: Fix Coverity id 388
Volker Lendecke [Mon, 9 Jul 2007 07:55:09 +0000 (07:55 +0000)]
r23756: Fix Coverity id 388
(This used to be commit 91af086823265ed66bbd0bdc1cced070b7dd0629)

16 years agor23755: Fix Coverity id 384
Volker Lendecke [Mon, 9 Jul 2007 07:51:39 +0000 (07:51 +0000)]
r23755: Fix Coverity id 384
(This used to be commit ebb410ca1e08d6f062154c9f8b3970682c6eeebd)

16 years agor23752: Fix bug introduced by checkin 22920, allow large
Jeremy Allison [Mon, 9 Jul 2007 00:48:07 +0000 (00:48 +0000)]
r23752: Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <dhsatrov@linux.vnet.ibm.com>.

"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."

This isn't in shipping code.

Jeremy.
(This used to be commit af715c602a8ef6038e6272c7cc6a08501617ae67)

16 years agor23751: Call tdb_close even when validation was not successful.
Michael Adam [Sun, 8 Jul 2007 22:01:43 +0000 (22:01 +0000)]
r23751: Call tdb_close even when validation was not successful.

Michael
(This used to be commit b68856d9902f41079224ba11c7d0ab811b082201)

16 years agor23750: Change the behaviour of net conf import when there is a global section
Michael Adam [Sat, 7 Jul 2007 23:57:25 +0000 (23:57 +0000)]
r23750: Change the behaviour of net conf import when there is a global section
in the current registry and there is no global section in the input
file (or only global options with default values):
In that case the existing global section is now not touched. Before, it
would have been deleted and recreated empty. The new behaviour is how
other shares are treated too.

Note that since the input file is parsed by lp_load, there is currently
no way to distinguish between a section with only default parameters
and a non-existing section in net conf import.

Michael

PS: A couple of trailing white-spaces have been eliminated
and a line was broken to be not longer than 80 chars, too.
(This used to be commit ec21a0cf9f01986d333b50b883f2105e32cf7fc9)

16 years agor23749: Simplify prototype of reg_setvalue_internal:
Michael Adam [Sat, 7 Jul 2007 22:33:45 +0000 (22:33 +0000)]
r23749: Simplify prototype of reg_setvalue_internal:
eliminate "type" parameter since we store only REG_SZ.

Michael
(This used to be commit 65ce4633171eabd6fc94677cb7d884d6125d0745)

16 years agor23748: Clean use of talloc in import_process_service:
Michael Adam [Sat, 7 Jul 2007 22:29:34 +0000 (22:29 +0000)]
r23748: Clean use of talloc in import_process_service:
create a temporary talloc ctx for the function.

Michael
(This used to be commit 39df7faaa9472d565653b36203860eee8a259f2c)

16 years agor23747: Move formatting of a parameter's value into a value string
Michael Adam [Sat, 7 Jul 2007 22:18:54 +0000 (22:18 +0000)]
r23747: Move formatting of a parameter's value into a value string
to a function of its own. (for storing it in registry),
Eliminate the valtype variable : store everything as "sz".
Eliminate some trailing white spaces on the way.

Michael
(This used to be commit 76f4f224aa65b1414222818996e215ec80d117a4)

16 years agor23746: Fix missing assignments to target string of asprintf in import function.
Michael Adam [Sat, 7 Jul 2007 21:41:59 +0000 (21:41 +0000)]
r23746: Fix missing assignments to target string of asprintf in import function.

Michael
(This used to be commit 6b1bf7c1f49f737ca3cbee96b184e3b21fdc4931)

16 years agor23745: Fix: Check whether top subkeyname instead of whole registry key name
Michael Adam [Sat, 7 Jul 2007 21:33:48 +0000 (21:33 +0000)]
r23745: Fix: Check whether top subkeyname instead of whole registry key name
is equal to GLOBAL_NAME.

Michael
(This used to be commit fdcdcacf0a9513829ad474605879ef55ce8b389e)

16 years agor23744: Remove TODO-comment. lp_load returns False if opening
Michael Adam [Sat, 7 Jul 2007 20:40:59 +0000 (20:40 +0000)]
r23744: Remove TODO-comment. lp_load returns False if opening
of the config file fails. That's enough of checking for
existence and readbility to my taste.

Michael
(This used to be commit 204f4f1a94a6693ab5d92df0de48e6cb446c7a7f)

16 years agor23743: Simplify stat_cache_lookup() logic. For the history of this, see
Volker Lendecke [Sat, 7 Jul 2007 09:57:27 +0000 (09:57 +0000)]
r23743: Simplify stat_cache_lookup() logic. For the history of this, see
http://article.gmane.org/gmane.network.samba.internals/32486.
(This used to be commit e5e42fe3d5b26c0ec48d98c001b9cb1623c0b5a7)

16 years agor23738: Re-add commented out code snipped that got lost by accident
Volker Lendecke [Sat, 7 Jul 2007 08:46:26 +0000 (08:46 +0000)]
r23738: Re-add commented out code snipped that got lost by accident
(This used to be commit c38c31afb770350e47713bf1025c23fd774607ab)

16 years agor23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy Allison [Fri, 6 Jul 2007 23:07:40 +0000 (23:07 +0000)]
r23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy.
(This used to be commit 9e1663b1f18d716a7f307bea2b09dadeef392ab8)

16 years agor23735: Second part of the bugfix for #4763
Jeremy Allison [Fri, 6 Jul 2007 21:46:43 +0000 (21:46 +0000)]
r23735: Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
Jeremy.
(This used to be commit 1aaa1f5bbe9222acbe3dea1daa1c6c5ce72e1c2c)

16 years agor23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.
Lars Müller [Fri, 6 Jul 2007 18:49:49 +0000 (18:49 +0000)]
r23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.

Credits to Ralf Haferkamp for the discussion and help on this.
(This used to be commit 5be96d09a7c457b1763d7ad482b5a5a92c02d157)

16 years agor23732: removed reference to non-existent structure
Herb Lewis [Fri, 6 Jul 2007 17:48:19 +0000 (17:48 +0000)]
r23732: removed reference to non-existent structure
(This used to be commit 4c04059f7dfa0096c9f3249b55269f7335137f48)

16 years agor23731: Forgot one reference to inbuf
Volker Lendecke [Fri, 6 Jul 2007 16:39:58 +0000 (16:39 +0000)]
r23731: Forgot one reference to inbuf
(This used to be commit b02115f2ca6aca8655a4ebd1bd0adaa1e50578ce)

16 years agor23730: Squashed commit of the following:
Gerald Carter [Thu, 5 Jul 2007 19:55:40 +0000 (19:55 +0000)]
r23730: Squashed commit of the following:

commit 3941269fa01038fca242a197e8d7c1f234d45ea7
Author: Gerald (Jerry) Carter <jerry@samba.org>
Date:   Thu Jul 5 14:52:03 2007 -0500

    Two fixes for "winbind expand groups".

    (a) Update the counter for the number of new groups to resolve else
        we'll only expand one group member per level and drop the rest.
    (b) Don't reset the num_names counter in winbindd_ads.c:lookup_groupmem()
        or we'll drop the SIDs resolved to names via cache from the resulting
        list.
(This used to be commit dfb89dfcaa02f497ff22ac0213b70add6e4d5b8f)

16 years agor23728: First part of bugfix for #4763. Limit notify responses
Jeremy Allison [Thu, 5 Jul 2007 18:28:18 +0000 (18:28 +0000)]
r23728: First part of bugfix for #4763. Limit notify responses
to client max buf size.
Jeremy.
(This used to be commit 6113f56919a3cd7fd753808dbbe473603851bc3c)

16 years agor23727: Explicitly pass down FLAGS2 to srvstr_get_path.
Volker Lendecke [Thu, 5 Jul 2007 16:36:15 +0000 (16:36 +0000)]
r23727: Explicitly pass down FLAGS2 to srvstr_get_path.

Next step is to remove the bug that in the trans2 code we use the inbuf
as the base pointer to decide whether we need ucs2 alignment where we
need to use the beginning of the params buffer

Jeremy, last one for today to reviw :-)
(This used to be commit 18078b9faa3820fb34604063c9079c1ebe3ad47f)

16 years agor23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
Volker Lendecke [Thu, 5 Jul 2007 16:33:37 +0000 (16:33 +0000)]
r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.
(This used to be commit 836782b07bf133e9b2598c4a089f1c810e4c7754)

16 years agor23725: Remove get_current_mid()
Volker Lendecke [Thu, 5 Jul 2007 16:27:47 +0000 (16:27 +0000)]
r23725: Remove get_current_mid()

Jeremy, next one to review :-)
(This used to be commit a50555dda7db5e848e337185ed91c41c2557f7be)

16 years agor23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
Volker Lendecke [Thu, 5 Jul 2007 16:26:27 +0000 (16:26 +0000)]
r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
that contains some of the fields from the SMB header, removing the need
to access inbuf directly. This right now is used only in the open file
code & friends, and creating that header is only done when needed. This
needs more work, but it is a start.

Jeremy, I'm only checking this into 3_0, please review before I merge it
to _26.

Volker
(This used to be commit ca988f4e79e977160d82e86486972afd15d4acf5)

16 years agor23723: Alexander Larsson pointed me at a missing mapping in clierror.c
Simo Sorce [Thu, 5 Jul 2007 13:46:47 +0000 (13:46 +0000)]
r23723: Alexander Larsson pointed me at a missing mapping in clierror.c
When renaming a file across 2 filesystem a samba server returns
NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV,
and the generic EINVAL is returned instead.
This should fix it, Jeremy or Derrel please check if this is ok.
(This used to be commit b35038fa4e3e69f1397758497a46dc0d37edee79)

16 years agor23722: Fix the build of the catia module
Volker Lendecke [Thu, 5 Jul 2007 10:32:51 +0000 (10:32 +0000)]
r23722: Fix the build of the catia module
(This used to be commit fa09744cce6c1aa63e46bd61e4c01234574f3b32)

16 years agor23714: but now:
Michael Adam [Thu, 5 Jul 2007 00:12:24 +0000 (00:12 +0000)]
r23714: but now:

This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test
scenarios.

Michael
(This used to be commit b3e5082e105f6eaeed51e9a42d525d811e7155ee)

16 years agor23713: Oops accidentially checked in the wrong file - sorry!
Michael Adam [Thu, 5 Jul 2007 00:11:07 +0000 (00:11 +0000)]
r23713: Oops accidentially checked in the wrong file - sorry!

Michael
(This used to be commit ae23e6d04b8551e66b77995994a0c50cd880ea32)

16 years agor23712: This script allows for adding lists of users (or other objects)
Michael Adam [Thu, 5 Jul 2007 00:07:40 +0000 (00:07 +0000)]
r23712: This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test
scenarios.

Michael
(This used to be commit 0c03c78af8f62ece2965e0f5a16c001aad61c8fa)

16 years agor23711: Refactor the actual creation of object into its own small function.
Michael Adam [Wed, 4 Jul 2007 23:21:51 +0000 (23:21 +0000)]
r23711: Refactor the actual creation of object into its own small function.

Michael
(This used to be commit 26349c0b173e8baf6fa43deb39cb2bfdb31bf18e)

16 years agor23710: Remove some code duplication, we do have a random number generator
Volker Lendecke [Wed, 4 Jul 2007 22:30:25 +0000 (22:30 +0000)]
r23710: Remove some code duplication, we do have a random number generator
(This used to be commit afd7febd980bb000f81d5251d03d500cb43c39f4)

16 years agor23709: C++ warnings
Volker Lendecke [Wed, 4 Jul 2007 22:28:04 +0000 (22:28 +0000)]
r23709: C++ warnings
(This used to be commit 2d5e3322d6ecd00c0e936ee64483e63a3ad87c0b)