From 1137ebc654e4dfd91601abd20262024063a495c8 Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Mon, 14 Mar 2022 18:18:39 +1300 Subject: [PATCH] sddl: Remove SDDL SID strings unsupported by Windows Signed-off-by: Joseph Sutton Reviewed-by: Stefan Metzmacher --- libcli/security/sddl.c | 3 --- selftest/knownfail.d/sid-strings | 3 --- 2 files changed, 6 deletions(-) diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c index 5f7d70be980..5bb65ddfd6b 100644 --- a/libcli/security/sddl.c +++ b/libcli/security/sddl.c @@ -116,11 +116,9 @@ static const struct { { .code = "PO", .sid = SID_BUILTIN_PRINT_OPERATORS }, { .code = "BO", .sid = SID_BUILTIN_BACKUP_OPERATORS }, { .code = "RE", .sid = SID_BUILTIN_REPLICATOR }, - { .code = "BR", .sid = SID_BUILTIN_RAS_SERVERS }, { .code = "RU", .sid = SID_BUILTIN_PREW2K }, { .code = "RD", .sid = SID_BUILTIN_REMOTE_DESKTOP_USERS }, { .code = "NO", .sid = SID_BUILTIN_NETWORK_CONF_OPERATORS }, - { .code = "IF", .sid = SID_BUILTIN_INCOMING_FOREST_TRUST }, { .code = "MU", .sid = SID_BUILTIN_PERFMON_USERS }, { .code = "LU", .sid = SID_BUILTIN_PERFLOG_USERS }, @@ -152,7 +150,6 @@ static const struct { { .code = "LA", .sid = NULL, .rid = DOMAIN_RID_ADMINISTRATOR }, { .code = "LG", .sid = NULL, .rid = DOMAIN_RID_GUEST }, - { .code = "LK", .sid = NULL, .rid = DOMAIN_RID_KRBTGT }, { .code = "DA", .sid = NULL, .rid = DOMAIN_RID_ADMINS }, { .code = "DU", .sid = NULL, .rid = DOMAIN_RID_USERS }, diff --git a/selftest/knownfail.d/sid-strings b/selftest/knownfail.d/sid-strings index a9cefedc8a2..69536432585 100644 --- a/selftest/knownfail.d/sid-strings +++ b/selftest/knownfail.d/sid-strings @@ -1,6 +1,3 @@ ^samba.tests.sid_strings.samba.tests.sid_strings.SidStringTests.test_sid_string_Aa.ad_dc -^samba.tests.sid_strings.samba.tests.sid_strings.SidStringTests.test_sid_string_BR.ad_dc -^samba.tests.sid_strings.samba.tests.sid_strings.SidStringTests.test_sid_string_IF.ad_dc -^samba.tests.sid_strings.samba.tests.sid_strings.SidStringTests.test_sid_string_LK.ad_dc ^samba.tests.sid_strings.samba.tests.sid_strings.SidStringTests.test_sid_string_aA.ad_dc ^samba.tests.sid_strings.samba.tests.sid_strings.SidStringTests.test_sid_string_aa.ad_dc -- 2.34.1