From: Simo Sorce <idra@samba.org>
Date: Thu, 26 Dec 2013 04:28:58 +0000 (-0500)
Subject: Compare the correct values
X-Git-Tag: tevent-0.9.21~270
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=ac7de8021050e560d39f613ea4a2caab06c7a2a8;p=samba.git

Compare the correct values

Reported by herwin <samba@herwinw.nl>
Resolves: https://bugzilla.samba.org/show_bug.cgi?id=10349

Signed-off-by: Simo Sorce <idra@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Dec 27 20:39:54 CET 2013 on sn-devel-104
---

diff --git a/source3/torture/pdbtest.c b/source3/torture/pdbtest.c
index 17da4552564..df2c3263783 100644
--- a/source3/torture/pdbtest.c
+++ b/source3/torture/pdbtest.c
@@ -117,7 +117,7 @@ static bool samu_correct(struct samu *s1, struct samu *s2)
 		DEBUG(0, ("Password history is not set\n"));
 	} else if (d1_buf == NULL) {
 		/* Do nothing */
-	} else if (s1_len != s1_len) {
+	} else if (s1_len != s2_len) {
 		DEBUG(0, ("Password history not written correctly, lengths differ, want %d, got %d\n",
 					s1_len, s2_len));
 		ret = False;