From: Andrew Tridgell <tridge@samba.org>
Date: Mon, 13 Mar 2006 06:56:07 +0000 (+0000)
Subject: r14305: fixed a memory leak and a break error
X-Git-Tag: samba-4.0.0alpha6~801^3~6944
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=27c9674455e8741f13bdfb13fcf3c36ae94c3dc8;p=samba.git

r14305: fixed a memory leak and a break error
(This used to be commit c791db60c88ed0f50aa7b13822f95f6f17360fee)
---

diff --git a/source4/auth/auth_unix.c b/source4/auth/auth_unix.c
index 417025dfdf3..959eb6703cc 100644
--- a/source4/auth/auth_unix.c
+++ b/source4/auth/auth_unix.c
@@ -197,6 +197,7 @@ static int smb_pam_conv(int num_msg, const struct pam_message **msg,
 				(*reply)[num].resp_retcode = PAM_SUCCESS;
 				(*reply)[num].resp = NULL;
 				DEBUG(4,("PAM Info message in conversation function: %s\n", (msg[num]->msg)));
+				break;
 
 			case PAM_ERROR_MSG:
 				(*reply)[num].resp_retcode = PAM_SUCCESS;
@@ -205,6 +206,10 @@ static int smb_pam_conv(int num_msg, const struct pam_message **msg,
 				break;
 
 			default:
+				while (num > 0) {
+					SAFE_FREE((*reply)[num-1].resp);
+					num--;
+				}
 				SAFE_FREE(*reply);
 				*reply = NULL;
 				DEBUG(1,("Error: PAM subsystme sent an UNKNOWN message type to the conversation function!\n"));