From: Andrew Bartlett <abartlet@samba.org>
Date: Sun, 8 Jan 2006 02:05:20 +0000 (+0000)
Subject: r12763: Oops.  If you call ldb_search from within an ldb module's search
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=1162b37ff0ce46a578b7e8a6cd92f66a5a1982d9;p=abartlet%2Fsamba.git%2F.git

r12763: Oops.  If you call ldb_search from within an ldb module's search
request handler, you really have to watch the recursion issues...

Andrew Bartlett
(This used to be commit 46628e86a2be6d334b2d0427e7052517c7ab1d4c)
---

diff --git a/source4/dsdb/samdb/ldb_modules/kludge_acl.c b/source4/dsdb/samdb/ldb_modules/kludge_acl.c
index 09d8e825765..cc6a0d18f4b 100644
--- a/source4/dsdb/samdb/ldb_modules/kludge_acl.c
+++ b/source4/dsdb/samdb/ldb_modules/kludge_acl.c
@@ -91,7 +91,9 @@ static int kludge_acl_search(struct ldb_module *module, struct ldb_request *req)
 	struct kludge_private_data *data = talloc_get_type(module->private_data, struct kludge_private_data);
 	int i, j;
 
-	if (ret != LDB_SUCCESS) {
+	/* We may not be fully initialised yet, or we might have just
+	 * got an error */
+	if (ret != LDB_SUCCESS || !data->password_attrs) {
 		return ret;
 	}