s4:torture/smb2: FSCTL_QUERY_NETWORK_INTERFACE_INFO gives INVALID_PARAMETER with...

An invalid file id for FSCTL_QUERY_NETWORK_INTERFACE_INFO gives
INVALID_PARAMETER instead of FILE_CLOSED.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14788

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/selftest/knownfail.d/smb2.ioctl.bug14788 b/selftest/knownfail.d/smb2.ioctl.bug14788
new file mode 100644 (file)
index 0000000..b228bfa
--- /dev/null
+++ b/selftest/knownfail.d/smb2.ioctl.bug14788
@@ -0,0 +1 @@
+^samba3.smb2.ioctl.*.bug14788.NETWORK_INTERFACE

diff --git a/source4/torture/smb2/ioctl.c b/source4/torture/smb2/ioctl.c
index c9ebc35314b4052fd805f947e96f9d9e73b2a98f..35c413dc57ce6079284d1f42cc20c63e6fae901a 100644 (file)
--- a/source4/torture/smb2/ioctl.c
+++ b/source4/torture/smb2/ioctl.c
@@ -7126,6 +7126,59 @@ static bool test_ioctl_bug14788_NETWORK_INTERFACE(struct torture_context *tortur
                                      NT_STATUS_BUFFER_TOO_SMALL,
                                      "FSCTL_QUERY_NETWORK_INTERFACE_INFO");
 
+       /*
+        * An invalid FSCTL_QUERY_NETWORK_INTERFACE_INFO,
+        * with file_id_* not being UINT64_MAX.
+        *
+        * This gives INVALID_PARAMETER instead
+        * of FILE_CLOSED.
+        */
+       status = smb2cli_ioctl(transport->conn,
+                              timeout_msec,
+                              session->smbXcli,
+                              tree->smbXcli,
+                              INT64_MAX, /* in_fid_persistent */
+                              INT64_MAX, /* in_fid_volatile */
+                              FSCTL_QUERY_NETWORK_INTERFACE_INFO,
+                              0, /* in_max_input_length */
+                              NULL, /* in_input_buffer */
+                              UINT16_MAX, /* in_max_output_length */
+                              NULL, /* in_output_buffer */
+                              SMB2_IOCTL_FLAG_IS_FSCTL,
+                              torture,
+                              &out_input_buffer,
+                              &out_output_buffer);
+       torture_assert_ntstatus_equal(torture, status,
+                                     NT_STATUS_INVALID_PARAMETER,
+                                     "FSCTL_QUERY_NETWORK_INTERFACE_INFO");
+
+       /*
+        * An invalid FSCTL_QUERY_NETWORK_INTERFACE_INFO,
+        * with file_id_* not being UINT64_MAX and
+        * in_max_output_length = 1.
+        *
+        * This proves INVALID_PARAMETER instead
+        * of BUFFER_TOO_SMALL.
+        */
+       status = smb2cli_ioctl(transport->conn,
+                              timeout_msec,
+                              session->smbXcli,
+                              tree->smbXcli,
+                              INT64_MAX, /* in_fid_persistent */
+                              INT64_MAX, /* in_fid_volatile */
+                              FSCTL_QUERY_NETWORK_INTERFACE_INFO,
+                              0, /* in_max_input_length */
+                              NULL, /* in_input_buffer */
+                              1, /* in_max_output_length */
+                              NULL, /* in_output_buffer */
+                              SMB2_IOCTL_FLAG_IS_FSCTL,
+                              torture,
+                              &out_input_buffer,
+                              &out_output_buffer);
+       torture_assert_ntstatus_equal(torture, status,
+                                     NT_STATUS_INVALID_PARAMETER,
+                                     "FSCTL_QUERY_NETWORK_INTERFACE_INFO");
+
        return true;
 }