BUG 9699: Fix adding case sensitive spn.

We should be able to define the case of the spn cause it is important
for some services like nfs. 'net ads keytab add "nfs"' should not
result in an uppercase spn.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6848fb121a3a16b2d87b2bf2f7cca8364a1343f1)

diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index e62a4b4137d14841a12ad633567b3820d3a3f581..b841c843c63c6bcf904e0f9305051f392af9fd5f 100644 (file)
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -1920,8 +1920,7 @@ ADS_STATUS ads_add_service_principal_name(ADS_STRUCT *ads, const char *machine_n
                ads_msgfree(ads, res);
                return ADS_ERROR(LDAP_NO_MEMORY);
        }
-       strupper_m(psp1);
-       strlower_m(&psp1[strlen(spn)]);
+       strlower_m(&psp1[strlen(spn) + 1]);
        servicePrincipalName[0] = psp1;
 
        DEBUG(5,("ads_add_service_principal_name: INFO: Adding %s to host %s\n", 
@@ -1934,8 +1933,7 @@ ADS_STATUS ads_add_service_principal_name(ADS_STRUCT *ads, const char *machine_n
                ret = ADS_ERROR(LDAP_NO_MEMORY);
                goto out;
        }
-       strupper_m(psp2);
-       strlower_m(&psp2[strlen(spn)]);
+       strlower_m(&psp2[strlen(spn) + 1]);
        servicePrincipalName[1] = psp2;
 
        DEBUG(5,("ads_add_service_principal_name: INFO: Adding %s to host %s\n",