s3: smbd: rename_internals_fsp() has to reopen the parent directory of the target...

So it never looks at any passed in dst_dirfsp.

Prove this by passing NULL.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source3/smbd/smb2_reply.c b/source3/smbd/smb2_reply.c
index dfcd05d2cae18e7c058566c020410b0b73e61aae..aea5d627addea94ec9e1793d5e03b7ab5dd1a847 100644 (file)
--- a/source3/smbd/smb2_reply.c
+++ b/source3/smbd/smb2_reply.c
@@ -1938,7 +1938,7 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
 
        status = rename_internals_fsp(conn,
                                        fsp,
-                                       dst_dirfsp,
+                                       NULL,
                                        smb_fname_dst,
                                        dst_original_lcomp,
                                        attrs,

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index 23081a11e43b93443df27841b28ec97ddd1601f1..0f1ef2d43543367bb1259d0b786d2df5122ddb1e 100644 (file)
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -4751,7 +4751,7 @@ static NTSTATUS smb_file_rename_information(connection_struct *conn,
                          smb_fname_str_dbg(smb_fname_dst)));
                status = rename_internals_fsp(conn,
                                        fsp,
-                                       dst_dirfsp,
+                                       NULL,
                                        smb_fname_dst,
                                        dst_original_lcomp,
                                        0,