recoverd: Remove duplicate code to update flags during recovery
authorMartin Schwenke <martin@meltin.net>
Thu, 14 Nov 2013 03:25:47 +0000 (14:25 +1100)
committerMartin Schwenke <martin@meltin.net>
Thu, 14 Nov 2013 03:42:29 +0000 (14:42 +1100)
This also happens earlier in do_recovery() and the nodemap is not
updated after that, so this update is redundant.

Signed-off-by: Martin Schwenke <martin@meltin.net>
server/ctdb_recoverd.c

index 8b4b6d0298bb73564db299da391abafdedf8ffc1..6d232e07066a144b6350a97de3c31a7184ff6557 100644 (file)
@@ -1989,23 +1989,6 @@ static int do_recovery(struct ctdb_recoverd *rec,
 
        DEBUG(DEBUG_NOTICE, (__location__ " Recovery - updated recmaster\n"));
 
-       /*
-         update all nodes to have the same flags that we have
-        */
-       for (i=0;i<nodemap->num;i++) {
-               if (nodemap->nodes[i].flags & NODE_FLAGS_DISCONNECTED) {
-                       continue;
-               }
-
-               ret = update_flags_on_all_nodes(ctdb, nodemap, i, nodemap->nodes[i].flags);
-               if (ret != 0) {
-                       DEBUG(DEBUG_ERR, (__location__ " Unable to update flags on all nodes for node %d\n", i));
-                       return -1;
-               }
-       }
-
-       DEBUG(DEBUG_NOTICE, (__location__ " Recovery - updated flags\n"));
-
        /* disable recovery mode */
        ret = set_recovery_mode(ctdb, rec, nodemap, CTDB_RECOVERY_NORMAL);
        if (ret != 0) {