s4:dsdb: Check return value of ldb_msg_add_empty() (CID 1272827)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 7dcd5f879e049906ef4396cb0d4654cfa5bcc46b..7aec0063c9684ba23056941b4ee7cba34185b4ee 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -3516,7 +3516,10 @@ static int replmd_modify_handle_linked_attribs(struct ldb_module *module,
                if (old_el) {
                        ldb_msg_remove_attr(old_msg, el->name);
                }
-               ldb_msg_add_empty(old_msg, el->name, 0, &new_el);
+               ret = ldb_msg_add_empty(old_msg, el->name, 0, &new_el);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
                new_el->num_values = el->num_values;
                new_el->values = talloc_steal(msg->elements, el->values);