s4:torture: Check return values of talloc functions
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 16 Oct 2023 06:09:54 +0000 (19:09 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 19 Oct 2023 21:37:36 +0000 (21:37 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/torture/rpc/backupkey.c

index 23572e82e57f2f9f58400e159f0518d5fe862e65..8b7c6c30d105a8f214d40e57e391fb61b31594af 100644 (file)
@@ -264,15 +264,26 @@ static DATA_BLOB *create_access_check(struct torture_context *tctx,
                                      bool broken,
                                      uint32_t version)
 {
-       TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
-       DATA_BLOB *blob = talloc_zero(mem_ctx, DATA_BLOB);
+       TALLOC_CTX *tmp_ctx = NULL;
+       DATA_BLOB *blob = NULL;
        enum ndr_err_code ndr_err;
-       const struct dom_sid *sid = get_user_sid(tctx, tmp_ctx, user);
+       const struct dom_sid *sid = NULL;
+
+       tmp_ctx = talloc_new(mem_ctx);
+       if (tmp_ctx == NULL) {
+               return NULL;
+       }
 
+       sid = get_user_sid(tctx, tmp_ctx, user);
        if (sid == NULL) {
                return NULL;
        }
 
+       blob = talloc_zero(mem_ctx, DATA_BLOB);
+       if (blob == NULL) {
+               return NULL;
+       }
+
        if (version == 2) {
                struct bkrp_access_check_v2 access_struct;
                gnutls_hash_hd_t dig_ctx;