pthreadpool: replace assert_return_code(ret, 0); with assert_int_equal(ret, 0);
authorStefan Metzmacher <metze@samba.org>
Mon, 23 Jul 2018 21:24:22 +0000 (23:24 +0200)
committerRalph Boehme <slow@samba.org>
Tue, 24 Jul 2018 15:38:26 +0000 (17:38 +0200)
We need to assert the exact value!

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
lib/pthreadpool/tests_cmocka.c

index e2fb8439428537890b2718b74859914de41100fd..e6af8849f01ddf7a8d7e3187e3443280ea165a86 100644 (file)
@@ -51,19 +51,19 @@ static int setup_pthreadpool_tevent(void **state)
        assert_non_null(t->ev);
 
        ret = pthreadpool_tevent_init(t->ev, UINT_MAX, &t->upool);
-       assert_return_code(ret, 0);
+       assert_int_equal(ret, 0);
 
        max_threads = pthreadpool_tevent_max_threads(t->upool);
        assert_int_equal(max_threads, UINT_MAX);
 
        ret = pthreadpool_tevent_init(t->ev, 1, &t->opool);
-       assert_return_code(ret, 0);
+       assert_int_equal(ret, 0);
 
        max_threads = pthreadpool_tevent_max_threads(t->opool);
        assert_int_equal(max_threads, 1);
 
        ret = pthreadpool_tevent_init(t->ev, 0, &t->spool);
-       assert_return_code(ret, 0);
+       assert_int_equal(ret, 0);
 
        max_threads = pthreadpool_tevent_max_threads(t->spool);
        assert_int_equal(max_threads, 0);