util/convert string: remove inaccurate misspelt comment
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 29 Jun 2023 06:23:55 +0000 (18:23 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 26 Oct 2023 01:24:32 +0000 (01:24 +0000)
Previous commit to the "embarrassing" line was ce10a7a673e8adf "Fix
typo in comment", which did not completely fix the typo in the
comment.

But there are no gotos anymore, so no embarrassment, however spelt.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/util/charset/convert_string.c

index 686b9ab846890222c6fd96612aa385248b69956c..9fa721b6d12722595e5959e7fdbd1492757f562f 100644 (file)
@@ -342,9 +342,6 @@ bool convert_string_handle(struct smb_iconv_handle *ic,
  * converted.
  *
  * Ensure the srclen contains the terminating zero.
- *
- * I hate the goto's in this function. It's emberrassing.....
- * There has to be a cleaner way to do this. JRA.
  */
 bool convert_string_talloc_handle(TALLOC_CTX *ctx, struct smb_iconv_handle *ic,
                                  charset_t from, charset_t to,