CVE-2015-5370: s3:rpc_server: don't ignore failures of dcerpc_push_ncacn_packet()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

diff --git a/source3/rpc_server/srv_pipe.c b/source3/rpc_server/srv_pipe.c
index 07046d45f0fe3208d7459227f72a67176825680b..ea9d50d8a57f1da8c6de05c09f25a2fa65e49655 100644 (file)
--- a/source3/rpc_server/srv_pipe.c
+++ b/source3/rpc_server/srv_pipe.c
@@ -798,6 +798,7 @@ static bool api_pipe_bind_req(struct pipes_struct *p,
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("Failed to marshall bind_ack packet. (%s)\n",
                          nt_errstr(status)));
+               goto err_exit;
        }
 
        if (auth_resp.length) {
@@ -1058,6 +1059,7 @@ static bool api_pipe_alter_context(struct pipes_struct *p,
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("Failed to marshall bind_ack packet. (%s)\n",
                          nt_errstr(status)));
+               goto err_exit;
        }
 
        if (auth_resp.length) {