python/samba: PY3 fix samba4.blackbox.upgradeprovision.release-4-0-0
authorNoel Power <noel.power@suse.com>
Fri, 5 Oct 2018 14:10:52 +0000 (15:10 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 23 Oct 2018 03:50:28 +0000 (05:50 +0200)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/provision/__init__.py
source4/scripting/bin/samba_upgradeprovision

index 9c7a30404ee08be492e8284a6e54f0b78fbd4883..cc7b8babb5a70d7b7cf297a45dfd8a4dbfd97bcb 100644 (file)
@@ -236,7 +236,7 @@ def find_provision_key_parameters(samdb, secretsdb, idmapdb, paths, smbconf,
     names.dnsdomaindn = None
 
     for i in range(0, len(names.ncs)):
-        nc = names.ncs[i]
+        nc = str(names.ncs[i])
 
         dnsforestdn = "DC=ForestDnsZones,%s" % (str(names.rootdn))
         if nc == dnsforestdn:
@@ -307,8 +307,8 @@ def find_provision_key_parameters(samdb, secretsdb, idmapdb, paths, smbconf,
                           attrs=["xidNumber", "type"])
     if len(res9) != 1:
         raise ProvisioningError("Unable to find uid/gid for Domain Admins rid (%s-%s" % (str(names.domainsid), security.DOMAIN_RID_ADMINISTRATOR))
-    if res9[0]["type"][0] == "ID_TYPE_BOTH":
-        names.root_gid = res9[0]["xidNumber"][0]
+    if str(res9[0]["type"][0]) == "ID_TYPE_BOTH":
+        names.root_gid = int(res9[0]["xidNumber"][0])
     else:
         names.root_gid = pwd.getpwuid(int(res9[0]["xidNumber"][0])).pw_gid
 
index 6de9d957194dbe73a4111ffc14d0c770628670df..5ec7b63fe2ed455c8b9006cd97af42d8b862992f 100755 (executable)
@@ -1387,7 +1387,7 @@ def backup_provision(samdb, paths, dir, only_db):
                        scope=ldb.SCOPE_BASE,
                        attrs=["backendStore"])
     if "backendStore" in res[0]:
-        backend_store = res[0]["backendStore"][0]
+        backend_store = str(res[0]["backendStore"][0])
 
 
     if paths.sysvol and not only_db: