ndrdump: Small simplification
authorVolker Lendecke <vl@samba.org>
Mon, 7 Feb 2022 09:11:36 +0000 (10:11 +0100)
committerJeremy Allison <jra@samba.org>
Fri, 11 Feb 2022 20:54:37 +0000 (20:54 +0000)
Remove the talloc_steal(), we can allocate on mem_ctx directly

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
librpc/tools/ndrdump.c

index b5d7f4fa3f6db40d429feb678d2db4e8e3201321..0d39ed3714bf28a65aa046a2dab8efe48f4c5415 100644 (file)
@@ -553,10 +553,9 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...)
                blob = hexdump_to_data_blob(mem_ctx, (const char *)data, size);
        } else if (base64_input) {
                /* Use talloc_strndup() to ensure null termination */
-               blob = base64_decode_data_blob(talloc_strndup(mem_ctx,
-                                                             (const char *)data, size));
-               /* base64_decode_data_blob() allocates on NULL */
-               talloc_steal(mem_ctx, blob.data);
+               blob = base64_decode_data_blob_talloc(
+                       mem_ctx,
+                       talloc_strndup(mem_ctx, (const char *)data, size));
        } else {
                blob = data_blob_const(data, size);
        }